refactor: add rector to enforce type declarations, code quality + style and remove dead code

- update CI process to include quality stage (tests + code review)
- add captainhook to install git pre-commit & pre-push hooks
- remove .devcontainer Dockerfile to use project's docker-compose services: all
services can now be started automatically using vscode
- update docs/setup-development.md
This commit is contained in:
Yassine Doghri 2021-05-06 14:00:48 +00:00
commit 5c5c6da4be
No known key found for this signature in database
GPG key ID: 3E7F89498B960C9F
302 changed files with 9802 additions and 4674 deletions

View file

@ -1,8 +1,11 @@
<?php
namespace Tests\Database;
use Tests\Support\DatabaseTestCase;
use Tests\Support\Models\ExampleModel;
class ExampleDatabaseTest extends \Tests\Support\DatabaseTestCase
class ExampleDatabaseTest extends DatabaseTestCase
{
public function setUp(): void
{
@ -11,7 +14,7 @@ class ExampleDatabaseTest extends \Tests\Support\DatabaseTestCase
// Extra code to run before each test
}
public function testModelFindAll()
public function testModelFindAll(): void
{
$model = new ExampleModel();
@ -22,7 +25,7 @@ class ExampleDatabaseTest extends \Tests\Support\DatabaseTestCase
$this->assertCount(3, $objects);
}
public function testSoftDeleteLeavesRow()
public function testSoftDeleteLeavesRow(): void
{
$model = new ExampleModel();
$this->setPrivateProperty($model, 'useSoftDeletes', true);