refactor: add rector to enforce type declarations, code quality + style and remove dead code

- update CI process to include quality stage (tests + code review)
- add captainhook to install git pre-commit & pre-push hooks
- remove .devcontainer Dockerfile to use project's docker-compose services: all
services can now be started automatically using vscode
- update docs/setup-development.md
This commit is contained in:
Yassine Doghri 2021-05-06 14:00:48 +00:00
commit 5c5c6da4be
No known key found for this signature in database
GPG key ID: 3E7F89498B960C9F
302 changed files with 9802 additions and 4674 deletions

View file

@ -8,6 +8,11 @@
namespace Analytics\Controllers;
use Analytics\Config\Analytics;
use CodeIgniter\HTTP\RequestInterface;
use CodeIgniter\HTTP\ResponseInterface;
use Psr\Log\LoggerInterface;
use Config\Services;
use CodeIgniter\Controller;
class EpisodeAnalyticsController extends Controller
@ -22,17 +27,17 @@ class EpisodeAnalyticsController extends Controller
protected $helpers = ['analytics'];
/**
* @var \Analytics\Config\Analytics
* @var Analytics
*/
protected $config;
/**
* Constructor.
*/
public function initController(
\CodeIgniter\HTTP\RequestInterface $request,
\CodeIgniter\HTTP\ResponseInterface $response,
\Psr\Log\LoggerInterface $logger
) {
RequestInterface $request,
ResponseInterface $response,
LoggerInterface $logger
): void {
// Do Not Edit This Line
parent::initController($request, $response, $logger);
@ -52,8 +57,9 @@ class EpisodeAnalyticsController extends Controller
// Add one hit to this episode:
public function hit($base64EpisodeData, ...$audioFilePath)
{
$session = \Config\Services::session();
$session = Services::session();
$session->start();
$serviceName = '';
if (isset($_GET['_from'])) {
$serviceName = $_GET['_from'];