refactor: add rector to enforce type declarations, code quality + style and remove dead code

- update CI process to include quality stage (tests + code review)
- add captainhook to install git pre-commit & pre-push hooks
- remove .devcontainer Dockerfile to use project's docker-compose services: all
services can now be started automatically using vscode
- update docs/setup-development.md
This commit is contained in:
Yassine Doghri 2021-05-06 14:00:48 +00:00
commit 5c5c6da4be
No known key found for this signature in database
GPG key ID: 3E7F89498B960C9F
302 changed files with 9802 additions and 4674 deletions

View file

@ -11,10 +11,15 @@
namespace ActivityPub\Objects;
use ActivityPub\Core\Activity;
use CodeIgniter\Pager\Pager;
use ActivityPub\Core\ObjectType;
class OrderedCollectionObject extends ObjectType
{
/**
* @var string
*/
protected $type = 'OrderedCollection';
/**
@ -43,18 +48,19 @@ class OrderedCollectionObject extends ObjectType
protected $orderedItems;
/**
* @param \ActivityPub\Libraries\ActivityPub\Activity[] $orderedItems
* @param \CodeIgniter\Pager\Pager $pager
* @param array $orderedItems
*/
public function __construct($orderedItems, $pager = null)
{
public function __construct(
?array $orderedItems = null,
?Pager $pager = null
) {
$this->id = current_url();
if ($pager) {
if ($pager !== null) {
$totalItems = $pager->getTotal();
$this->totalItems = $totalItems;
if ($totalItems) {
if ($totalItems !== 0) {
$this->first = $pager->getPageURI($pager->getFirstPage());
$this->current = $pager->getPageURI();
$this->last = $pager->getPageURI($pager->getLastPage());