refactor: add rector to enforce type declarations, code quality + style and remove dead code

- update CI process to include quality stage (tests + code review)
- add captainhook to install git pre-commit & pre-push hooks
- remove .devcontainer Dockerfile to use project's docker-compose services: all
services can now be started automatically using vscode
- update docs/setup-development.md
This commit is contained in:
Yassine Doghri 2021-05-06 14:00:48 +00:00
commit 5c5c6da4be
No known key found for this signature in database
GPG key ID: 3E7F89498B960C9F
302 changed files with 9802 additions and 4674 deletions

View file

@ -12,6 +12,9 @@ use CodeIgniter\Controller;
class BlockController extends Controller
{
/**
* @var string[]
*/
protected $helpers = ['activitypub'];
public function attemptBlockActor()
@ -32,7 +35,7 @@ class BlockController extends Controller
if ($parts = split_handle($handle)) {
extract($parts);
if (!($actor = get_or_create_actor($username, $domain))) {
if (($actor = get_or_create_actor($username, $domain)) === null) {
return redirect()
->back()
->withInput()