Hypolite Petovan
9be9741562
Fix uses in include/dba
2018-07-16 19:38:16 -04:00
Hypolite Petovan
762a786611
Replace direct accesses to App->config by Config::get/set calls
2018-07-16 19:38:16 -04:00
Hypolite Petovan
cd9b864045
Rework App modes
...
- Replace App mode constants with capability-based flags
- Add App->isInstallMode()
- Add file config fallback in (P)Config abstraction
- Removed logger disabling code
2018-07-16 19:38:15 -04:00
Hypolite Petovan
7d8c45dde8
Remove dependency to App in dba::connect
...
- Remove timing (can be done centrally)
- Add charset parameter to dba::connect and dba::reconnect
2018-07-16 19:38:13 -04:00
0e8fa34156
Fix for displaying public items
2018-07-16 04:00:57 +00:00
Hypolite Petovan
a6eae9adec
Add new put_item_in_cache hook in include/text
2018-07-15 08:03:12 -04:00
Roland Häder
6b5d90333f
Fixes for some E_NOTICE and type-hints added ( #5358 )
...
* Fixed http://github to https://github
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixes for #4965 :
- updated messages.po file
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixed E_NOTICE where isset()/empty() was absent.
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixed missing variable $sql_order causing E_NOTICE.
Signed-off-by: Roland Häder <roland@mxchange.org>
* Continued:
- added array type-hint where known (some)
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixes:
- in Profile::load() $user is now only one-dimensional
- $a->get_hostname is no property, it is a method
Signed-off-by: Roland Häder <roland@mxchange.org>
* reverted changes that are unintended
Signed-off-by: Roland Häder <roland@mxchange.org>
* Continued:
- removed leading \ (uncommon, okay)
- removed entire if() block (CR by Hypolite)
Signed-off-by: Roland Häder <roland@mxchange.org>
* Removed if() block
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-13 15:47:14 -04:00
Michael Vogel
0360f7197a
Several more warnings ... ( #5340 )
...
* Some more warnings removed
* Even more warnings ...
* Will it ever end? ;-)
* Avoid warning in dbstructure
* Origin and OStatus ...
* There are more warnings solved ... yeah!
* And again ...
* We are not done yet
* And more ...
* And some new places ...
* And more in the feeds
* Avoid some more
* And some backend stuff
* Notifications cleared
* Some more stuff
* and again ...
* It's getting fewer ...
* Some warnings had been hidden in the notifications
* Fix the fix
* And another missing one ...
* We need the owner here, not the user
* Forgotten user
* And more ...
* And some more warnings disappeared ...
* Some more frontend warnings
* Some backend warnings removed
* Fixed sidebar for "vier"
* And more ...
* Some more ...
* And something for "remote self"
* Am I stuck in an endless loop?
* Fix: Clear tag and file field on update
* Preset page content
2018-07-10 08:27:56 -04:00
c829e43725
moved get_guid to System::createGUID
2018-07-09 21:38:16 +02:00
675a6adf35
Added comment
2018-07-08 13:52:11 +00:00
8a2230bc4c
Avoid warnings in addons
2018-07-08 12:01:36 +00:00
3e797547a3
Warnings fixed
2018-07-08 09:37:05 +00:00
69db696ab1
Improve test behaviour
2018-07-08 05:29:06 +00:00
Michael Vogel
ff5ee74ecf
Merge branch 'develop' into item-activities
2018-07-08 06:35:50 +02:00
4d35e228c4
More item abstraction / making remote deletion work again
2018-07-07 18:14:16 +00:00
1ffe0cfd81
Added Lock Unittests & Bugfixings
...
Added Redis Lock Unittests
Added Memcached Lock Unittests
Fixed a bug in dba
Fixed a bug in RedisLock
2018-07-07 16:15:03 +02:00
Hypolite Petovan
e44111e935
Revert renaming lang to language in api
...
- Normalize some quotes
- Put "Empty user-agent" log message in a else statement
2018-07-04 17:33:09 -04:00
Hypolite Petovan
43688c04b1
Add NotFoundException for recipients in api_direct_messages_new()
2018-07-02 07:48:59 -04:00
Hypolite Petovan
cb7176ee70
Fix Config use in api_statusnet_config()
2018-07-02 07:48:53 -04:00
Hypolite Petovan
757fd357f6
Fix yet more undefined variable/index notice in api
2018-07-02 07:48:48 -04:00
Hypolite Petovan
dde61a77a4
Fix root element containing only text in api_create_xml()
2018-07-02 07:48:42 -04:00
Hypolite Petovan
62eba48679
Fix yet more undefined variable/index messages in api_statuses_show
2018-07-02 07:48:38 -04:00
Hypolite Petovan
0ee153e1bd
Fix Array to String conversion message for IN conditions
2018-07-02 07:47:47 -04:00
Hypolite Petovan
a380bcd1c1
Fix more undefined variable/index notice in tests
2018-07-02 07:45:25 -04:00
Hypolite Petovan
a329ce5b50
Fix $called_api expecting at least 2 elements in tests
2018-07-02 07:45:11 -04:00
Hypolite Petovan
6776c4e3f9
Fix some undefined variable/index notices in tests
2018-07-02 07:44:55 -04:00
717ca0b7eb
Use already fetched data for magiclink
2018-07-02 05:41:55 +00:00
0ab9f2e265
Preparations to not store the tags in the item table anymore
2018-06-30 13:54:01 +00:00
028c9f4da5
We now store the verb in the item-content as well
2018-06-27 19:37:13 +00:00
76dab3b2d7
Use gravity instead of verb
2018-06-27 18:09:33 +00:00
b03db4643f
The fetch function now centrally controls the content
2018-06-24 10:48:29 +00:00
Hypolite Petovan
98a5749b45
Merge pull request #5277 from annando/native-pdo
...
We now are using the native pdo mode
2018-06-22 16:04:50 -04:00
6e64091fc7
We now are using the native pdo mode
2018-06-22 19:35:42 +00:00
miqrogroove
c37a8cc661
Update dba.php
2018-06-22 07:34:27 -04:00
miqrogroove
150989ba99
Ensure IN() Conditions Never Mix Data Types
2018-06-21 23:56:19 -04:00
Hypolite Petovan
47ab72352e
Merge pull request #5269 from annando/non-unique-values
...
This fixes the problem with mixed variables in queries
2018-06-21 22:12:07 -04:00
e1e28ba7c3
Better float detection
2018-06-21 21:55:43 +00:00
miqrogroove
c600ccad5c
Correct dba::close() To Match dba::p()
2018-06-21 17:27:12 -04:00
1b85b75563
Currently removed, needs more testing
2018-06-21 20:42:58 +00:00
261d7435c0
Check for floats and enable native prepares
2018-06-21 20:33:27 +00:00
5656c0564a
We don't need to look $is_int there
2018-06-21 19:52:28 +00:00
c1059875bc
This fixes the problem with mixed variables in queries
2018-06-21 19:48:25 +00:00
Michael Vogel
4b0cf8d60f
Merge pull request #5267 from miqrogroove/patch-2
...
Allow for Integer Literals in PDO Database Driver
2018-06-21 18:51:01 +02:00
miqrogroove
759dfe6bb1
Allow for Integer Literals in PDO Database Driver
...
This should fix things like "LIMIT ?"
2018-06-21 11:42:43 -04:00
d643e00d33
Standards and a new function to fetch content
2018-06-21 15:14:01 +00:00
70af2cecf2
Some of the last direct SQL calls to the item table had been changed
2018-06-21 06:21:51 +00:00
1567eb0791
fixed another left-over ...
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-06-20 22:02:16 +02:00
852ef4021b
more spaces + some curly spaces added
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-06-20 22:02:16 +02:00
f2f12d6f50
Minor improvements:
...
- added spaces and curly braces
- added more TODOs as there really more to be done
- removed redundant braces from "return" keyword (no function)
- merged 2 nested if() into one single
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-06-20 22:02:15 +02:00
962fbc9166
Many "fetch_first" had been replaced
2018-06-19 21:33:07 +00:00
ab5669e091
Some more direct SQL calls had been replaced
2018-06-19 19:06:17 +00:00
Hypolite Petovan
82d55f120f
Merge pull request #5238 from annando/more-abstraction
...
Even more replaced item calls ...
2018-06-19 14:02:43 -04:00
e4adaa9900
Standards and variable renaming
2018-06-19 17:11:59 +00:00
rabuzarus
0a97a3f822
Bugfix: hide savedsearch butten and subthread button for non local_users
2018-06-19 18:27:54 +02:00
a5ca724fd3
Merge remote-tracking branch 'upstream/develop' into more-abstraction
2018-06-19 13:48:19 +00:00
4714cb746b
Use the item functions at many more places
2018-06-18 20:36:34 +00:00
Michael Vogel
f828350ba2
Merge pull request #5234 from fabrixxm/fix/api
...
API: fix sender/recipient of PMs
2018-06-18 12:03:53 +02:00
fabrixxm
e3ee9ee501
API: fix sender/recipient of PMs: check api_user before get user info.
...
To throw ForbiddenException and pass tests
2018-06-18 11:55:02 +02:00
507956818d
Use the item classes where possible
2018-06-18 05:19:28 +00:00
fabrixxm
c015bb1b77
API: fix sender/recipient of PMs
2018-06-17 19:57:32 +02:00
6e10de9284
New function to fetch item data especially for users
2018-06-17 17:05:17 +00:00
0280a46ab4
Use predefined field lists
2018-06-17 06:27:52 +00:00
abef0cd46c
Don't use the author-link anymore - just author-id
2018-06-16 15:35:30 +00:00
14cb128264
New function for generating item URI
2018-06-16 06:44:19 +00:00
bb79b8f4ac
More item calls have been replaced with the new functions
2018-06-15 22:30:49 +00:00
Hypolite Petovan
7469de29f1
Fix corrupt registration emails
...
- Use double quotes for line break-containing translation string
- Simplify HTML/plaintext email body conversion
2018-06-14 23:42:08 -04:00
Hypolite Petovan
d46cac7905
Wrap content filter around entire post including attachments
2018-06-12 21:54:36 -04:00
738644a006
Quit if database connection was lost during "e"
2018-06-11 03:56:19 +00:00
8584e09e12
Store the database credentials for reconnect
2018-06-11 03:45:45 +00:00
b02cdc8a7f
Merge remote-tracking branch 'upstream/develop' into quit-on-error
2018-06-11 03:15:59 +00:00
aa3f8ec09d
Force a database reconnection in the daemon to prevent lost connections
2018-06-10 22:04:09 +00:00
5d9083c369
Bugfix in notifications / network and display are using the new functions now
2018-06-10 07:26:37 +00:00
defd3d15b6
Possibly fixed test
2018-06-09 20:39:40 +00:00
b6c344a80a
$r was still in use
2018-06-09 20:08:15 +00:00
50dfc7d36e
Small query corrections
2018-06-09 19:27:44 +00:00
446a45003d
Added documentation, some indention fixes
2018-06-09 19:12:13 +00:00
baf316e898
The central item fetch does work now and the API now uses these functions
2018-06-09 16:56:37 +00:00
4874e589f1
New class function to fetch items
2018-06-07 06:03:12 +00:00
e632be763c
Corrected variable
2018-06-05 05:44:04 +00:00
18a77a1b45
Removed some quick and dirty hack to upload pictures
2018-06-05 05:42:26 +00:00
Hypolite Petovan
0a13ab6b9f
Merge pull request #5166 from annando/unsed-item-fields
...
Remove unused, unneeded or redundant item fields
2018-06-03 12:19:50 -04:00
Hypolite Petovan
973ece09c5
Merge pull request #5157 from annando/daemon
...
Workers can now be started exclusively from the daemon and other workers
2018-06-03 12:18:47 -04:00
443d828ba7
We don't need to look for the uid
2018-06-03 10:29:42 +00:00
6985ad4fb5
Improved error message
2018-06-03 09:55:41 +00:00
b654af28fa
We need "global"
2018-06-03 09:40:32 +00:00
ea498ff283
And a second SQL error fixed
2018-06-03 09:21:48 +00:00
d76fb6d0b9
Fixed SQL error
2018-06-03 09:19:27 +00:00
3f07d01dd1
Get rid of unneeded or redundant fields
2018-06-03 07:42:56 +00:00
a720c4f501
Removed unneeded fields from the API
2018-06-03 07:22:01 +00:00
723b5ae803
Use MagicLinkbyId when possible
2018-06-02 08:28:01 +00:00
8a34895a23
Use magicLink whenever possible
2018-06-02 08:05:06 +00:00
28f8beebfc
Workers can now be started exclusively from the daemon and other workers
2018-06-01 22:09:27 +00:00
b5b172500d
Merge remote-tracking branch 'upstream/develop' into public-redir
2018-06-01 12:32:51 +00:00
Hypolite Petovan
93daf7883e
Merge branch 'master' into develop
...
- Updated new develop version label
- Incremented database build number
2018-06-01 07:30:04 -04:00
ae8d7267a0
"redir" is now centralized and works with the public contact
2018-06-01 06:46:34 +00:00
8329705eba
New function to delete items for users
2018-05-29 05:22:57 +00:00
c5a22f86c7
Merge remote-tracking branch 'upstream/2018.05-rc' into deleted-item
2018-05-27 10:38:49 +00:00
Pascal Deklerck
334aa40292
Fix autoname output length
2018-05-27 10:20:27 +02:00
54136f3a74
Added the new parameter to the delete function.
2018-05-26 21:38:45 +00:00
4c36109f02
Some more places to add the user id
2018-05-26 20:03:30 +00:00
bdbc51229a
Fix for not being able to delete items
2018-05-26 18:07:27 +00:00
de609e49f0
Improved logging
2018-05-24 22:00:54 +00:00
f8230badba
Avoid problems with better variable naming
2018-05-24 21:46:57 +00:00
1bce39120d
Reconnect after the connection had been lost.
2018-05-24 21:19:59 +00:00
Hypolite Petovan
b0155fe37b
Remove obsolete DNS test from include/dba
2018-05-24 01:31:03 -04:00
87b5e26063
Do a hard exit when the SQL connection went down
2018-05-24 04:07:39 +00:00
3fe07cca57
Issue 2880: Editing post doesn't destroy mentions or hashtags anymore
2018-05-19 14:55:27 +00:00
Alexandre Alapetite
e7d2d27938
sizeof bug
...
sizeof cannot be used to test existance.
Fixes: Got error 'PHP message: PHP Warning: sizeof(): Parameter must be
an array or an object that implements Countable in
/.../include/items.php on line 66\n': 1 Time(s)
PHP 7.2.5 / Ubuntu 17.04 LTS
2018-05-17 07:37:50 +02:00
Hypolite Petovan
ce75177d4e
Merge pull request #5022 from Rudloff/feature/test_api
...
Add API tests
2018-05-16 08:25:11 -04:00
c9f55f6b3d
Show "Remove from your screen" or "delete" depending of the impact of the deletion
2018-05-15 21:06:34 +00:00
f34d72c143
Fixes:
...
- used empty() instead of x()
- removed superflous count()
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:22 +02:00
d0c7ba5257
Fixed parser error
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:21 +02:00
debcdea82a
Continued:
...
- merged 2 if() into one with &&
- added TODO for possible rewrite (avoid "complex" code)
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:05 +02:00
bacb7b70f6
Cleanups:
...
- added empty lines
- removed old-lost commented out line
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:05 +02:00
94a02f8572
Continued:
...
- return is a keyword, not a function, so don't add braces here
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:05 +02:00
57e668d9e0
Continued:
...
- avoided else() block which reduces code complexibility
- used more x()
- added curly braces
- added known type-hints
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:05 +02:00
e0a07d5f27
Continued:
...
- used x() to make sure the array key is there, else an E_NOTICE is triggered
- added type-hints where it is safe
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:04 +02:00
47f95855c0
added spaces + some curly braces + some usage of dbm::is_result()
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:01 +02:00
de50d62b81
more spaces + some curly spaces added
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:01 +02:00
35ada99954
Opps, added missing curly brace.
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:58 +02:00
78ffd5b80f
fixed parser error
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:58 +02:00
1c9dc6526f
Continued:
...
- added more curly braces
- replaced if (blaFoo()) { return true; } return false; with return blaFoo();
- added spaces
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:58 +02:00
337824f649
Continued:
...
- added curly braces/spaces
- added TODOs (type-hints, old-lost code)
- more usage of dbm::is_result()
- combined some if() return stuff into a simple return statement
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:58 +02:00
c3c9a53364
added spaces + curly braces and TODOs for upcoming type-hint rewrite. Please
...
note that PHP5 allows 'array' as type-hint already (+ interface/class name).
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:58 +02:00
61fdc32d2f
Continued a bit:
...
- more spaces added
- more curly braces added
- let's use x($_FOO, 'bar') and not isset($_FOOT['bar'])
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:57 +02:00
09384119b1
added spaces + some curly braces + some usage of dbm::is_result()
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:55 +02:00
c7e256f9de
more spaces + some curly spaces added
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:55 +02:00
1a61cee5a7
added spaces + some curly braces
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:55 +02:00
f7ceea7a85
added spaces + some curly braces
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:55 +02:00
5b56f189ae
more spaces + some curly spaces added
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:54 +02:00
bc259cdc44
added spaces + some curly braces
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:54 +02:00
914a4e2e0a
Fix: Public items werent visible under certain circumstances
2018-05-10 22:06:34 +00:00
Pierre Rudloff
3195d6e125
Add API tests
2018-05-10 19:12:00 +02:00
df019eb5bd
Issue 4772: Display posts with uid=0 as well
2018-05-10 10:13:48 +00:00
6c792588fd
Ensure to mostly fetch the item with an non zero user id
2018-05-08 22:26:49 +00:00
8d513d74be
Reverted SQL sorting
2018-05-08 22:08:25 +00:00
14833edb2d
Issue 4990: Fixes missing posts on network page
2018-05-08 22:00:32 +00:00
Pierre Rudloff
9bb11ccfa5
$attachments should aways be an array
...
In order to avoid a PHP 7.2 error when using count()
2018-05-08 12:16:48 +02:00
Pierre Rudloff
23371880e8
$called_api should always be an array
...
In order to avoid a PHP 7.2 error when using count()
2018-05-08 12:16:48 +02:00
Hypolite Petovan
3a3a4807a8
Merge pull request #4978 from annando/dba-2
...
Diaspora: Fix person/contact retraction
2018-05-04 18:04:38 -04:00
7cd7b1a9bf
Some more replaced queries
2018-05-04 21:43:29 +00:00
125afb4ae5
Suppress blocked contacts from being displayed
2018-05-04 21:27:20 +00:00
a83970bc0e
Some more dba stuff
2018-05-04 06:33:36 +00:00
4ad655ab80
Replace old database queries with the new ones
2018-05-02 19:26:15 +00:00
b4f5311e7f
Add Install Mode
...
- merge `friendica/develop` to `nupplaphil/install_mode`
2018-04-29 20:15:12 +02:00
Michael Vogel
bd0ba24518
Merge pull request #4951 from MrPetovan/bug/4946-move-current-theme-to-app
...
Move current_theme() to App
2018-04-29 19:11:49 +02:00
78f563407a
Fix PR 4942: Fixed item query
2018-04-29 16:32:46 +00:00
Hypolite Petovan
20289393da
Fix own post check for content filter
2018-04-28 19:11:11 -04:00
Hypolite Petovan
fde3d6f870
Replace current_theme() and current_theme_url() calls
2018-04-28 18:37:25 -04:00
Hypolite Petovan
9edff6cc5c
Add exception for self-contact in item_joins()
2018-04-28 11:38:01 -04:00
