Protect potentially missing array keys in mod/profiles

- Addresses https://github.com/friendica/friendica/issues/8000#issuecomment-568784029
- Addresses https://github.com/friendica/friendica/issues/8000#issuecomment-568785161
This commit is contained in:
Hypolite Petovan 2019-12-24 12:45:30 -05:00
parent 3694396758
commit b4704b7205

View file

@ -207,7 +207,7 @@ function profiles_post(App $a) {
return; return;
} }
$dob = $_POST['dob'] ? Strings::escapeHtml(trim($_POST['dob'])) : '0000-00-00'; $dob = !empty($_POST['dob']) ? Strings::escapeHtml(trim($_POST['dob'])) : '0000-00-00';
$y = substr($dob, 0, 4); $y = substr($dob, 0, 4);
if ((! ctype_digit($y)) || ($y < 1900)) { if ((! ctype_digit($y)) || ($y < 1900)) {
@ -238,17 +238,17 @@ function profiles_post(App $a) {
$namechanged = true; $namechanged = true;
} }
$pdesc = Strings::escapeTags(trim($_POST['pdesc'])); $pdesc = Strings::escapeTags(trim($_POST['pdesc'] ?? ''));
$gender = Strings::escapeTags(trim($_POST['gender'])); $gender = Strings::escapeTags(trim($_POST['gender'] ?? ''));
$address = Strings::escapeTags(trim($_POST['address'])); $address = Strings::escapeTags(trim($_POST['address'] ?? ''));
$locality = Strings::escapeTags(trim($_POST['locality'])); $locality = Strings::escapeTags(trim($_POST['locality'] ?? ''));
$region = Strings::escapeTags(trim($_POST['region'])); $region = Strings::escapeTags(trim($_POST['region'] ?? ''));
$postal_code = Strings::escapeTags(trim($_POST['postal_code'])); $postal_code = Strings::escapeTags(trim($_POST['postal_code'] ?? ''));
$country_name = Strings::escapeTags(trim($_POST['country_name'])); $country_name = Strings::escapeTags(trim($_POST['country_name'] ?? ''));
$pub_keywords = profile_clean_keywords(Strings::escapeTags(trim($_POST['pub_keywords']))); $pub_keywords = profile_clean_keywords(Strings::escapeTags(trim($_POST['pub_keywords'] ?? '')));
$prv_keywords = profile_clean_keywords(Strings::escapeTags(trim($_POST['prv_keywords']))); $prv_keywords = profile_clean_keywords(Strings::escapeTags(trim($_POST['prv_keywords'] ?? '')));
$marital = Strings::escapeTags(trim($_POST['marital'])); $marital = Strings::escapeTags(trim($_POST['marital'] ?? ''));
$howlong = Strings::escapeTags(trim($_POST['howlong'])); $howlong = Strings::escapeTags(trim($_POST['howlong'] ?? ''));
$with = (!empty($_POST['with']) ? Strings::escapeTags(trim($_POST['with'])) : ''); $with = (!empty($_POST['with']) ? Strings::escapeTags(trim($_POST['with'])) : '');
@ -338,7 +338,7 @@ function profiles_post(App $a) {
$hide_friends = (($_POST['hide-friends'] == 1) ? 1: 0); $hide_friends = (($_POST['hide-friends'] == 1) ? 1: 0);
PConfig::set(local_user(), 'system', 'detailled_profile', (($_POST['detailed_profile'] == 1) ? 1: 0)); PConfig::set(local_user(), 'system', 'detailled_profile', !empty($_POST['detailed_profile']) ? 1: 0);
$changes = []; $changes = [];
if ($is_default) { if ($is_default) {