Fixings

- Rename "facStorage" to "storageManager"
- Fix indentation
- Fix tests

doc/AddonStorageBackend.md

@@ -250,13 +250,13 @@ function samplestorage_install()
 	// on addon install, we register our class with name "Sample Storage".
 	// note: we use `::class` property, which returns full class name as string
 	// this save us the problem of correctly escape backslashes in class name
-	DI::facStorage()->register(SampleStorageBackend::class);
+	DI::storageManager()->register(SampleStorageBackend::class);
 }
 
 function samplestorage_unistall()
 {
 	// when the plugin is uninstalled, we unregister the backend.
-	DI::facStorage()->unregister(SampleStorageBackend::class);
+	DI::storageManager()->unregister(SampleStorageBackend::class);
 }
 
 function samplestorage_storage_instance(\Friendica\App $a, array $data)

src/DI.php

@@ -27,7 +27,7 @@ use Psr\Log\LoggerInterface;
  * @method static Core\L10n\L10n l10n()
  * @method static Core\Process process()
  * @method static Core\Session\ISession session()
- * @method static Core\StorageManager facStorage()
+ * @method static Core\StorageManager storageManager()
  * @method static Database\Database dba()
  * @method static Factory\Mastodon\Account mstdnAccount()
  * @method static Factory\Mastodon\FollowRequest mstdnFollowRequest()
@@ -66,7 +66,7 @@ abstract class DI
 		'lock'               => Core\Lock\ILock::class,
 		'process'            => Core\Process::class,
 		'session'            => Core\Session\ISession::class,
-		'facStorage'   => Core\StorageManager::class,
+		'storageManager'     => Core\StorageManager::class,
 		'dba'                => Database\Database::class,
 		'mstdnAccount'       => Factory\Mastodon\Account::class,
 		'mstdnFollowRequest' => Factory\Mastodon\FollowRequest::class,

src/Model/Attach.php

@@ -259,7 +259,7 @@ class Attach
 			$items = self::selectToArray(['backend-class','backend-ref'], $conditions);
 
 			foreach($items as $item) {
-				$backend_class = DI::facStorage()->getByName($item['backend-class'] ?? '');
+				$backend_class = DI::storageManager()->getByName($item['backend-class'] ?? '');
 				if ($backend_class !== '') {
 					$fields['backend-ref'] = $backend_class->put($img->asString(), $item['backend-ref'] ?? '');
 				} else {
@@ -291,7 +291,7 @@ class Attach
 		$items = self::selectToArray(['backend-class','backend-ref'], $conditions);
 
 		foreach($items as $item) {
-			$backend_class = DI::facStorage()->getByName($item['backend-class'] ?? '');
+			$backend_class = DI::storageManager()->getByName($item['backend-class'] ?? '');
 			if ($backend_class !== null) {
 				$backend_class->delete($item['backend-ref'] ?? '');
 			}

src/Model/Photo.php

@@ -179,7 +179,7 @@ class Photo
 			}
 			$data = $i['data'];
 		} else {
-			$backendClass = DI::facStorage()->getByName($photo['backend-class'] ?? '');
+			$backendClass = DI::storageManager()->getByName($photo['backend-class'] ?? '');
 			$backendRef = $photo['backend-ref'] ?? '';
 			$data = $backendClass->get($backendRef);
 		}
@@ -272,7 +272,7 @@ class Photo
 
 		if (DBA::isResult($existing_photo)) {
 			$backend_ref = (string)$existing_photo["backend-ref"];
-			$storage = DI::facStorage()->getByName($existing_photo["backend-class"] ?? '');
+			$storage = DI::storageManager()->getByName($existing_photo["backend-class"] ?? '');
 		} else {
 			$storage = DI::storage();
 		}
@@ -336,7 +336,7 @@ class Photo
 		$photos = self::selectToArray(['backend-class', 'backend-ref'], $conditions);
 
 		foreach($photos as $photo) {
-			$backend_class = DI::facStorage()->getByName($photo['backend-class'] ?? '');
+			$backend_class = DI::storageManager()->getByName($photo['backend-class'] ?? '');
 			if ($backend_class !== null) {
 				$backend_class->delete($photo["backend-ref"] ?? '');
 			}
@@ -365,7 +365,7 @@ class Photo
 			$photos = self::selectToArray(['backend-class', 'backend-ref'], $conditions);
 
 			foreach($photos as $photo) {
-				$backend_class = DI::facStorage()->getByName($photo['backend-class'] ?? '');
+				$backend_class = DI::storageManager()->getByName($photo['backend-class'] ?? '');
 				if ($backend_class !== null) {
 					$fields["backend-ref"] = $backend_class->put($img->asString(), $photo['backend-ref']);
 				} else {

src/Module/Admin/Site.php

@@ -202,7 +202,7 @@ class Site extends BaseAdminModule
 		$storagebackend    = Strings::escapeTags(trim($_POST['storagebackend'] ?? ''));
 
 		// save storage backend form
-		if (DI::facStorage()->setBackend($storagebackend)) {
+		if (DI::storageManager()->setBackend($storagebackend)) {
 			$storage_opts     = DI::storage()->getOptions();
 			$storage_form_prefix = preg_replace('|[^a-zA-Z0-9]|', '', $storagebackend);
 			$storage_opts_data   = [];
@@ -534,7 +534,7 @@ class Site extends BaseAdminModule
 			$available_storage_backends[''] = L10n::t('Database (legacy)');
 		}
 
-		foreach (DI::facStorage()->listBackends() as $name => $class) {
+		foreach (DI::storageManager()->listBackends() as $name => $class) {
 			$available_storage_backends[$name] = $name;
 		}
 

src/Worker/CronJobs.php

@@ -325,7 +325,7 @@ class CronJobs
 	private static function moveStorage()
 	{
 		$current = DI::storage();
-		$moved = DI::facStorage()->move($current);
+		$moved = DI::storageManager()->move($current);
 
 		if ($moved) {
 			Worker::add(PRIORITY_LOW, "CronJobs", "move_storage");

tests/src/Core/StorageManagerTest.php

@@ -28,7 +28,6 @@ use Friendica\Test\Util\SampleStorageBackend;
  * @todo Rework Hook:: methods to dynamic to remove the separated process annotation
  *
  * @runTestsInSeparateProcesses
- * @preserveGlobalState disabled
  */
 class StorageManagerTest extends DatabaseTest
 {