Ping is now using a standard routine to generate the xml.

include/xml.php

@@ -61,6 +61,18 @@ class xml {
 				continue;
 			}
 
+			$element_parts = explode(":", $key);
+			if ((count($element_parts) > 1) AND isset($namespaces[$element_parts[0]]))
+				$namespace = $namespaces[$element_parts[0]];
+			elseif (isset($namespaces[""])) {
+				$namespace = $namespaces[""];
+			} else
+				$namespace = NULL;
+
+			// Remove undefined namespaces from the key
+			if ((count($element_parts) > 1) AND is_null($namespace))
+				$key = $element_parts[1];
+
 			if (substr($key, 0, 11) == "@attributes") {
 				if (!isset($element) OR !is_array($value))
 					continue;
@@ -78,14 +90,6 @@ class xml {
 				continue;
 			}
 
-			$element_parts = explode(":", $key);
-			if ((count($element_parts) > 1) AND isset($namespaces[$element_parts[0]]))
-				$namespace = $namespaces[$element_parts[0]];
-			elseif (isset($namespaces[""]))
-				$namespace = $namespaces[""];
-			else
-				$namespace = NULL;
-
 			if (!is_array($value))
 				$element = $xml->addChild($key, xmlify($value), $namespace);
 			elseif (is_array($value)) {

mod/ping.php

@@ -4,22 +4,16 @@ require_once('include/bbcode.php');
 require_once('include/ForumManager.php');
 require_once('include/group.php');
 require_once("mod/proxy.php");
+require_once('include/xml.php');
 
 function ping_init(&$a) {
 
-	header("Content-type: text/xml");
-
-	echo "<?xml version=\"1.0\" encoding=\"UTF-8\" ?>
-		<result>";
-
-	$xmlhead="<"."?xml version='1.0' encoding='UTF-8' ?".">";
-
 	if (local_user()){
-
 		// Different login session than the page that is calling us.
-
 		if (intval($_GET['uid']) && intval($_GET['uid']) != local_user()) {
-			echo '<invalid>1</invalid></result>';
+		        $data = array("invalid" => 1);
+			header("Content-type: text/xml");
+			echo xml::from_array(array("result" => $data));
 			killme();
 		}
 
@@ -175,90 +169,56 @@ function ping_init(&$a) {
 			}
 		}
 
+	        $data = array();
+	        $data["intro"] = $intro;
+	        $data["mail"] = $mail;
+	        $data["net"] = $network;
+	        $data["home"] = $home;
 
-		/**
+		if ($register!=0)
-		 * return xml from notification array
+		        $data["register"] = $register;
-		 *
-		 * @param array $n Notification array:
-		 *		'href' => notification link
-		 *		'name' => subject name
-		 *		'url' => subject url
-		 *		'photo' => subject photo
-		 *		'date' => notification date
-		 *		'seen' => bool true/false
-		 *		'message' => notification message. "{0}" will be replaced by subject name
-		 **/
-		function xmlize($n){
 
-			$contact = get_contact_details_by_url($n['url']);
+		$groups = array();
-			if (isset($contact["micro"]))
-				$n['photo'] = proxy_url($contact["micro"], false, PROXY_SIZE_MICRO);
-			else
-				$n['photo'] = proxy_url($n['photo'], false, PROXY_SIZE_MICRO);
-
-			$n['message'] = html_entity_decode($n['message'], ENT_COMPAT | ENT_HTML401, "UTF-8");
-			$n['name'] = html_entity_decode($n['name'], ENT_COMPAT | ENT_HTML401, "UTF-8");
-
-			// Are the nofications calles from the regular process or via the friendica app?
-			$regularnotifications = (intval($_GET['uid']) AND intval($_GET['_']));
-
-			$a = get_app();
-
-			if ($a->is_friendica_app() OR !$regularnotifications)
-				$n['message'] = str_replace("{0}", $n['name'], $n['message']);
-
-			$local_time = datetime_convert('UTC',date_default_timezone_get(),$n['date']);
-
-			call_hooks('ping_xmlize', $n);
-			$notsxml = '<note id="%d" href="%s" name="%s" url="%s" photo="%s" date="%s" seen="%s" timestamp="%s" >%s</note>'."\n";
-			return sprintf ( $notsxml, intval($n['id']),
-				xmlify($n['href']), xmlify(xmlify($n['name'])), xmlify($n['url']), xmlify($n['photo']),
-				xmlify(relative_date($n['date'])), xmlify($n['seen']), xmlify(strtotime($local_time)),
-				xmlify($n['message'])
-			);
-		}
-
-		echo "<intro>$intro</intro>
-				<mail>$mail</mail>
-				<net>$network</net>
-				<home>$home</home>\r\n";
-		if ($register!=0) echo "<register>$register</register>";
 
 		if (dbm::is_result($groups_unseen)) {
-			echo '<groups>';
+			$count = 0;
 			foreach ($groups_unseen as $it)
-				if ($it['count'] > 0)
+				if ($it['count'] > 0) {
-					echo '<group id="'.$it['id'].'">'.$it['count']."</group>";
+					$count++;
-
+					$groups[$count.":group"] = $it['count'];
-			echo "</groups>";
+					$groups[$count.":@attributes"] = array("id" => $it['id']);
 				}
+			$data["groups"] = $groups;
+		}
+
+		$forums = array();
 
 		if (dbm::is_result($forums_unseen)) {
-			echo '<forums>';
+			$count = 0;
 			foreach ($forums_unseen as $it)
-				if ($it['count'] > 0)
+				if ($it['count'] > 0) {
-					echo '<forum id="'.$it['id'].'">'.$it['count']."</forum>";
+					$count++;
-
+					$forums[$count.":forum"] = $it['count'];
-			echo "</forums>";
+					$forums[$count.":@attributes"] = array("id" => $it['id']);
+				}
+			$data["forums"] = $forums;
 		}
 
-		echo "<all-events>$all_events</all-events>
+		$data["all-events"] = $all_events;
-			<all-events-today>$all_events_today</all-events-today>
+		$data["all-events-today"] = $all_events_today;
-			<events>$events</events>
+		$data["events"] = $events;
-			<events-today>$events_today</events-today>
+		$data["events-today"] = $events_today;
-			<birthdays>$birthdays</birthdays>
+		$data["birthdays"] = $birthdays;
-			<birthdays-today>$birthdays_today</birthdays-today>\r\n";
+		$data["birthdays-today"] = $birthdays_today;
 
 
-		if (dbm::is_result($notifs) && (! $sysnotify)) {
+		if (dbm::is_result($notifs) && !$sysnotify) {
 			foreach ($notifs as $zz) {
 				if ($zz['seen'] == 0)
 					$sysnotify ++;
 			}
 		}
 
-		echo '	<notif count="'. ($sysnotify + $intro + $mail + $register) .'">';
-
 		// merge all notification types in one array
 		if (dbm::is_result($intros)) {
 			foreach ($intros as $i) {
@@ -317,33 +277,68 @@ function ping_init(&$a) {
 		usort($notifs, $sort_function);
 
 		if (dbm::is_result($notifs)) {
+
+			// Are the nofications calles from the regular process or via the friendica app?
+			$regularnotifications = (intval($_GET['uid']) AND intval($_GET['_']));
+
+			$count = 0;
 			foreach($notifs as $n) {
-				echo xmlize($n);
+				$count++;
+				if ($a->is_friendica_app() OR !$regularnotifications)
+					$n['message'] = str_replace("{0}", $n['name'], $n['message']);
+
+				$notifications[$count.":note"] = $n['message'];
+
+				$contact = get_contact_details_by_url($n['url']);
+				if (isset($contact["micro"]))
+					$n['photo'] = proxy_url($contact["micro"], false, PROXY_SIZE_MICRO);
+				else
+					$n['photo'] = proxy_url($n['photo'], false, PROXY_SIZE_MICRO);
+
+				$local_time = datetime_convert('UTC',date_default_timezone_get(),$n['date']);
+
+				call_hooks('ping_xmlize', $n);
+
+				$notifications[$count.":@attributes"] = array("id" => $n["id"],
+										"href" => $n['href'],
+										"name" => $n['name'],
+										"url" => $n['url'],
+										"photo" => $n['photo'],
+										"date" => relative_date($n['date']),
+										"seen" => $n['seen'],
+										"timestamp" => strtotime($local_time));
+
 			}
 		}
 
-
+		$data["notif"] = $notifications;
-		echo "  </notif>";
+		$data["@attributes"] = array("count" => $sysnotify + $intro + $mail + $register);
 	}
-	echo " <sysmsgs>";
+
+	$sysmsg = array();
 
 	if (x($_SESSION,'sysmsg')){
+		$count = 0;
 		foreach ($_SESSION['sysmsg'] as $m){
-			echo "<notice>".xmlify($m)."</notice>";
+			$count++;
+			$sysmsg[$count.":notice"] = $m;
 		}
 		unset($_SESSION['sysmsg']);
 	}
+
 	if (x($_SESSION,'sysmsg_info')){
+		$count = 0;
 		foreach ($_SESSION['sysmsg_info'] as $m){
-			echo "<info>".xmlify($m)."</info>";
+			$count++;
+			$sysmsg[$count.":info"] = $m;
 		}
 		unset($_SESSION['sysmsg_info']);
 	}
 
-	echo " </sysmsgs>";
+	$data["sysmsgs"] = $sysmsg;
-	echo"</result>
-	";
 
+	header("Content-type: text/xml");
+	echo xml::from_array(array("result" => $data));
 	killme();
 }