Blockbot: Reworked user agent parsing #1500

heluecht · 2024-04-30T14:43:31+02:00

heluecht commented

2024-04-30 14:43:31 +02:00

This is a complete rework of the addon. There had been many issues with the way, the user agent had been parsed. There is now a sophisticated user gent string parser that had been tested with more than 22,000 entries, gathered from my servers and from public lists. Also included is some simple threat protection. The system will now reject any access to some critical paths like the login for any user agent that doesn't appear to be a regular browser.

heluecht added 1 commit 2024-04-30 14:43:31 +02:00

f5f8f9566f Blockbot: Reworked user agent parsing

heluecht added the

2024.06

label 2024-04-30 14:43:48 +02:00

MrPetovan requested changes 2024-05-01 03:06:21 +02:00

Dismissed

blockbot/blockbot.php Outdated

					
				@ -109,2 +71,2 @@

						$agents = array_merge($agents, $good_agents);

					} elseif (blockbot_match($good_agents)) {

					if (empty($parts)) {

						logger::debug('Known frontend found', $logdata);

MrPetovan commented

2024-05-01 02:57:27 +02:00

logger should read Logger across the file.

`logger` should read `Logger` across the file.

heluecht commented

2024-05-04 03:23:59 +02:00

Done

blockbot/blockbot.php Outdated

					
				@ -183,0 +171,4 @@

						return;

					}

					$ressource = dba_open(System::getTempPath() . '/' . $database, 'cl');

MrPetovan commented

2024-05-01 03:06:17 +02:00

$resource.

`$resource`.

heluecht commented

2024-05-04 03:22:24 +02:00

Done

blockbot/blockbot.php Outdated

					
				@ -188,0 +721,4 @@

							$part = substr($part, 0, $pos1 - 1) . substr($part, $pos2 + 1);

						}

						$part = trim(preg_replace('=(.*) [\d\.]+=', '$1', $part), ' +,-;­');

MrPetovan commented

2024-05-01 03:06:01 +02:00

There's a warning that says "This line has invisible Unicode characters" in the trim() character list, is this intended?

If yes please use the \u{00AD} notation in double quotes.

There's a warning that says "This line has invisible Unicode characters" in the `trim()` character list, is this intended? If yes please use the `\u{00AD}` notation in double quotes.

heluecht commented

2024-05-04 03:22:14 +02:00

Is changed