[piwik] Short Endpoint option #1379

Merged
MrPetovan merged 1 commit from EntropyEngineer/friendica-addons:piwik-Short-Endpoint-option into develop 2023-04-30 13:43:36 +02:00
Contributor

[piwik] Short Endpoint option

Added setting for short endpoint.
If you are concerned about the impact of browser-based privacy filters which attempt to block tracking, you can change your tracking code to use "js/" instead of "piwik.js" and "piwik.php", respectively.

link to the description of this functionality:
https://github.com/lipis/piwik/blob/master/js/README.md

Support for this option exists in current versions of piwik and matomo.

[piwik] Short Endpoint option Added setting for short endpoint. If you are concerned about the impact of browser-based privacy filters which attempt to block tracking, you can change your tracking code to use "js/" instead of "piwik.js" and "piwik.php", respectively. link to the description of this functionality: https://github.com/lipis/piwik/blob/master/js/README.md Support for this option exists in current versions of piwik and matomo.
EntropyEngineer added 2 commits 2023-04-29 15:56:26 +02:00
MrPetovan requested changes 2023-04-29 21:31:22 +02:00
MrPetovan left a comment
Owner

Please rebase your branch onto the latest develop branch to avoid having merge commits in your pull request history. Let me know if you need help doing it.

Please rebase your branch onto the latest `develop` branch to avoid having merge commits in your pull request history. Let me know if you need help doing it.
piwik/piwik.php Outdated
@ -25,6 +25,7 @@
* 'sideid' => '',
* 'optout' => true,
* 'async' => false,
* 'shortendpoint' => false,
Owner

Please match the indentation style of the previous lines.

 *              'shortendpoint' => false,
Please match the indentation style of the previous lines. ``` * 'shortendpoint' => false, ```
EntropyEngineer marked this conversation as resolved
piwik/piwik.php Outdated
@ -61,3 +62,3 @@
* into the page header.
*/
DI::page()['htmlhead'] .= '<link rel="stylesheet" type="text/css" href="' . DI::baseUrl() . '/addon/piwik/piwik.css' . '" media="all" />';
DI::page()['htmlhead'] .= '<link rel="stylesheet" type="text/css" href="' . DI::baseUrl() . '/addon/piwik/piwik.css" media="all" />';
Owner

Please use the App\Page->registerStylesheet() method instead.

	DI::page()->registerStylesheet('addon/piwik/piwik.css', 'all');
Please use the `App\Page->registerStylesheet()` method instead. ```php DI::page()->registerStylesheet('addon/piwik/piwik.css', 'all'); ```
EntropyEngineer marked this conversation as resolved
tobias reviewed 2023-04-30 07:45:31 +02:00
@ -9,3 +9,4 @@ $a->strings["Site ID"] = "ID сайта";
$a->strings["Show opt-out cookie link?"] = "Показать ссылку opt-out cookie?";
$a->strings["Asynchronous tracking"] = "Асинхронное отслеживание";
$a->strings["Settings updated."] = "Настройки обновлены.";
$a->strings["Shortcut path to the script ('/js/' instead of '/piwik.js')"] = "Сокращенный путь к скрипту ('/js/' вместо '/piwik.js')";
Owner

These translations will get overwritten, once updates from Transifex will be pulled in. Once the addon source file is checked from their system and the strings for the addon updated, you should make sure that this translation is added there.

These translations will get overwritten, once updates from Transifex will be pulled in. Once the addon source file is checked from their system and the strings for the addon updated, you should make sure that this translation is added there.
Author
Contributor

I understand

I understand
EntropyEngineer marked this conversation as resolved
EntropyEngineer closed this pull request 2023-04-30 09:56:15 +02:00
EntropyEngineer deleted branch piwik-Short-Endpoint-option 2023-04-30 09:56:28 +02:00
EntropyEngineer reopened this pull request 2023-04-30 10:32:41 +02:00
EntropyEngineer force-pushed piwik-Short-Endpoint-option from 0d7f0c8191 to 199205a07c 2023-04-30 10:34:29 +02:00 Compare
EntropyEngineer requested review from MrPetovan 2023-04-30 10:41:58 +02:00
MrPetovan approved these changes 2023-04-30 13:43:31 +02:00
MrPetovan left a comment
Owner

Thank you for your work!

Thank you for your work!
MrPetovan merged commit df2e9863ed into develop 2023-04-30 13:43:36 +02:00
MrPetovan added the
2023.05
label 2023-04-30 13:43:41 +02:00
Sign in to join this conversation.
No description provided.