From 9f18d7e6ded53ce9338c624ed4228315581fb217 Mon Sep 17 00:00:00 2001
From: Michael <heluecht@pirati.ca>
Date: Sun, 25 Dec 2016 23:39:23 +0000
Subject: [PATCH 1/2] Twitter: The sync process is split into several short
 processes

---
 twitter/twitter.php      | 13 +++++--
 twitter/twitter_sync.php | 78 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 89 insertions(+), 2 deletions(-)
 create mode 100644 twitter/twitter_sync.php

diff --git a/twitter/twitter.php b/twitter/twitter.php
index 934b8d3ce..0f074ba31 100644
--- a/twitter/twitter.php
+++ b/twitter/twitter.php
@@ -625,7 +625,12 @@ function twitter_cron($a,$b) {
 	if(count($r)) {
 		foreach($r as $rr) {
 			logger('twitter: fetching for user '.$rr['uid']);
-			twitter_fetchtimeline($a, $rr['uid']);
+
+			if (get_config("system", "worker")) {
+				proc_run(PRIORITY_MEDIUM, "addon/twitter/twitter_sync.php", 1, $rr['uid']);
+			} else {
+				twitter_fetchtimeline($a, $rr['uid']);
+			}
 		}
 	}
 
@@ -647,8 +652,12 @@ function twitter_cron($a,$b) {
 			}
 
 			logger('twitter: importing timeline from user '.$rr['uid']);
-			twitter_fetchhometimeline($a, $rr["uid"]);
 
+			if (get_config("system", "worker")) {
+				proc_run(PRIORITY_MEDIUM, "addon/twitter/twitter_sync.php", 2, $rr['uid']);
+			} else {
+				twitter_fetchhometimeline($a, $rr["uid"]);
+			}
 /*
 			// To-Do
 			// check for new contacts once a day
diff --git a/twitter/twitter_sync.php b/twitter/twitter_sync.php
new file mode 100644
index 000000000..e8987f8f6
--- /dev/null
+++ b/twitter/twitter_sync.php
@@ -0,0 +1,78 @@
+<?php
+if (!file_exists("boot.php") AND (sizeof($_SERVER["argv"]) != 0)) {
+	$directory = dirname($_SERVER["argv"][0]);
+
+	if (substr($directory, 0, 1) != "/")
+		$directory = $_SERVER["PWD"]."/".$directory;
+
+	$directory = realpath($directory."/..");
+
+	chdir($directory);
+}
+
+require_once("boot.php");
+
+
+function twitter_sync_run($argv, $argc){
+	global $a, $db;
+
+	if(is_null($a)) {
+		$a = new App;
+	}
+
+	if(is_null($db)) {
+		@include(".htconfig.php");
+		require_once("include/dba.php");
+		$db = new dba($db_host, $db_user, $db_pass, $db_data);
+		unset($db_host, $db_user, $db_pass, $db_data);
+	};
+
+	require_once("addon/twitter/twitter.php");
+	require_once("include/pidfile.php");
+
+	$maxsysload = intval(get_config('system','maxloadavg'));
+	if($maxsysload < 1)
+		$maxsysload = 50;
+	if(function_exists('sys_getloadavg')) {
+		$load = sys_getloadavg();
+		if(intval($load[0]) > $maxsysload) {
+			logger('system: load ' . $load[0] . ' too high. Twitter sync deferred to next scheduled run.');
+			return;
+		}
+	}
+
+	if ($argc < 3) {
+		return;
+	}
+
+	$mode = intval($argv[1]);
+	$uid = intval($argv[2]);
+
+	/// @todo Replace it with "App::is_already_running" in the next release
+	$lockpath = get_lockpath();
+	if ($lockpath != '') {
+		$pidfile = new pidfile($lockpath, 'twitter_sync-'.$mode.'-'.$uid);
+		if($pidfile->is_already_running()) {
+			logger("Already running");
+			if ($pidfile->running_time() > 9*60) {
+				$pidfile->kill();
+				logger("killed stale process");
+				// Calling a new instance
+				proc_run('php','addon/twitter/twitter_sync.php', $mode, $uid);
+			}
+			exit;
+		}
+	}
+
+	if ($mode == 1) {
+		twitter_fetchtimeline($a, $uid);
+	} elseif ($mode == 2) {
+		twitter_fetchhometimeline($a, $uid);
+	}
+}
+
+if (array_search(__file__,get_included_files())===0){
+	twitter_sync_run($_SERVER["argv"],$_SERVER["argc"]);
+	killme();
+}
+?>

From bacb6b379bd8f58fec7b2164aadc2d3dffd622e9 Mon Sep 17 00:00:00 2001
From: Michael <heluecht@pirati.ca>
Date: Wed, 28 Dec 2016 03:28:26 +0000
Subject: [PATCH 2/2] Standards

---
 twitter/twitter_sync.php | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/twitter/twitter_sync.php b/twitter/twitter_sync.php
index e8987f8f6..434cb2042 100644
--- a/twitter/twitter_sync.php
+++ b/twitter/twitter_sync.php
@@ -16,11 +16,11 @@ require_once("boot.php");
 function twitter_sync_run($argv, $argc){
 	global $a, $db;
 
-	if(is_null($a)) {
+	if (is_null($a)) {
 		$a = new App;
 	}
 
-	if(is_null($db)) {
+	if (is_null($db)) {
 		@include(".htconfig.php");
 		require_once("include/dba.php");
 		$db = new dba($db_host, $db_user, $db_pass, $db_data);
@@ -31,11 +31,12 @@ function twitter_sync_run($argv, $argc){
 	require_once("include/pidfile.php");
 
 	$maxsysload = intval(get_config('system','maxloadavg'));
-	if($maxsysload < 1)
+	if ($maxsysload < 1) {
 		$maxsysload = 50;
-	if(function_exists('sys_getloadavg')) {
+	}
+	if (function_exists('sys_getloadavg')) {
 		$load = sys_getloadavg();
-		if(intval($load[0]) > $maxsysload) {
+		if (intval($load[0]) > $maxsysload) {
 			logger('system: load ' . $load[0] . ' too high. Twitter sync deferred to next scheduled run.');
 			return;
 		}
@@ -52,7 +53,7 @@ function twitter_sync_run($argv, $argc){
 	$lockpath = get_lockpath();
 	if ($lockpath != '') {
 		$pidfile = new pidfile($lockpath, 'twitter_sync-'.$mode.'-'.$uid);
-		if($pidfile->is_already_running()) {
+		if ($pidfile->is_already_running()) {
 			logger("Already running");
 			if ($pidfile->running_time() > 9*60) {
 				$pidfile->kill();