From 558962169ffe947906703f179d81aabccbd84a24 Mon Sep 17 00:00:00 2001
From: Friendika <info@friendika.com>
Date: Thu, 2 Jun 2011 00:52:26 -0700
Subject: [PATCH] warning message if Facebook post does not succeed. It happens
 quite a lot.

---
 addon/facebook/facebook.php | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/addon/facebook/facebook.php b/addon/facebook/facebook.php
index dc1aa02dd9..00098a7ddc 100644
--- a/addon/facebook/facebook.php
+++ b/addon/facebook/facebook.php
@@ -624,19 +624,23 @@ function facebook_post_hook(&$a,&$b) {
 				// "test_mode" prevents anything from actually being posted.
 				// Otherwise, let's do it. 
 
-				if(! get_config('facebook','test_mode'))
+				if(! get_config('facebook','test_mode')) {
 					$x = post_url($url, $postvars);
 
-				$retj = json_decode($x);
-				if($retj->id) {
-					q("UPDATE `item` SET `extid` = '%s' WHERE `id` = %d LIMIT 1",
-						dbesc('fb::' . $retj->id),
-						intval($b['id'])
-					);
+					$retj = json_decode($x);
+					if($retj->id) {
+						q("UPDATE `item` SET `extid` = '%s' WHERE `id` = %d LIMIT 1",
+							dbesc('fb::' . $retj->id),
+							intval($b['id'])
+						);
+					}
+					else {
+						// FIXME queue the message so we can attempt to redeliver, see include/notifier.php and include/queue.php
+						notice( t('Facebook delivery failed.') . EOL);
+					}
+					
+					logger('Facebook post returns: ' . $x, LOGGER_DEBUG);
 				}
-				
-				logger('Facebook post returns: ' . $x, LOGGER_DEBUG);
-
 			}
 		}
 	}