Commit graph

8953 commits

Author SHA1 Message Date
Michael 4e45987f74 Merge remote-tracking branch 'upstream/develop' into fetch-usage 2022-03-19 11:21:38 +00:00
Hypolite Petovan 4329f5381b
Merge pull request #11355 from annando/notifications
Fixes for the notifications
2022-03-19 06:52:04 -04:00
Michael aef9cb9992 Moved "ignore" check to a better location 2022-03-19 09:48:50 +00:00
Michael 1fe756b5b6 Fixes for the notifications 2022-03-19 09:27:49 +00:00
Hypolite Petovan 9eb6299f19 Check array key existence in ActivityPub\Transmitter::createPermissionBlockForItem
- APContact::getByURL can return empty array
- Address https://github.com/friendica/friendica/issues/11218#issuecomment-1066753232
2022-03-19 03:15:08 -04:00
Michael 0aa229489f Improved function description 2022-03-18 07:24:45 -04:00
Michael 040abc7743 Use a nicer GUID style format 2022-03-18 07:24:44 -04:00
Hypolite Petovan 04ac4841f9 Add support for notification visibility settings 2022-03-16 22:03:26 -04:00
Michael 0b10806ce3 Fix the problem that the post update never stopped on larger systems 2022-03-16 22:00:34 -04:00
Michael Vogel f5bcc4ad4b
Merge pull request #11346 from MrPetovan/bug/11343-memcached-bad-key
Suppress a couple MemcachedException
2022-03-16 15:19:40 +01:00
Tobias Diekershoff 8d64cf4f9b
typo 2022-03-16 06:25:21 +01:00
Hypolite Petovan 7b9e62198e Suppress a couple MemcachedException
- Replace URL by uri-id in apcontact
- Replace date with a space and nurl by nick and Zulu time in mod/poco
2022-03-15 10:54:00 -04:00
Hypolite Petovan a07f840c74 Add correct ordering for detailed notifications 2022-03-15 07:05:59 -04:00
Tobias Diekershoff 02b6ac3ed3
limit parameter was missing from docblock 2022-03-15 08:46:26 +01:00
Tobias Diekershoff 12038d45d0
PHP deprecation warning due wrong order of function parameters
With PHP 8.0 I got the following PHP Deprecation message

```
PHP Deprecated:  Required parameter $limit follows optional parameter $ids in src/Worker/UpdateContacts.php on line 104
```

this PR fixes the wrong order of the parameters.
2022-03-15 08:44:17 +01:00
Michael Vogel e252b5972e
Merge pull request #11336 from MrPetovan/task/4639-soapbox-intro-notification
Add exception when message is empty in FormatteNavNotification::createFromNotification
2022-03-15 07:09:24 +01:00
Hypolite Petovan 07d4cdbdde Fix misleading notification message strings
- The mentioned title is from the top-level post, not the liked post
2022-03-14 22:56:46 -04:00
Hypolite Petovan 36e85b01c6 Hide like notifications from menu again 2022-03-14 22:56:46 -04:00
Hypolite Petovan 73c7b88fb2 Add exception when message is empty in FormatteNavNotification::createFromNotification
- Filter out message less notifications in Ping
2022-03-14 22:56:44 -04:00
Hypolite Petovan 371b2b22bd
Merge pull request #11333 from annando/feed-guid
Don't use the GUID value directly
2022-03-14 18:02:29 -04:00
Michael 7940b31685 Don't use the GUID value directly 2022-03-14 21:09:14 +00:00
Hypolite Petovan e6f745bcb1 Delete follow notification on unfollow
- Fix translation string typo
2022-03-14 07:58:39 -04:00
Hypolite Petovan 49971b1465 Switch data source from notify to notification in Module\Notifications\Ping
- Change unused FormattedNotification classes to FormattedNavNotification classes
2022-03-14 07:58:38 -04:00
Hypolite Petovan 1ae7cac236 Move mod/ping to module class 2022-03-14 07:57:41 -04:00
Hypolite Petovan 5a12bd87f3 Replace Javascript notification string formatting with Smarty templates 2022-03-14 07:56:58 -04:00
Hypolite Petovan b7cee324b0 Add legacy notification endpoint for deprecated Notify entity
- Add dependencies to Notifications\Notification module class
2022-03-14 07:56:21 -04:00
Hypolite Petovan deafdcde95 Use public contact ID in Model\Post\UserNotification::insertNotification
- Add localRelationship dependency to Notification factory
- Remove dependencies from Factory\Notification->getMessageFromNotification method
2022-03-14 07:56:20 -04:00
Hypolite Petovan 7ce97459d4 Deprecated the notify table/classes 2022-03-14 07:56:20 -04:00
Michael 0956d1dd64 Don't send forum posts to the user's followers 2022-03-14 06:07:51 +00:00
Michael 2642996171 Send community posts only to the community 2022-03-13 19:31:21 +00:00
Michael ca086b880b Some small improvements for importing feeds 2022-03-13 15:29:07 +00:00
Michael 12d7c99f46 Don't send notifications for activities caused by the community contact 2022-03-13 05:44:29 +00:00
Hypolite Petovan 9e3dbfab3e
Merge pull request #11323 from annando/direction
Issue 11309: improved check for wanted posts
2022-03-12 13:42:08 -05:00
Michael 314bf92ead Added Documentation 2022-03-12 17:29:46 +00:00
Michael fb13890341 Added parameter values 2022-03-12 15:27:56 +00:00
Michael 8c778ca02e Improved completion check for AP 2022-03-12 11:17:33 +00:00
Michael 56cd98b38b Further improved logging 2022-03-12 07:48:31 +00:00
Michael c1bb1cf0fc Improved logging 2022-03-12 07:34:30 +00:00
Michael Vogel 5c4871fe6d
Merge pull request #11321 from MrPetovan/bug/11319-wrong-path-subfolder-install
Normalize base URL usage in admin templates
2022-03-12 08:10:07 +01:00
Michael 5a16a424ac Issue 11309: improved check for wanted posts 2022-03-12 07:08:10 +00:00
Michael 073a6afaaf Reduce amount of notifications by communities 2022-03-12 04:20:19 +00:00
Hypolite Petovan d15ebb6fd3 Normalize base URL usage in admin templates 2022-03-11 23:14:21 -05:00
Michael 5eb647585d Issue 11315: Fix for all receivers in "to" 2022-03-11 20:39:03 +00:00
Michael f264923cad Issue 11309: Check if a post is wanted 2022-03-11 14:00:05 +00:00
Michael 2f97d61a09 Estimate active server users when not provided by the system 2022-03-10 21:50:00 +00:00
Michael 03d38d9e35 Show permissions for all posts when possible 2022-03-10 07:38:12 +00:00
Michael 38fbe281f9 API: Fixed the bookmarking 2022-03-08 22:38:06 +00:00
Hypolite Petovan 00aa905c15
Merge pull request #11307 from annando/api-reply-fix
API: Fix "in_reply_to_status_id"
2022-03-08 15:53:12 -05:00
Hypolite Petovan 0f9a239d59
Merge pull request #11306 from annando/abstract-space
Replace abstract content with a space to prevent missing spaces
2022-03-08 15:52:48 -05:00
Hypolite Petovan c13ae36256
Merge pull request #11305 from annando/api-spoiler
API: Improve support for the summary field
2022-03-08 15:48:46 -05:00
Michael 4803b99157 API: Fix "in_reply_to_status_id" 2022-03-08 20:46:26 +00:00
Michael e0295abdab Replace abstract content with a space to prevent missing spaces 2022-03-08 19:58:55 +00:00
Michael e0468ac914 API: Improve support for the summary field 2022-03-08 18:32:09 +00:00
Michael 8039ab731f Type hints reverted 2022-03-08 18:26:59 +00:00
Hypolite Petovan 285ff75482
Merge pull request #11294 from annando/fix-mail-setting
Fix storing mail settings
2022-03-06 10:17:02 -05:00
Michael Vogel acba7d25a0
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-03-06 14:15:59 +01:00
Michael 31dbdd3677 variable type for the return value is added 2022-03-06 12:21:27 +00:00
Michael 903bc9b679 Improved support for Mastodon style content warnings 2022-03-06 11:49:55 +00:00
Michael Vogel 1ec1adf904
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-03-06 05:49:49 +01:00
Michael 421dd028ce Fix storing mail settings 2022-03-05 13:08:09 +00:00
Michael 5539e42743 API: Support for the "direct" visibility 2022-03-05 06:14:30 +00:00
Michael 15de709b89 API: We can now post to groups via the Mastodon endpoint 2022-03-04 05:50:33 +00:00
Michael f059e56e0f Fix test / Use new expandTags function 2022-03-02 17:17:07 +00:00
Michael f853d58198 API: Forum mentions are now working 2022-03-02 06:59:07 +00:00
Michael 1f1d3b2578 API: Only display active incoming contact requests 2022-03-02 05:05:49 +00:00
Michael 772294494e API: Fix display of reshares / return value of activities 2022-02-28 20:10:42 +00:00
Hypolite Petovan f36d4891bc
Merge pull request #11282 from annando/api-fix
API: several fixes to the Twitter/Statusnet API
2022-02-25 16:11:18 -05:00
Michael 6415fc62a0 Fix missing field 2022-02-25 19:27:25 +00:00
Michael bf5c8a2c43 API: several fixes to the Twitter/Statusnet API 2022-02-25 19:16:40 +00:00
Hypolite Petovan 419fe67c6c
Merge pull request #11265 from k-alin/6606-k-alin-mysql-unix-socket
Enable MySQL unix socket connection
2022-02-25 10:36:43 -05:00
k-alin e4cfd4a7c3
Update src/Database/Database.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-02-25 16:09:54 +01:00
k-alin 8a10b0c635 add socket to database settings in the autoinstaller 2022-02-25 15:01:02 +01:00
k-alin 33c4fbf2a6
Update src/Database/Database.php
Correct indent

Co-authored-by: Philipp <admin+Github@philipp.info>
2022-02-25 12:09:54 +01:00
k-alin 470be2b5e4
Update src/Database/Database.php
Correct indent

Co-authored-by: Philipp <admin+Github@philipp.info>
2022-02-25 12:09:30 +01:00
k-alin 335be6f032
Update src/Database/Database.php
Correct indent

Co-authored-by: Philipp <admin+Github@philipp.info>
2022-02-25 12:09:12 +01:00
Hypolite Petovan cddead2343 Move follow revoke protocol to worker task
- Switch to public contact for revoke_follow hook
2022-02-24 09:35:55 -05:00
Hypolite Petovan 6a1f9a7fa3 Move unfollow protocol to worker task
- Add uid parameter to unfollow hook
- Rework and unify Contact::unfollow, Contact::removeSharer and Contact::terminateFriendship
- Add missing twitterUser property to Twitter\Friendships\Destroy module
2022-02-24 09:35:54 -05:00
Hypolite Petovan 48e2963ac7 Remove unused variable in Core\Worker::defer 2022-02-24 09:35:54 -05:00
Hypolite Petovan 52f5d924b7 Replace remaining instances of DBA::update('contact') with Contact::update()
- This was breaking the synchronisation between the contact and user-contact tables
2022-02-24 09:35:54 -05:00
Michael d32b9d5d95 Display the BCC receiver when it is the local user 2022-02-24 07:09:34 +00:00
Hypolite Petovan 1d779c6193 Ensure the private message recipient is valid in Mail::send
- Arbitrary input could be used to circumvent most restrictions regarding recipients (except contact relationship)
2022-02-23 21:30:18 -05:00
Michael 59630a2c82 Improve the name of the "followers" receiver 2022-02-23 20:18:37 +00:00
Michael Vogel 948405a486
Merge pull request #11267 from MrPetovan/task/11264-mastodon-api-version
Update Mastodon API version string to include Mastodon version compatibility
2022-02-23 05:38:25 +01:00
Michael ec0b05d826 Display announces identital for starting posts and comments 2022-02-21 05:17:54 +00:00
Hypolite Petovan d7b573c6d7 Update Mastodon API version string to include Mastodon version compatibility 2022-02-20 20:22:39 -05:00
Hypolite Petovan e0ea51818e Add constructors to a couple of Mastodon API value objects 2022-02-20 16:17:03 -05:00
Michael 2321c7a55b Updated messages.po 2022-02-20 20:47:08 +00:00
Michael d6725437b0 Merge remote-tracking branch 'upstream/develop' into display-permissions 2022-02-20 20:45:32 +00:00
Michael 39e820e6a3 Display the post receivers 2022-02-20 19:25:55 +00:00
k-alin ff439272b9 mysql connection via socket if location of mysqld.sock was specified 2022-02-20 17:45:51 +01:00
k-alin 50580fd04c
Merge branch 'friendica:develop' into 6606-k-alin-mysql-unix-socket 2022-02-20 17:27:03 +01:00
Hypolite Petovan c86cc83524
Merge pull request #11260 from mkljczk/develop
API: add list members editing
2022-02-20 09:45:25 -05:00
marcin mikołajczak 0209892631 Apply suggestions
Signed-off-by: marcin mikołajczak <git@mkljczk.pl>
2022-02-20 14:10:57 +01:00
Tobias Diekershoff 446775cdc8
Merge pull request #11261 from annando/notices
Avoid warning and notice
2022-02-20 07:23:53 +01:00
Michael Vogel d5373c583b
Merge pull request #11258 from MrPetovan/bug/11234-categories-profile
Show only the user's categories on their profile
2022-02-20 06:35:37 +01:00
Michael 311c1fdd81 Avoid warning and notice 2022-02-20 05:14:36 +00:00
marcin mikołajczak 9c6f6bcb95 API: add list members editing
Signed-off-by: marcin mikołajczak <git@mkljczk.pl>
2022-02-19 23:22:54 +01:00
Michael 00f39cd308 Reverted change 2022-02-19 20:32:19 +00:00
Michael 22952f88ca SImplify code 2022-02-19 19:45:27 +00:00
Michael 9aa0f6f547 Merge remote-tracking branch 'upstream/develop' into conversation-receivers 2022-02-19 13:52:45 +00:00
Michael c867581530 Store the receivers of a post in the tags 2022-02-19 13:31:49 +00:00
Tobias Diekershoff 32c4d8c565
Merge pull request #11256 from MrPetovan/bug/notices
Check for array content before querying keys in Worker\Notifier
2022-02-19 07:44:17 +01:00
Tobias Diekershoff 4770903f54
Merge pull request #11257 from MrPetovan/bug/11212-smarty-4-php8
Switch to Smarty 4
2022-02-19 07:38:28 +01:00
Hypolite Petovan 30dcf3380c Show only the user's categories on their profile 2022-02-18 23:58:23 -05:00
Hypolite Petovan 4fe2257d8e Prevent warnings on undefined Smarty template variables 2022-02-18 22:44:11 -05:00
Hypolite Petovan 35abf33c05 Check for array content before querying keys in Worker\Notifier
- Address https://github.com/friendica/friendica/issues/11218#issuecomment-1045137358
2022-02-18 20:25:18 -05:00
Hypolite Petovan c03ff7833b
Merge pull request #11253 from annando/forum3
More rework to make private communities working
2022-02-18 12:19:57 -05:00
Michael Vogel 4c39faca95
Merge pull request #11249 from MrPetovan/bug/11248-getinfofromurl-cache-key
Hash the URL before using it as cache key in Util\Images::getInfoFromURLCached
2022-02-18 17:53:20 +01:00
Tobias Diekershoff 4c7d3a6371
Merge pull request #11255 from MrPetovan/task/11245-thread-completion-like
Relax comparison with pconfig system.accept_only_sharer value
2022-02-18 17:09:42 +01:00
Hypolite Petovan c376081d0d Relax comparison with pconfig system.accept_only_sharer value
- DI::pConfig()->get returns a string value, not an integer
- Removed superfluous default values now that we aren't doing strict type checking
2022-02-18 09:32:30 -05:00
Hypolite Petovan 17d49422b4 Hash the URL before using it as cache key in Util\Images::getInfoFromURLCached
- This prevents oversized URL from stunting the database cache
2022-02-18 09:19:36 -05:00
Michael 39724d5079 Add the mentions 2022-02-18 09:12:33 +00:00
Michael ebb4c0f947 tests 2022-02-18 06:12:02 +00:00
Michael 0ce756596e Tests again 2022-02-18 05:56:17 +00:00
Michael 830a91e586 Avoid failed test 2022-02-18 05:34:18 +00:00
Michael 7a5a8c8d68 Improve look of reshared items on the forum profile 2022-02-17 23:06:57 +00:00
Michael 49dd97e5fd User lower case 2022-02-17 21:51:47 +00:00
Michael 234dac49b4 Rrepeat comments as well 2022-02-17 21:44:59 +00:00
Michael 1b6b6bcc6d Renamed function 2022-02-17 07:53:24 +00:00
Michael 51fb265621 Merge remote-tracking branch 'upstream/develop' into forum3 2022-02-17 07:11:50 +00:00
Michael Vogel 618dda7dd2
Merge pull request #11246 from MrPetovan/task/11245-thread-completion-like
Expand system.accept_only_sharer pconfig value to include previous behavior with likes
2022-02-17 08:02:19 +01:00
Michael 9ac24a0f36 More rework to make private communities working 2022-02-16 22:56:55 +00:00
Hypolite Petovan 6c0dbc1775
Merge pull request #11251 from annando/forum2
Fix for private communities
2022-02-15 20:16:07 -05:00
Hypolite Petovan 7dadc7f6dc
Merge pull request #11250 from nupplaphil/bug/redis_pw
Don't use empty values for redis password and port
2022-02-15 20:15:06 -05:00
Michael 33edfc6a5f Fix for private communities 2022-02-15 23:51:13 +00:00
Philipp Holzer be240ca500
Config Console Show 'NULL' for null-values 2022-02-15 23:10:41 +01:00
Philipp Holzer 4e58c6981c
Don't use empty, but not null values for redis password and port 2022-02-15 23:04:43 +01:00
Hypolite Petovan 3b6c40e2e6 Check the existence of the uid field before accessing it in Module\Photo
- Address https://github.com/friendica/friendica/issues/11218#issuecomment-1039512291
2022-02-15 15:59:35 -05:00
Hypolite Petovan 99979019bf Expand system.accept_only_sharer pconfig value to include previous behavior with likes 2022-02-15 15:54:36 -05:00
Hypolite Petovan 361fdccdc7
Merge pull request #11242 from annando/private-forums
Private forums are now working via AP
2022-02-15 12:06:34 -05:00
Michael d019ef57d2 Database version increased, code simplified 2022-02-15 15:44:44 +00:00
Michael Vogel 4d274cc3ea
Merge pull request #11244 from MrPetovan/bug/11232-post-media-order
Use expected order for post medias
2022-02-15 16:38:36 +01:00
Hypolite Petovan f329d5c067
Merge pull request #11241 from annando/timing
Workaround for timing problems / Avoid a notice in the scheduled posts
2022-02-15 10:20:04 -05:00
Hypolite Petovan 9ae0234bb5 Use expected order for post medias
- This fixes the wrong display order of post pictures
2022-02-15 09:53:24 -05:00
Michael 29d83c0ffb Block communication with Diaspora for communities 2022-02-15 07:08:02 +00:00
Michael 2b0518ac04 unset several table fields before distribution 2022-02-15 06:21:46 +00:00
k-alin 31ff583c5e mysql connection via unix sockets (mysqli + PDO) 2022-02-14 23:18:41 +01:00
Michael d404f15312 Improve local forum distribution 2022-02-14 22:04:33 +00:00
Michael a5a1c81790 Fetch the user id when not provided 2022-02-13 16:42:43 +00:00
Michael 9c60b4127b Merge remote-tracking branch 'upstream/develop' into private-forums 2022-02-13 07:03:20 +00:00
Tobias Diekershoff 41f502266e
Merge pull request #11240 from annando/thread-completion
Avoid thread completion on activities
2022-02-13 07:51:55 +01:00
Michael ee3a8ccb3b No notifcations for forum / fetch user for fetching content 2022-02-13 05:45:06 +00:00
Michael e394143148 Private forums are now working via ActivityPub 2022-02-12 18:38:36 +00:00
Michael Vogel 6bc69f3353 Workaround for timing problems / Avoid a notice in the scheduled posts 2022-02-12 18:27:58 +01:00
Michael cdee2b44db Avoid thread completion on activities 2022-02-12 13:05:56 +00:00
Tobias Diekershoff d65357dd92
added two help texts in the admin panel site config 2022-02-10 09:04:48 +01:00
Hypolite Petovan 1b73e4d267
Merge pull request #11230 from annando/account-type
Use "account-type" instead of "page-flags"
2022-02-09 22:23:55 -05:00
Hypolite Petovan 0e6fe8d8ad
Merge pull request #11228 from annando/no-db-exception
Don't throw an exception when the database query fails
2022-02-09 22:16:56 -05:00
Michael 5b46b41226 New function to add group members from a forum 2022-02-09 21:34:25 +00:00
Michael 9a764516d0 Use the "contact-type" instead of "forum" or "prv" 2022-02-09 06:52:16 +00:00