From 95507cf90fda35bb90fd32db4e7786765f7498e2 Mon Sep 17 00:00:00 2001
From: Friendika <info@friendika.com>
Date: Tue, 4 Jan 2011 23:18:52 -0800
Subject: [PATCH] secure admin hijacking from openid
---
mod/register.php | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/mod/register.php b/mod/register.php
index 68c7297c9..fcc9ebcab 100644
--- a/mod/register.php
+++ b/mod/register.php
@@ -37,8 +37,13 @@ function register_post(&$a) {
$openid_url = ((x($_POST,'openid_url')) ? notags(trim($_POST['openid_url'])) : '');
$photo = ((x($_POST,'photo')) ? notags(trim($_POST['photo'])) : '');
+ $tmp_str = $openid_url;
if((! x($username)) || (! x($email)) || (! x($nickname))) {
if($openid_url) {
+ if(! validate_url($tmp_str)) {
+ notice( t('Invalid OpenID url') . EOL);
+ return;
+ }
$_SESSION['register'] = 1;
$_SESSION['openid'] = $openid_url;
require_once('library/openid.php');
@@ -82,6 +87,12 @@ function register_post(&$a) {
if((! valid_email($email)) || (! validate_email($email)))
$err .= t('Not a valid email address.') . EOL;
+ // Disallow somebody creating an account using openid that uses the admin email address,
+ // since openid bypasses email verification.
+
+ if((x($a->config,'admin_email')) && (strcasecmp($email,$a->config['admin_email']) == 0) && strlen($openid_url))
+ $err .= t('Cannot use that email.') . EOL;
+
$nickname = $_POST['nickname'] = strtolower($nickname);
if(! preg_match("/^[a-z][a-z0-9\-\_]*$/",$nickname))