From 51f6c469234209c8c3bff3e080daf8271f00000b Mon Sep 17 00:00:00 2001
From: Michael <heluecht@pirati.ca>
Date: Sat, 12 Aug 2017 05:08:45 +0000
Subject: [PATCH] Issue 3616: Don't create notifications for forum accounts

---
 include/enotify.php | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/include/enotify.php b/include/enotify.php
index 39665d14d..3b5672dcd 100644
--- a/include/enotify.php
+++ b/include/enotify.php
@@ -45,9 +45,14 @@ function notification($params) {
 	if (empty($sender_email))
 		$sender_email = t('noreply').'@'.$hostname;
 
-	$user = q("SELECT `nickname` FROM `user` WHERE `uid` = %d", intval($params['uid']));
-	if ($user)
-		$nickname = $user[0]["nickname"];
+	$user = dba::select('user', array('nickname', 'page-flags'),
+			array('uid' => $params['uid']), array('limit' => 1));
+
+	// There is no need to create notifications for forum accounts
+	if (!dbm::is_result($user) || in_array($user["page-flags"], array(PAGE_COMMUNITY, PAGE_PRVGROUP))) {
+		return;
+	}
+	$nickname = $user["nickname"];
 
 	// with $params['show_in_notification_page'] == false, the notification isn't inserted into
 	// the database, and an email is sent if applicable.