From 21d73bc83a26e8c666e9dbc8c442e07a32a4aac3 Mon Sep 17 00:00:00 2001
From: Matthew Exon <mat.github@exon.name>
Date: Thu, 20 Jun 2024 20:34:14 +0100
Subject: [PATCH] handle failed image urls better

---
 mailstream/mailstream.php | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/mailstream/mailstream.php b/mailstream/mailstream.php
index b513cf367..4056aac61 100644
--- a/mailstream/mailstream.php
+++ b/mailstream/mailstream.php
@@ -220,6 +220,11 @@ function mailstream_do_images(array &$item, array &$attachments)
 		$cookiejar = tempnam(System::getTempPath(), 'cookiejar-mailstream-');
 		try {
 			$curlResult = DI::httpClient()->fetchFull($url, HttpClientAccept::DEFAULT, 0, $cookiejar);
+			if (!$curlResult->isSuccess()) {
+				Logger::debug('mailstream: fetch image url failed', [
+					'url' => $url, 'item_id' => $item['id'], 'return_code' => $curlResult->getReturnCode()]);
+				continue;
+			}
 		} catch (InvalidArgumentException $e) {
 			Logger::error('mailstream_do_images exception fetching url', ['url' => $url, 'item_id' => $item['id']]);
 			continue;