heluecht/friendica-addons
1
0
Fork 0
forked from friendica/friendica-addons
Code Issues Pull requests Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse source 
Co-authored-by: Philipp <admin+Github@philipp.info>
This commit is contained in:
Michael Vogel 2021-11-07 14:02:13 +01:00 committed by GitHub
parent cff3dd67b0
commit 8fea67dade
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 29 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
buffer/buffer.php
View file

@ -73,8 +73,8 @@ function buffer_addon_admin(App $a, &$o)
function buffer_addon_admin_post(App $a) function buffer_addon_admin_post(App $a)
{ {
$client_id = (!empty($_POST['client_id']) ? trim($_POST['client_id']) : ''); $client_id = trim($_POST['client_id'] ?? '');
$client_secret = (!empty($_POST['client_secret']) ? trim($_POST['client_secret']) : ''); $client_secret = trim($_POST['client_secret'] ?? '');
DI::config()->set('buffer', 'client_id' , $client_id); DI::config()->set('buffer', 'client_id' , $client_id);
DI::config()->set('buffer', 'client_secret', $client_secret); DI::config()->set('buffer', 'client_secret', $client_secret);

4
geocoordinates/geocoordinates.php
View file

@ -90,9 +90,9 @@ function geocoordinates_addon_admin(&$a, &$o)
function geocoordinates_addon_admin_post(&$a) function geocoordinates_addon_admin_post(&$a)
{ {
$api_key = (!empty($_POST['api_key']) ? trim($_POST['api_key']) : ''); $api_key = trim($_POST['api_key'] ?? '');
DI::config()->set('geocoordinates', 'api_key', $api_key); DI::config()->set('geocoordinates', 'api_key', $api_key);
$language = (!empty($_POST['language']) ? trim($_POST['language']) : ''); $language = trim($_POST['language'] ?? '');
DI::config()->set('geocoordinates', 'language', $language); DI::config()->set('geocoordinates', 'language', $language);
} }

4
gravatar/gravatar.php
View file

@ -108,8 +108,8 @@ function gravatar_addon_admin (&$a, &$o) {
function gravatar_addon_admin_post (&$a) { function gravatar_addon_admin_post (&$a) {
BaseModule::checkFormSecurityToken('gravatarsave'); BaseModule::checkFormSecurityToken('gravatarsave');
$default_avatar = (!empty($_POST['avatar']) ? trim($_POST['avatar']) : 'identicon'); $default_avatar = trim($_POST['avatar'] ?? 'identicon');
$rating = (!empty($_POST['rating']) ? trim($_POST['rating']) : 'g'); $rating = trim($_POST['rating'] ?? 'g');
DI::config()->set('gravatar', 'default_avatar', $default_avatar); DI::config()->set('gravatar', 'default_avatar', $default_avatar);
DI::config()->set('gravatar', 'rating', $rating); DI::config()->set('gravatar', 'rating', $rating);
} }

12
impressum/impressum.php
View file

@ -78,12 +78,12 @@ function impressum_show($a,&$b) {
} }
function impressum_addon_admin_post (&$a) { function impressum_addon_admin_post (&$a) {
$owner = (!empty($_POST['owner']) ? trim($_POST['owner']) : ''); $owner = trim($_POST['owner'] ?? '');
$ownerprofile = (!empty($_POST['ownerprofile']) ? trim($_POST['ownerprofile']) : ''); $ownerprofile = trim($_POST['ownerprofile'] ?? '');
$postal = (!empty($_POST['postal']) ? (trim($_POST['postal'])) : ''); $postal = trim($_POST['postal'] ?? '');
$notes = (!empty($_POST['notes']) ? (trim($_POST['notes'])) : ''); $notes = trim($_POST['notes'] ?? '');
$email = (!empty($_POST['email']) ? trim($_POST['email']) : ''); $email = trim($_POST['email'] ?? '');
$footer_text = (!empty($_POST['footer_text']) ? (trim($_POST['footer_text'])) : ''); $footer_text = trim($_POST['footer_text'] ?? '');
DI::config()->set('impressum','owner',strip_tags($owner)); DI::config()->set('impressum','owner',strip_tags($owner));
DI::config()->set('impressum','ownerprofile',strip_tags($ownerprofile)); DI::config()->set('impressum','ownerprofile',strip_tags($ownerprofile));
DI::config()->set('impressum','postal',strip_tags($postal)); DI::config()->set('impressum','postal',strip_tags($postal));

2
libravatar/libravatar.php
View file

@ -89,6 +89,6 @@ function libravatar_addon_admin(&$a, &$o)
*/ */
function libravatar_addon_admin_post(&$a) function libravatar_addon_admin_post(&$a)
{ {
$default_avatar = (!empty($_POST['avatar']) ? trim($_POST['avatar']) : 'identicon'); $default_avatar = trim($_POST['avatar'] ?? 'identicon');
DI::config()->set('libravatar', 'default_avatar', $default_avatar); DI::config()->set('libravatar', 'default_avatar', $default_avatar);
} }

2
newmemberwidget/newmemberwidget.php
View file

@ -48,7 +48,7 @@ function newmemberwidget_network_mod_init ($a, $b)
function newmemberwidget_addon_admin_post(&$a) function newmemberwidget_addon_admin_post(&$a)
{ {
$ft = (!empty($_POST['freetext']) ? trim($_POST['freetext']) : ""); $ft = (!empty($_POST['freetext']) ? trim($_POST['freetext']) : "");
$lsn = (!empty($_POST['localsupportname']) ? trim($_POST['localsupportname']) : ""); $lsn = trim($_POST['localsupportname'] ?? '');
$gs = intval($_POST['linkglobalsupport']); $gs = intval($_POST['linkglobalsupport']);
$ls = intval($_POST['linklocalsupport']); $ls = intval($_POST['linklocalsupport']);
DI::config()->set('newmemberwidget', 'freetext', trim($ft)); DI::config()->set('newmemberwidget', 'freetext', trim($ft));

8
piwik/piwik.php
View file

@ -101,10 +101,10 @@ function piwik_addon_admin (&$a, &$o) {
]); ]);
} }
function piwik_addon_admin_post (&$a) { function piwik_addon_admin_post (&$a) {
$url = (!empty($_POST['baseurl']) ? trim($_POST['baseurl']) : ''); $url = trim($_POST['baseurl'] ?? '');
$id = (!empty($_POST['siteid']) ? trim($_POST['siteid']) : ''); $id = trim($_POST['siteid'] ?? '');
$optout = (!empty($_POST['optout']) ? trim($_POST['optout']) : ''); $optout = trim($_POST['optout'] ?? '');
$async = (!empty($_POST['async']) ? trim($_POST['async']) : ''); $async = trim($_POST['async'] ?? '');
DI::config()->set('piwik', 'baseurl', $url); DI::config()->set('piwik', 'baseurl', $url);
DI::config()->set('piwik', 'siteid', $id); DI::config()->set('piwik', 'siteid', $id);
DI::config()->set('piwik', 'optout', $optout); DI::config()->set('piwik', 'optout', $optout);

12
public_server/public_server.php
View file

@ -125,12 +125,12 @@ function public_server_login($a, $b)
function public_server_addon_admin_post(&$a) function public_server_addon_admin_post(&$a)
{ {
BaseModule::checkFormSecurityTokenRedirectOnError('/admin/addons/publicserver', 'publicserver'); BaseModule::checkFormSecurityTokenRedirectOnError('/admin/addons/publicserver', 'publicserver');
$expiredays = (!empty($_POST['expiredays']) ? trim($_POST['expiredays']) : ''); $expiredays = trim($_POST['expiredays'] ?? '');
$expireposts = (!empty($_POST['expireposts']) ? trim($_POST['expireposts']) : ''); $expireposts = trim($_POST['expireposts'] ?? '');
$nologin = (!empty($_POST['nologin']) ? trim($_POST['nologin']) : ''); $nologin = trim($_POST['nologin'] ?? '');
$flagusers = (!empty($_POST['flagusers']) ? trim($_POST['flagusers']) : ''); $flagusers = trim($_POST['flagusers'] ?? '');
$flagposts = (!empty($_POST['flagposts']) ? trim($_POST['flagposts']) : ''); $flagposts = trim($_POST['flagposts'] ?? '');
$flagpostsexpire = (!empty($_POST['flagpostsexpire']) ? trim($_POST['flagpostsexpire']) : ''); $flagpostsexpire = trim($_POST['flagpostsexpire'] ?? '');
DI::config()->set('public_server', 'expiredays', $expiredays); DI::config()->set('public_server', 'expiredays', $expiredays);
DI::config()->set('public_server', 'expireposts', $expireposts); DI::config()->set('public_server', 'expireposts', $expireposts);
DI::config()->set('public_server', 'nologin', $nologin); DI::config()->set('public_server', 'nologin', $nologin);

4
tumblr/tumblr.php
View file

@ -75,8 +75,8 @@ function tumblr_addon_admin(App $a, &$o)
function tumblr_addon_admin_post(App $a) function tumblr_addon_admin_post(App $a)
{ {
$consumer_key = (!empty($_POST['consumer_key']) ? trim($_POST['consumer_key']) : ''); $consumer_key = trim($_POST['consumer_key'] ?? : '');
$consumer_secret = (!empty($_POST['consumer_secret']) ? trim($_POST['consumer_secret']): ''); $consumer_secret = trim($_POST['consumer_secret'] ?? '');
DI::config()->set('tumblr', 'consumer_key',$consumer_key); DI::config()->set('tumblr', 'consumer_key',$consumer_key);
DI::config()->set('tumblr', 'consumer_secret',$consumer_secret); DI::config()->set('tumblr', 'consumer_secret',$consumer_secret);

4
twitter/twitter.php
View file

@ -791,8 +791,8 @@ function twitter_post_hook(App $a, array &$b)
function twitter_addon_admin_post(App $a) function twitter_addon_admin_post(App $a)
{ {
$consumerkey = !empty($_POST['consumerkey']) ? trim($_POST['consumerkey']) : ''; $consumerkey = trim($_POST['consumerkey'] ?? : '');
$consumersecret = !empty($_POST['consumersecret']) ? trim($_POST['consumersecret']) : ''; $consumersecret = trim($_POST['consumersecret'] ?? '');
DI::config()->set('twitter', 'consumerkey', $consumerkey); DI::config()->set('twitter', 'consumerkey', $consumerkey);
DI::config()->set('twitter', 'consumersecret', $consumersecret); DI::config()->set('twitter', 'consumersecret', $consumersecret);
} }

2
webrtc/webrtc.php
View file

@ -26,7 +26,7 @@ function webrtc_addon_admin (&$a, &$o) {
]); ]);
} }
function webrtc_addon_admin_post (&$a) { function webrtc_addon_admin_post (&$a) {
$url = (!empty($_POST['webrtcurl']) ? trim($_POST['webrtcurl']) : ''); $url = trim($_POST['webrtcurl'] ?? '');
DI::config()->set('webrtc', 'webrtcurl', $url); DI::config()->set('webrtc', 'webrtcurl', $url);
} }