From fa4b42c6dd5a1ddb3bd181538e88933ec2088b6f Mon Sep 17 00:00:00 2001
From: Hypolite Petovan <hypolite@mrpetovan.com>
Date: Thu, 25 Apr 2019 23:56:14 -0400
Subject: [PATCH] Move phpinfo module to src/Module/Admin

---
 mod/phpinfo.php                | 14 --------------
 src/App/Router.php             |  2 ++
 src/Module/Admin/PhpInfo.php   | 16 ++++++++++++++++
 src/Module/BaseAdminModule.php | 17 ++++++++++++++++-
 4 files changed, 34 insertions(+), 15 deletions(-)
 delete mode 100644 mod/phpinfo.php
 create mode 100644 src/Module/Admin/PhpInfo.php

diff --git a/mod/phpinfo.php b/mod/phpinfo.php
deleted file mode 100644
index 3228d250ba..0000000000
--- a/mod/phpinfo.php
+++ /dev/null
@@ -1,14 +0,0 @@
-<?php
-/**
- * @file mod/phpinfo.php
- */
-
-function phpinfo_content()
-{
-	if (!is_site_admin()) {
-		return false;
-	}
-
-	phpinfo();
-	exit();
-}
diff --git a/src/App/Router.php b/src/App/Router.php
index e0048a3321..e2a6719f6c 100644
--- a/src/App/Router.php
+++ b/src/App/Router.php
@@ -140,6 +140,8 @@ class Router
 			$collector->addRoute(['GET']        , '/logs/view'              , Module\Admin\Logs\View::class);
 			$collector->addRoute(['GET', 'POST'], '/logs'                   , Module\Admin\Logs\Settings::class);
 
+			$collector->addRoute(['GET']        , '/phpinfo'                , Module\Admin\PhpInfo::class);
+
 			$collector->addRoute(['GET']        , '/queue[/deferred]'       , Module\Admin\Queue::class);
 
 			$collector->addRoute(['GET', 'POST'], '/site'                   , Module\Admin\Site::class);
diff --git a/src/Module/Admin/PhpInfo.php b/src/Module/Admin/PhpInfo.php
new file mode 100644
index 0000000000..2d0e9c1d5a
--- /dev/null
+++ b/src/Module/Admin/PhpInfo.php
@@ -0,0 +1,16 @@
+<?php
+
+namespace Friendica\Module\Admin;
+
+use Friendica\Module\BaseAdminModule;
+
+class PhpInfo extends BaseAdminModule
+{
+	public static function rawContent()
+	{
+		parent::rawContent();
+
+		phpinfo();
+		exit();
+	}
+}
diff --git a/src/Module/BaseAdminModule.php b/src/Module/BaseAdminModule.php
index 42197aa51c..b06eed24e5 100644
--- a/src/Module/BaseAdminModule.php
+++ b/src/Module/BaseAdminModule.php
@@ -5,6 +5,7 @@ namespace Friendica\Module;
 use Friendica\BaseModule;
 use Friendica\Core\L10n;
 use Friendica\Core\Renderer;
+use Friendica\Core\System;
 use Friendica\Database\DBA;
 
 abstract class BaseAdminModule extends BaseModule
@@ -21,6 +22,19 @@ abstract class BaseAdminModule extends BaseModule
 		}
 	}
 
+	public static function rawContent()
+	{
+		if (!is_site_admin()) {
+			System::httpExit(403);
+		}
+
+		if (!empty($_SESSION['submanage'])) {
+			System::httpExit(403);
+		}
+
+		return '';
+	}
+
 	public static function content()
 	{
 		if (!is_site_admin()) {
@@ -71,10 +85,11 @@ abstract class BaseAdminModule extends BaseModule
 				'deleteitem'   => ['admin/item/delete' , L10n::t('Delete Item')             , 'deleteitem'],
 			]],
 			'logs' => [L10n::t('Logs'), [
-				'logsconfig'   => ['admin/logs/', L10n::t('Logs')                   , 'logs'],
+				'logsconfig'   => ['admin/logs/', L10n::t('Logs')                           , 'logs'],
 				'logsview'     => ['admin/logs/view'    , L10n::t('View Logs')              , 'viewlogs'],
 			]],
 			'diagnostics' => [L10n::t('Diagnostics'), [
+				'phpinfo'      => ['admin/phpinfo'           , L10n::t('PHP Info')          , 'phpinfo'],
 				'itemsource'   => ['admin/item/source' , L10n::t('Item Source')             , 'itemsource'],
 			]],
 		];