From de7c026590576e6215abeee5d762680355f61dd1 Mon Sep 17 00:00:00 2001 From: Philipp Holzer Date: Mon, 26 Aug 2019 23:55:54 +0200 Subject: [PATCH] Some code hardenings for semaphore locking --- src/Core/Lock/SemaphoreLock.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Core/Lock/SemaphoreLock.php b/src/Core/Lock/SemaphoreLock.php index d5153d432e..adfab5fc0e 100644 --- a/src/Core/Lock/SemaphoreLock.php +++ b/src/Core/Lock/SemaphoreLock.php @@ -39,8 +39,8 @@ class SemaphoreLock extends Lock public function acquireLock($key, $timeout = 120, $ttl = Cache\Cache::FIVE_MINUTES) { self::$semaphore[$key] = sem_get(self::semaphoreKey($key)); - if (self::$semaphore[$key]) { - if (sem_acquire(self::$semaphore[$key], ($timeout == 0))) { + if (!empty(self::$semaphore[$key])) { + if ((bool)sem_acquire(self::$semaphore[$key], ($timeout === 0))) { $this->markAcquire($key); return true; }