From 878ce3b85803aeae505c5d6c5527928dd159940a Mon Sep 17 00:00:00 2001 From: Adam Magness Date: Tue, 9 Jan 2018 09:40:45 -0500 Subject: [PATCH 1/8] Move follow functions move follow functions into Contact class --- src/Model/Contact.php | 276 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 276 insertions(+) diff --git a/src/Model/Contact.php b/src/Model/Contact.php index 3e8b1f5d65..44386f28ad 100644 --- a/src/Model/Contact.php +++ b/src/Model/Contact.php @@ -1009,4 +1009,280 @@ class Contact extends BaseObject return $data; } + + /** + * @param integer $id contact id + * @return boolean + */ + function update_contact($id) + { + /* + Warning: Never ever fetch the public key via Probe::uri and write it into the contacts. + This will reliably kill your communication with Friendica contacts. + */ + + $r = q("SELECT `url`, `nurl`, `addr`, `alias`, `batch`, `notify`, `poll`, `poco`, `network` FROM `contact` WHERE `id` = %d", intval($id)); + if (!$r) { + return false; + } + + $ret = Probe::uri($r[0]["url"]); + + // If Probe::uri fails the network code will be different + if ($ret["network"] != $r[0]["network"]) { + return false; + } + + $update = false; + + // make sure to not overwrite existing values with blank entries + foreach ($ret AS $key => $val) { + if (isset($r[0][$key]) && ($r[0][$key] != "") && ($val == "")) + $ret[$key] = $r[0][$key]; + + if (isset($r[0][$key]) && ($ret[$key] != $r[0][$key])) + $update = true; + } + + if (!$update) { + return true; + } + + q("UPDATE `contact` SET `url` = '%s', `nurl` = '%s', `addr` = '%s', `alias` = '%s', `batch` = '%s', `notify` = '%s', `poll` = '%s', `poco` = '%s' WHERE `id` = %d", + dbesc($ret['url']), + dbesc(normalise_link($ret['url'])), + dbesc($ret['addr']), + dbesc($ret['alias']), + dbesc($ret['batch']), + dbesc($ret['notify']), + dbesc($ret['poll']), + dbesc($ret['poco']), + intval($id) + ); + + // Update the corresponding gcontact entry + PortableContact::lastUpdated($ret["url"]); + + return true; + } + + /** + * Takes a $uid and a url/handle and adds a new contact + * Currently if the contact is DFRN, interactive needs to be true, to redirect to the + * dfrn_request page. + * + * Otherwise this can be used to bulk add statusnet contacts, twitter contacts, etc. + * + * Returns an array + * $return['success'] boolean true if successful + * $return['message'] error text if success is false. + * + * @brief Takes a $uid and a url/handle and adds a new contact + * @param int $uid + * @param string $url + * @param bool $interactive + * @param string $network + * @return boolean|string + */ + function new_contact($uid, $url, $interactive = false, $network = '') + { + $result = array('cid' => -1, 'success' => false, 'message' => ''); + + $a = get_app(); + + // remove ajax junk, e.g. Twitter + $url = str_replace('/#!/', '/', $url); + + if (!allowed_url($url)) { + $result['message'] = t('Disallowed profile URL.'); + return $result; + } + + if (blocked_url($url)) { + $result['message'] = t('Blocked domain'); + return $result; + } + + if (!$url) { + $result['message'] = t('Connect URL missing.'); + return $result; + } + + $arr = array('url' => $url, 'contact' => array()); + + call_hooks('follow', $arr); + + if (x($arr['contact'], 'name')) { + $ret = $arr['contact']; + } else { + $ret = Probe::uri($url, $network, $uid, false); + } + + if (($network != '') && ($ret['network'] != $network)) { + logger('Expected network ' . $network . ' does not match actual network ' . $ret['network']); + return result; + } + + if ($ret['network'] === NETWORK_DFRN) { + if ($interactive) { + if (strlen($a->path)) { + $myaddr = bin2hex(System::baseUrl() . '/profile/' . $a->user['nickname']); + } else { + $myaddr = bin2hex($a->user['nickname'] . '@' . $a->get_hostname()); + } + + goaway($ret['request'] . "&addr=$myaddr"); + + // NOTREACHED + } + } elseif (Config::get('system', 'dfrn_only')) { + $result['message'] = t('This site is not configured to allow communications with other networks.') . EOL; + $result['message'] != t('No compatible communication protocols or feeds were discovered.') . EOL; + return $result; + } + + // This extra param just confuses things, remove it + if ($ret['network'] === NETWORK_DIASPORA) { + $ret['url'] = str_replace('?absolute=true', '', $ret['url']); + } + + // do we have enough information? + + if (!((x($ret, 'name')) && (x($ret, 'poll')) && ((x($ret, 'url')) || (x($ret, 'addr'))))) { + $result['message'] .= t('The profile address specified does not provide adequate information.') . EOL; + if (!x($ret, 'poll')) { + $result['message'] .= t('No compatible communication protocols or feeds were discovered.') . EOL; + } + if (!x($ret, 'name')) { + $result['message'] .= t('An author or name was not found.') . EOL; + } + if (!x($ret, 'url')) { + $result['message'] .= t('No browser URL could be matched to this address.') . EOL; + } + if (strpos($url, '@') !== false) { + $result['message'] .= t('Unable to match @-style Identity Address with a known protocol or email contact.') . EOL; + $result['message'] .= t('Use mailto: in front of address to force email check.') . EOL; + } + return $result; + } + + if ($ret['network'] === NETWORK_OSTATUS && Config::get('system', 'ostatus_disabled')) { + $result['message'] .= t('The profile address specified belongs to a network which has been disabled on this site.') . EOL; + $ret['notify'] = ''; + } + + if (!$ret['notify']) { + $result['message'] .= t('Limited profile. This person will be unable to receive direct/personal notifications from you.') . EOL; + } + + $writeable = ((($ret['network'] === NETWORK_OSTATUS) && ($ret['notify'])) ? 1 : 0); + + $subhub = (($ret['network'] === NETWORK_OSTATUS) ? true : false); + + $hidden = (($ret['network'] === NETWORK_MAIL) ? 1 : 0); + + if (in_array($ret['network'], array(NETWORK_MAIL, NETWORK_DIASPORA))) { + $writeable = 1; + } + + // check if we already have a contact + // the poll url is more reliable than the profile url, as we may have + // indirect links or webfinger links + + $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `poll` IN ('%s', '%s') AND `network` = '%s' LIMIT 1", + intval($uid), + dbesc($ret['poll']), + dbesc(normalise_link($ret['poll'])), + dbesc($ret['network']) + ); + + if (!DBM::is_result($r)) { + $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `nurl` = '%s' AND `network` = '%s' LIMIT 1", + intval($uid), dbesc(normalise_link($url)), dbesc($ret['network']) + ); + } + + if (DBM::is_result($r)) { + // update contact + $new_relation = (($r[0]['rel'] == CONTACT_IS_FOLLOWER) ? CONTACT_IS_FRIEND : CONTACT_IS_SHARING); + + $fields = array('rel' => $new_relation, 'subhub' => $subhub, 'readonly' => false); + dba::update('contact', $fields, array('id' => $r[0]['id'])); + } else { + $new_relation = ((in_array($ret['network'], array(NETWORK_MAIL))) ? CONTACT_IS_FRIEND : CONTACT_IS_SHARING); + + // create contact record + q("INSERT INTO `contact` ( `uid`, `created`, `url`, `nurl`, `addr`, `alias`, `batch`, `notify`, `poll`, `poco`, `name`, `nick`, `network`, `pubkey`, `rel`, `priority`, + `writable`, `hidden`, `blocked`, `readonly`, `pending`, `subhub` ) + VALUES ( %d, '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', %d, %d, %d, %d, 0, 0, 0, %d ) ", + intval($uid), + dbesc(datetime_convert()), + dbesc($ret['url']), + dbesc(normalise_link($ret['url'])), + dbesc($ret['addr']), + dbesc($ret['alias']), + dbesc($ret['batch']), + dbesc($ret['notify']), + dbesc($ret['poll']), + dbesc($ret['poco']), + dbesc($ret['name']), + dbesc($ret['nick']), + dbesc($ret['network']), + dbesc($ret['pubkey']), + intval($new_relation), + intval($ret['priority']), + intval($writeable), + intval($hidden), + intval($subhub) + ); + } + + $r = q("SELECT * FROM `contact` WHERE `url` = '%s' AND `network` = '%s' AND `uid` = %d LIMIT 1", + dbesc($ret['url']), + dbesc($ret['network']), + intval($uid) + ); + + if (!DBM::is_result($r)) { + $result['message'] .= t('Unable to retrieve contact information.') . EOL; + return $result; + } + + $contact = $r[0]; + $contact_id = $r[0]['id']; + $result['cid'] = $contact_id; + + Group::addMember(User::getDefaultGroup($uid, $contact["network"]), $contact_id); + + // Update the avatar + Contact::updateAvatar($ret['photo'], $uid, $contact_id); + + // pull feed and consume it, which should subscribe to the hub. + + Worker::add(PRIORITY_HIGH, "OnePoll", $contact_id, "force"); + + $r = q("SELECT `contact`.*, `user`.* FROM `contact` INNER JOIN `user` ON `contact`.`uid` = `user`.`uid` + WHERE `user`.`uid` = %d AND `contact`.`self` LIMIT 1", + intval($uid) + ); + + if (DBM::is_result($r)) { + if (($contact['network'] == NETWORK_OSTATUS) && (strlen($contact['notify']))) { + // create a follow slap + $item = array(); + $item['verb'] = ACTIVITY_FOLLOW; + $item['follow'] = $contact["url"]; + $slap = OStatus::salmon($item, $r[0]); + Salmon::slapper($r[0], $contact['notify'], $slap); + } + + if ($contact['network'] == NETWORK_DIASPORA) { + $ret = Diaspora::sendShare($a->user, $contact); + logger('share returns: ' . $ret); + } + } + + $result['success'] = true; + return $result; + } } From fd1515eff40341dab917f486bf15e392040cd48d Mon Sep 17 00:00:00 2001 From: Adam Magness Date: Tue, 9 Jan 2018 09:44:22 -0500 Subject: [PATCH 2/8] Update function Update the update function --- src/Model/Contact.php | 42 +++++++++++++++++++++++------------------- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/src/Model/Contact.php b/src/Model/Contact.php index 44386f28ad..5a540ae978 100644 --- a/src/Model/Contact.php +++ b/src/Model/Contact.php @@ -16,6 +16,7 @@ use Friendica\Model\Photo; use Friendica\Protocol\Diaspora; use Friendica\Protocol\DFRN; use Friendica\Protocol\OStatus; +use Friendica\Protocol\PortableContact; use Friendica\Protocol\Salmon; use dba; @@ -1014,33 +1015,33 @@ class Contact extends BaseObject * @param integer $id contact id * @return boolean */ - function update_contact($id) + public static function update($id) { /* Warning: Never ever fetch the public key via Probe::uri and write it into the contacts. This will reliably kill your communication with Friendica contacts. */ - $r = q("SELECT `url`, `nurl`, `addr`, `alias`, `batch`, `notify`, `poll`, `poco`, `network` FROM `contact` WHERE `id` = %d", intval($id)); - if (!$r) { + $r = dba::select('contact', ['url', 'nurl', 'addr', 'alias', 'batch', 'notify', 'poll', 'poco', 'network'], ['id' => $id], ['limit' => 1]); + if (!DBM::is_result($r)) { return false; } - $ret = Probe::uri($r[0]["url"]); + $ret = Probe::uri($r["url"]); // If Probe::uri fails the network code will be different - if ($ret["network"] != $r[0]["network"]) { + if ($ret["network"] != $r["network"]) { return false; } $update = false; // make sure to not overwrite existing values with blank entries - foreach ($ret AS $key => $val) { - if (isset($r[0][$key]) && ($r[0][$key] != "") && ($val == "")) - $ret[$key] = $r[0][$key]; + foreach ($ret as $key => $val) { + if (isset($r[$key]) && ($r[$key] != "") && ($val == "")) + $ret[$key] = $r[$key]; - if (isset($r[0][$key]) && ($ret[$key] != $r[0][$key])) + if (isset($r[$key]) && ($ret[$key] != $r[$key])) $update = true; } @@ -1048,16 +1049,19 @@ class Contact extends BaseObject return true; } - q("UPDATE `contact` SET `url` = '%s', `nurl` = '%s', `addr` = '%s', `alias` = '%s', `batch` = '%s', `notify` = '%s', `poll` = '%s', `poco` = '%s' WHERE `id` = %d", - dbesc($ret['url']), - dbesc(normalise_link($ret['url'])), - dbesc($ret['addr']), - dbesc($ret['alias']), - dbesc($ret['batch']), - dbesc($ret['notify']), - dbesc($ret['poll']), - dbesc($ret['poco']), - intval($id) + dba::update( + 'contact', + [ + 'url' => $ret['url'], + 'nurl' => normalise_link($ret['url']), + 'addr' => $ret['addr'], + 'alias' => $ret['alias'], + 'batch' => $ret['batch'], + 'notify' => $ret['notify'], + 'poll' => $ret['poll'], + 'poco' => $ret['poco'] + ], + ['id' => $id] ); // Update the corresponding gcontact entry From edfb08a779b2d98039c23512cfe9e05edb3ef559 Mon Sep 17 00:00:00 2001 From: Adam Magness Date: Tue, 9 Jan 2018 09:48:31 -0500 Subject: [PATCH 3/8] Update new function update function name and statements --- src/Model/Contact.php | 60 +++++++++++++++++++++---------------------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/src/Model/Contact.php b/src/Model/Contact.php index 5a540ae978..7fe5c5e6d4 100644 --- a/src/Model/Contact.php +++ b/src/Model/Contact.php @@ -1088,7 +1088,7 @@ class Contact extends BaseObject * @param string $network * @return boolean|string */ - function new_contact($uid, $url, $interactive = false, $network = '') + public static function add($uid, $url, $interactive = false, $network = '') { $result = array('cid' => -1, 'success' => false, 'message' => ''); @@ -1216,44 +1216,44 @@ class Contact extends BaseObject $new_relation = ((in_array($ret['network'], array(NETWORK_MAIL))) ? CONTACT_IS_FRIEND : CONTACT_IS_SHARING); // create contact record - q("INSERT INTO `contact` ( `uid`, `created`, `url`, `nurl`, `addr`, `alias`, `batch`, `notify`, `poll`, `poco`, `name`, `nick`, `network`, `pubkey`, `rel`, `priority`, - `writable`, `hidden`, `blocked`, `readonly`, `pending`, `subhub` ) - VALUES ( %d, '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', %d, %d, %d, %d, 0, 0, 0, %d ) ", - intval($uid), - dbesc(datetime_convert()), - dbesc($ret['url']), - dbesc(normalise_link($ret['url'])), - dbesc($ret['addr']), - dbesc($ret['alias']), - dbesc($ret['batch']), - dbesc($ret['notify']), - dbesc($ret['poll']), - dbesc($ret['poco']), - dbesc($ret['name']), - dbesc($ret['nick']), - dbesc($ret['network']), - dbesc($ret['pubkey']), - intval($new_relation), - intval($ret['priority']), - intval($writeable), - intval($hidden), - intval($subhub) + dba::insert( + 'contact', + [ + 'uid' => $uid, + 'created' => datetime_convert(), + 'url' => $ret['url'], + 'nurl' => normalise_link($ret['url']), + 'addr' => $ret['addr'], + 'alias' => $ret['alias'], + 'batch' => $ret['batch'], + `notify` => $ret['notify'], + `poll` => $ret['poll'], + `poco` => $ret['poco'], + `name` => $ret['name'], + `nick` => $ret['nick'], + `network` => $ret['network'], + `pubkey` => $ret['pubkey'], + `rel` => $new_relation, + `priority` => $ret['priority'], + `writable` => $writeable, + `hidden` => $hidden, + `blocked` => 0, + `readonly` => 0, + `pending` => 0, + `subhub` => $subhub + ] ); } - $r = q("SELECT * FROM `contact` WHERE `url` = '%s' AND `network` = '%s' AND `uid` = %d LIMIT 1", - dbesc($ret['url']), - dbesc($ret['network']), - intval($uid) - ); + $r = dba::select('contact', ['url' => $ret['url'], 'network' => $ret['network'], 'uid' => $uid], ['limit' => 1]); if (!DBM::is_result($r)) { $result['message'] .= t('Unable to retrieve contact information.') . EOL; return $result; } - $contact = $r[0]; - $contact_id = $r[0]['id']; + $contact = $r; + $contact_id = $r['id']; $result['cid'] = $contact_id; Group::addMember(User::getDefaultGroup($uid, $contact["network"]), $contact_id); From a59ab5552e21c927d861b2b4ef193a545b956b2c Mon Sep 17 00:00:00 2001 From: Adam Magness Date: Tue, 9 Jan 2018 09:59:52 -0500 Subject: [PATCH 4/8] Includes and calls Remove includes and update function calls --- mod/contacts.php | 5 ++--- mod/follow.php | 7 ++++--- mod/fsuggest.php | 6 +++--- mod/ostatus_subscribe.php | 9 +++++---- mod/repair_ostatus.php | 9 +++++---- mod/salmon.php | 4 ++-- mod/unfollow.php | 5 +++-- src/Protocol/OStatus.php | 1 - src/Worker/OnePoll.php | 3 +-- 9 files changed, 25 insertions(+), 24 deletions(-) diff --git a/mod/contacts.php b/mod/contacts.php index b347617a1c..ea384fbefd 100644 --- a/mod/contacts.php +++ b/mod/contacts.php @@ -14,7 +14,6 @@ use Friendica\Network\Probe; require_once 'include/contact_selectors.php'; require_once 'include/contact_widgets.php'; -require_once 'include/follow.php'; require_once 'mod/proxy.php'; function contacts_init(App $a) @@ -243,7 +242,7 @@ function _contact_update($contact_id) $uid = $contact["uid"]; if ($r[0]["network"] == NETWORK_OSTATUS) { - $result = new_contact($uid, $contact["url"], false, $contact["network"]); + $result = Contact::new($uid, $contact["url"], false, $contact["network"]); if ($result['success']) { q("UPDATE `contact` SET `subhub` = 1 WHERE `id` = %d", intval($contact_id)); @@ -275,7 +274,7 @@ function _contact_update_profile($contact_id) $update = array(); if ($data["network"] == NETWORK_OSTATUS) { - $result = new_contact($uid, $data["url"], false); + $result = Contact::new($uid, $data["url"], false); if ($result['success']) { $update["subhub"] = true; diff --git a/mod/follow.php b/mod/follow.php index 41c008da51..1f5abccae0 100644 --- a/mod/follow.php +++ b/mod/follow.php @@ -1,12 +1,13 @@ ".t("Keep this window open until done.")."

"; - $result = new_contact($uid,$r[0]["url"],true); + $result = Contact::new($uid,$r[0]["url"],true); $a->page['htmlhead'] = ''; diff --git a/mod/salmon.php b/mod/salmon.php index bd08431a4c..1cb118355b 100644 --- a/mod/salmon.php +++ b/mod/salmon.php @@ -5,12 +5,12 @@ use Friendica\App; use Friendica\Core\PConfig; use Friendica\Database\DBM; +use Friendica\Model\Contact; use Friendica\Protocol\OStatus; use Friendica\Protocol\Salmon; use Friendica\Util\Crypto; require_once 'include/items.php'; -require_once 'include/follow.php'; function salmon_return($val) { @@ -164,7 +164,7 @@ function salmon_post(App $a) { if (! DBM::is_result($r)) { logger('mod-salmon: Author unknown to us.'); if(PConfig::get($importer['uid'],'system','ostatus_autofriend')) { - $result = new_contact($importer['uid'],$author_link); + $result = Contact::new($importer['uid'], $author_link); if($result['success']) { $r = q("SELECT * FROM `contact` WHERE `network` = '%s' AND ( `url` = '%s' OR `alias` = '%s') AND `uid` = %d LIMIT 1", diff --git a/mod/unfollow.php b/mod/unfollow.php index 907982cd8a..98ad9fd026 100644 --- a/mod/unfollow.php +++ b/mod/unfollow.php @@ -1,11 +1,12 @@ Date: Tue, 9 Jan 2018 10:02:53 -0500 Subject: [PATCH 5/8] update use update useings and self --- src/Model/Contact.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Model/Contact.php b/src/Model/Contact.php index 7fe5c5e6d4..057a06a31d 100644 --- a/src/Model/Contact.php +++ b/src/Model/Contact.php @@ -7,6 +7,7 @@ namespace Friendica\Model; use Friendica\BaseObject; +use Friendica\Core\Config; use Friendica\Core\PConfig; use Friendica\Core\System; use Friendica\Core\Worker; @@ -1259,7 +1260,7 @@ class Contact extends BaseObject Group::addMember(User::getDefaultGroup($uid, $contact["network"]), $contact_id); // Update the avatar - Contact::updateAvatar($ret['photo'], $uid, $contact_id); + self::updateAvatar($ret['photo'], $uid, $contact_id); // pull feed and consume it, which should subscribe to the hub. From 484eb960d7b63fee4b083ab9351bd0ab2c0e3aa0 Mon Sep 17 00:00:00 2001 From: Adam Magness Date: Tue, 9 Jan 2018 10:03:31 -0500 Subject: [PATCH 6/8] Remove follow remove follow.php --- include/follow.php | 290 --------------------------------------------- 1 file changed, 290 deletions(-) delete mode 100644 include/follow.php diff --git a/include/follow.php b/include/follow.php deleted file mode 100644 index 9aedafb64d..0000000000 --- a/include/follow.php +++ /dev/null @@ -1,290 +0,0 @@ - $val) { - if (isset($r[0][$key]) && ($r[0][$key] != "") && ($val == "")) - $ret[$key] = $r[0][$key]; - - if (isset($r[0][$key]) && ($ret[$key] != $r[0][$key])) - $update = true; - } - - if (!$update) { - return true; - } - - q("UPDATE `contact` SET `url` = '%s', `nurl` = '%s', `addr` = '%s', `alias` = '%s', `batch` = '%s', `notify` = '%s', `poll` = '%s', `poco` = '%s' WHERE `id` = %d", - dbesc($ret['url']), - dbesc(normalise_link($ret['url'])), - dbesc($ret['addr']), - dbesc($ret['alias']), - dbesc($ret['batch']), - dbesc($ret['notify']), - dbesc($ret['poll']), - dbesc($ret['poco']), - intval($id) - ); - - // Update the corresponding gcontact entry - PortableContact::lastUpdated($ret["url"]); - - return true; -} - -/** - * Takes a $uid and a url/handle and adds a new contact - * Currently if the contact is DFRN, interactive needs to be true, to redirect to the - * dfrn_request page. - * - * Otherwise this can be used to bulk add statusnet contacts, twitter contacts, etc. - * - * Returns an array - * $return['success'] boolean true if successful - * $return['message'] error text if success is false. - * - * @brief Takes a $uid and a url/handle and adds a new contact - * @param int $uid - * @param string $url - * @param bool $interactive - * @param string $network - * @return boolean|string - */ -function new_contact($uid, $url, $interactive = false, $network = '') -{ - $result = array('cid' => -1, 'success' => false, 'message' => ''); - - $a = get_app(); - - // remove ajax junk, e.g. Twitter - $url = str_replace('/#!/', '/', $url); - - if (!allowed_url($url)) { - $result['message'] = t('Disallowed profile URL.'); - return $result; - } - - if (blocked_url($url)) { - $result['message'] = t('Blocked domain'); - return $result; - } - - if (!$url) { - $result['message'] = t('Connect URL missing.'); - return $result; - } - - $arr = array('url' => $url, 'contact' => array()); - - call_hooks('follow', $arr); - - if (x($arr['contact'], 'name')) { - $ret = $arr['contact']; - } else { - $ret = Probe::uri($url, $network, $uid, false); - } - - if (($network != '') && ($ret['network'] != $network)) { - logger('Expected network ' . $network . ' does not match actual network ' . $ret['network']); - return result; - } - - if ($ret['network'] === NETWORK_DFRN) { - if ($interactive) { - if (strlen($a->path)) { - $myaddr = bin2hex(System::baseUrl() . '/profile/' . $a->user['nickname']); - } else { - $myaddr = bin2hex($a->user['nickname'] . '@' . $a->get_hostname()); - } - - goaway($ret['request'] . "&addr=$myaddr"); - - // NOTREACHED - } - } elseif (Config::get('system', 'dfrn_only')) { - $result['message'] = t('This site is not configured to allow communications with other networks.') . EOL; - $result['message'] != t('No compatible communication protocols or feeds were discovered.') . EOL; - return $result; - } - - // This extra param just confuses things, remove it - if ($ret['network'] === NETWORK_DIASPORA) { - $ret['url'] = str_replace('?absolute=true', '', $ret['url']); - } - - // do we have enough information? - - if (!((x($ret, 'name')) && (x($ret, 'poll')) && ((x($ret, 'url')) || (x($ret, 'addr'))))) { - $result['message'] .= t('The profile address specified does not provide adequate information.') . EOL; - if (!x($ret, 'poll')) { - $result['message'] .= t('No compatible communication protocols or feeds were discovered.') . EOL; - } - if (!x($ret, 'name')) { - $result['message'] .= t('An author or name was not found.') . EOL; - } - if (!x($ret, 'url')) { - $result['message'] .= t('No browser URL could be matched to this address.') . EOL; - } - if (strpos($url, '@') !== false) { - $result['message'] .= t('Unable to match @-style Identity Address with a known protocol or email contact.') . EOL; - $result['message'] .= t('Use mailto: in front of address to force email check.') . EOL; - } - return $result; - } - - if ($ret['network'] === NETWORK_OSTATUS && Config::get('system', 'ostatus_disabled')) { - $result['message'] .= t('The profile address specified belongs to a network which has been disabled on this site.') . EOL; - $ret['notify'] = ''; - } - - if (!$ret['notify']) { - $result['message'] .= t('Limited profile. This person will be unable to receive direct/personal notifications from you.') . EOL; - } - - $writeable = ((($ret['network'] === NETWORK_OSTATUS) && ($ret['notify'])) ? 1 : 0); - - $subhub = (($ret['network'] === NETWORK_OSTATUS) ? true : false); - - $hidden = (($ret['network'] === NETWORK_MAIL) ? 1 : 0); - - if (in_array($ret['network'], array(NETWORK_MAIL, NETWORK_DIASPORA))) { - $writeable = 1; - } - - // check if we already have a contact - // the poll url is more reliable than the profile url, as we may have - // indirect links or webfinger links - - $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `poll` IN ('%s', '%s') AND `network` = '%s' LIMIT 1", - intval($uid), - dbesc($ret['poll']), - dbesc(normalise_link($ret['poll'])), - dbesc($ret['network']) - ); - - if (!DBM::is_result($r)) { - $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `nurl` = '%s' AND `network` = '%s' LIMIT 1", - intval($uid), dbesc(normalise_link($url)), dbesc($ret['network']) - ); - } - - if (DBM::is_result($r)) { - // update contact - $new_relation = (($r[0]['rel'] == CONTACT_IS_FOLLOWER) ? CONTACT_IS_FRIEND : CONTACT_IS_SHARING); - - $fields = array('rel' => $new_relation, 'subhub' => $subhub, 'readonly' => false); - dba::update('contact', $fields, array('id' => $r[0]['id'])); - } else { - $new_relation = ((in_array($ret['network'], array(NETWORK_MAIL))) ? CONTACT_IS_FRIEND : CONTACT_IS_SHARING); - - // create contact record - q("INSERT INTO `contact` ( `uid`, `created`, `url`, `nurl`, `addr`, `alias`, `batch`, `notify`, `poll`, `poco`, `name`, `nick`, `network`, `pubkey`, `rel`, `priority`, - `writable`, `hidden`, `blocked`, `readonly`, `pending`, `subhub` ) - VALUES ( %d, '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', %d, %d, %d, %d, 0, 0, 0, %d ) ", - intval($uid), - dbesc(datetime_convert()), - dbesc($ret['url']), - dbesc(normalise_link($ret['url'])), - dbesc($ret['addr']), - dbesc($ret['alias']), - dbesc($ret['batch']), - dbesc($ret['notify']), - dbesc($ret['poll']), - dbesc($ret['poco']), - dbesc($ret['name']), - dbesc($ret['nick']), - dbesc($ret['network']), - dbesc($ret['pubkey']), - intval($new_relation), - intval($ret['priority']), - intval($writeable), - intval($hidden), - intval($subhub) - ); - } - - $r = q("SELECT * FROM `contact` WHERE `url` = '%s' AND `network` = '%s' AND `uid` = %d LIMIT 1", - dbesc($ret['url']), - dbesc($ret['network']), - intval($uid) - ); - - if (!DBM::is_result($r)) { - $result['message'] .= t('Unable to retrieve contact information.') . EOL; - return $result; - } - - $contact = $r[0]; - $contact_id = $r[0]['id']; - $result['cid'] = $contact_id; - - Group::addMember(User::getDefaultGroup($uid, $contact["network"]), $contact_id); - - // Update the avatar - Contact::updateAvatar($ret['photo'], $uid, $contact_id); - - // pull feed and consume it, which should subscribe to the hub. - - Worker::add(PRIORITY_HIGH, "OnePoll", $contact_id, "force"); - - $r = q("SELECT `contact`.*, `user`.* FROM `contact` INNER JOIN `user` ON `contact`.`uid` = `user`.`uid` - WHERE `user`.`uid` = %d AND `contact`.`self` LIMIT 1", - intval($uid) - ); - - if (DBM::is_result($r)) { - if (($contact['network'] == NETWORK_OSTATUS) && (strlen($contact['notify']))) { - // create a follow slap - $item = array(); - $item['verb'] = ACTIVITY_FOLLOW; - $item['follow'] = $contact["url"]; - $slap = OStatus::salmon($item, $r[0]); - Salmon::slapper($r[0], $contact['notify'], $slap); - } - - if ($contact['network'] == NETWORK_DIASPORA) { - $ret = Diaspora::sendShare($a->user, $contact); - logger('share returns: ' . $ret); - } - } - - $result['success'] = true; - return $result; -} From c81e83c5008da66a945b02ca035f6d364b827367 Mon Sep 17 00:00:00 2001 From: Adam Magness Date: Tue, 9 Jan 2018 11:23:26 -0500 Subject: [PATCH 7/8] Review changes Update update and new functions to updateFromProbe and create. Update calls to renamed functions. --- mod/contacts.php | 4 ++-- mod/follow.php | 2 +- mod/ostatus_subscribe.php | 2 +- mod/repair_ostatus.php | 2 +- mod/salmon.php | 2 +- src/Model/Contact.php | 4 ++-- src/Worker/OnePoll.php | 2 +- 7 files changed, 9 insertions(+), 9 deletions(-) diff --git a/mod/contacts.php b/mod/contacts.php index ea384fbefd..a2a734f758 100644 --- a/mod/contacts.php +++ b/mod/contacts.php @@ -242,7 +242,7 @@ function _contact_update($contact_id) $uid = $contact["uid"]; if ($r[0]["network"] == NETWORK_OSTATUS) { - $result = Contact::new($uid, $contact["url"], false, $contact["network"]); + $result = Contact::create($uid, $contact["url"], false, $contact["network"]); if ($result['success']) { q("UPDATE `contact` SET `subhub` = 1 WHERE `id` = %d", intval($contact_id)); @@ -274,7 +274,7 @@ function _contact_update_profile($contact_id) $update = array(); if ($data["network"] == NETWORK_OSTATUS) { - $result = Contact::new($uid, $data["url"], false); + $result = Contact::create($uid, $data["url"], false); if ($result['success']) { $update["subhub"] = true; diff --git a/mod/follow.php b/mod/follow.php index 1f5abccae0..58ebdf88ed 100644 --- a/mod/follow.php +++ b/mod/follow.php @@ -30,7 +30,7 @@ function follow_post(App $a) { // This is just a precaution if maybe this page is called somewhere directly via POST $_SESSION["fastlane"] = $url; - $result = Contact::new($uid, $url, true); + $result = Contact::create($uid, $url, true); if ($result['success'] == false) { if ($result['message']) { diff --git a/mod/ostatus_subscribe.php b/mod/ostatus_subscribe.php index cae042c672..0104c3ca1b 100644 --- a/mod/ostatus_subscribe.php +++ b/mod/ostatus_subscribe.php @@ -68,7 +68,7 @@ function ostatus_subscribe_content(App $a) { $data = Probe::uri($url); if ($data["network"] == NETWORK_OSTATUS) { - $result = Contact::new($uid, $url, true, NETWORK_OSTATUS); + $result = Contact::create($uid, $url, true, NETWORK_OSTATUS); if ($result["success"]) { $o .= " - ".t("success"); } else { diff --git a/mod/repair_ostatus.php b/mod/repair_ostatus.php index b3d5a402b5..5ac08890cd 100644 --- a/mod/repair_ostatus.php +++ b/mod/repair_ostatus.php @@ -52,7 +52,7 @@ function repair_ostatus_content(App $a) { $o .= "

".t("Keep this window open until done.")."

"; - $result = Contact::new($uid,$r[0]["url"],true); + $result = Contact::create($uid,$r[0]["url"],true); $a->page['htmlhead'] = ''; diff --git a/mod/salmon.php b/mod/salmon.php index 1cb118355b..9dddc0096d 100644 --- a/mod/salmon.php +++ b/mod/salmon.php @@ -164,7 +164,7 @@ function salmon_post(App $a) { if (! DBM::is_result($r)) { logger('mod-salmon: Author unknown to us.'); if(PConfig::get($importer['uid'],'system','ostatus_autofriend')) { - $result = Contact::new($importer['uid'], $author_link); + $result = Contact::create($importer['uid'], $author_link); if($result['success']) { $r = q("SELECT * FROM `contact` WHERE `network` = '%s' AND ( `url` = '%s' OR `alias` = '%s') AND `uid` = %d LIMIT 1", diff --git a/src/Model/Contact.php b/src/Model/Contact.php index 057a06a31d..1ab6d63ce8 100644 --- a/src/Model/Contact.php +++ b/src/Model/Contact.php @@ -1016,7 +1016,7 @@ class Contact extends BaseObject * @param integer $id contact id * @return boolean */ - public static function update($id) + public static function updateFromProbe($id) { /* Warning: Never ever fetch the public key via Probe::uri and write it into the contacts. @@ -1089,7 +1089,7 @@ class Contact extends BaseObject * @param string $network * @return boolean|string */ - public static function add($uid, $url, $interactive = false, $network = '') + public static function create($uid, $url, $interactive = false, $network = '') { $result = array('cid' => -1, 'success' => false, 'message' => ''); diff --git a/src/Worker/OnePoll.php b/src/Worker/OnePoll.php index f175c4aa5c..a527bf0da1 100644 --- a/src/Worker/OnePoll.php +++ b/src/Worker/OnePoll.php @@ -117,7 +117,7 @@ Class OnePoll return; } - if (!Contact::update($contact["id"])) { + if (!Contact::updateFromProbe($contact["id"])) { Contact::markForArchival($contact); logger('Contact is marked dead'); From 5358f5742e1332f25fc81bb9439a57c571eea569 Mon Sep 17 00:00:00 2001 From: Adam Magness Date: Tue, 9 Jan 2018 11:40:25 -0500 Subject: [PATCH 8/8] Rename create rename create function to createFromProbe and update calls. --- mod/contacts.php | 4 ++-- mod/follow.php | 2 +- mod/ostatus_subscribe.php | 2 +- mod/repair_ostatus.php | 2 +- mod/salmon.php | 2 +- src/Model/Contact.php | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/mod/contacts.php b/mod/contacts.php index a2a734f758..f673f84f10 100644 --- a/mod/contacts.php +++ b/mod/contacts.php @@ -242,7 +242,7 @@ function _contact_update($contact_id) $uid = $contact["uid"]; if ($r[0]["network"] == NETWORK_OSTATUS) { - $result = Contact::create($uid, $contact["url"], false, $contact["network"]); + $result = Contact::createFromProbe($uid, $contact["url"], false, $contact["network"]); if ($result['success']) { q("UPDATE `contact` SET `subhub` = 1 WHERE `id` = %d", intval($contact_id)); @@ -274,7 +274,7 @@ function _contact_update_profile($contact_id) $update = array(); if ($data["network"] == NETWORK_OSTATUS) { - $result = Contact::create($uid, $data["url"], false); + $result = Contact::createFromProbe($uid, $data["url"], false); if ($result['success']) { $update["subhub"] = true; diff --git a/mod/follow.php b/mod/follow.php index 58ebdf88ed..503410fd09 100644 --- a/mod/follow.php +++ b/mod/follow.php @@ -30,7 +30,7 @@ function follow_post(App $a) { // This is just a precaution if maybe this page is called somewhere directly via POST $_SESSION["fastlane"] = $url; - $result = Contact::create($uid, $url, true); + $result = Contact::createFromProbe($uid, $url, true); if ($result['success'] == false) { if ($result['message']) { diff --git a/mod/ostatus_subscribe.php b/mod/ostatus_subscribe.php index 0104c3ca1b..9ec58e6f11 100644 --- a/mod/ostatus_subscribe.php +++ b/mod/ostatus_subscribe.php @@ -68,7 +68,7 @@ function ostatus_subscribe_content(App $a) { $data = Probe::uri($url); if ($data["network"] == NETWORK_OSTATUS) { - $result = Contact::create($uid, $url, true, NETWORK_OSTATUS); + $result = Contact::createFromProbe($uid, $url, true, NETWORK_OSTATUS); if ($result["success"]) { $o .= " - ".t("success"); } else { diff --git a/mod/repair_ostatus.php b/mod/repair_ostatus.php index 5ac08890cd..5b207c2860 100644 --- a/mod/repair_ostatus.php +++ b/mod/repair_ostatus.php @@ -52,7 +52,7 @@ function repair_ostatus_content(App $a) { $o .= "

".t("Keep this window open until done.")."

"; - $result = Contact::create($uid,$r[0]["url"],true); + $result = Contact::createFromProbe($uid,$r[0]["url"],true); $a->page['htmlhead'] = ''; diff --git a/mod/salmon.php b/mod/salmon.php index 9dddc0096d..3a4dececde 100644 --- a/mod/salmon.php +++ b/mod/salmon.php @@ -164,7 +164,7 @@ function salmon_post(App $a) { if (! DBM::is_result($r)) { logger('mod-salmon: Author unknown to us.'); if(PConfig::get($importer['uid'],'system','ostatus_autofriend')) { - $result = Contact::create($importer['uid'], $author_link); + $result = Contact::createFromProbe($importer['uid'], $author_link); if($result['success']) { $r = q("SELECT * FROM `contact` WHERE `network` = '%s' AND ( `url` = '%s' OR `alias` = '%s') AND `uid` = %d LIMIT 1", diff --git a/src/Model/Contact.php b/src/Model/Contact.php index 1ab6d63ce8..b0f5ef9f24 100644 --- a/src/Model/Contact.php +++ b/src/Model/Contact.php @@ -1089,7 +1089,7 @@ class Contact extends BaseObject * @param string $network * @return boolean|string */ - public static function create($uid, $url, $interactive = false, $network = '') + public static function createFromProbe($uid, $url, $interactive = false, $network = '') { $result = array('cid' => -1, 'success' => false, 'message' => '');