From 8e87c5f05f5934798f94b6074f03715a0e5e641c Mon Sep 17 00:00:00 2001 From: Michael Date: Tue, 7 Jan 2020 22:00:39 +0000 Subject: [PATCH 1/9] Fix: removed unneeded HTML escaping --- src/Content/Text/HTML.php | 2 -- src/Protocol/DFRN.php | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/Content/Text/HTML.php b/src/Content/Text/HTML.php index a25883eb16..557e737096 100644 --- a/src/Content/Text/HTML.php +++ b/src/Content/Text/HTML.php @@ -336,8 +336,6 @@ class HTML $message = html_entity_decode($message, ENT_QUOTES, 'UTF-8'); - $message = str_replace(["<"], ["<"], $message); - // remove quotes if they don't make sense $message = preg_replace('=\[/quote\][\s]*\[quote\]=i', "\n", $message); diff --git a/src/Protocol/DFRN.php b/src/Protocol/DFRN.php index 798f607927..2202331b12 100644 --- a/src/Protocol/DFRN.php +++ b/src/Protocol/DFRN.php @@ -2365,7 +2365,7 @@ class DFRN $item["body"] = XML::getFirstNodeValue($xpath, "dfrn:env/text()", $entry); $item["body"] = str_replace([' ',"\t","\r","\n"], ['','','',''], $item["body"]); // make sure nobody is trying to sneak some html tags by us - $item["body"] = Strings::escapeTags(Strings::base64UrlDecode($item["body"])); + $item["body"] = Strings::base64UrlDecode($item["body"]); $item["body"] = BBCode::limitBodySize($item["body"]); From d07760f62972be514842fe534251a15c7a658d43 Mon Sep 17 00:00:00 2001 From: Michael Date: Tue, 7 Jan 2020 23:05:07 +0000 Subject: [PATCH 2/9] Added test files, don't know if this works --- tests/datasets/content/text/html/bug-8075.html | 1 + tests/datasets/content/text/html/bug-8075.txt | 1 + 2 files changed, 2 insertions(+) create mode 100644 tests/datasets/content/text/html/bug-8075.html create mode 100644 tests/datasets/content/text/html/bug-8075.txt diff --git a/tests/datasets/content/text/html/bug-8075.html b/tests/datasets/content/text/html/bug-8075.html new file mode 100644 index 0000000000..2b0dbb9be5 --- /dev/null +++ b/tests/datasets/content/text/html/bug-8075.html @@ -0,0 +1 @@ + I don't understand tests diff --git a/tests/datasets/content/text/html/bug-8075.txt b/tests/datasets/content/text/html/bug-8075.txt new file mode 100644 index 0000000000..2b0dbb9be5 --- /dev/null +++ b/tests/datasets/content/text/html/bug-8075.txt @@ -0,0 +1 @@ + I don't understand tests From 5bc4d24e709db5ae14915f8a13ffc06adc85dd4f Mon Sep 17 00:00:00 2001 From: Michael Date: Tue, 7 Jan 2020 23:23:38 +0000 Subject: [PATCH 3/9] Removed tests --- tests/datasets/content/text/html/bug-8075.html | 1 - tests/datasets/content/text/html/bug-8075.txt | 1 - 2 files changed, 2 deletions(-) delete mode 100644 tests/datasets/content/text/html/bug-8075.html delete mode 100644 tests/datasets/content/text/html/bug-8075.txt diff --git a/tests/datasets/content/text/html/bug-8075.html b/tests/datasets/content/text/html/bug-8075.html deleted file mode 100644 index 2b0dbb9be5..0000000000 --- a/tests/datasets/content/text/html/bug-8075.html +++ /dev/null @@ -1 +0,0 @@ - I don't understand tests diff --git a/tests/datasets/content/text/html/bug-8075.txt b/tests/datasets/content/text/html/bug-8075.txt deleted file mode 100644 index 2b0dbb9be5..0000000000 --- a/tests/datasets/content/text/html/bug-8075.txt +++ /dev/null @@ -1 +0,0 @@ - I don't understand tests From 6133ccb1b64e2ce6d5e3377438e3ca05597f1ac0 Mon Sep 17 00:00:00 2001 From: Michael Date: Wed, 8 Jan 2020 06:43:15 +0000 Subject: [PATCH 4/9] Tests, next try --- tests/src/Content/Text/HTMLTest.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/src/Content/Text/HTMLTest.php b/tests/src/Content/Text/HTMLTest.php index 1d550049a9..027f6ddb1d 100644 --- a/tests/src/Content/Text/HTMLTest.php +++ b/tests/src/Content/Text/HTMLTest.php @@ -58,6 +58,10 @@ class HTMLTest extends MockedTest 'expectedBBCode' => '[audio]http://www.cendrones.fr/colloque2017/jonathanbocquet.mp3[/audio]', 'html' => '', ], + 'bug-8075-html-tags' => [ + 'expectedBBCode' => " I don't understand tests", + 'html' => " I don't understand tests", + ], ]; } From e80234d20a7b1362dae1ae40dce3c5c0d191aae0 Mon Sep 17 00:00:00 2001 From: Michael Date: Wed, 8 Jan 2020 09:36:05 +0000 Subject: [PATCH 5/9] Corrected test --- include/enotify.php | 122 +++++++++++++++------------- tests/src/Content/Text/HTMLTest.php | 4 +- 2 files changed, 67 insertions(+), 59 deletions(-) diff --git a/include/enotify.php b/include/enotify.php index ced0a285e4..9206e32aa3 100644 --- a/include/enotify.php +++ b/include/enotify.php @@ -154,6 +154,7 @@ function notification($params) // Check to see if there was already a tag notify or comment notify for this post. // If so don't create a second notification + /// @todo In the future we should store the notification with the highest "value" and replace notifications $condition = ['type' => [NOTIFY_TAGSELF, NOTIFY_COMMENT, NOTIFY_SHARE], 'link' => $params['link'], 'uid' => $params['uid']]; if (DBA::exists('notify', $condition)) { @@ -166,16 +167,68 @@ function notification($params) $item = Item::selectFirstForUser($params['uid'], Item::ITEM_FIELDLIST, ['id' => $parent_id, 'deleted' => false]); } + if (empty($item)) { + return false; + } + $item_post_type = Item::postType($item); $itemlink = $item['plink']; + // "their post" + if ($item['author-link'] == $params['source_link']) { + if ($params['activity']['explicit_tagged']) { + $dest_str = $l10n->t('%1$s tagged you on [url=%2$s]their %3$s[/url]', + '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', + $itemlink, + $item_post_type + ); + } elseif ($params['activity']['origin_comment']) { + $dest_str = $l10n->t('%1$s answered you on [url=%2$s]their %3$s[/url]', + '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', + $itemlink, + $item_post_type + ); + } else { + $dest_str = $l10n->t('%1$s commented on [url=%2$s]their %3$s[/url]', + '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', + $itemlink, + $item_post_type + ); + } + // "your post" + } elseif ($params['activity']['origin_thread']) { + if ($params['activity']['explicit_tagged']) { + $dest_str = $l10n->t('%1$s tagged you on [url=%2$s]your %3$s[/url]', + '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', + $itemlink, + $item_post_type + ); + } elseif ($params['activity']['origin_comment']) { + $dest_str = $l10n->t('%1$s answered you on [url=%2$s]your %3$s[/url]', + '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', + $itemlink, + $item_post_type + ); + } else { + $dest_str = $l10n->t('%1$s commented on [url=%2$s]your %3$s[/url]', + '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', + $itemlink, + $item_post_type + ); + } // "a post" - if ($params['type'] == NOTIFY_TAGSELF) { + } elseif ($params['activity']['explicit_tagged']) { $dest_str = $l10n->t('%1$s tagged you on [url=%2$s]a %3$s[/url]', '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', $itemlink, $item_post_type ); + } elseif ($params['activity']['origin_comment']) { + $dest_str = $l10n->t('%1$s answered you on [url=%2$s]a %3$s[/url]', + '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', + $itemlink, + $item_post_type + ); } else { $dest_str = $l10n->t('%1$s commented on [url=%2$s]a %3$s[/url]', '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', @@ -184,64 +237,11 @@ function notification($params) ); } - // "George Bull's post" - if (DBA::isResult($item)) { - if ($params['type'] == NOTIFY_TAGSELF) { - $dest_str = $l10n->t('%1$s tagged you on [url=%2$s]%3$s\'s %4$s[/url]', - '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', - $itemlink, - $item['author-name'], - $item_post_type - ); - } else { - $dest_str = $l10n->t('%1$s commented on [url=%2$s]%3$s\'s %4$s[/url]', - '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', - $itemlink, - $item['author-name'], - $item_post_type - ); - } - } - - // "your post" - if (DBA::isResult($item) && $item['owner-id'] == $item['author-id'] && $item['wall']) { - if ($params['type'] == NOTIFY_TAGSELF) { - $dest_str = $l10n->t('%1$s tagged you on [url=%2$s]your %3$s[/url]', - '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', - $itemlink, - $item_post_type - ); - } else { - $dest_str = $l10n->t('%1$s commented on [url=%2$s]your %3$s[/url]', - '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', - $itemlink, - $item_post_type - ); - } - } - - // "their post" - if (DBA::isResult($item) && $item['author-link'] == $params['source_link']) { - if ($params['type'] == NOTIFY_TAGSELF) { - $dest_str = $l10n->t('%1$s tagged you on [url=%2$s]their %3$s[/url]', - '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', - $itemlink, - $item_post_type - ); - } else { - $dest_str = $l10n->t('%1$s commented on [url=%2$s]their %3$s[/url]', - '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', - $itemlink, - $item_post_type - ); - } - } - // Some mail software relies on subject field for threading. // So, we cannot have different subjects for notifications of the same thread. // Before this we have the name of the replier on the subject rendering // different subjects for messages on the same thread. - if ($params['type'] == NOTIFY_TAGSELF) { + if ($params['activity']['explicit_tagged']) { $subject = $l10n->t('[Friendica:Notify] %s tagged you', $params['source_name']); $preamble = $l10n->t('%1$s tagged you at %2$s', $params['source_name'], $sitename); @@ -713,6 +713,14 @@ function check_item_notification($itemid, $uid, $notification_type) { $params['source_link'] = $item['author-link']; $params['source_photo'] = $item['author-avatar']; + // Set the activity flags + $params['activity']['explicit_tagged'] = ($notification_type & UserItem::NOTIF_EXPLICIT_TAGGED); + $params['activity']['implicit_tagged'] = ($notification_type & UserItem::NOTIF_IMPLICIT_TAGGED); + $params['activity']['origin_comment'] = ($notification_type & UserItem::NOTIF_DIRECT_COMMENT); + $params['activity']['origin_thread'] = ($notification_type & UserItem::NOTIF_THREAD_COMMENT); + $params['activity']['thread_comment'] = ($notification_type & UserItem::NOTIF_COMMENT_PARTICIPATION); + $params['activity']['thread_activity'] = ($notification_type & UserItem::NOTIF_ACTIVITY_PARTICIPATION); + if ($notification_type & UserItem::NOTIF_SHARED) { $params['type'] = NOTIFY_SHARE; $params['verb'] = Activity::TAG; @@ -720,8 +728,8 @@ function check_item_notification($itemid, $uid, $notification_type) { $params['type'] = NOTIFY_TAGSELF; $params['verb'] = Activity::TAG; } elseif ($notification_type & UserItem::NOTIF_IMPLICIT_TAGGED) { - $params['type'] = NOTIFY_TAGSELF; - $params['verb'] = Activity::TAG; + $params['type'] = NOTIFY_COMMENT; + $params['verb'] = Activity::POST; } elseif ($notification_type & UserItem::NOTIF_THREAD_COMMENT) { $params['type'] = NOTIFY_COMMENT; $params['verb'] = Activity::POST; diff --git a/tests/src/Content/Text/HTMLTest.php b/tests/src/Content/Text/HTMLTest.php index 027f6ddb1d..8ddb83c442 100644 --- a/tests/src/Content/Text/HTMLTest.php +++ b/tests/src/Content/Text/HTMLTest.php @@ -59,8 +59,8 @@ class HTMLTest extends MockedTest 'html' => '', ], 'bug-8075-html-tags' => [ - 'expectedBBCode' => " I don't understand tests", - 'html' => " I don't understand tests", + 'expectedBBCode' => " I don't understand tests", + 'html' => " I don't understand tests", ], ]; } From 4a252868162f5f5d42955b92ae93e3d8ea5e2a25 Mon Sep 17 00:00:00 2001 From: Michael Date: Wed, 8 Jan 2020 09:43:29 +0000 Subject: [PATCH 6/9] Fixed notification text --- include/enotify.php | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/include/enotify.php b/include/enotify.php index 9206e32aa3..63006c509d 100644 --- a/include/enotify.php +++ b/include/enotify.php @@ -216,23 +216,26 @@ function notification($params) $item_post_type ); } - // "a post" + // "George Bull's post" } elseif ($params['activity']['explicit_tagged']) { - $dest_str = $l10n->t('%1$s tagged you on [url=%2$s]a %3$s[/url]', + $dest_str = $l10n->t('%1$s tagged you on [url=%2$s]%3$s\'s %4$s[/url]', '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', $itemlink, + $item['author-name'], $item_post_type ); } elseif ($params['activity']['origin_comment']) { - $dest_str = $l10n->t('%1$s answered you on [url=%2$s]a %3$s[/url]', + $dest_str = $l10n->t('%1$s answered on [url=%2$s]%3$s\'s %4$s[/url]', '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', $itemlink, + $item['author-name'], $item_post_type ); } else { - $dest_str = $l10n->t('%1$s commented on [url=%2$s]a %3$s[/url]', + $dest_str = $l10n->t('%1$s commented on [url=%2$s]%3$s\'s %4$s[/url]', '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', $itemlink, + $item['author-name'], $item_post_type ); } From a2af9f55a915bb5de3169e6119c33c18d9508c05 Mon Sep 17 00:00:00 2001 From: Michael Date: Wed, 8 Jan 2020 20:15:01 +0000 Subject: [PATCH 7/9] Reverted notify, changed test --- include/enotify.php | 103 +++++++++++++--------------- tests/src/Content/Text/HTMLTest.php | 4 +- 2 files changed, 48 insertions(+), 59 deletions(-) diff --git a/include/enotify.php b/include/enotify.php index 63006c509d..ced0a285e4 100644 --- a/include/enotify.php +++ b/include/enotify.php @@ -154,7 +154,6 @@ function notification($params) // Check to see if there was already a tag notify or comment notify for this post. // If so don't create a second notification - /// @todo In the future we should store the notification with the highest "value" and replace notifications $condition = ['type' => [NOTIFY_TAGSELF, NOTIFY_COMMENT, NOTIFY_SHARE], 'link' => $params['link'], 'uid' => $params['uid']]; if (DBA::exists('notify', $condition)) { @@ -167,48 +166,51 @@ function notification($params) $item = Item::selectFirstForUser($params['uid'], Item::ITEM_FIELDLIST, ['id' => $parent_id, 'deleted' => false]); } - if (empty($item)) { - return false; - } - $item_post_type = Item::postType($item); $itemlink = $item['plink']; - // "their post" - if ($item['author-link'] == $params['source_link']) { - if ($params['activity']['explicit_tagged']) { - $dest_str = $l10n->t('%1$s tagged you on [url=%2$s]their %3$s[/url]', - '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', - $itemlink, - $item_post_type - ); - } elseif ($params['activity']['origin_comment']) { - $dest_str = $l10n->t('%1$s answered you on [url=%2$s]their %3$s[/url]', + // "a post" + if ($params['type'] == NOTIFY_TAGSELF) { + $dest_str = $l10n->t('%1$s tagged you on [url=%2$s]a %3$s[/url]', + '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', + $itemlink, + $item_post_type + ); + } else { + $dest_str = $l10n->t('%1$s commented on [url=%2$s]a %3$s[/url]', + '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', + $itemlink, + $item_post_type + ); + } + + // "George Bull's post" + if (DBA::isResult($item)) { + if ($params['type'] == NOTIFY_TAGSELF) { + $dest_str = $l10n->t('%1$s tagged you on [url=%2$s]%3$s\'s %4$s[/url]', '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', $itemlink, + $item['author-name'], $item_post_type ); } else { - $dest_str = $l10n->t('%1$s commented on [url=%2$s]their %3$s[/url]', + $dest_str = $l10n->t('%1$s commented on [url=%2$s]%3$s\'s %4$s[/url]', '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', $itemlink, + $item['author-name'], $item_post_type ); } + } + // "your post" - } elseif ($params['activity']['origin_thread']) { - if ($params['activity']['explicit_tagged']) { + if (DBA::isResult($item) && $item['owner-id'] == $item['author-id'] && $item['wall']) { + if ($params['type'] == NOTIFY_TAGSELF) { $dest_str = $l10n->t('%1$s tagged you on [url=%2$s]your %3$s[/url]', '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', $itemlink, $item_post_type ); - } elseif ($params['activity']['origin_comment']) { - $dest_str = $l10n->t('%1$s answered you on [url=%2$s]your %3$s[/url]', - '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', - $itemlink, - $item_post_type - ); } else { $dest_str = $l10n->t('%1$s commented on [url=%2$s]your %3$s[/url]', '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', @@ -216,35 +218,30 @@ function notification($params) $item_post_type ); } - // "George Bull's post" - } elseif ($params['activity']['explicit_tagged']) { - $dest_str = $l10n->t('%1$s tagged you on [url=%2$s]%3$s\'s %4$s[/url]', - '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', - $itemlink, - $item['author-name'], - $item_post_type - ); - } elseif ($params['activity']['origin_comment']) { - $dest_str = $l10n->t('%1$s answered on [url=%2$s]%3$s\'s %4$s[/url]', - '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', - $itemlink, - $item['author-name'], - $item_post_type - ); - } else { - $dest_str = $l10n->t('%1$s commented on [url=%2$s]%3$s\'s %4$s[/url]', - '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', - $itemlink, - $item['author-name'], - $item_post_type - ); + } + + // "their post" + if (DBA::isResult($item) && $item['author-link'] == $params['source_link']) { + if ($params['type'] == NOTIFY_TAGSELF) { + $dest_str = $l10n->t('%1$s tagged you on [url=%2$s]their %3$s[/url]', + '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', + $itemlink, + $item_post_type + ); + } else { + $dest_str = $l10n->t('%1$s commented on [url=%2$s]their %3$s[/url]', + '[url=' . $params['source_link'] . ']' . $params['source_name'] . '[/url]', + $itemlink, + $item_post_type + ); + } } // Some mail software relies on subject field for threading. // So, we cannot have different subjects for notifications of the same thread. // Before this we have the name of the replier on the subject rendering // different subjects for messages on the same thread. - if ($params['activity']['explicit_tagged']) { + if ($params['type'] == NOTIFY_TAGSELF) { $subject = $l10n->t('[Friendica:Notify] %s tagged you', $params['source_name']); $preamble = $l10n->t('%1$s tagged you at %2$s', $params['source_name'], $sitename); @@ -716,14 +713,6 @@ function check_item_notification($itemid, $uid, $notification_type) { $params['source_link'] = $item['author-link']; $params['source_photo'] = $item['author-avatar']; - // Set the activity flags - $params['activity']['explicit_tagged'] = ($notification_type & UserItem::NOTIF_EXPLICIT_TAGGED); - $params['activity']['implicit_tagged'] = ($notification_type & UserItem::NOTIF_IMPLICIT_TAGGED); - $params['activity']['origin_comment'] = ($notification_type & UserItem::NOTIF_DIRECT_COMMENT); - $params['activity']['origin_thread'] = ($notification_type & UserItem::NOTIF_THREAD_COMMENT); - $params['activity']['thread_comment'] = ($notification_type & UserItem::NOTIF_COMMENT_PARTICIPATION); - $params['activity']['thread_activity'] = ($notification_type & UserItem::NOTIF_ACTIVITY_PARTICIPATION); - if ($notification_type & UserItem::NOTIF_SHARED) { $params['type'] = NOTIFY_SHARE; $params['verb'] = Activity::TAG; @@ -731,8 +720,8 @@ function check_item_notification($itemid, $uid, $notification_type) { $params['type'] = NOTIFY_TAGSELF; $params['verb'] = Activity::TAG; } elseif ($notification_type & UserItem::NOTIF_IMPLICIT_TAGGED) { - $params['type'] = NOTIFY_COMMENT; - $params['verb'] = Activity::POST; + $params['type'] = NOTIFY_TAGSELF; + $params['verb'] = Activity::TAG; } elseif ($notification_type & UserItem::NOTIF_THREAD_COMMENT) { $params['type'] = NOTIFY_COMMENT; $params['verb'] = Activity::POST; diff --git a/tests/src/Content/Text/HTMLTest.php b/tests/src/Content/Text/HTMLTest.php index 8ddb83c442..df940ef96f 100644 --- a/tests/src/Content/Text/HTMLTest.php +++ b/tests/src/Content/Text/HTMLTest.php @@ -59,8 +59,8 @@ class HTMLTest extends MockedTest 'html' => '', ], 'bug-8075-html-tags' => [ - 'expectedBBCode' => " I don't understand tests", - 'html' => " I don't understand tests", + 'expectedBBCode' => "<big rant here&rt; I don't understand tests", + 'html' => " I don't understand tests", ], ]; } From b9b19f7744ad0ba2a4bd3a692d1e6d7a3fea57cc Mon Sep 17 00:00:00 2001 From: Michael Date: Wed, 8 Jan 2020 20:27:54 +0000 Subject: [PATCH 8/9] tests ... --- tests/src/Content/Text/HTMLTest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/src/Content/Text/HTMLTest.php b/tests/src/Content/Text/HTMLTest.php index df940ef96f..003913a3dd 100644 --- a/tests/src/Content/Text/HTMLTest.php +++ b/tests/src/Content/Text/HTMLTest.php @@ -59,8 +59,8 @@ class HTMLTest extends MockedTest 'html' => '', ], 'bug-8075-html-tags' => [ - 'expectedBBCode' => "<big rant here&rt; I don't understand tests", - 'html' => " I don't understand tests", + 'expectedBBCode' => " I don't understand tests", + 'html' => "<big rant here&rt; I don't understand tests", ], ]; } From 7f2356c7fe8c7659dc9258d7d12f2ebdbd11a126 Mon Sep 17 00:00:00 2001 From: Michael Date: Wed, 8 Jan 2020 20:39:27 +0000 Subject: [PATCH 9/9] Tests, still ongoing ... --- tests/src/Content/Text/HTMLTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/src/Content/Text/HTMLTest.php b/tests/src/Content/Text/HTMLTest.php index 003913a3dd..fe54399014 100644 --- a/tests/src/Content/Text/HTMLTest.php +++ b/tests/src/Content/Text/HTMLTest.php @@ -60,7 +60,7 @@ class HTMLTest extends MockedTest ], 'bug-8075-html-tags' => [ 'expectedBBCode' => " I don't understand tests", - 'html' => "<big rant here&rt; I don't understand tests", + 'html' => "<big rant here> I don't understand tests", ], ]; }