From ae3bf47019faf51422c80303e000643c8d655531 Mon Sep 17 00:00:00 2001 From: Hypolite Petovan Date: Thu, 14 Feb 2019 22:26:18 -0500 Subject: [PATCH] Improve global open/close functions in main.js --- view/js/main.js | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/view/js/main.js b/view/js/main.js index c3d9cbed5c..3370d7ccd3 100644 --- a/view/js/main.js +++ b/view/js/main.js @@ -17,25 +17,30 @@ function _resizeIframe(obj, desth) { } function openClose(theID) { - if (document.getElementById(theID).style.display == "block") { - document.getElementById(theID).style.display = "none" - } else { - document.getElementById(theID).style.display = "block" + var el = document.getElementById(theID); + if (el) { + if (window.getComputedStyle(el).display === "none") { + openMenu(theID); + } else { + closeMenu(theID); + } } } function openMenu(theID) { var el = document.getElementById(theID); - if (el) { - el.style.display = "block"; + if (!el.dataset.display) { + el.dataset.display = 'block'; + } + el.style.display = el.dataset.display; } } function closeMenu(theID) { - var el = document.getElementById(theID) - + var el = document.getElementById(theID); if (el) { + el.dataset.display = window.getComputedStyle(el).display; el.style.display = "none"; } }