Merge remote-tracking branch 'upstream/develop' into 1701-poco

boot.php

@@ -1889,11 +1889,35 @@ function goaway($s) {
  * @return int|bool user id or false
  */
 function local_user() {
-	if((x($_SESSION,'authenticated')) && (x($_SESSION,'uid')))
+	if (x($_SESSION, 'authenticated') && x($_SESSION, 'uid')) {
 		return intval($_SESSION['uid']);
+	}
 	return false;
 }
 
+/**
+ * @brief Returns the public contact id of logged in user or false.
+ *
+ * @return int|bool public contact id or false
+ */
+function public_contact() {
+	static $public_contact_id = false;
+
+	if (!$public_contact_id && x($_SESSION, 'authenticated')) {
+		if (x($_SESSION, 'my_address')) {
+			// Local user
+			$public_contact_id = intval(get_contact($_SESSION['my_address'], 0));
+		} else if (x($_SESSION, 'visitor_home')) {
+			// Remote user
+			$public_contact_id = intval(get_contact($_SESSION['visitor_home'], 0));
+		}
+	} else if (!x($_SESSION, 'authenticated')) {
+		$public_contact_id = false;
+	}
+
+	return $public_contact_id;
+}
+
 /**
  * @brief Returns contact id of authenticated site visitor or false
  *

include/Contact.php

@@ -702,15 +702,6 @@ function posts_from_gcontact(App $a, $gcontact_id) {
 	else
 		$sql = "`item`.`uid` = %d";
 
-	if(get_config('system', 'old_pager')) {
-		$r = q("SELECT COUNT(*) AS `total` FROM `item`
-			WHERE `gcontact-id` = %d and $sql",
-			intval($gcontact_id),
-			intval(local_user()));
-
-		$a->set_pager_total($r[0]['total']);
-	}
-
 	$r = q("SELECT `item`.`uri`, `item`.*, `item`.`id` AS `item_id`,
 			`author-name` AS `name`, `owner-avatar` AS `photo`,
 			`owner-link` AS `url`, `owner-avatar` AS `thumb`
@@ -724,13 +715,9 @@ function posts_from_gcontact(App $a, $gcontact_id) {
 		intval($a->pager['itemspage'])
 	);
 
-	$o = conversation($a,$r,'community',false);
+	$o = conversation($a, $r, 'community', false);
 
-	if(!get_config('system', 'old_pager')) {
+	$o .= alt_pager($a, count($r));
-		$o .= alt_pager($a,count($r));
-	} else {
-		$o .= paginate($a);
-	}
 
 	return $o;
 }
@@ -763,15 +750,6 @@ function posts_from_contact_url(App $a, $contact_url) {
 
 	$author_id = intval($r[0]["author-id"]);
 
-	if (get_config('system', 'old_pager')) {
-		$r = q("SELECT COUNT(*) AS `total` FROM `item`
-			WHERE `author-id` = %d and $sql",
-			intval($author_id),
-			intval(local_user()));
-
-		$a->set_pager_total($r[0]['total']);
-	}
-
 	$r = q(item_query()." AND `item`.`author-id` = %d AND ".$sql.
 		" ORDER BY `item`.`created` DESC LIMIT %d, %d",
 		intval($author_id),
@@ -780,13 +758,9 @@ function posts_from_contact_url(App $a, $contact_url) {
 		intval($a->pager['itemspage'])
 	);
 
-	$o = conversation($a,$r,'community',false);
+	$o = conversation($a, $r, 'community', false);
 
-	if (!get_config('system', 'old_pager')) {
+	$o .= alt_pager($a, count($r));
-		$o .= alt_pager($a,count($r));
-	} else {
-		$o .= paginate($a);
-	}
 
 	return $o;
 }

include/auth.php

@@ -125,6 +125,7 @@ if (isset($_SESSION) && x($_SESSION,'authenticated') && (!x($_POST,'auth-params'
 				$openid = new LightOpenID;
 				$openid->identity = $openid_url;
 				$_SESSION['openid'] = $openid_url;
+				$_SESSION['remember'] = $_POST['remember'];
 				$openid->returnUrl = App::get_baseurl(true).'/openid';
 				goaway($openid->authUrl());
 			} catch (Exception $e) {
@@ -178,17 +179,12 @@ if (isset($_SESSION) && x($_SESSION,'authenticated') && (!x($_POST,'auth-params'
 			goaway(z_root());
 		}
 
-		// If the user specified to remember the authentication, then set a cookie
+		if (! $_POST['remember']) {
-		// that expires after one week (the default is when the browser is closed).
-		// The cookie will be renewed automatically.
-		// The week ensures that sessions will expire after some inactivity.
-		if ($_POST['remember'])
-			new_cookie(604800, $r[0]);
-		else
 			new_cookie(0); // 0 means delete on browser exit
+		}
 
 		// if we haven't failed up this point, log them in.
-
+		$_SESSION['remember'] = $_POST['remember'];
 		$_SESSION['last_login_date'] = datetime_convert('UTC','UTC');
 		authenticate_success($record, true, true);
 	}
@@ -203,39 +199,3 @@ function nuke_session() {
 	session_unset();
 	session_destroy();
 }
-
-/**
- * @brief Calculate the hash that is needed for the "Friendica" cookie
- *
- * @param array $user Record from "user" table
- *
- * @return string Hashed data
- */
-function cookie_hash($user) {
-	return(hash("sha256", get_config("system", "site_prvkey").
-				$user["uprvkey"].
-				$user["password"]));
-}
-
-/**
- * @brief Set the "Friendica" cookie
- *
- * @param int $time
- * @param array $user Record from "user" table
- */
-function new_cookie($time, $user = array()) {
-
-	if ($time != 0)
-		$time = $time + time();
-
-	if ($user)
-		$value = json_encode(array("uid" => $user["uid"],
-					"hash" => cookie_hash($user),
-					"ip" => $_SERVER['REMOTE_ADDR']));
-	else
-		$value = "";
-
-	setcookie("Friendica", $value, $time, "/", "",
-		(get_config('system', 'ssl_policy') == SSL_POLICY_FULL), true);
-
-}

include/conversation.php

@@ -416,8 +416,8 @@ These Fields are not added below (yet). They are here to for bug search.
 `item`.`shadow`,
 */
 
-	return "`item`.`author-link`, `item`.`author-name`, `item`.`author-avatar`,
+	return "`item`.`author-id`, `item`.`author-link`, `item`.`author-name`, `item`.`author-avatar`,
-		`item`.`owner-link`, `item`.`owner-name`, `item`.`owner-avatar`,
+		`item`.`owner-id`, `item`.`owner-link`, `item`.`owner-name`, `item`.`owner-avatar`,
 		`item`.`contact-id`, `item`.`uid`, `item`.`id`, `item`.`parent`,
 		`item`.`uri`, `item`.`thr-parent`, `item`.`parent-uri`,
 		`item`.`commented`, `item`.`created`, `item`.`edited`,
@@ -1066,8 +1066,9 @@ function builtin_activity_puller($item, &$conv_responses) {
 			else
 				$conv_responses[$mode][$item['thr-parent']] ++;
 
-			if((local_user()) && (local_user() == $item['uid']) && ($item['self']))
+			if (public_contact() == $item['author-id']) {
 				$conv_responses[$mode][$item['thr-parent'] . '-self'] = 1;
+			}
 
 			$conv_responses[$mode][$item['thr-parent'] . '-l'][] = $url;
 

include/feed.php

@@ -17,11 +17,11 @@ function feed_import($xml,$importer,&$contact, &$hub, $simulate = false) {
 
 	$a = get_app();
 
-	if (!$simulate)
+	if (!$simulate) {
 		logger("Import Atom/RSS feed '".$contact["name"]."' (Contact ".$contact["id"].") for user ".$importer["uid"], LOGGER_DEBUG);
-	else
+	} else {
 		logger("Test Atom/RSS feed", LOGGER_DEBUG);
-
+	}
 	if ($xml == "") {
 		logger('XML is empty.', LOGGER_DEBUG);
 		return;
@@ -45,63 +45,69 @@ function feed_import($xml,$importer,&$contact, &$hub, $simulate = false) {
 		$author["author-link"] = $xpath->evaluate('/rdf:RDF/rss:channel/rss:link/text()')->item(0)->nodeValue;
 		$author["author-name"] = $xpath->evaluate('/rdf:RDF/rss:channel/rss:title/text()')->item(0)->nodeValue;
 
-		if ($author["author-name"] == "")
+		if ($author["author-name"] == "") {
 			$author["author-name"] = $xpath->evaluate('/rdf:RDF/rss:channel/rss:description/text()')->item(0)->nodeValue;
-
+		}
 		$entries = $xpath->query('/rdf:RDF/rss:item');
 	}
 
 	// Is it Atom?
 	if ($xpath->query('/atom:feed')->length > 0) {
 		$alternate = $xpath->query("atom:link[@rel='alternate']")->item(0)->attributes;
-		if (is_object($alternate))
+		if (is_object($alternate)) {
-			foreach($alternate AS $attributes)
+			foreach($alternate AS $attributes) {
-				if ($attributes->name == "href")
+				if ($attributes->name == "href") {
 					$author["author-link"] = $attributes->textContent;
-
+				}
-		if ($author["author-link"] == "")
+			}
-			$author["author-link"] = $author["author-id"];
-
-		if ($author["author-link"] == "") {
-			$self = $xpath->query("atom:link[@rel='self']")->item(0)->attributes;
-			if (is_object($self))
-				foreach($self AS $attributes)
-					if ($attributes->name == "href")
-						$author["author-link"] = $attributes->textContent;
 		}
 
-		if ($author["author-link"] == "")
+		if ($author["author-link"] == "") {
-			$author["author-link"] = $xpath->evaluate('/atom:feed/atom:id/text()')->item(0)->nodeValue;
+			$author["author-link"] = $author["author-id"];
+		}
+		if ($author["author-link"] == "") {
+			$self = $xpath->query("atom:link[@rel='self']")->item(0)->attributes;
+			if (is_object($self)) {
+				foreach($self AS $attributes) {
+					if ($attributes->name == "href") {
+						$author["author-link"] = $attributes->textContent;
+					}
+				}
+			}
+		}
 
+		if ($author["author-link"] == "") {
+			$author["author-link"] = $xpath->evaluate('/atom:feed/atom:id/text()')->item(0)->nodeValue;
+		}
 		$author["author-avatar"] = $xpath->evaluate('/atom:feed/atom:logo/text()')->item(0)->nodeValue;
 
 		$author["author-name"] = $xpath->evaluate('/atom:feed/atom:title/text()')->item(0)->nodeValue;
 
-		if ($author["author-name"] == "")
+		if ($author["author-name"] == "") {
 			$author["author-name"] = $xpath->evaluate('/atom:feed/atom:subtitle/text()')->item(0)->nodeValue;
-
+		}
-		if ($author["author-name"] == "")
+		if ($author["author-name"] == "") {
 			$author["author-name"] = $xpath->evaluate('/atom:feed/atom:author/atom:name/text()')->item(0)->nodeValue;
-
+		}
 		$value = $xpath->evaluate('atom:author/poco:displayName/text()')->item(0)->nodeValue;
-		if ($value != "")
+		if ($value != "") {
 			$author["author-name"] = $value;
-
+		}
 		if ($simulate) {
 			$author["author-id"] = $xpath->evaluate('/atom:feed/atom:author/atom:uri/text()')->item(0)->nodeValue;
 
 			$value = $xpath->evaluate('atom:author/poco:preferredUsername/text()')->item(0)->nodeValue;
-			if ($value != "")
+			if ($value != "") {
 				$author["author-nick"] = $value;
-
+			}
 			$value = $xpath->evaluate('atom:author/poco:address/poco:formatted/text()', $context)->item(0)->nodeValue;
-			if ($value != "")
+			if ($value != "") {
 				$author["author-location"] = $value;
-
+			}
 			$value = $xpath->evaluate('atom:author/poco:note/text()')->item(0)->nodeValue;
-			if ($value != "")
+			if ($value != "") {
 				$author["author-about"] = $value;
-
+			}
 		}
 
 		$author["edited"] = $author["created"] = $xpath->query('/atom:feed/atom:updated/text()')->item(0)->nodeValue;
@@ -118,12 +124,12 @@ function feed_import($xml,$importer,&$contact, &$hub, $simulate = false) {
 		$author["author-name"] = $xpath->evaluate('/rss/channel/title/text()')->item(0)->nodeValue;
 		$author["author-avatar"] = $xpath->evaluate('/rss/channel/image/url/text()')->item(0)->nodeValue;
 
-		if ($author["author-name"] == "")
+		if ($author["author-name"] == "") {
 			$author["author-name"] = $xpath->evaluate('/rss/channel/copyright/text()')->item(0)->nodeValue;
-
+		}
-		if ($author["author-name"] == "")
+		if ($author["author-name"] == "") {
 			$author["author-name"] = $xpath->evaluate('/rss/channel/description/text()')->item(0)->nodeValue;
-
+		}
 		$author["edited"] = $author["created"] = $xpath->query('/rss/channel/pubDate/text()')->item(0)->nodeValue;
 
 		$author["app"] = $xpath->evaluate('/rss/channel/generator/text()')->item(0)->nodeValue;
@@ -134,9 +140,9 @@ function feed_import($xml,$importer,&$contact, &$hub, $simulate = false) {
 	if (!$simulate) {
 		$author["author-link"] = $contact["url"];
 
-		if ($author["author-name"] == "")
+		if ($author["author-name"] == "") {
 			$author["author-name"] = $contact["name"];
-
+		}
 		$author["author-avatar"] = $contact["thumb"];
 
 		$author["owner-link"] = $contact["url"];
@@ -171,33 +177,39 @@ function feed_import($xml,$importer,&$contact, &$hub, $simulate = false) {
 
 	$entrylist = array();
 
-	foreach ($entries AS $entry)
+	foreach ($entries AS $entry) {
 		$entrylist[] = $entry;
-
+	}
 	foreach (array_reverse($entrylist) AS $entry) {
 		$item = array_merge($header, $author);
 
-		if (is_object($alternate))
+		$alternate = $xpath->query("atom:link[@rel='alternate']", $entry)->item(0)->attributes;
-			foreach($alternate AS $attributes)
+		if (!is_object($alternate)) {
-				if ($attributes->name == "href")
+			$alternate = $xpath->query("atom:link", $entry)->item(0)->attributes;
+		}
+		if (is_object($alternate)) {
+			foreach($alternate AS $attributes) {
+				if ($attributes->name == "href") {
 					$item["plink"] = $attributes->textContent;
-
+				}
-		if ($item["plink"] == "")
+			}
+		}
+		if ($item["plink"] == "") {
 			$item["plink"] = $xpath->evaluate('link/text()', $entry)->item(0)->nodeValue;
-
+		}
-		if ($item["plink"] == "")
+		if ($item["plink"] == "") {
 			$item["plink"] = $xpath->evaluate('rss:link/text()', $entry)->item(0)->nodeValue;
-
+		}
 		$item["plink"] = original_url($item["plink"]);
 
 		$item["uri"] = $xpath->evaluate('atom:id/text()', $entry)->item(0)->nodeValue;
 
-		if ($item["uri"] == "")
+		if ($item["uri"] == "") {
 			$item["uri"] = $xpath->evaluate('guid/text()', $entry)->item(0)->nodeValue;
-
+		}
-		if ($item["uri"] == "")
+		if ($item["uri"] == "") {
 			$item["uri"] = $item["plink"];
-
+		}
 		$item["parent-uri"] = $item["uri"];
 
 		if (!$simulate) {
@@ -211,54 +223,50 @@ function feed_import($xml,$importer,&$contact, &$hub, $simulate = false) {
 
 		$item["title"] = $xpath->evaluate('atom:title/text()', $entry)->item(0)->nodeValue;
 
-		if ($item["title"] == "")
+		if ($item["title"] == "") {
 			$item["title"] = $xpath->evaluate('title/text()', $entry)->item(0)->nodeValue;
-
+		}
-		if ($item["title"] == "")
+		if ($item["title"] == "") {
 			$item["title"] = $xpath->evaluate('rss:title/text()', $entry)->item(0)->nodeValue;
-
+		}
-		$alternate = $xpath->query("atom:link[@rel='alternate']", $entry)->item(0)->attributes;
-		if (!is_object($alternate))
-			$alternate = $xpath->query("atom:link", $entry)->item(0)->attributes;
-
 		$published = $xpath->query('atom:published/text()', $entry)->item(0)->nodeValue;
 
-		if ($published == "")
+		if ($published == "") {
 			$published = $xpath->query('pubDate/text()', $entry)->item(0)->nodeValue;
-
+		}
-		if ($published == "")
+		if ($published == "") {
 			$published = $xpath->query('dc:date/text()', $entry)->item(0)->nodeValue;
-
+		}
 		$updated = $xpath->query('atom:updated/text()', $entry)->item(0)->nodeValue;
 
-		if ($updated == "")
+		if ($updated == "") {
 			$updated = $published;
-
+		}
-		if ($published != "")
+		if ($published != "") {
 			$item["created"] = $published;
-
+		}
-		if ($updated != "")
+		if ($updated != "") {
 			$item["edited"] = $updated;
-
+		}
 		$creator = $xpath->query('author/text()', $entry)->item(0)->nodeValue;
 
-		if ($creator == "")
+		if ($creator == "") {
 			$creator = $xpath->query('atom:author/atom:name/text()', $entry)->item(0)->nodeValue;
-
+		}
-		if ($creator == "")
+		if ($creator == "") {
 			$creator = $xpath->query('dc:creator/text()', $entry)->item(0)->nodeValue;
-
+		}
-		if ($creator != "")
+		if ($creator != "") {
 			$item["author-name"] = $creator;
-
+		}
-		if ($pubDate != "")
+		if ($pubDate != "") {
 			$item["edited"] = $item["created"] = $pubDate;
-
+		}
 		$creator = $xpath->query('dc:creator/text()', $entry)->item(0)->nodeValue;
 
-		if ($creator != "")
+		if ($creator != "") {
 			$item["author-name"] = $creator;
-
+		}
 		/// @TODO ?
 		// <category>Ausland</category>
 		// <media:thumbnail width="152" height="76" url="http://www.taz.de/picture/667875/192/14388767.jpg"/>
@@ -273,12 +281,13 @@ function feed_import($xml,$importer,&$contact, &$hub, $simulate = false) {
 			$title = "";
 
 			foreach($enclosure->attributes AS $attributes) {
-				if ($attributes->name == "url")
+				if ($attributes->name == "url") {
 					$href = $attributes->textContent;
-				elseif ($attributes->name == "length")
+				} elseif ($attributes->name == "length") {
 					$length = $attributes->textContent;
-				elseif ($attributes->name == "type")
+				} elseif ($attributes->name == "type") {
 					$type = $attributes->textContent;
+				}
 			}
 			if(strlen($item["attach"]))
 				$item["attach"] .= ',';
@@ -292,9 +301,11 @@ function feed_import($xml,$importer,&$contact, &$hub, $simulate = false) {
 			$preview = "";
 
 			// Handle enclosures and treat them as preview picture
-			foreach ($attachments AS $attachment)
+			foreach ($attachments AS $attachment) {
-				if ($attachment["type"] == "image/jpeg")
+				if ($attachment["type"] == "image/jpeg") {
 					$preview = $attachment["link"];
+				}
+			}
 
 			$item["body"] = $item["title"].add_page_info($item["plink"], false, $preview, ($contact["fetch_further_information"] == 2), $contact["ffi_keyword_blacklist"]);
 			$item["tag"] = add_page_keywords($item["plink"], false, $preview, ($contact["fetch_further_information"] == 2), $contact["ffi_keyword_blacklist"]);
@@ -304,20 +315,20 @@ function feed_import($xml,$importer,&$contact, &$hub, $simulate = false) {
 		} else {
 			$body = trim($xpath->evaluate('atom:content/text()', $entry)->item(0)->nodeValue);
 
-			if ($body == "")
+			if ($body == "") {
 				$body = trim($xpath->evaluate('content:encoded/text()', $entry)->item(0)->nodeValue);
-
+			}
-			if ($body == "")
+			if ($body == "") {
 				$body = trim($xpath->evaluate('description/text()', $entry)->item(0)->nodeValue);
-
+			}
-			if ($body == "")
+			if ($body == "") {
 				$body = trim($xpath->evaluate('atom:summary/text()', $entry)->item(0)->nodeValue);
-
+			}
 			// remove the content of the title if it is identically to the body
 			// This helps with auto generated titles e.g. from tumblr
-			if (title_is_body($item["title"], $body))
+			if (title_is_body($item["title"], $body)) {
 				$item["title"] = "";
-
+			}
 			$item["body"] = html2bbcode($body);
 		}
 
@@ -336,14 +347,16 @@ function feed_import($xml,$importer,&$contact, &$hub, $simulate = false) {
 			$id = item_store($item, false, $notify);
 
 			logger("Feed for contact ".$contact["url"]." stored under id ".$id);
-		} else
+		} else {
 			$items[] = $item;
-
+		}
-		if ($simulate)
+		if ($simulate) {
 			break;
+		}
 	}
 
-	if ($simulate)
+	if ($simulate) {
 		return array("header" => $author, "items" => $items);
+	}
 }
 ?>

include/like.php

@@ -18,155 +18,169 @@ require_once("include/diaspora.php");
 function do_like($item_id, $verb) {
 	$a = get_app();
 
-	if(! local_user() && ! remote_user()) {
+	if (! local_user() && ! remote_user()) {
 		return false;
 	}
 
-	switch($verb) {
+	switch ($verb) {
 		case 'like':
+			$bodyverb = t('%1$s likes %2$s\'s %3$s');
+			$activity = ACTIVITY_LIKE;
+			break;
 		case 'unlike':
+			$bodyverb = t('%1$s doesn\'t like %2$s\'s %3$s');
 			$activity = ACTIVITY_LIKE;
 			break;
 		case 'dislike':
 		case 'undislike':
+			$bodyverb = t('%1$s doesn\'t like %2$s\'s %3$s');
 			$activity = ACTIVITY_DISLIKE;
 			break;
 		case 'attendyes':
 		case 'unattendyes':
+			$bodyverb = t('%1$s is attending %2$s\'s %3$s');
 			$activity = ACTIVITY_ATTEND;
 			break;
 		case 'attendno':
 		case 'unattendno':
+			$bodyverb = t('%1$s is not attending %2$s\'s %3$s');
 			$activity = ACTIVITY_ATTENDNO;
 			break;
 		case 'attendmaybe':
 		case 'unattendmaybe':
+			$bodyverb = t('%1$s may attend %2$s\'s %3$s');
 			$activity = ACTIVITY_ATTENDMAYBE;
 			break;
 		default:
+			logger('like: unknown verb ' . $verb . ' for item ' . $item_id);
 			return false;
-			break;
 	}
 
+	// Enable activity toggling instead of on/off
+	$event_verb_flag = $activity === ACTIVITY_ATTEND || $activity === ACTIVITY_ATTENDNO || $activity === ACTIVITY_ATTENDMAYBE;
+
 	logger('like: verb ' . $verb . ' item ' . $item_id);
 
-	$r = q("SELECT * FROM `item` WHERE `id` = '%s' OR `uri` = '%s' LIMIT 1",
+	// Retrieve item
+	$items = q("SELECT * FROM `item` WHERE `id` = '%s' OR `uri` = '%s' LIMIT 1",
 		dbesc($item_id),
 		dbesc($item_id)
 	);
 
-	if(! $item_id || (! dbm::is_result($r))) {
+	if (! $item_id || ! dbm::is_result($items)) {
-		logger('like: no item ' . $item_id);
+		logger('like: unknown item ' . $item_id);
 		return false;
 	}
 
-	$item = $r[0];
+	$item = $items[0];
 
-	$owner_uid = $item['uid'];
+	if (! can_write_wall($a, $item['uid'])) {
-
+		logger('like: unable to write on wall ' . $item['uid']);
-	if (! can_write_wall($a,$owner_uid)) {
 		return false;
 	}
 
-	$remote_owner = null;
+	// Retrieves the local post owner
+	$owners = q("SELECT `contact`.* FROM `contact`
+		WHERE `contact`.`self` = 1
+		AND `contact`.`uid` = %d",
+		intval($item['uid'])
+	);
+	if (dbm::is_result($owners)) {
+		$owner_self_contact = $owners[0];
+	} else {
+		logger('like: unknown owner ' . $item['uid']);
+		return false;
+	}
 
-	if(! $item['wall']) {
+	// Retrieve the current logged in user's public contact
-		// The top level post may have been written by somebody on another system
+	$author_id = public_contact();
-		$r = q("SELECT * FROM `contact` WHERE `id` = %d AND `uid` = %d LIMIT 1",
+
-			intval($item['contact-id']),
+	$contacts = q("SELECT * FROM `contact` WHERE `id` = %d",
-			intval($item['uid'])
+		intval($author_id)
+	);
+	if (dbm::is_result($contacts)) {
+		$author_contact = $contacts[0];
+	} else {
+		logger('like: unknown author ' . $author_id);
+		return false;
+	}
+
+	// Contact-id is the uid-dependant author contact
+	if (local_user() == $item['uid']) {
+		$item_contact_id = $owner_self_contact['id'];
+		$item_contact = $owner_self_contact;
+	} else {
+		$item_contact_id = get_contact($author_contact['url'], $item['uid']);
+
+		$contacts = q("SELECT * FROM `contact` WHERE `id` = %d",
+			intval($item_contact_id)
 		);
-		if (! dbm::is_result($r)) {
+		if (dbm::is_result($contacts)) {
+			$item_contact = $contacts[0];
+		} else {
+			logger('like: unknown item contact ' . $item_contact_id);
 			return false;
 		}
-		if (! $r[0]['self']) {
-			$remote_owner = $r[0];
-		}
 	}
 
-	// this represents the post owner on this system.
+	// Look for an existing verb row
-
-	$r = q("SELECT `contact`.*, `user`.`nickname` FROM `contact` LEFT JOIN `user` ON `contact`.`uid` = `user`.`uid`
-		WHERE `contact`.`self` = 1 AND `contact`.`uid` = %d LIMIT 1",
-		intval($owner_uid)
-	);
-	if (dbm::is_result($r)) {
-		$owner = $r[0];
-	}
-
-	if (! $owner) {
-		logger('like: no owner');
-		return false;
-	}
-
-	if (! $remote_owner) {
-		$remote_owner = $owner;
-	}
-
-	// This represents the person posting
-
-	if ((local_user()) && (local_user() == $owner_uid)) {
-		$contact = $owner;
-	} else {
-		$r = q("SELECT * FROM `contact` WHERE `id` = %d AND `uid` = %d LIMIT 1",
-			intval($_SESSION['visitor_id']),
-			intval($owner_uid)
-		);
-		if (dbm::is_result($r)) {
-			$contact = $r[0];
-		}
-	}
-	if (! $contact) {
-		return false;
-	}
-
-
-	$verbs = " '".dbesc($activity)."' ";
-
 	// event participation are essentially radio toggles. If you make a subsequent choice,
 	// we need to eradicate your first choice.
-	if ($activity === ACTIVITY_ATTEND || $activity === ACTIVITY_ATTENDNO || $activity === ACTIVITY_ATTENDMAYBE) {
+	if ($event_verb_flag) {
-		$verbs = " '" . dbesc(ACTIVITY_ATTEND) . "','" . dbesc(ACTIVITY_ATTENDNO) . "','" . dbesc(ACTIVITY_ATTENDMAYBE) . "' ";
+		$verbs = "'" . dbesc(ACTIVITY_ATTEND) . "', '" . dbesc(ACTIVITY_ATTENDNO) . "', '" . dbesc(ACTIVITY_ATTENDMAYBE) . "'";
+	} else {
+		$verbs = "'".dbesc($activity)."'";
 	}
 
-	$r = q("SELECT `id`, `guid` FROM `item` WHERE `verb` IN ( $verbs ) AND `deleted` = 0
+	$existing_like = q("SELECT `id`, `guid`, `verb` FROM `item`
-		AND `contact-id` = %d AND `uid` = %d
+		WHERE `verb` IN ($verbs)
-		AND (`parent` = '%s' OR `parent-uri` = '%s' OR `thr-parent` = '%s') LIMIT 1",
+		AND `deleted` = 0
-		intval($contact['id']), intval($owner_uid),
+		AND `author-id` = %d
+		AND `uid` = %d
+		AND (`parent` = '%s' OR `parent-uri` = '%s' OR `thr-parent` = '%s')
+		LIMIT 1",
+		intval($author_contact['id']),
+		intval($item['uid']),
 		dbesc($item_id), dbesc($item_id), dbesc($item['uri'])
 	);
 
-	if (dbm::is_result($r)) {
+	// If it exists, mark it as deleted
-		$like_item = $r[0];
+	if (dbm::is_result($existing_like)) {
+		$like_item = $existing_like[0];
 
 		// Already voted, undo it
-		$r = q("UPDATE `item` SET `deleted` = 1, `unseen` = 1, `changed` = '%s' WHERE `id` = %d",
+		q("UPDATE `item` SET `deleted` = 1, `unseen` = 1, `changed` = '%s' WHERE `id` = %d",
 			dbesc(datetime_convert()),
 			intval($like_item['id'])
 		);
 
-
 		// Clean up the Diaspora signatures for this like
 		// Go ahead and do it even if Diaspora support is disabled. We still want to clean up
 		// if it had been enabled in the past
-		$r = q("DELETE FROM `sign` WHERE `iid` = %d",
+		q("DELETE FROM `sign` WHERE `iid` = %d",
 			intval($like_item['id'])
 		);
 
 		$like_item_id = $like_item['id'];
 		proc_run(PRIORITY_HIGH, "include/notifier.php", "like", $like_item_id);
 
+		if (!$event_verb_flag || $like_item['verb'] == $activity) {
+			return true;
+		}
+	}
+
+	// Verb is "un-something", just trying to delete existing entries
+	if (strpos($verb, 'un') === 0) {
 		return true;
 	}
 
-	$uri = item_new_uri($a->get_hostname(),$owner_uid);
+	// Else or if event verb different from existing row, create a new item row
-
 	$post_type = (($item['resource-id']) ? t('photo') : t('status'));
 	if ($item['object-type'] === ACTIVITY_OBJ_EVENT) {
 		$post_type = t('event');
 	}
-	$objtype = (($item['resource-id']) ? ACTIVITY_OBJ_IMAGE : ACTIVITY_OBJ_NOTE );
+	$objtype = $item['resource-id'] ? ACTIVITY_OBJ_IMAGE : ACTIVITY_OBJ_NOTE ;
-	$link = xmlify('<link rel="alternate" type="text/html" href="' . App::get_baseurl() . '/display/' . $owner['nickname'] . '/' . $item['id'] . '" />' . "\n") ;
+	$link = xmlify('<link rel="alternate" type="text/html" href="' . App::get_baseurl() . '/display/' . $owner_self_contact['nick'] . '/' . $item['id'] . '" />' . "\n") ;
 	$body = $item['body'];
 
 	$obj = <<< EOT
@@ -180,80 +194,62 @@ function do_like($item_id, $verb) {
 		<content>$body</content>
 	</object>
 EOT;
-	if ($verb === 'like') {
-		$bodyverb = t('%1$s likes %2$s\'s %3$s');
-	}
-	if ($verb === 'dislike') {
-		$bodyverb = t('%1$s doesn\'t like %2$s\'s %3$s');
-	}
-	if ($verb === 'attendyes') {
-		$bodyverb = t('%1$s is attending %2$s\'s %3$s');
-	}
-	if ($verb === 'attendno') {
-		$bodyverb = t('%1$s is not attending %2$s\'s %3$s');
-	}
-	if ($verb === 'attendmaybe') {
-		$bodyverb = t('%1$s may attend %2$s\'s %3$s');
-	}
 
-	if (! isset($bodyverb)) {
+	$ulink = '[url=' . $author_contact['url'] . ']' . $author_contact['name'] . '[/url]';
-		return false;
-	}
-
-	$ulink = '[url=' . $contact['url'] . ']' . $contact['name'] . '[/url]';
 	$alink = '[url=' . $item['author-link'] . ']' . $item['author-name'] . '[/url]';
-	$plink = '[url=' . App::get_baseurl() . '/display/' . $owner['nickname'] . '/' . $item['id'] . ']' . $post_type . '[/url]';
+	$plink = '[url=' . App::get_baseurl() . '/display/' . $owner_self_contact['nick'] . '/' . $item['id'] . ']' . $post_type . '[/url]';
 
-	/// @TODO Or rewrite this to multi-line initialization of the array?
+	$new_item = array(
-	$arr = array();
+		'guid'          => get_guid(32),
+		'uri'           => item_new_uri($a->get_hostname(), $item['uid']),
+		'uid'           => $item['uid'],
+		'contact-id'    => $item_contact_id,
+		'type'          => 'activity',
+		'wall'          => $item['wall'],
+		'origin'        => 1,
+		'gravity'       => GRAVITY_LIKE,
+		'parent'        => $item['id'],
+		'parent-uri'    => $item['uri'],
+		'thr-parent'    => $item['uri'],
+		'owner-id'      => $item['owner-id'],
+		'owner-name'    => $item['owner-name'],
+		'owner-link'    => $item['owner-link'],
+		'owner-avatar'  => $item['owner-avatar'],
+		'author-id'     => $author_contact['id'],
+		'author-name'   => $author_contact['name'],
+		'author-link'   => $author_contact['url'],
+		'author-avatar' => $author_contact['thumb'],
+		'body'          => sprintf($bodyverb, $ulink, $alink, $plink),
+		'verb'          => $activity,
+		'object-type'   => $objtype,
+		'object'        => $obj,
+		'allow_cid'     => $item['allow_cid'],
+		'allow_gid'     => $item['allow_gid'],
+		'deny_cid'      => $item['deny_cid'],
+		'deny_gid'      => $item['deny_gid'],
+		'visible'       => 1,
+		'unseen'        => 1,
+		'last-child'    => 0
+	);
 
-	$arr['guid'] = get_guid(32);
+	$new_item_id = item_store($new_item);
-	$arr['uri'] = $uri;
-	$arr['uid'] = $owner_uid;
-	$arr['contact-id'] = $contact['id'];
-	$arr['type'] = 'activity';
-	$arr['wall'] = $item['wall'];
-	$arr['origin'] = 1;
-	$arr['gravity'] = GRAVITY_LIKE;
-	$arr['parent'] = $item['id'];
-	$arr['parent-uri'] = $item['uri'];
-	$arr['thr-parent'] = $item['uri'];
-	$arr['owner-name'] = $remote_owner['name'];
-	$arr['owner-link'] = $remote_owner['url'];
-	$arr['owner-avatar'] = $remote_owner['thumb'];
-	$arr['author-name'] = $contact['name'];
-	$arr['author-link'] = $contact['url'];
-	$arr['author-avatar'] = $contact['thumb'];
-	$arr['body'] =  sprintf( $bodyverb, $ulink, $alink, $plink );
-	$arr['verb'] = $activity;
-	$arr['object-type'] = $objtype;
-	$arr['object'] = $obj;
-	$arr['allow_cid'] = $item['allow_cid'];
-	$arr['allow_gid'] = $item['allow_gid'];
-	$arr['deny_cid'] = $item['deny_cid'];
-	$arr['deny_gid'] = $item['deny_gid'];
-	$arr['visible'] = 1;
-	$arr['unseen'] = 1;
-	$arr['last-child'] = 0;
-
-	$post_id = item_store($arr);
 
+	// @todo: Explain this block
 	if (! $item['visible']) {
-		$r = q("UPDATE `item` SET `visible` = 1 WHERE `id` = %d AND `uid` = %d",
+		q("UPDATE `item` SET `visible` = 1 WHERE `id` = %d AND `uid` = %d",
 			intval($item['id']),
-			intval($owner_uid)
+			intval($item['uid'])
 		);
 	}
 
-
 	// Save the author information for the like in case we need to relay to Diaspora
-	Diaspora::store_like_signature($contact, $post_id);
+	Diaspora::store_like_signature($item_contact, $new_item_id);
 
-	$arr['id'] = $post_id;
+	$new_item['id'] = $new_item_id;
 
-	call_hooks('post_local_end', $arr);
+	call_hooks('post_local_end', $new_item);
 
-	proc_run(PRIORITY_HIGH, "include/notifier.php", "like", $post_id);
+	proc_run(PRIORITY_HIGH, "include/notifier.php", "like", $new_item_id);
 
 	return true;
 }

include/security.php

@@ -1,5 +1,44 @@
 <?php
 
+/**
+ * @brief Calculate the hash that is needed for the "Friendica" cookie
+ *
+ * @param array $user Record from "user" table
+ *
+ * @return string Hashed data
+ */
+function cookie_hash($user) {
+	return(hash("sha256", get_config("system", "site_prvkey").
+				$user["uprvkey"].
+				$user["password"]));
+}
+
+/**
+ * @brief Set the "Friendica" cookie
+ *
+ * @param int $time
+ * @param array $user Record from "user" table
+ */
+function new_cookie($time, $user = array()) {
+
+	if ($time != 0) {
+		$time = $time + time();
+	}
+
+	if ($user) {
+		$value = json_encode(array("uid" => $user["uid"],
+					"hash" => cookie_hash($user),
+					"ip" => $_SERVER['REMOTE_ADDR']));
+	}
+	else {
+		$value = "";
+	}
+
+	setcookie("Friendica", $value, $time, "/", "",
+		(get_config('system', 'ssl_policy') == SSL_POLICY_FULL), true);
+
+}
+
 function authenticate_success($user_record, $login_initial = false, $interactive = false, $login_refresh = false) {
 
 	$a = get_app();
@@ -94,6 +133,21 @@ function authenticate_success($user_record, $login_initial = false, $interactive
 
 
 	}
+
+	if ($login_initial) {
+		// If the user specified to remember the authentication, then set a cookie
+		// that expires after one week (the default is when the browser is closed).
+		// The cookie will be renewed automatically.
+		// The week ensures that sessions will expire after some inactivity.
+		if ($_SESSION['remember']) {
+			logger('Injecting cookie for remembered user '. $_SESSION['remember_user']['nickname']);
+			new_cookie(604800, $user_record);
+			unset($_SESSION['remember']);
+		}
+	}
+
+
+
 	if ($login_initial) {
 		call_hooks('logged_in', $a->user);
 

include/text.php

@@ -268,90 +268,90 @@ function hex2bin($s) {
 }}
 
 
-if(! function_exists('paginate_data')) {
 /**
- * Automatica pagination data.
+ * @brief Paginator function. Pushes relevant links in a pager array structure.
+ *
+ * Links are generated depending on the current page and the total number of items.
+ * Inactive links (like "first" and "prev" on page 1) are given the "disabled" class.
+ * Current page link is given the "active" CSS class
  *
  * @param App $a App instance
- * @param int $count [optional] item count (used with alt pager)
+ * @param int $count [optional] item count (used with minimal pager)
  * @return Array data for pagination template
  */
-function paginate_data(App $a, $count=null) {
+function paginate_data(App $a, $count = null) {
-	$stripped = preg_replace('/([&?]page=[0-9]*)/','',$a->query_string);
+	$stripped = preg_replace('/([&?]page=[0-9]*)/', '', $a->query_string);
 
-	$stripped = str_replace('q=','',$stripped);
+	$stripped = str_replace('q=', '', $stripped);
-	$stripped = trim($stripped,'/');
+	$stripped = trim($stripped, '/');
 	$pagenum = $a->pager['page'];
 
-	if (($a->page_offset != "") AND !preg_match('/[?&].offset=/', $stripped))
+	if (($a->page_offset != '') AND !preg_match('/[?&].offset=/', $stripped)) {
-		$stripped .= "&offset=".urlencode($a->page_offset);
+		$stripped .= '&offset=' . urlencode($a->page_offset);
-
-	$url = $stripped;
-
-	$data = array();
-	function _l(&$d, $name, $url, $text, $class="") {
-		if (!strpos($url, "?")) {
-			if ($pos = strpos($url, "&"))
-				$url = substr($url, 0, $pos)."?".substr($url, $pos + 1);
-		}
-
-		$d[$name] = array('url'=>$url, 'text'=>$text, 'class'=>$class);
 	}
 
-	if (!is_null($count)){
+	$url = $stripped;
-		// alt pager
+	$data = array();
-		if($a->pager['page']>1)
+
-			_l($data,  "prev", $url.'&page='.($a->pager['page'] - 1), t('newer'));
+	function _l(&$d, $name, $url, $text, $class = '') {
-		if($count>0)
+		if (strpos($url, '?') === false && ($pos = strpos($url, '&')) !== false) {
-			_l($data,  "next", $url.'&page='.($a->pager['page'] + 1), t('older'));
+			$url = substr($url, 0, $pos) . '?' . substr($url, $pos + 1);
+		}
+
+		$d[$name] = array('url' => $url, 'text' => $text, 'class' => $class);
+	}
+
+	if (!is_null($count)) {
+		// minimal pager (newer / older)
+		$data['class'] = 'pager';
+		_l($data, 'prev', $url . '&page=' . ($a->pager['page'] - 1), t('newer'), 'previous' . ($a->pager['page'] == 1 ? ' disabled' : ''));
+		_l($data, 'next', $url . '&page=' . ($a->pager['page'] + 1), t('older'), 'next' . ($count <= 0 ? ' disabled' : ''));
 	} else {
-		// full pager
+		// full pager (first / prev / 1 / 2 / ... / 14 / 15 / next / last)
-		if($a->pager['total'] > $a->pager['itemspage']) {
+		$data['class'] = 'pagination';
-			if($a->pager['page'] != 1)
+		if ($a->pager['total'] > $a->pager['itemspage']) {
-				_l($data,  "prev", $url.'&page='.($a->pager['page'] - 1), t('prev'));
+			_l($data, 'first', $url . '&page=1',  t('first'), $a->pager['page'] == 1 ? 'disabled' : '');
-
+			_l($data, 'prev', $url . '&page=' . ($a->pager['page'] - 1), t('prev'), $a->pager['page'] == 1 ? 'disabled' : '');
-			_l($data, "first", $url."&page=1",  t('first'));
-
 
 			$numpages = $a->pager['total'] / $a->pager['itemspage'];
 
 			$numstart = 1;
 			$numstop = $numpages;
 
-			if($numpages > 14) {
+			// Limit the number of displayed page number buttons.
-				$numstart = (($pagenum > 7) ? ($pagenum - 7) : 1);
+			if ($numpages > 8) {
-				$numstop = (($pagenum > ($numpages - 7)) ? $numpages : ($numstart + 14));
+				$numstart = (($pagenum > 4) ? ($pagenum - 4) : 1);
+				$numstop = (($pagenum > ($numpages - 7)) ? $numpages : ($numstart + 8));
 			}
 
 			$pages = array();
 
-			for($i = $numstart; $i <= $numstop; $i++){
+			for ($i = $numstart; $i <= $numstop; $i++) {
-				if($i == $a->pager['page'])
+				if ($i == $a->pager['page']) {
-					_l($pages, $i, "#",  $i, "current");
+					_l($pages, $i, '#',  $i, 'current active');
-				else
+				} else {
-					_l($pages, $i, $url."&page=$i", $i, "n");
+					_l($pages, $i, $url . '&page='. $i, $i, 'n');
+				}
 			}
 
-			if(($a->pager['total'] % $a->pager['itemspage']) != 0) {
+			if (($a->pager['total'] % $a->pager['itemspage']) != 0) {
-				if($i == $a->pager['page'])
+				if ($i == $a->pager['page']) {
-					_l($pages, $i, "#",  $i, "current");
+					_l($pages, $i, '#',  $i, 'current active');
-				else
+				} else {
-					_l($pages, $i, $url."&page=$i", $i, "n");
+					_l($pages, $i, $url . '&page=' . $i, $i, 'n');
+				}
 			}
 
 			$data['pages'] = $pages;
 
 			$lastpage = (($numpages > intval($numpages)) ? intval($numpages)+1 : $numpages);
-			_l($data, "last", $url."&page=$lastpage", t('last'));
+			_l($data, 'next', $url . '&page=' . ($a->pager['page'] + 1), t('next'), $a->pager['page'] == $lastpage ? 'disabled' : '');
-
+			_l($data, 'last', $url . '&page=' . $lastpage, t('last'), $a->pager['page'] == $lastpage ? 'disabled' : '');
-			if(($a->pager['total'] - ($a->pager['itemspage'] * $a->pager['page'])) > 0)
-				_l($data, "next", $url."&page=".($a->pager['page'] + 1), t('next'));
-
 		}
 	}
-	return $data;
 
-}}
+	return $data;
+}
 
 if(! function_exists('paginate')) {
 /**

mod/admin.php

@@ -660,7 +660,6 @@ function admin_page_site_post(App $a) {
 	$basepath		=	((x($_POST,'basepath'))			? notags(trim($_POST['basepath']))		: '');
 	$singleuser		=	((x($_POST,'singleuser'))		? notags(trim($_POST['singleuser']))		: '');
 	$proxy_disabled		=	((x($_POST,'proxy_disabled'))		? True						: False);
-	$old_pager		=	((x($_POST,'old_pager'))		? True						: False);
 	$only_tag_search	=	((x($_POST,'only_tag_search'))		? True						: False);
 	$rino			=	((x($_POST,'rino'))			? intval($_POST['rino'])			: 0);
 	$embedly		=	((x($_POST,'embedly'))			? notags(trim($_POST['embedly']))		: '');
@@ -811,7 +810,6 @@ function admin_page_site_post(App $a) {
 	set_config('system','temppath', $temppath);
 	set_config('system','basepath', $basepath);
 	set_config('system','proxy_disabled', $proxy_disabled);
-	set_config('system','old_pager', $old_pager);
 	set_config('system','only_tag_search', $only_tag_search);
 	set_config('system','worker', $worker);
 	set_config('system','worker_queues', $worker_queues);
@@ -1055,7 +1053,6 @@ function admin_page_site(App $a) {
 		'$temppath'		=> array('temppath', t("Temp path"), get_config('system','temppath'), t("If you have a restricted system where the webserver can't access the system temp path, enter another path here.")),
 		'$basepath'		=> array('basepath', t("Base path to installation"), get_config('system','basepath'), t("If the system cannot detect the correct path to your installation, enter the correct path here. This setting should only be set if you are using a restricted system and symbolic links to your webroot.")),
 		'$proxy_disabled'	=> array('proxy_disabled', t("Disable picture proxy"), get_config('system','proxy_disabled'), t("The picture proxy increases performance and privacy. It shouldn't be used on systems with very low bandwith.")),
-		'$old_pager'		=> array('old_pager', t("Enable old style pager"), get_config('system','old_pager'), t("The old style pager has page numbers but slows down massively the page speed.")),
 		'$only_tag_search'	=> array('only_tag_search', t("Only search in tags"), get_config('system','only_tag_search'), t("On large systems the text search can slow down the system extremely.")),
 
 		'$relocate_url'		=> array('relocate_url', t("New base url"), App::get_baseurl(), t("Change base url for this server. Sends relocate message to all DFRN contacts of all users.")),

mod/community.php

@@ -48,27 +48,6 @@ function community_content(App $a, $update = 0) {
 	// Only public posts can be shown
 	// OR your own posts if you are a logged in member
 
-	if(get_config('system', 'old_pager')) {
-		$r = qu("SELECT COUNT(distinct(`item`.`uri`)) AS `total`
-			FROM `item` INNER JOIN `contact` ON `contact`.`id` = `item`.`contact-id`
-			AND `contact`.`blocked` = 0 AND `contact`.`pending` = 0
-			INNER JOIN `user` ON `user`.`uid` = `item`.`uid` AND `user`.`hidewall` = 0
-			WHERE `item`.`visible` = 1 AND `item`.`deleted` = 0 and `item`.`moderated` = 0
-			AND `item`.`allow_cid` = ''  AND `item`.`allow_gid` = ''
-			AND `item`.`deny_cid`  = '' AND `item`.`deny_gid`  = ''
-			AND `item`.`private` = 0 AND `item`.`wall` = 1"
-		);
-
-		if (dbm::is_result($r))
-			$a->set_pager_total($r[0]['total']);
-
-		if(! $r[0]['total']) {
-			info( t('No results.') . EOL);
-			return $o;
-		}
-
-	}
-
 	$r = community_getitems($a->pager['start'], $a->pager['itemspage']);
 
 	if (! dbm::is_result($r)) {
@@ -105,13 +84,9 @@ function community_content(App $a, $update = 0) {
 
 	// we behave the same in message lists as the search module
 
-	$o .= conversation($a,$s,'community',$update);
+	$o .= conversation($a, $s, 'community', $update);
 
-	if(!get_config('system', 'old_pager')) {
+        $o .= alt_pager($a, count($r));
-	        $o .= alt_pager($a,count($r));
-	} else {
-	        $o .= paginate($a);
-	}
 
 	return $o;
 }

mod/network.php

@@ -599,21 +599,6 @@ function network_content(App $a, $update = 0) {
 		$pager_sql = '';
 
 	} else {
-		if(get_config('system', 'old_pager')) {
-			$r = qu("SELECT COUNT(*) AS `total`
-				FROM $sql_table $sql_post_table INNER JOIN `contact` ON `contact`.`id` = $sql_table.`contact-id`
-				AND (NOT `contact`.`blocked` OR `contact`.`pending`)
-				WHERE $sql_table.`uid` = %d AND $sql_table.`visible` AND NOT $sql_table.`deleted`
-				$sql_extra2 $sql_extra3
-				$sql_extra $sql_nets ",
-				intval($_SESSION['uid'])
-			);
-
-			if (dbm::is_result($r)) {
-				$a->set_pager_total($r[0]['total']);
-			}
-		}
-
 		//  check if we serve a mobile device and get the user settings
 		//  accordingly
 		if ($a->is_mobile) {
@@ -788,15 +773,13 @@ function network_content(App $a, $update = 0) {
 
 	$mode = (($nouveau) ? 'network-new' : 'network');
 
-	$o .= conversation($a,$items,$mode,$update);
+	$o .= conversation($a, $items, $mode, $update);
 
 	if (!$update) {
-		if (get_pconfig(local_user(),'system','infinite_scroll')) {
+		if (get_pconfig(local_user(), 'system', 'infinite_scroll')) {
 			$o .= scroll_loader();
-		} elseif (!get_config('system', 'old_pager')) {
-			$o .= alt_pager($a,count($items));
 		} else {
-			$o .= paginate($a);
+			$o .= alt_pager($a, count($items));
 		}
 	}
 

mod/openid.php

@@ -30,7 +30,7 @@ function openid_content(App $a) {
 			//       mod/settings.php in 8367cad so it might have left mixed
 			//       records in the user table
 			//
-			$r = q("SELECT * FROM `user`
+			$r = q("SELECT *, `user`.`pubkey` as `upubkey`, `user`.`prvkey` as `uprvkey` FROM `user`
 				WHERE ( `openid` = '%s' OR `openid` = '%s' )
 				AND `blocked` = 0 AND `account_expired` = 0
 				AND `account_removed` = 0 AND `verified` = 1

mod/profile.php

@@ -251,23 +251,6 @@ function profile_content(App $a, $update = 0) {
 			$sql_extra3 = sprintf(" AND `thread`.`contact-id` = %d ", intval(intval($a->profile['contact_id'])));
 		}
 
-		if(get_config('system', 'old_pager')) {
-		    $r = q("SELECT COUNT(*) AS `total`
-			    FROM `thread` INNER JOIN `item` ON `item`.`id` = `thread`.`iid`
-			    $sql_post_table INNER JOIN `contact` ON `contact`.`id` = `thread`.`contact-id`
-			    AND `contact`.`blocked` = 0 AND `contact`.`pending` = 0
-			    WHERE `thread`.`uid` = %d AND `thread`.`visible` = 1 AND `thread`.`deleted` = 0
-			    and `thread`.`moderated` = 0
-			    AND `thread`.`wall` = 1
-			    $sql_extra3 $sql_extra $sql_extra2 ",
-			    intval($a->profile['profile_uid'])
-			);
-
-			if (dbm::is_result($r)) {
-				$a->set_pager_total($r[0]['total']);
-			}
-		}
-
 		//  check if we serve a mobile device and get the user settings
 		//  accordingly
 		if ($a->is_mobile) {
@@ -335,14 +318,10 @@ function profile_content(App $a, $update = 0) {
 		);
 	}
 
-	$o .= conversation($a,$items,'profile',$update);
+	$o .= conversation($a, $items, 'profile', $update);
 
-	if(! $update) {
+	if (!$update) {
-		if(!get_config('system', 'old_pager')) {
+		$o .= alt_pager($a, count($items));
-			$o .= alt_pager($a,count($items));
-		} else {
-			$o .= paginate($a);
-		}
 	}
 
 	return $o;

view/templates/admin_site.tpl

@@ -151,7 +151,6 @@
 	{{include file="field_input.tpl" field=$itemcache_duration}}
 	{{include file="field_input.tpl" field=$max_comments}}
 	{{include file="field_checkbox.tpl" field=$proxy_disabled}}
-	{{include file="field_checkbox.tpl" field=$old_pager}}
 	<div class="submit"><input type="submit" name="page_site" value="{{$submit|escape:'html'}}" /></div>
 
 	<h3>{{$worker_title}}</h3>

view/templates/paginate.tpl

@@ -2,7 +2,7 @@
 	{{if $pager}}
 	{{if $pager.prev}}<span class="pager_prev {{$pager.prev.class}}"><a href="{{$pager.prev.url}}">{{$pager.prev.text}}</a></span>{{/if}}
 
-	{{if $pager.first}}<span class="pager_first $pager.first.class"><a href="{{$pager.first.url}}">{{$pager.first.text}}</a></span>{{/if}}
+	{{if $pager.first}}<span class="pager_first {{$pager.first.class}}"><a href="{{$pager.first.url}}">{{$pager.first.text}}</a></span>{{/if}}
 
 	{{foreach $pager.pages as $p}}<span class="pager_{{$p.class}}"><a href="{{$p.url}}">{{$p.text}}</a></span>{{/foreach}}
 

view/theme/duepuntozero/style.css

@@ -1552,6 +1552,9 @@ blockquote.shared_content {
   clear:left;
 }
 
+.pager .disabled {
+	display: none;
+}
 
 .pager_first,
 .pager_last,

view/theme/frio/css/style.css

@@ -2508,6 +2508,56 @@ body .tread-wrapper .hovercard:hover .hover-card-content a {
     color: $link_color !important;
 }
 
+/* Pagination improvements */
+.pagination {
+    text-align: center;
+    display: block;
+}
+.pagination > li > a,
+.pagination > li > span {
+    color: $link_color;
+    float: none;
+}
+.pagination>li>a:hover,
+.pagination>li>span:hover {
+    color: $link_hover_color;
+}
+.pagination > .active > a,
+.pagination > .active > a:focus,
+.pagination > .active > a:hover,
+.pagination > .active > span,
+.pagination > .active > span:focus,
+.pagination > .active > span:hover {
+    background-color: $link_color;
+    border-color: $link_color;
+    border-radius: 3px;
+}
+.pagination li.pager_n a {
+    margin-left: 3px;
+    border-radius: 3px;
+}
+.pagination .pager_prev a {
+    margin-left: -5px;
+    margin-right: 4px;
+    border-top-right-radius: 3px;
+    border-bottom-right-radius: 3px;
+}
+.pagination .pager_next a {
+    margin-left: 4px;
+    margin-right: -5px;
+    border-top-left-radius: 3px;
+    border-bottom-left-radius: 3px;
+}
+.pager .next > a,
+.pager .previous > a {
+    float: none;
+    border-radius: 3px;
+}
+.pagination .disabled > a,
+.pager .disabled > a {
+    display: none;
+}
+
 /*
  * some temporary workarounds until this will solved
  * elsewhere (e.g. new templates)

view/theme/frio/js/textedit.js

@@ -162,21 +162,29 @@ function qCommentInsert(obj,id) {
 
 function confirmDelete() { return confirm(aStr.delitem); }
 
-function dropItem(url, object) {
+/**
+ * Hide and removes an item element from the DOM after the deletion url is
+ * successful, restore it else.
+ *
+ * @param {string} url The item removal URL
+ * @param {string} elementId The DOM id of the item element
+ * @returns {undefined}
+ */
+function dropItem(url, elementId) {
 	var confirm = confirmDelete();
 
-	//if the first character of the object is #, remove it because
+	if (confirm) {
-	// we use getElementById which don't need the #
-	// getElementByID selects elements even if there are special characters
-	// in the ID (like %) which won't work with jQuery
-	/// @todo ceck if we can solve this in the template
-	object = object.indexOf('#') == 0 ? object.substring(1) : object;
-
-	if(confirm) {
 		$('body').css('cursor', 'wait');
-		$(document.getElementById(object)).fadeTo('fast', 0.33, function () {
+
-			$.get(url).done(function() {
+		var $el = $(document.getElementById(elementId));
-				$(document.getElementById(object)).remove();
+
+		$el.fadeTo('fast', 0.33, function () {
+			$.get(url).then(function() {
+				$el.remove();
+			}).error(function() {
+				// @todo Show related error message
+				$el.show();
+			}).always(function() {
 				$('body').css('cursor', 'auto');
 			});
 		});

view/theme/frio/js/theme.js

@@ -573,31 +573,38 @@ String.prototype.rtrim = function() {
 	return trimmed;
 };
 
-// Scroll to a specific item and highlight it
+/**
-// Note: jquery.color.js is needed
+ * Scroll the screen to the item element whose id is provided, then highlights it
-function scrollToItem(itemID) {
+ *
-	if( typeof itemID === "undefined")
+ * Note: jquery.color.js is required
+ *
+ * @param {string} elementId The item element id
+ * @returns {undefined}
+ */
+function scrollToItem(elementId) {
+	if (typeof elementId === "undefined") {
 		return;
+	}
 
-	var elm = $('#'+itemID);
+	var $el = $(document.getElementById(elementId));
 	// Test if the Item exists
-	if(!elm.length)
+	if (!$el.length) {
 		return;
+	}
 
 	// Define the colors which are used for highlighting
 	var colWhite = {backgroundColor:'#F5F5F5'};
 	var colShiny = {backgroundColor:'#FFF176'};
 
-	// Get the Item Position (we need to substract 100 to match
+	// Get the Item Position (we need to substract 100 to match correct position
-	// correct position
+	var itemPos = $el.offset().top - 100;
-	var itemPos = $(elm).offset().top - 100;
 
 	// Scroll to the DIV with the ID (GUID)
 	$('html, body').animate({
 		scrollTop: itemPos
 	}, 400, function() {
 		// Highlight post/commenent with ID  (GUID)
-		$(elm).animate(colWhite, 1000).animate(colShiny).animate(colWhite, 600);
+		$el.animate(colWhite, 1000).animate(colShiny).animate(colWhite, 600);
 	});
 }
 

view/theme/frio/php/Colors.php

@@ -1,292 +0,0 @@
-<?php
-
-class colors {
-
-/* Convert hexdec color string to rgb(a) string */
- 
-	function hex2rgba($color, $opacity = false) {
-
-		$default = 'rgb(0,0,0)';
-
-		//Return default if no color provided
-		if(empty($color))
-		  return $default; 
-
-		//Sanitize $color if "#" is provided 
-		if ($color[0] == '#' ) {
-			$color = substr( $color, 1 );
-		}
-
-		//Check if color has 6 or 3 characters and get values
-		if (strlen($color) == 6) {
-			$hex = array( $color[0] . $color[1], $color[2] . $color[3], $color[4] . $color[5] );
-		} elseif ( strlen( $color ) == 3 ) {
-			$hex = array( $color[0] . $color[0], $color[1] . $color[1], $color[2] . $color[2] );
-		} else {
-			return $default;
-		}
-
-		//Convert hexadec to rgb
-		$rgb =  array_map('hexdec', $hex);
-
-		//Check if opacity is set(rgba or rgb)
-		if($opacity){
-			if(abs($opacity) > 1)
-				$opacity = 1.0;
-			$output = 'rgba('.implode(",",$rgb).','.$opacity.')';
-		} else {
-			$output = 'rgb('.implode(",",$rgb).')';
-		}
-
-		//Return rgb(a) color string
-		return $output;
-	}
-
-	function hex2rgb( $colour ) {
-		if ( $colour[0] == '#' ) {
-			$colour = substr( $colour, 1 );
-		}
-		if ( strlen( $colour ) == 6 ) {
-			list( $r, $g, $b ) = array( $colour[0] . $colour[1], $colour[2] . $colour[3], $colour[4] . $colour[5] );
-		} elseif ( strlen( $colour ) == 3 ) {
-			list( $r, $g, $b ) = array( $colour[0] . $colour[0], $colour[1] . $colour[1], $colour[2] . $colour[2] );
-		} else {
-			return false;
-		}
-		$r = hexdec( $r );
-		$g = hexdec( $g );
-		$b = hexdec( $b );
-		return array( 'red' => $r, 'green' => $g, 'blue' => $b );
-	}
-
-
-	function rgbToHsl( $r, $g, $b ) {
-		$oldR = $r;
-		$oldG = $g;
-		$oldB = $b;
-		$r /= 255;
-		$g /= 255;
-		$b /= 255;
-		$max = max( $r, $g, $b );
-		$min = min( $r, $g, $b );
-		$h;
-		$s;
-		$l = ( $max + $min ) / 2;
-		$d = $max - $min;
-
-		if( $d == 0 ){
-			$h = $s = 0; // achromatic
-		} else {
-			$s = $d / ( 1 - abs( 2 * $l - 1 ) );
-			switch( $max ){
-				case $r:
-					$h = 60 * fmod( ( ( $g - $b ) / $d ), 6 ); 
-					if ($b > $g) {
-						$h += 360;
-					}
-					break;
-				case $g: 
-					$h = 60 * ( ( $b - $r ) / $d + 2 ); 
-					break;
-				case $b: 
-					$h = 60 * ( ( $r - $g ) / $d + 4 ); 
-					break;
-			}
-		}
-
-		return array( round( $h, 2 ), round( $s, 2 ), round( $l, 2 ) );
-	}
-	function hslToRgb( $h, $s, $l ){
-		$r = ""; 
-		$g = ""; 
-		$b = "";
-
-		$c = ( 1 - abs( 2 * $l - 1 ) ) * $s;
-		$x = $c * ( 1 - abs( fmod( ( $h / 60 ), 2 ) - 1 ) );
-		$m = $l - ( $c / 2 );
-		if ( $h < 60 ) {
-			$r = $c;
-			$g = $x;
-			$b = 0;
-		} else if ( $h < 120 ) {
-			$r = $x;
-			$g = $c;
-			$b = 0;
-		} else if ( $h < 180 ) {
-			$r = 0;
-			$g = $c;
-			$b = $x;
-		} else if ( $h < 240 ) {
-			$r = 0;
-			$g = $x;
-			$b = $c;
-		} else if ( $h < 300 ) {
-			$r = $x;
-			$g = 0;
-			$b = $c;
-		} else {
-			$r = $c;
-			$g = 0;
-			$b = $x;
-		}
-
-		$r = ( $r + $m ) * 255;
-		$g = ( $g + $m ) * 255;
-		$b = ( $b + $m  ) * 255;
-
-		return array( floor( $r ), floor( $g ), floor( $b ) );
-	}
-
-	/*
-	 * Som more example code - this needs to be deletet if we don't need it in
-	 * the future
-	 */
-
-	  function HTMLToRGB($htmlCode)
-	  {
-	    if($htmlCode[0] == '#')
-	      $htmlCode = substr($htmlCode, 1);
-
-	    if (strlen($htmlCode) == 3)
-	    {
-	      $htmlCode = $htmlCode[0] . $htmlCode[0] . $htmlCode[1] . $htmlCode[1] . $htmlCode[2] . $htmlCode[2];
-	    }
-
-	    $r = hexdec($htmlCode[0] . $htmlCode[1]);
-	    $g = hexdec($htmlCode[2] . $htmlCode[3]);
-	    $b = hexdec($htmlCode[4] . $htmlCode[5]);
-
-	    return $b + ($g << 0x8) + ($r << 0x10);
-	  }
-
-	  function RGBToHTML($RGB)
-	  {
-	    $r = 0xFF & ($RGB >> 0x10);
-	    $g = 0xFF & ($RGB >> 0x8);
-	    $b = 0xFF & $RGB;
-
-	    $r = dechex($r);
-	    $g = dechex($g);
-	    $b = dechex($b);
-
-	    return "#" . str_pad($r, 2, "0", STR_PAD_LEFT) . str_pad($g, 2, "0", STR_PAD_LEFT) . str_pad($b, 2, "0", STR_PAD_LEFT);
-	  }
-
-	  function ChangeLuminosity($RGB, $LuminosityPercent)
-	  {
-	    $HSL = RGBToHSL($RGB);
-	    $NewHSL = (int)(((float)$LuminosityPercent / 100) * 255) + (0xFFFF00 & $HSL);
-	    return HSLToRGB($NewHSL);
-	  }
-
-	  function RGBToHSL($RGB)
-	  {
-	    $r = 0xFF & ($RGB >> 0x10);
-	    $g = 0xFF & ($RGB >> 0x8);
-	    $b = 0xFF & $RGB;
-
-	    $r = ((float)$r) / 255.0;
-	    $g = ((float)$g) / 255.0;
-	    $b = ((float)$b) / 255.0;
-
-	    $maxC = max($r, $g, $b);
-	    $minC = min($r, $g, $b);
-
-	    $l = ($maxC + $minC) / 2.0;
-
-	    if($maxC == $minC)
-	    {
-	      $s = 0;
-	      $h = 0;
-	    }
-	    else
-	    {
-	      if($l < .5)
-	      {
-		$s = ($maxC - $minC) / ($maxC + $minC);
-	      }
-	      else
-	      {
-		$s = ($maxC - $minC) / (2.0 - $maxC - $minC);
-	      }
-	      if($r == $maxC)
-		$h = ($g - $b) / ($maxC - $minC);
-	      if($g == $maxC)
-		$h = 2.0 + ($b - $r) / ($maxC - $minC);
-	      if($b == $maxC)
-		$h = 4.0 + ($r - $g) / ($maxC - $minC);
-
-	      $h = $h / 6.0; 
-	    }
-
-	    $h = (int)round(255.0 * $h);
-	    $s = (int)round(255.0 * $s);
-	    $l = (int)round(255.0 * $l);
-
-	    $HSL = $l + ($s << 0x8) + ($h << 0x10);
-	    return $HSL;
-	  }
-
-	  function HSLToRGB($HSL)
-	  {
-	    $h = 0xFF & ($HSL >> 0x10);
-	    $s = 0xFF & ($HSL >> 0x8);
-	    $l = 0xFF & $HSL;
-
-	    $h = ((float)$h) / 255.0;
-	    $s = ((float)$s) / 255.0;
-	    $l = ((float)$l) / 255.0;
-
-	    if($s == 0)
-	    {
-	      $r = $l;
-	      $g = $l;
-	      $b = $l;
-	    }
-	    else
-	    {
-	      if($l < .5)
-	      {
-		$t2 = $l * (1.0 + $s);
-	      }
-	      else
-	      {
-		$t2 = ($l + $s) - ($l * $s);
-	      }
-	      $t1 = 2.0 * $l - $t2;
-
-	      $rt3 = $h + 1.0/3.0;
-	      $gt3 = $h;
-	      $bt3 = $h - 1.0/3.0;
-
-	      if($rt3 < 0) $rt3 += 1.0;
-	      if($rt3 > 1) $rt3 -= 1.0;
-	      if($gt3 < 0) $gt3 += 1.0;
-	      if($gt3 > 1) $gt3 -= 1.0;
-	      if($bt3 < 0) $bt3 += 1.0;
-	      if($bt3 > 1) $bt3 -= 1.0;
-
-	      if(6.0 * $rt3 < 1) $r = $t1 + ($t2 - $t1) * 6.0 * $rt3;
-	      elseif(2.0 * $rt3 < 1) $r = $t2;
-	      elseif(3.0 * $rt3 < 2) $r = $t1 + ($t2 - $t1) * ((2.0/3.0) - $rt3) * 6.0;
-	      else $r = $t1;
-
-	      if(6.0 * $gt3 < 1) $g = $t1 + ($t2 - $t1) * 6.0 * $gt3;
-	      elseif(2.0 * $gt3 < 1) $g = $t2;
-	      elseif(3.0 * $gt3 < 2) $g = $t1 + ($t2 - $t1) * ((2.0/3.0) - $gt3) * 6.0;
-	      else $g = $t1;
-
-	      if(6.0 * $bt3 < 1) $b = $t1 + ($t2 - $t1) * 6.0 * $bt3;
-	      elseif(2.0 * $bt3 < 1) $b = $t2;
-	      elseif(3.0 * $bt3 < 2) $b = $t1 + ($t2 - $t1) * ((2.0/3.0) - $bt3) * 6.0;
-	      else $b = $t1;
-	    }
-
-	    $r = (int)round(255.0 * $r);
-	    $g = (int)round(255.0 * $g);
-	    $b = (int)round(255.0 * $b);
-
-	    $RGB = $b + ($g << 0x8) + ($r << 0x10);
-	    return $RGB;
-	  }
-}

view/theme/frio/templates/paginate.tpl

@@ -0,0 +1,16 @@
+
+{{* Pager template, uses output of paginate_data() in include/text.php *}}
+
+{{if $pager}}
+<ul class="{{$pager.class}} pagination-sm">
+	{{if $pager.first}}<li class="pager_first {{$pager.first.class}}"><a href="{{$pager.first.url}}" title="{{$pager.first.text}}">&#8739;&lt;</a></li>{{/if}}
+
+	{{if $pager.prev}}<li class="pager_prev {{$pager.prev.class}}"><a href="{{$pager.prev.url}}" title="{{$pager.prev.text}}">&lt;</a></li>{{/if}}
+
+	{{foreach $pager.pages as $p}}<li class="pager_{{$p.class}} hidden-xs hidden-sm"><a href="{{$p.url}}">{{$p.text}}</a></li>{{/foreach}}
+
+	{{if $pager.next}}<li class="pager_next {{$pager.next.class}}"><a href="{{$pager.next.url}}" title="{{$pager.next.text}}">&gt;</a></li>{{/if}}
+
+	{{if $pager.last}}<li class="pager_last {{$pager.last.class}}"><a href="{{$pager.last.url}}" title="{{$pager.last.text}}">&gt;&#8739;</a></li>{{/if}}
+</ul>
+{{/if}}

view/theme/frio/templates/search_item.tpl

@@ -7,7 +7,7 @@
 <!-- ./TODO => Unknow block -->
 
 
-<div class="panel">
+<div class="panel" id="item-{{$item.guid}}">
 	<div class="wall-item-container panel-body{{$item.indent}} {{$item.shiny}} {{$item.previewing}}" >
 		<div class="media">
 			{{* Put additional actions in a top-right dropdown menu *}}
@@ -54,7 +54,7 @@
 						{{if $item.drop.dropping}}
 						<li role="separator" class="divider"></li>
 						<li role="menuitem">
-							<a class="navicon delete" onclick="dropItem('item/drop/{{$item.id}}', '#item-{{$item.guid}}'); return false;" title="{{$item.drop.delete}}"><i class="fa fa-trash"></i> {{$item.drop.delete}}</a>
+							<a class="navicon delete" onclick="dropItem('item/drop/{{$item.id}}', 'item-{{$item.guid}}'); return false;" title="{{$item.drop.delete}}"><i class="fa fa-trash"></i> {{$item.drop.delete}}</a>
 						</li>
 						{{/if}}
 					</ul>

view/theme/frio/templates/wall_thread.tpl

@@ -68,9 +68,9 @@ as the value of $top_child_total (this is done at the end of this file)
 
 {{* Use a different div container in dependence max thread-level = 7 *}}
 {{if $item.thread_level<7}}
-<div class="wall-item-container {{$item.indent}} {{$item.shiny}} {{$item.network}} thread_level_{{$item.thread_level}} {{if $item.thread_level==1}}panel-body h-entry{{else}}u-comment h-cite{{/if}}" id="item-{{$item.guid|regex_replace:'/%.*/':''}}"><!-- wall-item-container -->
+<div class="wall-item-container {{$item.indent}} {{$item.shiny}} {{$item.network}} thread_level_{{$item.thread_level}} {{if $item.thread_level==1}}panel-body h-entry{{else}}u-comment h-cite{{/if}}" id="item-{{$item.guid}}"><!-- wall-item-container -->
 {{else}}
-<div class="wall-item-container {{$item.indent}} {{$item.shiny}} {{$item.network}} thread_level_7 u-comment h-cite" id="item-{{$item.guid|regex_replace:'/%.*/':''}}">
+<div class="wall-item-container {{$item.indent}} {{$item.shiny}} {{$item.network}} thread_level_7 u-comment h-cite" id="item-{{$item.guid}}">
  {{/if}}
 	<div class="media">
 		{{* Put addional actions in a top-right dropdown menu *}}
@@ -129,7 +129,7 @@ as the value of $top_child_total (this is done at the end of this file)
 
 					{{if $item.drop.dropping}}
 					<li role="menuitem">
-						<a class="navicon delete" onclick="dropItem('item/drop/{{$item.id}}', '#item-{{$item.guid}}'); return false;" title="{{$item.drop.delete}}"><i class="fa fa-trash"></i> {{$item.drop.delete}}</a>
+						<a class="navicon delete" onclick="dropItem('item/drop/{{$item.id}}', 'item-{{$item.guid}}'); return false;" title="{{$item.drop.delete}}"><i class="fa fa-trash"></i> {{$item.drop.delete}}</a>
 					</li>
 					{{/if}}
 				</ul>

view/theme/frost-mobile/style.css

@@ -1909,6 +1909,9 @@ input#profile-jot-email {
 	-webkit-border-radius: 10px;
 }
 
+.pager .disabled {
+	display: none;
+}
 
 .pager_first,
 .pager_last,

view/theme/frost/style.css

@@ -1866,6 +1866,9 @@ input#dfrn-url {
 	-webkit-border-radius: 10px;
 }
 
+.pager .disabled {
+	display: none;
+}
 
 .pager_first,
 .pager_last,

view/theme/quattro/green/style.css

@@ -2481,6 +2481,9 @@ footer {
   margin-top: 25px;
   clear: both;
 }
+.pager .disabled {
+	display: none;
+}
 /**
  * ADMIN
  */

view/theme/quattro/lilac/style.css

@@ -2481,6 +2481,9 @@ footer {
   margin-top: 25px;
   clear: both;
 }
+.pager .disabled {
+	display: none;
+}
 /**
  * ADMIN
  */

view/theme/quattro/quattro.less

@@ -1675,6 +1675,9 @@ footer { height: 100px; display: table-row; }
         margin-top: 25px;
         clear: both;
 }
+.pager .disabled {
+	display: none;
+}
 
 /**
  * ADMIN

view/theme/smoothly/style.css

@@ -396,6 +396,10 @@ ul.menu-popup li a:hover {
 	margin: 4px;
 }
 
+.pager .disabled {
+	display: none;
+}
+
 .pager_current {
 	background-color: #1873a2;
 	color: #ffffff;

view/theme/vier/style.css

@@ -247,6 +247,10 @@ div.pager {
   float: left;
 }
 
+.pager .disabled {
+	display: none;
+}
+
 .hide-comments-outer {
   margin-left: 80px;
   margin-bottom: 5px;