Browse Source

Class file relocations

Issue #3878
tags/3.6
Adam Magness 2 years ago
parent
commit
9e99066fd7
100 changed files with 661 additions and 8457 deletions
  1. +4
    -3
      boot.php
  2. +2
    -2
      doc/Developer-How-To-Move-Classes-to-src.md
  3. +4
    -4
      doc/autoloader.md
  4. +24
    -23
      include/Contact.php
  5. +2
    -1
      include/ForumManager.php
  6. +0
    -866
      include/NotificationsManager.php
  7. +7
    -6
      include/Photo.php
  8. +8
    -7
      include/acl_selectors.php
  9. +44
    -43
      include/api.php
  10. +4
    -3
      include/auth.php
  11. +2
    -1
      include/auth_ejabberd.php
  12. +2
    -1
      include/cache.php
  13. +3
    -2
      include/contact_selectors.php
  14. +3
    -2
      include/contact_widgets.php
  15. +6
    -5
      include/conversation.php
  16. +3
    -2
      include/cron.php
  17. +6
    -5
      include/cronjobs.php
  18. +3
    -2
      include/datetime.php
  19. +3
    -3
      include/dba.php
  20. +0
    -112
      include/dbm.php
  21. +18
    -17
      include/dbstructure.php
  22. +15
    -14
      include/delivery.php
  23. +0
    -2966
      include/dfrn.php
  24. +0
    -3943
      include/diaspora.php
  25. +2
    -1
      include/directory.php
  26. +3
    -2
      include/discover_poco.php
  27. +6
    -5
      include/enotify.php
  28. +11
    -10
      include/event.php
  29. +2
    -1
      include/expire.php
  30. +4
    -4
      include/fcontact.php
  31. +2
    -1
      include/feed.php
  32. +5
    -4
      include/follow.php
  33. +3
    -2
      include/gprobe.php
  34. +11
    -10
      include/group.php
  35. +9
    -8
      include/identity.php
  36. +43
    -42
      include/items.php
  37. +6
    -5
      include/like.php
  38. +5
    -4
      include/message.php
  39. +2
    -1
      include/nav.php
  40. +10
    -9
      include/notifier.php
  41. +8
    -7
      include/oauth.php
  42. +2
    -1
      include/oembed.php
  43. +7
    -6
      include/onepoll.php
  44. +16
    -15
      include/ostatus.php
  45. +3
    -2
      include/plugin.php
  46. +3
    -2
      include/post_update.php
  47. +2
    -1
      include/pubsubpublish.php
  48. +8
    -7
      include/queue.php
  49. +4
    -3
      include/queue_fn.php
  50. +3
    -2
      include/redir.php
  51. +9
    -8
      include/security.php
  52. +2
    -1
      include/session.php
  53. +30
    -29
      include/socgraph.php
  54. +10
    -9
      include/text.php
  55. +15
    -14
      include/threads.php
  56. +3
    -2
      include/uimport.php
  57. +2
    -1
      include/update_gcontact.php
  58. +9
    -8
      include/user.php
  59. +2
    -1
      index.php
  60. +3
    -2
      mod/admin.php
  61. +3
    -2
      mod/allfriends.php
  62. +2
    -1
      mod/api.php
  63. +3
    -2
      mod/attach.php
  64. +4
    -3
      mod/cal.php
  65. +7
    -6
      mod/common.php
  66. +2
    -1
      mod/community.php
  67. +3
    -2
      mod/contactgroup.php
  68. +7
    -6
      mod/contacts.php
  69. +4
    -3
      mod/crepair.php
  70. +8
    -7
      mod/delegate.php
  71. +14
    -13
      mod/dfrn_confirm.php
  72. +7
    -6
      mod/dfrn_notify.php
  73. +15
    -14
      mod/dfrn_poll.php
  74. +15
    -14
      mod/dfrn_request.php
  75. +3
    -2
      mod/directory.php
  76. +1
    -1
      mod/dirfind.php
  77. +19
    -18
      mod/display.php
  78. +3
    -2
      mod/editpost.php
  79. +5
    -4
      mod/events.php
  80. +3
    -2
      mod/friendica.php
  81. +5
    -4
      mod/fsuggest.php
  82. +6
    -5
      mod/group.php
  83. +2
    -1
      mod/ignored.php
  84. +2
    -1
      mod/install.php
  85. +28
    -27
      mod/item.php
  86. +6
    -5
      mod/lockview.php
  87. +4
    -3
      mod/lostpass.php
  88. +7
    -6
      mod/manage.php
  89. +2
    -1
      mod/match.php
  90. +8
    -7
      mod/message.php
  91. +2
    -1
      mod/modexp.php
  92. +2
    -1
      mod/mood.php
  93. +3
    -2
      mod/msearch.php
  94. +10
    -9
      mod/network.php
  95. +3
    -2
      mod/nogroup.php
  96. +5
    -4
      mod/noscrape.php
  97. +4
    -3
      mod/notes.php
  98. +2
    -1
      mod/notice.php
  99. +2
    -1
      mod/notifications.php
  100. +2
    -1
      mod/notify.php

+ 4
- 3
boot.php View File

@@ -24,6 +24,7 @@ use Friendica\App;
use Friendica\Core\System;
use Friendica\Core\Config;
use Friendica\Core\PConfig;
use Friendica\Database\DBM;
use Friendica\Util\Lock;

require_once 'include/network.php';
@@ -768,7 +769,7 @@ function run_update_function($x) {
function check_plugins(App $a) {

$r = q("SELECT * FROM `addon` WHERE `installed` = 1");
if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$installed = $r;
} else {
$installed = array();
@@ -1054,7 +1055,7 @@ function current_theme() {
$r = q("select theme from user where uid = %d limit 1",
intval($a->profile_uid)
);
if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$page_theme = $r[0]['theme'];
}
}
@@ -1176,7 +1177,7 @@ function feed_birthday($uid, $tz) {
intval($uid)
);

if (dbm::is_result($p)) {
if (DBM::is_result($p)) {
$tmp_dob = substr($p[0]['dob'], 5);
if (intval($tmp_dob)) {
$y = datetime_convert($tz, $tz, 'now', 'Y');


+ 2
- 2
doc/Developer-How-To-Move-Classes-to-src.md View File

@@ -73,7 +73,7 @@ If there are only a handful of references to a single non-namespaced class, just
````php
namespace Friendica\Core;
...
if (\dbm::is_result($r)) {
if (\DBM::is_result($r)) {
...
}
````
@@ -82,7 +82,7 @@ namespace Friendica\Core;

use \dbm;

if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
...
}
````


+ 4
- 4
doc/autoloader.md View File

@@ -104,7 +104,7 @@ class Dfrn {

mail_post($a){
...
Friendica\dfrn::mail($item, $owner);
Friendica\DFRN::mail($item, $owner);
...
}
```
@@ -125,12 +125,12 @@ switch($contact['network']) {
case NETWORK_DFRN:
if ($mail) {
$item['body'] = ...
$atom = Dfrn::mail($item, $owner);
$atom = DFRN::mail($item, $owner);
} elseif ($fsuggest) {
$atom = Dfrn::fsuggest($item, $owner);
$atom = DFRN::fsuggest($item, $owner);
q("DELETE FROM `fsuggest` WHERE `id` = %d LIMIT 1", intval($item['id']));
} elseif ($relocate)
$atom = Dfrn::relocate($owner, $uid);
$atom = DFRN::relocate($owner, $uid);
[...]
```



+ 24
- 23
include/Contact.php View File

@@ -4,9 +4,10 @@ use Friendica\App;
use Friendica\Core\PConfig;
use Friendica\Core\System;
use Friendica\Core\Worker;
use Friendica\Database\DBM;
use Friendica\Network\Probe;
use Friendica\Protocol\Diaspora;
use Friendica\Protocol\Dfrn;
use Friendica\Protocol\DFRN;

// Included here for completeness, but this is a very dangerous operation.
// It is the caller's responsibility to confirm the requestor's intent and
@@ -49,7 +50,7 @@ function contact_remove($id) {
$r = q("SELECT `uid` FROM `contact` WHERE `id` = %d AND NOT `self` LIMIT 1",
intval($id)
);
if (!dbm::is_result($r) || !intval($r[0]['uid'])) {
if (!DBM::is_result($r) || !intval($r[0]['uid'])) {
return;
}

@@ -94,7 +95,7 @@ function terminate_friendship($user,$self,$contact) {
} elseif ($contact['network'] === NETWORK_DIASPORA) {
Diaspora::send_unshare($user,$contact);
} elseif ($contact['network'] === NETWORK_DFRN) {
Dfrn::deliver($user,$contact,'placeholder', 1);
DFRN::deliver($user,$contact,'placeholder', 1);
}

}
@@ -163,7 +164,7 @@ function unmark_for_death($contact) {
);

// We don't need to update, we never marked this contact as dead
if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
return;
}

@@ -213,7 +214,7 @@ function get_contact_details_by_url($url, $uid = -1, $default = array()) {
$r = dba::inArray($s);

// Fetch contact data from the contact table for the given user, checking with the alias
if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
$s = dba::p("SELECT `id`, `id` AS `cid`, 0 AS `gid`, 0 AS `zid`, `uid`, `url`, `nurl`, `alias`, `network`, `name`, `nick`, `addr`, `location`, `about`, `xmpp`,
`keywords`, `gender`, `photo`, `thumb`, `micro`, `forum`, `prv`, (`forum` | `prv`) AS `community`, `contact-type`, `bd` AS `birthday`, `self`
FROM `contact` WHERE `alias` IN (?, ?, ?) AND `uid` = ?",
@@ -222,7 +223,7 @@ function get_contact_details_by_url($url, $uid = -1, $default = array()) {
}

// Fetch the data from the contact table with "uid=0" (which is filled automatically)
if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
$s = dba::p("SELECT `id`, 0 AS `cid`, `id` AS `zid`, 0 AS `gid`, `uid`, `url`, `nurl`, `alias`, `network`, `name`, `nick`, `addr`, `location`, `about`, `xmpp`,
`keywords`, `gender`, `photo`, `thumb`, `micro`, `forum`, `prv`, (`forum` | `prv`) AS `community`, `contact-type`, `bd` AS `birthday`, 0 AS `self`
FROM `contact` WHERE `nurl` = ? AND `uid` = 0",
@@ -231,7 +232,7 @@ function get_contact_details_by_url($url, $uid = -1, $default = array()) {
}

// Fetch the data from the contact table with "uid=0" (which is filled automatically) - checked with the alias
if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
$s = dba::p("SELECT `id`, 0 AS `cid`, `id` AS `zid`, 0 AS `gid`, `uid`, `url`, `nurl`, `alias`, `network`, `name`, `nick`, `addr`, `location`, `about`, `xmpp`,
`keywords`, `gender`, `photo`, `thumb`, `micro`, `forum`, `prv`, (`forum` | `prv`) AS `community`, `contact-type`, `bd` AS `birthday`, 0 AS `self`
FROM `contact` WHERE `alias` IN (?, ?, ?) AND `uid` = 0",
@@ -240,7 +241,7 @@ function get_contact_details_by_url($url, $uid = -1, $default = array()) {
}

// Fetch the data from the gcontact table
if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
$s = dba::p("SELECT 0 AS `id`, 0 AS `cid`, `id` AS `gid`, 0 AS `zid`, 0 AS `uid`, `url`, `nurl`, `alias`, `network`, `name`, `nick`, `addr`, `location`, `about`, '' AS `xmpp`,
`keywords`, `gender`, `photo`, `photo` AS `thumb`, `photo` AS `micro`, `community` AS `forum`, 0 AS `prv`, `community`, `contact-type`, `birthday`, 0 AS `self`
FROM `gcontact` WHERE `nurl` = ?",
@@ -248,7 +249,7 @@ function get_contact_details_by_url($url, $uid = -1, $default = array()) {
$r = dba::inArray($s);
}

if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
// If there is more than one entry we filter out the connector networks
if (count($r) > 1) {
foreach ($r AS $id => $result) {
@@ -351,20 +352,20 @@ function get_contact_details_by_addr($addr, $uid = -1) {
dbesc($addr), intval($uid));

// Fetch the data from the contact table with "uid=0" (which is filled automatically)
if (!dbm::is_result($r))
if (!DBM::is_result($r))
$r = q("SELECT `id`, 0 AS `cid`, `id` AS `zid`, 0 AS `gid`, `uid`, `url`, `nurl`, `alias`, `network`, `name`, `nick`, `addr`, `location`, `about`, `xmpp`,
`keywords`, `gender`, `photo`, `thumb`, `micro`, `forum`, `prv`, (`forum` | `prv`) AS `community`, `contact-type`, `bd` AS `birthday`, 0 AS `self`
FROM `contact` WHERE `addr` = '%s' AND `uid` = 0",
dbesc($addr));

// Fetch the data from the gcontact table
if (!dbm::is_result($r))
if (!DBM::is_result($r))
$r = q("SELECT 0 AS `id`, 0 AS `cid`, `id` AS `gid`, 0 AS `zid`, 0 AS `uid`, `url`, `nurl`, `alias`, `network`, `name`, `nick`, `addr`, `location`, `about`, '' AS `xmpp`,
`keywords`, `gender`, `photo`, `photo` AS `thumb`, `photo` AS `micro`, `community` AS `forum`, 0 AS `prv`, `community`, `contact-type`, `birthday`, 0 AS `self`
FROM `gcontact` WHERE `addr` = '%s'",
dbesc($addr));

if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
$data = Probe::uri($addr);

$profile = get_contact_details_by_url($data['url'], $uid);
@@ -486,7 +487,7 @@ function random_profile() {
ORDER BY rand() LIMIT 1",
dbesc(NETWORK_DFRN));

if (dbm::is_result($r))
if (DBM::is_result($r))
return dirname($r[0]['url']);
return '';
}
@@ -553,12 +554,12 @@ function get_contact($url, $uid = 0, $no_update = false) {
$contact = dba::select('contact', array('id', 'avatar-date'), array('nurl' => normalise_link($url), 'uid' => $uid), array('limit' => 1));

// Then the addr (nick@server.tld)
if (!dbm::is_result($contact)) {
if (!DBM::is_result($contact)) {
$contact = dba::select('contact', array('id', 'avatar-date'), array('addr' => $url, 'uid' => $uid), array('limit' => 1));
}

// Then the alias (which could be anything)
if (!dbm::is_result($contact)) {
if (!DBM::is_result($contact)) {
// The link could be provided as http although we stored it as https
$ssl_url = str_replace('http://', 'https://', $url);
$r = dba::p("SELECT `id`, `avatar-date` FROM `contact` WHERE `alias` IN (?, ?, ?) AND `uid` = ? LIMIT 1",
@@ -567,7 +568,7 @@ function get_contact($url, $uid = 0, $no_update = false) {
dba::close($r);
}

if (dbm::is_result($contact)) {
if (DBM::is_result($contact)) {
$contact_id = $contact["id"];

// Update the contact every 7 days
@@ -597,7 +598,7 @@ function get_contact($url, $uid = 0, $no_update = false) {
// Get data from the gcontact table
$gcontacts = dba::select('gcontact', array('name', 'nick', 'url', 'photo', 'addr', 'alias', 'network'),
array('nurl' => normalise_link($url)), array('limit' => 1));
if (!dbm::is_result($gcontacts)) {
if (!DBM::is_result($gcontacts)) {
return 0;
}

@@ -626,7 +627,7 @@ function get_contact($url, $uid = 0, $no_update = false) {
$contacts = q("SELECT `id` FROM `contact` WHERE `nurl` = '%s' AND `uid` = %d ORDER BY `id` LIMIT 2",
dbesc(normalise_link($data["url"])),
intval($uid));
if (!dbm::is_result($contacts)) {
if (!DBM::is_result($contacts)) {
return 0;
}

@@ -635,7 +636,7 @@ function get_contact($url, $uid = 0, $no_update = false) {
// Update the newly created contact from data in the gcontact table
$gcontact = dba::select('gcontact', array('location', 'about', 'keywords', 'gender'),
array('nurl' => normalise_link($data["url"])), array('limit' => 1));
if (dbm::is_result($gcontact)) {
if (DBM::is_result($gcontact)) {
// Only use the information when the probing hadn't fetched these values
if ($data['keywords'] != '') {
unset($gcontact['keywords']);
@@ -663,7 +664,7 @@ function get_contact($url, $uid = 0, $no_update = false) {
array('id' => $contact_id), array('limit' => 1));

// This condition should always be true
if (!dbm::is_result($contact)) {
if (!DBM::is_result($contact)) {
return $contact_id;
}

@@ -711,7 +712,7 @@ function blockedContact($cid) {
}

$blocked = dba::select('contact', array('blocked'), array('id' => $cid), array('limit' => 1));
if (!dbm::is_result($blocked)) {
if (!DBM::is_result($blocked)) {
return false;
}
return (bool)$blocked['blocked'];
@@ -730,7 +731,7 @@ function hiddenContact($cid) {
}

$hidden = dba::select('contact', array('hidden'), array('id' => $cid), array('limit' => 1));
if (!dbm::is_result($hidden)) {
if (!DBM::is_result($hidden)) {
return false;
}
return (bool)$hidden['hidden'];
@@ -793,7 +794,7 @@ function posts_from_contact_url(App $a, $contact_url) {
WHERE `contact`.`nurl` = '%s' AND `contact`.`uid` = 0",
dbesc(normalise_link($contact_url)));

if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
return '';
}



+ 2
- 1
include/ForumManager.php View File

@@ -2,6 +2,7 @@

use Friendica\App;
use Friendica\Core\System;
use Friendica\Database\DBM;

/**
* @file include/ForumManager.php
@@ -93,7 +94,7 @@ class ForumManager {
$total = count($contacts);
$visible_forums = 10;

if (dbm::is_result($contacts)) {
if (DBM::is_result($contacts)) {

$id = 0;



+ 0
- 866
include/NotificationsManager.php View File

@@ -1,866 +0,0 @@
<?php
/**
* @file include/NotificationsManager.php
* @brief Methods for read and write notifications from/to database
* or for formatting notifications
*/

use Friendica\Core\Pconfig;
use Friendica\Core\System;

require_once 'include/html2plain.php';
require_once 'include/datetime.php';
require_once 'include/bbcode.php';
require_once 'include/Contact.php';

/**
* @brief Methods for read and write notifications from/to database
* or for formatting notifications
*/
class NotificationsManager {
private $a;

public function __construct() {
$this->a = get_app();
}

/**
* @brief set some extra note properties
*
* @param array $notes array of note arrays from db
* @return array Copy of input array with added properties
*
* Set some extra properties to note array from db:
* - timestamp as int in default TZ
* - date_rel : relative date string
* - msg_html: message as html string
* - msg_plain: message as plain text string
*/
private function _set_extra($notes) {
$rets = array();
foreach($notes as $n) {
$local_time = datetime_convert('UTC',date_default_timezone_get(),$n['date']);
$n['timestamp'] = strtotime($local_time);
$n['date_rel'] = relative_date($n['date']);
$n['msg_html'] = bbcode($n['msg'], false, false, false, false);
$n['msg_plain'] = explode("\n",trim(html2plain($n['msg_html'], 0)))[0];

$rets[] = $n;
}
return $rets;
}


/**
* @brief Get all notifications for local_user()
*
* @param array $filter optional Array "column name"=>value: filter query by columns values
* @param string $order optional Space separated list of column to sort by. prepend name with "+" to sort ASC, "-" to sort DESC. Default to "-date"
* @param string $limit optional Query limits
*
* @return array of results or false on errors
*/
public function getAll($filter = array(), $order="-date", $limit="") {
$filter_str = array();
$filter_sql = "";
foreach($filter as $column => $value) {
$filter_str[] = sprintf("`%s` = '%s'", $column, dbesc($value));
}
if (count($filter_str)>0) {
$filter_sql = "AND ".implode(" AND ", $filter_str);
}

$aOrder = explode(" ", $order);
$asOrder = array();
foreach($aOrder as $o) {
$dir = "asc";
if ($o[0]==="-") {
$dir = "desc";
$o = substr($o,1);
}
if ($o[0]==="+") {
$dir = "asc";
$o = substr($o,1);
}
$asOrder[] = "$o $dir";
}
$order_sql = implode(", ", $asOrder);

if($limit!="")
$limit = " LIMIT ".$limit;

$r = q("SELECT * FROM `notify` WHERE `uid` = %d $filter_sql ORDER BY $order_sql $limit",
intval(local_user())
);

if (dbm::is_result($r))
return $this->_set_extra($r);

return false;
}

/**
* @brief Get one note for local_user() by $id value
*
* @param int $id
* @return array note values or null if not found
*/
public function getByID($id) {
$r = q("SELECT * FROM `notify` WHERE `id` = %d AND `uid` = %d LIMIT 1",
intval($id),
intval(local_user())
);
if (dbm::is_result($r)) {
return $this->_set_extra($r)[0];
}
return null;
}

/**
* @brief set seen state of $note of local_user()
*
* @param array $note
* @param bool $seen optional true or false, default true
* @return bool true on success, false on errors
*/
public function setSeen($note, $seen = true) {
return q("UPDATE `notify` SET `seen` = %d WHERE ( `link` = '%s' OR ( `parent` != 0 AND `parent` = %d AND `otype` = '%s' )) AND `uid` = %d",
intval($seen),
dbesc($note['link']),
intval($note['parent']),
dbesc($note['otype']),
intval(local_user())
);
}

/**
* @brief set seen state of all notifications of local_user()
*
* @param bool $seen optional true or false. default true
* @return bool true on success, false on error
*/
public function setAllSeen($seen = true) {
return q("UPDATE `notify` SET `seen` = %d WHERE `uid` = %d",
intval($seen),
intval(local_user())
);
}

/**
* @brief List of pages for the Notifications TabBar
*
* @return array with with notifications TabBar data
*/
public function getTabs() {
$tabs = array(
array(
'label' => t('System'),
'url'=>'notifications/system',
'sel'=> (($this->a->argv[1] == 'system') ? 'active' : ''),
'id' => 'system-tab',
'accesskey' => 'y',
),
array(
'label' => t('Network'),
'url'=>'notifications/network',
'sel'=> (($this->a->argv[1] == 'network') ? 'active' : ''),
'id' => 'network-tab',
'accesskey' => 'w',
),
array(
'label' => t('Personal'),
'url'=>'notifications/personal',
'sel'=> (($this->a->argv[1] == 'personal') ? 'active' : ''),
'id' => 'personal-tab',
'accesskey' => 'r',
),
array(
'label' => t('Home'),
'url' => 'notifications/home',
'sel'=> (($this->a->argv[1] == 'home') ? 'active' : ''),
'id' => 'home-tab',
'accesskey' => 'h',
),
array(
'label' => t('Introductions'),
'url' => 'notifications/intros',
'sel'=> (($this->a->argv[1] == 'intros') ? 'active' : ''),
'id' => 'intro-tab',
'accesskey' => 'i',
),
);

return $tabs;
}

/**
* @brief Format the notification query in an usable array
*
* @param array $notifs The array from the db query
* @param string $ident The notifications identifier (e.g. network)
* @return array
* string 'label' => The type of the notification
* string 'link' => URL to the source
* string 'image' => The avatar image
* string 'url' => The profile url of the contact
* string 'text' => The notification text
* string 'when' => The date of the notification
* string 'ago' => T relative date of the notification
* bool 'seen' => Is the notification marked as "seen"
*/
private function formatNotifs($notifs, $ident = "") {

$notif = array();
$arr = array();

if (dbm::is_result($notifs)) {

foreach ($notifs as $it) {
// Because we use different db tables for the notification query
// we have sometimes $it['unseen'] and sometimes $it['seen].
// So we will have to transform $it['unseen']
if (array_key_exists('unseen', $it)) {
$it['seen'] = ($it['unseen'] > 0 ? false : true);
}

// Depending on the identifier of the notification we need to use different defaults
switch ($ident) {
case 'system':
$default_item_label = 'notify';
$default_item_link = System::baseUrl(true).'/notify/view/'. $it['id'];
$default_item_image = proxy_url($it['photo'], false, PROXY_SIZE_MICRO);
$default_item_url = $it['url'];
$default_item_text = strip_tags(bbcode($it['msg']));
$default_item_when = datetime_convert('UTC', date_default_timezone_get(), $it['date'], 'r');
$default_item_ago = relative_date($it['date']);
break;

case 'home':
$default_item_label = 'comment';
$default_item_link = System::baseUrl(true).'/display/'.$it['pguid'];
$default_item_image = proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO);
$default_item_url = $it['author-link'];
$default_item_text = sprintf(t("%s commented on %s's post"), $it['author-name'], $it['pname']);
$default_item_when = datetime_convert('UTC', date_default_timezone_get(), $it['created'], 'r');
$default_item_ago = relative_date($it['created']);
break;

default:
$default_item_label = (($it['id'] == $it['parent']) ? 'post' : 'comment');
$default_item_link = System::baseUrl(true).'/display/'.$it['pguid'];
$default_item_image = proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO);
$default_item_url = $it['author-link'];
$default_item_text = (($it['id'] == $it['parent'])
? sprintf(t("%s created a new post"), $it['author-name'])
: sprintf(t("%s commented on %s's post"), $it['author-name'], $it['pname']));
$default_item_when = datetime_convert('UTC', date_default_timezone_get(), $it['created'], 'r');
$default_item_ago = relative_date($it['created']);

}

// Transform the different types of notification in an usable array
switch ($it['verb']){
case ACTIVITY_LIKE:
$notif = array(
'label' => 'like',
'link' => System::baseUrl(true).'/display/'.$it['pguid'],
'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
'url' => $it['author-link'],
'text' => sprintf(t("%s liked %s's post"), $it['author-name'], $it['pname']),
'when' => $default_item_when,
'ago' => $default_item_ago,
'seen' => $it['seen']
);
break;

case ACTIVITY_DISLIKE:
$notif = array(
'label' => 'dislike',
'link' => System::baseUrl(true).'/display/'.$it['pguid'],
'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
'url' => $it['author-link'],
'text' => sprintf(t("%s disliked %s's post"), $it['author-name'], $it['pname']),
'when' => $default_item_when,
'ago' => $default_item_ago,
'seen' => $it['seen']
);
break;

case ACTIVITY_ATTEND:
$notif = array(
'label' => 'attend',
'link' => System::baseUrl(true).'/display/'.$it['pguid'],
'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
'url' => $it['author-link'],
'text' => sprintf(t("%s is attending %s's event"), $it['author-name'], $it['pname']),
'when' => $default_item_when,
'ago' => $default_item_ago,
'seen' => $it['seen']
);
break;

case ACTIVITY_ATTENDNO:
$notif = array(
'label' => 'attendno',
'link' => System::baseUrl(true).'/display/'.$it['pguid'],
'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
'url' => $it['author-link'],
'text' => sprintf( t("%s is not attending %s's event"), $it['author-name'], $it['pname']),
'when' => $default_item_when,
'ago' => $default_item_ago,
'seen' => $it['seen']
);
break;

case ACTIVITY_ATTENDMAYBE:
$notif = array(
'label' => 'attendmaybe',
'link' => System::baseUrl(true).'/display/'.$it['pguid'],
'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
'url' => $it['author-link'],
'text' => sprintf(t("%s may attend %s's event"), $it['author-name'], $it['pname']),
'when' => $default_item_when,
'ago' => $default_item_ago,
'seen' => $it['seen']
);
break;

case ACTIVITY_FRIEND:
$xmlhead="<"."?xml version='1.0' encoding='UTF-8' ?".">";
$obj = parse_xml_string($xmlhead.$it['object']);
$it['fname'] = $obj->title;

$notif = array(
'label' => 'friend',
'link' => System::baseUrl(true).'/display/'.$it['pguid'],
'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
'url' => $it['author-link'],
'text' => sprintf(t("%s is now friends with %s"), $it['author-name'], $it['fname']),
'when' => $default_item_when,
'ago' => $default_item_ago,
'seen' => $it['seen']
);
break;

default:
$notif = array(
'label' => $default_item_label,
'link' => $default_item_link,
'image' => $default_item_image,
'url' => $default_item_url,
'text' => $default_item_text,
'when' => $default_item_when,
'ago' => $default_item_ago,
'seen' => $it['seen']
);
}

$arr[] = $notif;
}
}

return $arr;

}

/**
* @brief Total number of network notifications
* @param int|string $seen
* If 0 only include notifications into the query
* which aren't marked as "seen"
* @return int Number of network notifications
*/
private function networkTotal($seen = 0) {
$sql_seen = "";

if($seen === 0)
$sql_seen = " AND `item`.`unseen` = 1 ";

$r = q("SELECT COUNT(*) AS `total`
FROM `item` INNER JOIN `item` AS `pitem` ON `pitem`.`id`=`item`.`parent`
WHERE `item`.`visible` = 1 AND `pitem`.`parent` != 0 AND
`item`.`deleted` = 0 AND `item`.`uid` = %d AND `item`.`wall` = 0
$sql_seen",
intval(local_user())
);

if (dbm::is_result($r))
return $r[0]['total'];

return 0;
}

/**
* @brief Get network notifications
*
* @param int|string $seen
* If 0 only include notifications into the query
* which aren't marked as "seen"
* @param int $start Start the query at this point
* @param int $limit Maximum number of query results
*
* @return array with
* string 'ident' => Notification identifier
* int 'total' => Total number of available network notifications
* array 'notifications' => Network notifications
*/
public function networkNotifs($seen = 0, $start = 0, $limit = 80) {
$ident = 'network';
$total = $this->networkTotal($seen);
$notifs = array();
$sql_seen = "";

if($seen === 0)
$sql_seen = " AND `item`.`unseen` = 1 ";


$r = q("SELECT `item`.`id`,`item`.`parent`, `item`.`verb`, `item`.`author-name`, `item`.`unseen`,
`item`.`author-link`, `item`.`author-avatar`, `item`.`created`, `item`.`object` AS `object`,
`pitem`.`author-name` AS `pname`, `pitem`.`author-link` AS `plink`, `pitem`.`guid` AS `pguid`
FROM `item` INNER JOIN `item` AS `pitem` ON `pitem`.`id`=`item`.`parent`
WHERE `item`.`visible` = 1 AND `pitem`.`parent` != 0 AND
`item`.`deleted` = 0 AND `item`.`uid` = %d AND `item`.`wall` = 0
$sql_seen
ORDER BY `item`.`created` DESC LIMIT %d, %d ",
intval(local_user()),
intval($start),
intval($limit)
);

if (dbm::is_result($r))
$notifs = $this->formatNotifs($r, $ident);

$arr = array (
'notifications' => $notifs,
'ident' => $ident,
'total' => $total,
);

return $arr;
}

/**
* @brief Total number of system notifications
* @param int|string $seen
* If 0 only include notifications into the query
* which aren't marked as "seen"
* @return int Number of system notifications
*/
private function systemTotal($seen = 0) {
$sql_seen = "";

if($seen === 0)
$sql_seen = " AND `seen` = 0 ";

$r = q("SELECT COUNT(*) AS `total` FROM `notify` WHERE `uid` = %d $sql_seen",
intval(local_user())
);

if (dbm::is_result($r))
return $r[0]['total'];

return 0;
}

/**
* @brief Get system notifications
*
* @param int|string $seen
* If 0 only include notifications into the query
* which aren't marked as "seen"
* @param int $start Start the query at this point
* @param int $limit Maximum number of query results
*
* @return array with
* string 'ident' => Notification identifier
* int 'total' => Total number of available system notifications
* array 'notifications' => System notifications
*/
public function systemNotifs($seen = 0, $start = 0, $limit = 80) {
$ident = 'system';
$total = $this->systemTotal($seen);
$notifs = array();
$sql_seen = "";

if($seen === 0)
$sql_seen = " AND `seen` = 0 ";

$r = q("SELECT `id`, `url`, `photo`, `msg`, `date`, `seen` FROM `notify`
WHERE `uid` = %d $sql_seen ORDER BY `date` DESC LIMIT %d, %d ",
intval(local_user()),
intval($start),
intval($limit)
);

if (dbm::is_result($r))
$notifs = $this->formatNotifs($r, $ident);

$arr = array (
'notifications' => $notifs,
'ident' => $ident,
'total' => $total,
);

return $arr;
}

/**
* @brief Addional SQL query string for the personal notifications
*
* @return string The additional sql query
*/
private function _personal_sql_extra() {
$myurl = System::baseUrl(true) . '/profile/'. $this->a->user['nickname'];
$myurl = substr($myurl,strpos($myurl,'://')+3);
$myurl = str_replace(array('www.','.'),array('','\\.'),$myurl);
$diasp_url = str_replace('/profile/','/u/',$myurl);
$sql_extra = sprintf(" AND ( `item`.`author-link` regexp '%s' OR `item`.`tag` regexp '%s' OR `item`.`tag` regexp '%s' ) ",
dbesc($myurl . '$'),
dbesc($myurl . '\\]'),
dbesc($diasp_url . '\\]')
);

return $sql_extra;
}

/**
* @brief Total number of personal notifications
* @param int|string $seen
* If 0 only include notifications into the query
* which aren't marked as "seen"
* @return int Number of personal notifications
*/
private function personalTotal($seen = 0) {
$sql_seen = "";
$sql_extra = $this->_personal_sql_extra();

if($seen === 0)
$sql_seen = " AND `item`.`unseen` = 1 ";

$r = q("SELECT COUNT(*) AS `total`
FROM `item` INNER JOIN `item` AS `pitem` ON `pitem`.`id`=`item`.`parent`
WHERE `item`.`visible` = 1
$sql_extra
$sql_seen
AND `item`.`deleted` = 0 AND `item`.`uid` = %d AND `item`.`wall` = 0 " ,
intval(local_user())
);

if (dbm::is_result($r))
return $r[0]['total'];

return 0;
}

/**
* @brief Get personal notifications
*
* @param int|string $seen
* If 0 only include notifications into the query
* which aren't marked as "seen"
* @param int $start Start the query at this point
* @param int $limit Maximum number of query results
*
* @return array with
* string 'ident' => Notification identifier
* int 'total' => Total number of available personal notifications
* array 'notifications' => Personal notifications
*/
public function personalNotifs($seen = 0, $start = 0, $limit = 80) {
$ident = 'personal';
$total = $this->personalTotal($seen);
$sql_extra = $this->_personal_sql_extra();
$notifs = array();
$sql_seen = "";

if($seen === 0)
$sql_seen = " AND `item`.`unseen` = 1 ";

$r = q("SELECT `item`.`id`,`item`.`parent`, `item`.`verb`, `item`.`author-name`, `item`.`unseen`,
`item`.`author-link`, `item`.`author-avatar`, `item`.`created`, `item`.`object` AS `object`,
`pitem`.`author-name` AS `pname`, `pitem`.`author-link` AS `plink`, `pitem`.`guid` AS `pguid`
FROM `item` INNER JOIN `item` AS `pitem` ON `pitem`.`id`=`item`.`parent`
WHERE `item`.`visible` = 1
$sql_extra
$sql_seen
AND `item`.`deleted` = 0 AND `item`.`uid` = %d AND `item`.`wall` = 0
ORDER BY `item`.`created` DESC LIMIT %d, %d " ,
intval(local_user()),
intval($start),
intval($limit)
);

if (dbm::is_result($r))
$notifs = $this->formatNotifs($r, $ident);

$arr = array (
'notifications' => $notifs,
'ident' => $ident,
'total' => $total,
);

return $arr;
}

/**
* @brief Total number of home notifications
* @param int|string $seen
* If 0 only include notifications into the query
* which aren't marked as "seen"
* @return int Number of home notifications
*/
private function homeTotal($seen = 0) {
$sql_seen = "";

if($seen === 0)
$sql_seen = " AND `item`.`unseen` = 1 ";

$r = q("SELECT COUNT(*) AS `total` FROM `item`
WHERE `item`.`visible` = 1 AND
`item`.`deleted` = 0 AND `item`.`uid` = %d AND `item`.`wall` = 1
$sql_seen",
intval(local_user())
);

if (dbm::is_result($r))
return $r[0]['total'];

return 0;
}

/**
* @brief Get home notifications
*
* @param int|string $seen
* If 0 only include notifications into the query
* which aren't marked as "seen"
* @param int $start Start the query at this point
* @param int $limit Maximum number of query results
*
* @return array with
* string 'ident' => Notification identifier
* int 'total' => Total number of available home notifications
* array 'notifications' => Home notifications
*/
public function homeNotifs($seen = 0, $start = 0, $limit = 80) {
$ident = 'home';
$total = $this->homeTotal($seen);
$notifs = array();
$sql_seen = "";

if($seen === 0)
$sql_seen = " AND `item`.`unseen` = 1 ";

$r = q("SELECT `item`.`id`,`item`.`parent`, `item`.`verb`, `item`.`author-name`, `item`.`unseen`,
`item`.`author-link`, `item`.`author-avatar`, `item`.`created`, `item`.`object` AS `object`,
`pitem`.`author-name` AS `pname`, `pitem`.`author-link` AS `plink`, `pitem`.`guid` AS `pguid`
FROM `item` INNER JOIN `item` AS `pitem` ON `pitem`.`id`=`item`.`parent`
WHERE `item`.`visible` = 1 AND
`item`.`deleted` = 0 AND `item`.`uid` = %d AND `item`.`wall` = 1
$sql_seen
ORDER BY `item`.`created` DESC LIMIT %d, %d ",
intval(local_user()),
intval($start),
intval($limit)
);

if (dbm::is_result($r))
$notifs = $this->formatNotifs($r, $ident);

$arr = array (
'notifications' => $notifs,
'ident' => $ident,
'total' => $total,
);

return $arr;
}

/**
* @brief Total number of introductions
* @param bool $all
* If false only include introductions into the query
* which aren't marked as ignored
* @return int Number of introductions
*/
private function introTotal($all = false) {
$sql_extra = "";

if(!$all)
$sql_extra = " AND `ignore` = 0 ";

$r = q("SELECT COUNT(*) AS `total` FROM `intro`
WHERE `intro`.`uid` = %d $sql_extra AND `intro`.`blocked` = 0 ",
intval($_SESSION['uid'])
);

if (dbm::is_result($r))
return $r[0]['total'];

return 0;
}

/**
* @brief Get introductions
*
* @param bool $all
* If false only include introductions into the query
* which aren't marked as ignored
* @param int $start Start the query at this point
* @param int $limit Maximum number of query results
*
* @return array with
* string 'ident' => Notification identifier
* int 'total' => Total number of available introductions
* array 'notifications' => Introductions
*/
public function introNotifs($all = false, $start = 0, $limit = 80) {
$ident = 'introductions';
$total = $this->introTotal($seen);
$notifs = array();
$sql_extra = "";

if(!$all)
$sql_extra = " AND `ignore` = 0 ";

/// @todo Fetch contact details by "get_contact_details_by_url" instead of queries to contact, fcontact and gcontact
$r = q("SELECT `intro`.`id` AS `intro_id`, `intro`.*, `contact`.*,
`fcontact`.`name` AS `fname`, `fcontact`.`url` AS `furl`,
`fcontact`.`photo` AS `fphoto`, `fcontact`.`request` AS `frequest`,
`gcontact`.`location` AS `glocation`, `gcontact`.`about` AS `gabout`,
`gcontact`.`keywords` AS `gkeywords`, `gcontact`.`gender` AS `ggender`,
`gcontact`.`network` AS `gnetwork`, `gcontact`.`addr` AS `gaddr`
FROM `intro`
LEFT JOIN `contact` ON `contact`.`id` = `intro`.`contact-id`
LEFT JOIN `gcontact` ON `gcontact`.`nurl` = `contact`.`nurl`
LEFT JOIN `fcontact` ON `intro`.`fid` = `fcontact`.`id`
WHERE `intro`.`uid` = %d $sql_extra AND `intro`.`blocked` = 0
LIMIT %d, %d",
intval($_SESSION['uid']),
intval($start),
intval($limit)
);

if (dbm::is_result($r))
$notifs = $this->formatIntros($r);

$arr = array (
'ident' => $ident,
'total' => $total,
'notifications' => $notifs,
);

return $arr;
}

/**
* @brief Format the notification query in an usable array
*
* @param array $intros The array from the db query
* @return array with the introductions
*/
private function formatIntros($intros) {
$knowyou = '';

foreach($intros as $it) {
// There are two kind of introduction. Contacts suggested by other contacts and normal connection requests.
// We have to distinguish between these two because they use different data.

// Contact suggestions
if($it['fid']) {

$return_addr = bin2hex($this->a->user['nickname'] . '@' . $this->a->get_hostname() . (($this->a->path) ? '/' . $this->a->path : ''));

$intro = array(
'label' => 'friend_suggestion',
'notify_type' => t('Friend Suggestion'),
'intro_id' => $it['intro_id'],
'madeby' => $it['name'],
'contact_id' => $it['contact-id'],
'photo' => ((x($it,'fphoto')) ? proxy_url($it['fphoto'], false, PROXY_SIZE_SMALL) : "images/person-175.jpg"),
'name' => $it['fname'],
'url' => zrl($it['furl']),
'hidden' => $it['hidden'] == 1,
'post_newfriend' => (intval(PConfig::get(local_user(),'system','post_newfriend')) ? '1' : 0),

'knowyou' => $knowyou,
'note' => $it['note'],
'request' => $it['frequest'] . '?addr=' . $return_addr,

);

// Normal connection requests
} else {

$it = $this->getMissingIntroData($it);

// Don't show these data until you are connected. Diaspora is doing the same.
if($it['gnetwork'] === NETWORK_DIASPORA) {
$it['glocation'] = "";
$it['gabout'] = "";
$it['ggender'] = "";
}
$intro = array(
'label' => (($it['network'] !== NETWORK_OSTATUS) ? 'friend_request' : 'follower'),
'notify_type' => (($it['network'] !== NETWORK_OSTATUS) ? t('Friend/Connect Request') : t('New Follower')),
'dfrn_id' => $it['issued-id'],
'uid' => $_SESSION['uid'],
'intro_id' => $it['intro_id'],
'contact_id' => $it['contact-id'],
'photo' => ((x($it,'photo')) ? proxy_url($it['photo'], false, PROXY_SIZE_SMALL) : "images/person-175.jpg"),
'name' => $it['name'],
'location' => bbcode($it['glocation'], false, false),
'about' => bbcode($it['gabout'], false, false),
'keywords' => $it['gkeywords'],
'gender' => $it['ggender'],
'hidden' => $it['hidden'] == 1,
'post_newfriend' => (intval(PConfig::get(local_user(),'system','post_newfriend')) ? '1' : 0),
'url' => $it['url'],
'zrl' => zrl($it['url']),
'addr' => $it['gaddr'],
'network' => $it['gnetwork'],
'knowyou' => $it['knowyou'],
'note' => $it['note'],
);
}

$arr[] = $intro;
}

return $arr;
}

/**
* @brief Check for missing contact data and try to fetch the data from
* from other sources
*
* @param array $arr The input array with the intro data
*
* @return array The array with the intro data
*/
private function getMissingIntroData($arr) {
// If the network and the addr isn't available from the gcontact
// table entry, take the one of the contact table entry
if ($arr['gnetwork'] == "") {
$arr['gnetwork'] = $arr['network'];
}
if ($arr['gaddr'] == "") {
$arr['gaddr'] = $arr['addr'];
}

// If the network and addr is still not available
// get the missing data data from other sources
if ($arr['gnetwork'] == "" || $arr['gaddr'] == "") {
$ret = get_contact_details_by_url($arr['url']);

if ($arr['gnetwork'] == "" && $ret['network'] != "") {
$arr['gnetwork'] = $ret['network'];
}
if ($arr['gaddr'] == "" && $ret['addr'] != "") {
$arr['gaddr'] = $ret['addr'];
}
}

return $arr;
}
}

+ 7
- 6
include/Photo.php View File

@@ -7,6 +7,7 @@
use Friendica\App;
use Friendica\Core\Config;
use Friendica\Core\System;
use Friendica\Database\DBM;

require_once("include/photos.php");

@@ -630,7 +631,7 @@ class Photo {
public function store($uid, $cid, $rid, $filename, $album, $scale, $profile = 0, $allow_cid = '', $allow_gid = '', $deny_cid = '', $deny_gid = '', $desc = '') {

$r = dba::select('photo', array('guid'), array("`resource-id` = ? AND `guid` != ?", $rid, ''), array('limit' => 1));
if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$guid = $r['guid'];
} else {
$guid = get_guid();
@@ -643,7 +644,7 @@ class Photo {
'datasize' => strlen($this->imageString()), 'data' => $this->imageString(), 'scale' => $scale, 'profile' => $profile,
'allow_cid' => $allow_cid, 'allow_gid' => $allow_gid, 'deny_cid' => $deny_cid, 'deny_gid' => $deny_gid, 'desc' => $desc);

if (dbm::is_result($x)) {
if (DBM::is_result($x)) {
$r = dba::update('photo', $fields, array('id' => $x['id']));
} else {
$r = dba::insert('photo', $fields);
@@ -713,7 +714,7 @@ function guess_image_type($filename, $fromcurl=false) {
*/
function update_contact_avatar($avatar, $uid, $cid, $force = false) {
$r = q("SELECT `avatar`, `photo`, `thumb`, `micro`, `nurl` FROM `contact` WHERE `id` = %d LIMIT 1", intval($cid));
if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
return false;
} else {
$data = array($r[0]["photo"], $r[0]["thumb"], $r[0]["micro"]);
@@ -730,7 +731,7 @@ function update_contact_avatar($avatar, $uid, $cid, $force = false) {
// Update the public contact (contact id = 0)
if ($uid != 0) {
$pcontact = dba::select('contact', array('id'), array('nurl' => $r[0]['nurl']), array('limit' => 1));
if (dbm::is_result($pcontact)) {
if (DBM::is_result($pcontact)) {
update_contact_avatar($avatar, 0, $pcontact['id'], $force);
}
}
@@ -748,7 +749,7 @@ function import_profile_photo($photo, $uid, $cid, $quit_on_error = false) {
intval($uid),
intval($cid)
);
if (dbm::is_result($r) && strlen($r[0]['resource-id'])) {
if (DBM::is_result($r) && strlen($r[0]['resource-id'])) {
$hash = $r[0]['resource-id'];
} else {
$hash = photo_new_resource();
@@ -919,7 +920,7 @@ function store_photo(App $a, $uid, $imagedata = "", $url = "") {
WHERE `user`.`uid` = %d AND `user`.`blocked` = 0 AND `contact`.`self` = 1 LIMIT 1",
intval($uid));

if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
logger("Can't detect user data for uid ".$uid, LOGGER_DEBUG);
return(array());
}


+ 8
- 7
include/acl_selectors.php View File

@@ -6,6 +6,7 @@

use Friendica\App;
use Friendica\Core\Config;
use Friendica\Database\DBM;

require_once "include/contact_selectors.php";
require_once "include/contact_widgets.php";
@@ -36,7 +37,7 @@ function group_select($selname,$selclass,$preselected = false,$size = 4) {

call_hooks($a->module . '_pre_' . $selname, $arr);

if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
foreach ($r as $rr) {
if ((is_array($preselected)) && in_array($rr['id'], $preselected)) {
$selected = " selected=\"selected\" ";
@@ -159,7 +160,7 @@ function contact_selector($selname, $selclass, $preselected = false, $options) {

call_hooks($a->module . '_pre_' . $selname, $arr);

if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
foreach ($r as $rr) {
if ((is_array($preselected)) && in_array($rr['id'], $preselected)) {
$selected = " selected=\"selected\" ";
@@ -239,7 +240,7 @@ function contact_select($selname, $selclass, $preselected = false, $size = 4, $p

$receiverlist = array();

if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
foreach ($r as $rr) {
if ((is_array($preselected)) && in_array($rr['id'], $preselected)) {
$selected = " selected=\"selected\" ";
@@ -286,7 +287,7 @@ function prune_deadguys($arr) {

$r = q("SELECT `id` FROM `contact` WHERE `id` IN ( " . $str . ") AND `blocked` = 0 AND `pending` = 0 AND `archive` = 0 ");

if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$ret = array();
foreach ($r as $rr) {
$ret[] = intval($rr['id']);
@@ -342,7 +343,7 @@ function populate_acl($user = null, $show_jotnets = false) {
$r = q("SELECT `pubmail` FROM `mailacct` WHERE `uid` = %d AND `server` != '' LIMIT 1",
intval(local_user())
);
if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$mail_enabled = true;
if (intval($r[0]['pubmail'])) {
$pubmail_enabled = true;
@@ -635,7 +636,7 @@ function acl_lookup(App $a, $out_type = 'json') {
}


if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$forums = array();
foreach ($r as $g) {
$entry = array(
@@ -689,7 +690,7 @@ function acl_lookup(App $a, $out_type = 'json') {
dbesc($search),
implode("', '", $known_contacts)
);
if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
foreach ($r as $row) {
$contact = get_contact_details_by_url($row['author-link']);



+ 44
- 43
include/api.php View File

@@ -11,6 +11,7 @@ use Friendica\Core\System;
use Friendica\Core\Config;
use Friendica\Core\NotificationsManager;
use Friendica\Core\Worker;
use Friendica\Database\DBM;

require_once 'include/HTTPExceptions.php';
require_once 'include/bbcode.php';
@@ -211,7 +212,7 @@ $called_api = null;
dbesc(trim($user)),
dbesc($encrypted)
);
if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$record = $r[0];
}
}
@@ -460,7 +461,7 @@ $called_api = null;
function api_unique_id_to_url($id) {
$r = dba::select('contact', array('url'), array('uid' => 0, 'id' => $id), array('limit' => 1));

if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
return $r["url"];
} else {
return false;
@@ -591,14 +592,14 @@ $called_api = null;
api_best_nickname($uinfo);

// if the contact wasn't found, fetch it from the contacts with uid = 0
if (!dbm::is_result($uinfo)) {
if (!DBM::is_result($uinfo)) {
$r = array();

if ($url != "") {
$r = q("SELECT * FROM `contact` WHERE `uid` = 0 AND `nurl` = '%s' LIMIT 1", dbesc(normalise_link($url)));
}

if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$network_name = network_to_name($r[0]['network'], $r[0]['url']);

// If no nick where given, extract it from the address
@@ -1092,7 +1093,7 @@ $called_api = null;
AND `created` > '%s' AND `id` = `parent`",
intval(api_user()), dbesc($datefrom));

if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$posts_day = $r[0]["posts_day"];
} else {
$posts_day = 0;
@@ -1113,7 +1114,7 @@ $called_api = null;
AND `created` > '%s' AND `id` = `parent`",
intval(api_user()), dbesc($datefrom));

if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$posts_week = $r[0]["posts_week"];
} else {
$posts_week = 0;
@@ -1134,7 +1135,7 @@ $called_api = null;
AND `created` > '%s' AND `id` = `parent`",
intval(api_user()), dbesc($datefrom));

if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$posts_month = $r[0]["posts_month"];
} else {
$posts_month = 0;
@@ -1163,7 +1164,7 @@ $called_api = null;
if (requestdata('media_ids')) {
$r = q("SELECT `resource-id`, `scale`, `nickname`, `type` FROM `photo` INNER JOIN `user` ON `user`.`uid` = `photo`.`uid` WHERE `resource-id` IN (SELECT `resource-id` FROM `photo` WHERE `id` = %d) AND `scale` > 0 AND `photo`.`uid` = %d ORDER BY `photo`.`width` DESC LIMIT 1",
intval(requestdata('media_ids')), api_user());
if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$phototypes = Photo::supportedTypes();
$ext = $phototypes[$r[0]['type']];
$_REQUEST['body'] .= "\n\n" . '[url=' . System::baseUrl() . '/photos/' . $r[0]['nickname'] . '/image/' . $r[0]['resource-id'] . ']';
@@ -1258,7 +1259,7 @@ $called_api = null;
dbesc(normalise_link($user_info['url']))
);

if (dbm::is_result($lastwall)) {
if (DBM::is_result($lastwall)) {
$lastwall = $lastwall[0];

$in_reply_to = api_in_reply_to($lastwall);
@@ -1356,7 +1357,7 @@ $called_api = null;
dbesc(normalise_link($user_info['url']))
);

if (dbm::is_result($lastwall)) {
if (DBM::is_result($lastwall)) {
$lastwall = $lastwall[0];

$in_reply_to = api_in_reply_to($lastwall);
@@ -1428,11 +1429,11 @@ $called_api = null;
if (x($_GET, 'q')) {
$r = q("SELECT id FROM `contact` WHERE `uid` = 0 AND `name` = '%s'", dbesc($_GET["q"]));

if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
$r = q("SELECT `id` FROM `contact` WHERE `uid` = 0 AND `nick` = '%s'", dbesc($_GET["q"]));
}

if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$k = 0;
foreach ($r AS $user) {
$user_info = api_get_user($a, $user["id"], "json");
@@ -1681,7 +1682,7 @@ $called_api = null;
);

/// @TODO How about copying this to above methods which don't check $r ?
if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
throw new BadRequestException("There is no status with this id.");
}

@@ -1736,7 +1737,7 @@ $called_api = null;
logger('API: api_conversation_show: '.$id);

$r = q("SELECT `parent` FROM `item` WHERE `id` = %d", intval($id));
if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$id = $r[0]["parent"];
}

@@ -1769,7 +1770,7 @@ $called_api = null;
intval($start), intval($count)
);

if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
throw new BadRequestException("There is no status with this id.");
}

@@ -1827,7 +1828,7 @@ $called_api = null;
);

/// @TODO other style than above functions!
if (dbm::is_result($r) && $r[0]['body'] != "") {
if (DBM::is_result($r) && $r[0]['body'] != "") {
if (strpos($r[0]['body'], "[/share]") !== false) {
$pos = strpos($r[0]['body'], "[share");
$post = substr($r[0]['body'], $pos);
@@ -2093,7 +2094,7 @@ $called_api = null;
$item = q("SELECT * FROM `item` WHERE `id`=%d AND `uid`=%d LIMIT 1",
$itemid, api_user());

if (!dbm::is_result($item) || count($item) == 0) {
if (!DBM::is_result($item) || count($item) == 0) {
throw new BadRequestException("Invalid item.");
}

@@ -3004,7 +3005,7 @@ $called_api = null;
intval(api_user())
);

if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
return;
}

@@ -3138,7 +3139,7 @@ $called_api = null;
intval($id));

// error message if specified id is not in database
if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
if ($verbose == "true") {
$answer = array('result' => 'error', 'message' => 'message id not in database');
return api_format_data("direct_messages_delete", $type, array('$result' => $answer));
@@ -3229,7 +3230,7 @@ $called_api = null;
intval($since_id),
intval($start), intval($count)
);
if ($verbose == "true" && !dbm::is_result($r)) {
if ($verbose == "true" && !DBM::is_result($r)) {
$answer = array('result' => 'error', 'message' => 'no mails available');
return api_format_data("direct_messages_all", $type, array('$result' => $answer));
}
@@ -3334,7 +3335,7 @@ $called_api = null;
$r = q("SELECT DISTINCT `resource-id` FROM `photo` WHERE `uid` = %d AND `album` = '%s'",
intval(api_user()),
dbesc($album));
if (!dbm::is_result($r))
if (!DBM::is_result($r))
throw new BadRequestException("album not available");

// function for setting the items to "deleted = 1" which ensures that comments, likes etc. are not shown anymore
@@ -3345,7 +3346,7 @@ $called_api = null;
dbesc($rr['resource-id'])
);

if (!dbm::is_result($photo_item)) {
if (!DBM::is_result($photo_item)) {
throw new InternalServerErrorException("problem with deleting items occured");
}
drop_item($photo_item[0]['id'],false);
@@ -3391,7 +3392,7 @@ $called_api = null;
$r = q("SELECT `id` FROM `photo` WHERE `uid` = %d AND `album` = '%s'",
intval(api_user()),
dbesc($album));
if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
throw new BadRequestException("album not available");
}
// now let's update all photos to the albumname
@@ -3431,7 +3432,7 @@ $called_api = null;
'image/gif' => 'gif'
);
$data = array('photo'=>array());
if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
foreach ($r as $rr) {
$photo = array();
$photo['id'] = $rr['resource-id'];
@@ -3500,7 +3501,7 @@ $called_api = null;
intval(api_user()),
dbesc($photo_id),
dbesc($album));
if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
throw new BadRequestException("photo not available");
}
}
@@ -3620,7 +3621,7 @@ $called_api = null;
intval(api_user()),
dbesc($photo_id)
);
if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
throw new BadRequestException("photo not available");
}
// now we can perform on the deletion of the photo
@@ -3636,7 +3637,7 @@ $called_api = null;
dbesc($photo_id)
);

if (!dbm::is_result($photo_item)) {
if (!DBM::is_result($photo_item)) {
throw new InternalServerErrorException("problem with deleting items occured");
}
// function for setting the items to "deleted = 1" which ensures that comments, likes etc. are not shown anymore
@@ -3699,7 +3700,7 @@ $called_api = null;
intval(api_user()),
intval($profileid));
// error message if specified profile id is not in database
if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
throw new BadRequestException("profile_id not available");
}
$is_default_profile = $r['profile'];
@@ -3804,7 +3805,7 @@ $called_api = null;
$contact = q("SELECT * FROM `contact` WHERE `id` = %d AND `uid` = %d",
intval($cid),
intval(api_user()));
$contact_not_found |= !dbm::is_result($contact);
$contact_not_found |= !DBM::is_result($contact);
}
return $contact_not_found;
}
@@ -4020,7 +4021,7 @@ $called_api = null;
);

// prepare output data for photo
if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$data = array('photo' => $r[0]);
$data['photo']['id'] = $data['photo']['resource-id'];
if ($scale !== false) {
@@ -4129,7 +4130,7 @@ $called_api = null;
intval(api_user())
);

if ((! dbm::is_result($r)) || ($r[0]['network'] !== NETWORK_DFRN)) {
if ((! DBM::is_result($r)) || ($r[0]['network'] !== NETWORK_DFRN)) {
throw new BadRequestException("Unknown contact");
}

@@ -4276,7 +4277,7 @@ $called_api = null;
$r = q("SELECT `nick` FROM `contact` WHERE `uid` = 0 AND `nurl` = '%s'",
dbesc(normalise_link($profile)));

if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$nick = $r[0]["nick"];
}

@@ -4284,7 +4285,7 @@ $called_api = null;
$r = q("SELECT `nick` FROM `contact` WHERE `uid` = 0 AND `nurl` = '%s'",
dbesc(normalise_link($profile)));

if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$nick = $r[0]["nick"];
}
}
@@ -4355,7 +4356,7 @@ $called_api = null;
intval($item['uid']),
dbesc($item['thr-parent']));

if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$in_reply_to['status_id'] = intval($r[0]['id']);
} else {
$in_reply_to['status_id'] = intval($item['parent']);
@@ -4369,7 +4370,7 @@ $called_api = null;
intval($in_reply_to['status_id'])
);

if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
if ($r[0]['nick'] == "") {
$r[0]['nick'] = api_get_nick($r[0]["url"]);
}
@@ -4503,7 +4504,7 @@ $called_api = null;
intval($uid),
intval($gid));
// error message if specified gid is not in database
if (!dbm::is_result($r))
if (!DBM::is_result($r))
throw new BadRequestException("gid not available");
}
else
@@ -4558,7 +4559,7 @@ $called_api = null;
intval($uid),
intval($gid));
// error message if specified gid is not in database
if (!dbm::is_result($r))
if (!DBM::is_result($r))
throw new BadRequestException('gid not available');

// get data of the specified group id and group name
@@ -4567,7 +4568,7 @@ $called_api = null;
intval($gid),
dbesc($name));
// error message if specified gid is not in database
if (!dbm::is_result($rname))
if (!DBM::is_result($rname))
throw new BadRequestException('wrong group name');

// delete group
@@ -4606,7 +4607,7 @@ $called_api = null;
intval($uid),
dbesc($name));
// error message if specified group name already exists
if (dbm::is_result($rname))
if (DBM::is_result($rname))
throw new BadRequestException('group name already exists');

// check if specified group name is a deleted group
@@ -4614,7 +4615,7 @@ $called_api = null;
intval($uid),
dbesc($name));
// error message if specified group name already exists
if (dbm::is_result($rname))
if (DBM::is_result($rname))
$reactivate_group = true;

// create group
@@ -4845,7 +4846,7 @@ $called_api = null;
intval($uid));

// error message if specified id is not in database
if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
$answer = array('result' => 'error', 'message' => 'message id not in database');
return api_format_data("direct_messages_setseen", $type, array('$result' => $answer));
}
@@ -4903,7 +4904,7 @@ $called_api = null;
$profile_url = $user_info["url"];

// message if nothing was found
if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
$success = array('success' => false, 'search_results' => 'problem with query');
} elseif (count($r) == 0) {
$success = array('success' => false, 'search_results' => 'nothing found');
@@ -4956,7 +4957,7 @@ $called_api = null;
intval($profileid));

// error message if specified gid is not in database
if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
throw new BadRequestException("profile_id not available");
}
} else {


+ 4
- 3
include/auth.php View File

@@ -3,6 +3,7 @@
use Friendica\App;
use Friendica\Core\System;
use Friendica\Core\Config;
use Friendica\Database\DBM;

require_once('include/security.php');
require_once('include/datetime.php');
@@ -58,7 +59,7 @@ if (isset($_SESSION) && x($_SESSION,'authenticated') && (!x($_POST,'auth-params'
$r = q("SELECT * FROM `contact` WHERE `id` = %d LIMIT 1",
intval($_SESSION['visitor_id'])
);
if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$a->contact = $r[0];
}
}
@@ -81,7 +82,7 @@ if (isset($_SESSION) && x($_SESSION,'authenticated') && (!x($_POST,'auth-params'
intval($_SESSION['uid'])
);

if (!dbm::is_result($r)) {
if (!DBM::is_result($r)) {
nuke_session();
goaway(System::baseUrl());
}
@@ -177,7 +178,7 @@ if (isset($_SESSION) && x($_SESSION,'authenticated') && (!x($_POST,'auth-params'
dbesc(trim($_POST['username'])),
dbesc($encrypted)
);
if (dbm::is_result($r))
if (DBM::is_result($r))
$record = $r[0];
}



+ 2
- 1
include/auth_ejabberd.php View File

@@ -34,6 +34,7 @@

use Friendica\App;
use Friendica\Core\Config;
use Friendica\Database\DBM;

if (sizeof($_SERVER["argv"]) == 0)
die();
@@ -152,7 +153,7 @@ class exAuth {
$sQuery = "SELECT `uid` FROM `user` WHERE `nickname`='".dbesc($sUser)."'";
$this->writeLog(LOG_DEBUG, "using query ". $sQuery);
$r = q($sQuery);
$found = dbm::is_result($r);
$found = DBM::is_result($r);
} else {
$found = false;
}


+ 2
- 1
include/cache.php View File

@@ -7,6 +7,7 @@

use Friendica\Core\Config;
use Friendica\Core\PConfig;
use Friendica\Database\DBM;

class Cache {
/**
@@ -104,7 +105,7 @@ class Cache {
dbesc($key)
);

if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$cached = $r[0]['v'];
$value = @unserialize($cached);



+ 3
- 2
include/contact_selectors.php View File

@@ -1,5 +1,6 @@
<?php

use Friendica\Database\DBM;
use Friendica\Protocol\Diaspora;

function contact_profile_assign($current,$foreign_net) {
@@ -13,7 +14,7 @@ function contact_profile_assign($current,$foreign_net) {
$r = q("SELECT `id`, `profile-name`, `is-default` FROM `profile` WHERE `uid` = %d",
intval($_SESSION['uid']));

if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
foreach ($r as $rr) {
$selected = (($rr['id'] == $current || ($current == 0 && $rr['is-default'] == 1)) ? " selected=\"selected\" " : "");
$o .= "<option value=\"{$rr['id']}\" $selected >{$rr['profile-name']}</option>\r\n";
@@ -106,7 +107,7 @@ function network_to_name($s, $profile = "") {
INNER JOIN `gserver` ON `gserver`.`nurl` = `gcontact`.`server_url`
WHERE `gcontact`.`nurl` = ? AND `platform` != ''", normalise_link($profile));

if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$networkname = $r['platform'];
}
}


+ 3
- 2
include/contact_widgets.php View File

@@ -4,6 +4,7 @@ use Friendica\App;
use Friendica\Core\System;
use Friendica\Core\Config;
use Friendica\Core\PConfig;
use Friendica\Database\DBM;

require_once 'include/contact_selectors.php';

@@ -233,11 +234,11 @@ function common_friends_visitor_widget($profile_uid) {
if (get_my_url()) {
$r = dba::select('contact', array('id'),
array('nurl' => normalise_link(get_my_url()), 'uid' => $profile_uid), array('limit' => 1));
if (dbm::is_result($r)) {
if (DBM::is_result($r)) {
$cid = $r['id'];
} else {
$r = dba::select('gcontact', array('id'), array('nurl' => normalise_link(get_my_url())), array('limit' => 1));
if (dbm::is_result($r))
if (DBM::is_result($r))
$zcid = $r['id'];
}
}


+ 6
- 5
include/conversation.php View File

@@ -4,6 +4,7 @@ use Friendica\App;
use Friendica\Core\Config;
use Friendica\Core\PConfig;
use Friendica\Core\System;
use Friendica\Database\DBM;

require_once "include/bbcode.php";
require_once "include/acl_selectors.php";