From 99440f3c56d1a87aa5aa357d68e371c726f6ba0a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Roland=20H=C3=A4der?= <roland@mxchange.org>
Date: Sun, 13 May 2018 14:20:15 +0200
Subject: [PATCH] Beatification: - added space after curly braces (MrPetovan) -
 added TODO for possible rewrite candidate
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Roland Häder <roland@mxchange.org>
---
 mod/share.php         | 7 +++++++
 src/Protocol/DFRN.php | 1 +
 2 files changed, 8 insertions(+)

diff --git a/mod/share.php b/mod/share.php
index ed9b5f9d17..555273443c 100644
--- a/mod/share.php
+++ b/mod/share.php
@@ -5,6 +5,7 @@ use Friendica\Database\DBM;
 
 function share_init(App $a) {
 	$post_id = (($a->argc > 1) ? intval($a->argv[1]) : 0);
+
 	if (!$post_id || !local_user()) {
 		killme();
 	}
@@ -14,9 +15,11 @@ function share_init(App $a) {
 		WHERE `item`.`id` = %d LIMIT 1",
 		intval($post_id)
 	);
+
 	if (!DBM::is_result($r) || ($r[0]['private'] == 1)) {
 		killme();
 	}
+
 	if (strpos($r[0]['body'], "[/share]") !== false) {
 		$pos = strpos($r[0]['body'], "[share");
 		$o = substr($r[0]['body'], $pos);
@@ -26,6 +29,7 @@ function share_init(App $a) {
 		if ($r[0]['title']) {
 			$o .= '[b]'.$r[0]['title'].'[/b]'."\n";
 		}
+
 		$o .= $r[0]['body'];
 		$o .= "[/share]";
 	}
@@ -34,6 +38,7 @@ function share_init(App $a) {
 	killme();
 }
 
+/// @TODO Rewrite to handle over whole record array
 function share_header($author, $profile, $avatar, $guid, $posted, $link) {
 	$header = "[share author='" . str_replace(["'", "[", "]"], ["&#x27;", "&#x5B;", "&#x5D;"], $author).
 		"' profile='" . str_replace(["'", "[", "]"], ["&#x27;", "&#x5B;", "&#x5D;"], $profile).
@@ -42,9 +47,11 @@ function share_header($author, $profile, $avatar, $guid, $posted, $link) {
 	if ($guid) {
 		$header .= "' guid='" . str_replace(["'", "[", "]"], ["&#x27;", "&#x5B;", "&#x5D;"], $guid);
 	}
+
 	if ($posted) {
 		$header .= "' posted='" . str_replace(["'", "[", "]"], ["&#x27;", "&#x5B;", "&#x5D;"], $posted);
 	}
+
 	$header .= "' link='" . str_replace(["'", "[", "]"], ["&#x27;", "&#x5B;", "&#x5D;"], $link)."']";
 
 	return $header;
diff --git a/src/Protocol/DFRN.php b/src/Protocol/DFRN.php
index 0f9cbeafab..00bb91f8de 100644
--- a/src/Protocol/DFRN.php
+++ b/src/Protocol/DFRN.php
@@ -181,6 +181,7 @@ class DFRN
 				for ($x = 0; $x < count($groups); $x ++) {
 					$groups[$x] = '<' . intval($groups[$x]) . '>' ;
 				}
+
 				$gs = implode('|', $groups);
 			} else {
 				$gs = '<<>>' ; // Impossible to match