From 6a434588a97799abc827332aa9268f5a8bc0a897 Mon Sep 17 00:00:00 2001 From: Michael Date: Thu, 24 Nov 2022 05:17:14 +0000 Subject: [PATCH 1/2] Silently quit on unfollow of invalid contacts --- src/Core/Protocol.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Core/Protocol.php b/src/Core/Protocol.php index 015612adea..511954c7f9 100644 --- a/src/Core/Protocol.php +++ b/src/Core/Protocol.php @@ -182,7 +182,8 @@ class Protocol public static function unfollow(array $contact, array $user): ?bool { if (empty($contact['network'])) { - throw new \InvalidArgumentException('Missing network key in contact array'); + Logger::notice('Contact has got no network, we quit here', ['id' => $contact['id']]); + return true; } $protocol = $contact['network']; @@ -205,7 +206,8 @@ class Protocol $slap = OStatus::salmon($item, $user); if (empty($contact['notify'])) { - throw new \InvalidArgumentException('Missing expected "notify" key in OStatus/DFRN contact'); + Logger::notice('OStatus/DFRN Contact is missing notify, we quit here', ['id' => $contact['id']]); + return true; } return Salmon::slapper($user, $contact['notify'], $slap) === 0; From 53b46855ef2d8c42787e03e7d1fd047e68765ad1 Mon Sep 17 00:00:00 2001 From: Michael Date: Thu, 24 Nov 2022 19:45:45 +0000 Subject: [PATCH 2/2] return "null" --- src/Core/Protocol.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Core/Protocol.php b/src/Core/Protocol.php index 511954c7f9..25955abd50 100644 --- a/src/Core/Protocol.php +++ b/src/Core/Protocol.php @@ -183,7 +183,7 @@ class Protocol { if (empty($contact['network'])) { Logger::notice('Contact has got no network, we quit here', ['id' => $contact['id']]); - return true; + return null; } $protocol = $contact['network']; @@ -207,7 +207,7 @@ class Protocol if (empty($contact['notify'])) { Logger::notice('OStatus/DFRN Contact is missing notify, we quit here', ['id' => $contact['id']]); - return true; + return null; } return Salmon::slapper($user, $contact['notify'], $slap) === 0;