From f35109827bd2e6184974989ac65bf3bd305f2fa0 Mon Sep 17 00:00:00 2001 From: Fabio Comuni Date: Mon, 2 Jan 2012 20:09:25 +0100 Subject: [PATCH 01/10] datetime: new field_timezone() function, new template field_select_raw.tpl returns a timezone select like select_timezone() but using template field_select_raw.tpl. field_select_raw get options html as forth argument, instead of array value=>label like field_select --- include/datetime.php | 20 ++++++++++++++++++-- view/field_select_raw.tpl | 8 ++++++++ 2 files changed, 26 insertions(+), 2 deletions(-) create mode 100644 view/field_select_raw.tpl diff --git a/include/datetime.php b/include/datetime.php index 087e6cb20d..d44e995cfa 100644 --- a/include/datetime.php +++ b/include/datetime.php @@ -15,7 +15,6 @@ function timezone_cmp($a, $b) { }} // emit a timezone selector grouped (primarily) by continent - if(! function_exists('select_timezone')) { function select_timezone($current = 'America/Los_Angeles') { @@ -55,6 +54,23 @@ function select_timezone($current = 'America/Los_Angeles') { return $o; }} +// return a select using 'field_select_raw' template, with timezones +// groupped (primarily) by continent +// arguments follow convetion as other field_* template array: +// 'name', 'label', $value, 'help' +if (!function_exists('field_timezone')){ +function field_timezone($name='timezone', $label='', $current = 'America/Los_Angeles', $help){ + $options = select_timezone($current); + $options = str_replace('','', $options); + + $tpl = get_markup_template('field_select_raw.tpl'); + return replace_macros($tpl, array( + '$field' => array($name, $label, $current, $help, $options), + )); + +}} + // General purpose date parse/convert function. // $from = source timezone // $to = dest timezone @@ -446,4 +462,4 @@ function update_contact_birthdays() { } } -} \ No newline at end of file +} diff --git a/view/field_select_raw.tpl b/view/field_select_raw.tpl new file mode 100644 index 0000000000..765b285d99 --- /dev/null +++ b/view/field_select_raw.tpl @@ -0,0 +1,8 @@ + +
+ + + $field.3 +
From 85fbdb00acf5ab1308f6d0da42d2a61e3f3ff074 Mon Sep 17 00:00:00 2001 From: Fabio Comuni Date: Mon, 2 Jan 2012 20:10:23 +0100 Subject: [PATCH 02/10] dba: leave unconnected if $server and $user are not defined --- include/dba.php | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/include/dba.php b/include/dba.php index b89cf53766..782c279d5d 100644 --- a/include/dba.php +++ b/include/dba.php @@ -18,7 +18,7 @@ class dba { private $db; public $mysqli = true; public $connected = false; - + public $error = false; function __construct($server,$user,$pass,$db,$install = false) { @@ -27,10 +27,16 @@ class dba { $pass = trim($pass); $db = trim($db); + if (!(strlen($server) && strlen($user))){ + $this->connected = false; + $this->db = null; + return; + } + if($install) { if(strlen($server) && ($server !== 'localhost') && ($server !== '127.0.0.1')) { if(! dns_get_record($server, DNS_A + DNS_CNAME + DNS_PTR)) { - notice( sprintf( t('Cannot locate DNS info for database server \'%s\''), $server)); + $this->error = sprintf( t('Cannot locate DNS info for database server \'%s\''), $server); $this->connected = false; $this->db = null; return; @@ -152,10 +158,11 @@ class dba { } function __destruct() { - if($this->mysqli) - @$this->db->close(); - else - @mysql_close($this->db); + if ($this->db) + if($this->mysqli) + $this->db->close(); + else + mysql_close($this->db); } }} @@ -186,6 +193,7 @@ function dbesc($str) { }} + // Function: q($sql,$args); // Description: execute SQL query with printf style args. // Example: $r = q("SELECT * FROM `%s` WHERE `uid` = %d", @@ -209,7 +217,6 @@ function q($sql) { * session data after abnormal program termination * */ - logger('dba: no database: ' . print_r($args,true)); return false; From 1fbffc76b18e94ecda86452fe16609295976c619 Mon Sep 17 00:00:00 2001 From: Fabio Comuni Date: Mon, 2 Jan 2012 20:11:06 +0100 Subject: [PATCH 03/10] text: "turn off" logger() if module is "install" --- include/text.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/text.php b/include/text.php index d6b3ceeab4..f32aaad07e 100644 --- a/include/text.php +++ b/include/text.php @@ -426,6 +426,10 @@ function attribute_contains($attr,$s) { if(! function_exists('logger')) { function logger($msg,$level = 0) { + // turn off logger in install mode + global $a; + if ($a->module == 'install') return; + $debugging = get_config('system','debugging'); $loglevel = intval(get_config('system','loglevel')); $logfile = get_config('system','logfile'); From c7bfd1e1bae28f2305e2d1d3425052a864a6e251 Mon Sep 17 00:00:00 2001 From: Fabio Comuni Date: Mon, 2 Jan 2012 20:16:28 +0100 Subject: [PATCH 04/10] install: fix install procedure install procedure as a wizard graphical rappresentation of passed/unpassed system checks db connection test don't try anymore to create the db admin email and timezone are asked in a separate pass fix loading of database.sql, removing comments from phpmyadmin export fix check for .htconfig.php writability ask for php-cli path if not found in PATH install_db.tpl use field_* templates to render the form --- mod/install.php | 528 ++++++++++++++++++++++++++------------ view/install.tpl | 10 + view/install_checks.tpl | 24 ++ view/install_db.tpl | 44 ++-- view/install_settings.tpl | 25 ++ 5 files changed, 443 insertions(+), 188 deletions(-) create mode 100644 view/install.tpl create mode 100644 view/install_checks.tpl create mode 100644 view/install_settings.tpl diff --git a/mod/install.php b/mod/install.php index d994ca70fd..f7820fc804 100644 --- a/mod/install.php +++ b/mod/install.php @@ -1,68 +1,99 @@ get_path(); - $dbhost = notags(trim($_POST['dbhost'])); - $dbuser = notags(trim($_POST['dbuser'])); - $dbpass = notags(trim($_POST['dbpass'])); - $dbdata = notags(trim($_POST['dbdata'])); - $timezone = notags(trim($_POST['timezone'])); - $phpath = notags(trim($_POST['phpath'])); - $adminmail = notags(trim($_POST['adminmail'])); - - require_once("dba.php"); - unset($db); - $db = new dba($dbhost, $dbuser, $dbpass, $dbdata, true); - - if(get_db_errno()) { - unset($db); - $db = new dba($dbhost, $dbuser, $dbpass, '', true); - if(! get_db_errno()) { - $r = q("CREATE DATABASE '%s'", - dbesc($dbdata) - ); - if($r) { - unset($db); - $db = new dba($dbhost, $dbuser, $dbpass, $dbdata, true); - } - } - if(get_db_errno()) { - notice( t('Could not create/connect to database.') . EOL); + switch($install_wizard_pass) { + case 1: + case 2: return; - } + break; // just in case return don't return :) + case 3: + $urlpath = $a->get_path(); + $dbhost = notags(trim($_POST['dbhost'])); + $dbuser = notags(trim($_POST['dbuser'])); + $dbpass = notags(trim($_POST['dbpass'])); + $dbdata = notags(trim($_POST['dbdata'])); + $phpath = notags(trim($_POST['phpath'])); + + require_once("dba.php"); + unset($db); + $db = new dba($dbhost, $dbuser, $dbpass, $dbdata, true); + /*if(get_db_errno()) { + unset($db); + $db = new dba($dbhost, $dbuser, $dbpass, '', true); + + if(! get_db_errno()) { + $r = q("CREATE DATABASE '%s'", + dbesc($dbdata) + ); + if($r) { + unset($db); + $db = new dba($dbhost, $dbuser, $dbpass, $dbdata, true); + } else { + $a->data['db_create_failed']=true; + } + } else { + $a->data['db_conn_failed']=true; + return; + } + }*/ + if(get_db_errno()) { + $a->data['db_conn_failed']=true; + } + + return; + break; + case 4; + $urlpath = $a->get_path(); + $dbhost = notags(trim($_POST['dbhost'])); + $dbuser = notags(trim($_POST['dbuser'])); + $dbpass = notags(trim($_POST['dbpass'])); + $dbdata = notags(trim($_POST['dbdata'])); + $phpath = notags(trim($_POST['phpath'])); + $timezone = notags(trim($_POST['timezone'])); + $adminmail = notags(trim($_POST['adminmail'])); + + // connect to db + $db = new dba($dbhost, $dbuser, $dbpass, $dbdata, true); + + $tpl = get_intltext_template('htconfig.tpl'); + $txt = replace_macros($tpl,array( + '$dbhost' => $dbhost, + '$dbuser' => $dbuser, + '$dbpass' => $dbpass, + '$dbdata' => $dbdata, + '$timezone' => $timezone, + '$urlpath' => $urlpath, + '$phpath' => $phpath, + '$adminmail' => $adminmail + )); + + $result = file_put_contents('.htconfig.php', $txt); + if(! $result) { + $a->data['txt'] = $txt; + } + + $errors = load_database($db); + + if($errors) + $a->data['db_failed'] = $errors; + else + $a->data['db_installed'] = true; + + return; + break; } - - info( t('Connected to database.') . EOL); - - $tpl = get_intltext_template('htconfig.tpl'); - $txt = replace_macros($tpl,array( - '$dbhost' => $dbhost, - '$dbuser' => $dbuser, - '$dbpass' => $dbpass, - '$dbdata' => $dbdata, - '$timezone' => $timezone, - '$urlpath' => $urlpath, - '$phpath' => $phpath, - '$adminmail' => $adminmail - )); - - $result = file_put_contents('.htconfig.php', $txt); - if(! $result) { - $a->data['txt'] = $txt; - } - - $errors = load_database($db); - - if($errors) - $a->data['db_failed'] = true; - else - $a->data['db_installed'] = true; - - return; } function get_db_errno() { @@ -74,107 +105,249 @@ function get_db_errno() { function install_content(&$a) { - global $db; + global $install_wizard_pass, $db; $o = ''; + $wizard_status = ""; + $install_title = t('Friendica Social Communications Server - Setup'); + + if(x($a->data,'txt') && strlen($a->data['txt'])) { + $tpl = get_markup_template('install.tpl'); + return replace_macros($tpl, array( + '$title' => $install_title, + '$pass' => t('Database connection'), + '$text' => manual_config($a), + )); + } + + if(x($a->data,'db_conn_failed')) { + $install_wizard_pass = 2; + $wizard_status = t('Could not connect to database.'); + } + if(x($a->data,'db_create_failed')) { + $install_wizard_pass = 2; + $wizard_status = t('Could not create table.'); + } if(x($a->data,'db_installed')) { - $o .= '

' . t('Proceed with Installation') . '

'; - $o .= '

'; - $o .= t('Your Friendica site database has been installed.') . EOL; - $o .= t('IMPORTANT: You will need to [manually] setup a scheduled task for the poller.') . EOL ; - $o .= t('Please see the file "INSTALL.txt".') . EOL ; - $o .= '
'; - $o .= '' . t('Proceed to registration') . '' ; - $o .= '

'; - return $o; + $txt = '

'; + $txt .= t('Your Friendica site database has been installed.') . EOL; + $txt .= t('IMPORTANT: You will need to [manually] setup a scheduled task for the poller.') . EOL ; + $txt .= t('Please see the file "INSTALL.txt".') . EOL ; + $txt .= '
'; + $txt .= '' . t('Proceed to registration') . '' ; + $txt .= '

'; + + $tpl = get_markup_template('install.tpl'); + return replace_macros($tpl, array( + '$title' => $install_title, + '$pass' => t('Proceed with Installation'), + '$text' => $txt, + )); + } if(x($a->data,'db_failed')) { - $o .= t('Database import failed.') . EOL; - $o .= t('You may need to import the file "database.sql" manually using phpmyadmin or mysql.') . EOL; - $o .= t('Please see the file "INSTALL.txt".') . EOL ; - return $o; + $txt = t('You may need to import the file "database.sql" manually using phpmyadmin or mysql.') . EOL; + $txt .= t('Please see the file "INSTALL.txt".') . EOL ."
" ; + $txt .= "
".$a->data['db_failed'] . "
". EOL ; + + $tpl = get_markup_template('install.tpl'); + return replace_macros($tpl, array( + '$title' => $install_title, + '$pass' => t('Database connection'), + '$status' => t('Database import failed.'), + '$text' => $txt, + )); + } if($db && $db->connected) { $r = q("SELECT COUNT(*) as `total` FROM `user`"); if($r && count($r) && $r[0]['total']) { - notice( t('Permission denied.') . EOL); - return ''; + $tpl = get_markup_template('install.tpl'); + return replace_macros($tpl, array( + '$title' => $install_title, + '$pass' => '', + '$status' => t('Permission denied.'), + '$text' => '', + )); } } - info( t('Welcome to Friendica.') . EOL); + switch ($install_wizard_pass){ + case 1: { // System check - check_funcs(); + $checks = array(); - $o .= check_htconfig(); - if(strlen($o)) - return $o; + check_funcs($checks); - if(strlen($a->data['txt'])) { - $o .= manual_config($a); - return; + check_htconfig($checks); + + check_keys($checks); + + if(x($_POST,'phppath')) + $phpath = notags(trim($_POST['phppath'])); + + check_php($phpath, $checks); + + + function check_passed($v, $c){ + if ($c['required']) + $v = $v && $c['status']; + return $v; + } + $checkspassed = array_reduce($checks, "check_passed", true); + + + $tpl = get_markup_template('install_checks.tpl'); + $o .= replace_macros($tpl, array( + '$title' => $install_title, + '$pass' => t('System check'), + '$checks' => $checks, + '$passed' => $checkspassed, + '$see_install' => t('Please see the file "INSTALL.txt".'), + '$next' => t('Next'), + '$reload' => t('Check again'), + '$phpath' => $phpath, + )); + return $o; + }; break; + + case 2: { // Database config + + $dbhost = ((x($_POST,'dbhost')) ? notags(trim($_POST['dbhost'])) : 'localhost'); + $dbuser = notags(trim($_POST['dbuser'])); + $dbpass = notags(trim($_POST['dbpass'])); + $dbdata = notags(trim($_POST['dbdata'])); + $phpath = notags(trim($_POST['phppath'])); + + + $tpl = get_markup_template('install_db.tpl'); + $o .= replace_macros($tpl, array( + '$title' => $install_title, + '$pass' => t('Database connection'), + '$info_01' => t('In order to install Friendica we need to know how to connect to your database.'), + '$info_02' => t('Please contact your hosting provider or site administrator if you have questions about these settings.'), + '$info_03' => t('The database you specify below should already exist. If it does not, please create it before continuing.'), + + '$status' => $wizard_status, + + '$dbhost' => array('dbhost', t('Database Server Name'), $dbhost, ''), + '$dbuser' => array('dbuser', t('Database Login Name'), $dbuser, ''), + '$dbpass' => array('dbpass', t('Database Login Password'), $dbpass, ''), + '$dbdata' => array('dbdata', t('Database Name'), $dbdata, ''), + '$adminmail' => array('adminmail', t('Site administrator email address'), $adminmail, t('Your account email address must match this in order to use the web admin panel.')), + + + + '$lbl_10' => t('Please select a default timezone for your website'), + + '$baseurl' => $a->get_baseurl(), + + '$phpath' => $phpath, + + '$submit' => t('Submit'), + + )); + return $o; + }; break; + case 3: { // Site settings + require_once('datetime.php'); + $dbhost = ((x($_POST,'dbhost')) ? notags(trim($_POST['dbhost'])) : 'localhost'); + $dbuser = notags(trim($_POST['dbuser'])); + $dbpass = notags(trim($_POST['dbpass'])); + $dbdata = notags(trim($_POST['dbdata'])); + $phpath = notags(trim($_POST['phppath'])); + + $adminmail = notags(trim($_POST['adminmail'])); + $timezone = ((x($_POST,'timezone')) ? ($_POST['timezone']) : 'America/Los_Angeles'); + + $tpl = get_markup_template('install_settings.tpl'); + $o .= replace_macros($tpl, array( + '$title' => $install_title, + '$pass' => t('Site settings'), + + '$status' => $wizard_status, + + '$dbhost' => $dbhost, + '$dbuser' => $dbuser, + '$dbpass' => $dbpass, + '$dbdata' => $dbdata, + '$phpath' => $phpath, + + '$adminmail' => array('adminmail', t('Site administrator email address'), $adminmail, t('Your account email address must match this in order to use the web admin panel.')), + + + '$timezone' => field_timezone('timezone', t('Please select a default timezone for your website'), $timezone, ''), + + '$baseurl' => $a->get_baseurl(), + + + + '$submit' => t('Submit'), + + )); + return $o; + }; break; + } - - $o .= check_php($phpath); - - $o .= check_keys(); - - - require_once('datetime.php'); - - $tpl = get_markup_template('install_db.tpl'); - $o .= replace_macros($tpl, array( - '$lbl_01' => t('Friendica Social Communications Server'), - '$lbl_02' => t('Installation'), - '$lbl_03' => t('In order to install Friendica we need to know how to connect to your database.'), - '$lbl_04' => t('Please contact your hosting provider or site administrator if you have questions about these settings.'), - '$lbl_05' => t('The database you specify below should already exist. If it does not, please create it before continuing.'), - '$lbl_06' => t('Database Server Name'), - '$lbl_07' => t('Database Login Name'), - '$lbl_08' => t('Database Login Password'), - '$lbl_09' => t('Database Name'), - '$lbl_10' => t('Please select a default timezone for your website'), - '$lbl_11' => t('Site administrator email address. Your account email address must match this in order to use the web admin panel.'), - '$baseurl' => $a->get_baseurl(), - '$tzselect' => ((x($_POST,'timezone')) ? select_timezone($_POST['timezone']) : select_timezone()), - '$submit' => t('Submit'), - '$dbhost' => ((x($_POST,'dbhost')) ? notags(trim($_POST['dbhost'])) : 'localhost'), - '$dbuser' => notags(trim($_POST['dbuser'])), - '$dbpass' => notags(trim($_POST['dbpass'])), - '$dbdata' => notags(trim($_POST['dbdata'])), - '$phpath' => $phpath, - '$adminmail' => notags(trim($_POST['adminmail'])) - )); - - return $o; } -function check_php(&$phpath) { - $o = ''; - $phpath = trim(shell_exec('which php')); - if(! strlen($phpath)) { - $o .= t('Could not find a command line version of PHP in the web server PATH.') . EOL; - $o .= t('This is required. Please adjust the configuration file .htconfig.php accordingly.') . EOL; +/** + * checks : array passed to template + * title : string + * status : boolean + * required : boolean + * help : string optional + */ +function check_add(&$checks, $title, $status, $required, $help){ + $checks[] = array( + 'title' => $title, + 'status' => $status, + 'required' => $required, + 'help' => $help, + ); +} + +function check_php(&$phpath, &$checks) { + if (strlen($phpath)){ + $passed = file_exists($phpath); + } else { + $phpath = trim(shell_exec('which php')); + $passed = strlen($phpath); } - if(strlen($phpath)) { + $help = ""; + if(!$passed) { + $help .= t('Could not find a command line version of PHP in the web server PATH.'). EOL; + $tpl = get_markup_template('field_input.tpl'); + $help .= replace_macros($tpl, array( + '$field' => array('phppath', t('PHP executable path'), $phpath, t('Enter full path to php executable')), + )); + $phpath=""; + } + + check_add($checks, t('Command line PHP'), $passed, true, $help); + + if($passed) { $str = autoname(8); $cmd = "$phpath testargs.php $str"; $result = trim(shell_exec($cmd)); - if($result != $str) { - $o .= t('The command line version of PHP on your system does not have "register_argc_argv" enabled.') . EOL; - $o .= t('This is required for message delivery to work.') . EOL; + $passed2 = $result == $str; + $help = ""; + if(!$passed2) { + $help .= t('The command line version of PHP on your system does not have "register_argc_argv" enabled.'). EOL; + $help .= t('This is required for message delivery to work.'); } + check_add($checks, t('PHP "register_argc_argv"'), $passed, true, $help); } - return $o; + } -function check_keys() { +function check_keys(&$checks) { - $o = ''; + $help = ''; $res = false; @@ -187,45 +360,73 @@ function check_keys() { // Get private key if(! $res) { - $o .= t('Error: the "openssl_pkey_new" function on this system is not able to generate encryption keys') . EOL; - $o .= t('If running under Windows, please see "http://www.php.net/manual/en/openssl.installation.php".') . EOL; + $help .= t('Error: the "openssl_pkey_new" function on this system is not able to generate encryption keys'). EOL; + $help .= t('If running under Windows, please see "http://www.php.net/manual/en/openssl.installation.php".'); } - return $o; + check_add($checks, t('Generate encryption keys'), $res, true, $help); } -function check_funcs() { - if((function_exists('apache_get_modules')) && (! in_array('mod_rewrite',apache_get_modules()))) - notice( t('Error: Apache webserver mod-rewrite module is required but not installed.') . EOL); - if(! function_exists('curl_init')) - notice( t('Error: libCURL PHP module required but not installed.') . EOL); - if(! function_exists('imagecreatefromjpeg')) - notice( t('Error: GD graphics PHP module with JPEG support required but not installed.') . EOL); - if(! function_exists('openssl_public_encrypt')) - notice( t('Error: openssl PHP module required but not installed.') . EOL); - if(! function_exists('mysqli_connect')) - notice( t('Error: mysqli PHP module required but not installed.') . EOL); - if(! function_exists('mb_strlen')) - notice( t('Error: mb_string PHP module required but not installed.') . EOL); +function check_funcs(&$checks) { + $ck_funcs = array(); + check_add($ck_funcs, t('libCurl PHP module'), true, true, ""); + check_add($ck_funcs, t('GD graphics PHP module'), true, true, ""); + check_add($ck_funcs, t('OpenSSL PHP module'), true, true, ""); + check_add($ck_funcs, t('mysqli PHP module'), true, true, ""); + check_add($ck_funcs, t('mb_string PHP module'), true, true, ""); + - if((x($_SESSION,'sysmsg')) && is_array($_SESSION['sysmsg']) && count($_SESSION['sysmsg'])) - notice( t('Please see the file "INSTALL.txt".') . EOL); + if(function_exists('apache_get_modules')){ + if (! in_array('mod_rewrite',apache_get_modules())) { + check_add($ck_funcs, t('Apace mod_rewrite module'), false, true, t('Error: Apache webserver mod-rewrite module is required but not installed.')); + } else { + check_add($ck_funcs, t('Apace mod_rewrite module'), true, true, ""); + } + } + if(! function_exists('curl_init')){ + $ck_funcs[0]['status']= false; + $ck_funcs[0]['help']= t('Error: libCURL PHP module required but not installed.'); + } + if(! function_exists('imagecreatefromjpeg')){ + $ck_funcs[1]['status']= false; + $ck_funcs[1]['help']= t('Error: GD graphics PHP module with JPEG support required but not installed.'); + } + if(! function_exists('openssl_public_encrypt')) { + $ck_funcs[2]['status']= false; + $ck_funcs[2]['help']= t('Error: openssl PHP module required but not installed.'); + } + if(! function_exists('mysqli_connect')){ + $ck_funcs[3]['status']= false; + $ck_funcs[3]['help']= t('Error: mysqli PHP module required but not installed.'); + } + if(! function_exists('mb_strlen')){ + $ck_funcs[4]['status']= false; + $ck_funcs[4]['help']= t('Error: mb_string PHP module required but not installed.'); + } + + $checks = array_merge($checks, $ck_funcs); + + /*if((x($_SESSION,'sysmsg')) && is_array($_SESSION['sysmsg']) && count($_SESSION['sysmsg'])) + notice( t('Please see the file "INSTALL.txt".') . EOL);*/ } -function check_htconfig() { - - if(((file_exists('.htconfig.php')) && (! is_writable('.htconfig.php'))) - || (! is_writable('.'))) { - - $o = t('The web installer needs to be able to create a file called ".htconfig.php" in the top folder of your web server and it is unable to do so.'); - $o .= t('This is most often a permission setting, as the web server may not be able to write files in your folder - even if you can.'); - $o .= t('Please check with your site documentation or support people to see if this situation can be corrected.'); - $o .= t('If not, you may be required to perform a manual installation. Please see the file "INSTALL.txt" for instructions.'); +function check_htconfig(&$checks) { + $status = true; + $help = ""; + if( (file_exists('.htconfig.php') && !is_writable('.htconfig.php')) || + (!file_exists('.htconfig.php') && !is_writable('.')) ) { + + $status=false; + $help = t('The web installer needs to be able to create a file called ".htconfig.php" in the top folder of your web server and it is unable to do so.') .EOL; + $help .= t('This is most often a permission setting, as the web server may not be able to write files in your folder - even if you can.').EOL; + $help .= t('Please check with your site documentation or support people to see if this situation can be corrected.').EOL; + $help .= t('If not, you may be required to perform a manual installation. Please see the file "INSTALL.txt" for instructions.').EOL; } - return $o; + check_add($checks, t('.htconfig.php is writable'), $status, true, $help); + } @@ -236,18 +437,27 @@ function manual_config(&$a) { return $o; } +function load_database_rem($v, $i){ + $l = trim($i); + if (strlen($l)>1 && ($l[0]=="-" || ($l[0]=="/" && $l[1]=="*"))){ + return $v; + } else { + return $v."\n".$i; + } +} + function load_database($db) { $str = file_get_contents('database.sql'); + $str = array_reduce(explode("\n", $str),"load_database_rem",""); $arr = explode(';',$str); - $errors = 0; + $errors = false; foreach($arr as $a) { if(strlen(trim($a))) { $r = @$db->q(trim($a)); if(! $r) { - notice( t('Errors encountered creating database tables.') . $a . EOL); - $errors ++; + $errors .= t('Errors encountered creating database tables.') . $a . EOL; } } } diff --git a/view/install.tpl b/view/install.tpl new file mode 100644 index 0000000000..b3a5f46fff --- /dev/null +++ b/view/install.tpl @@ -0,0 +1,10 @@ + +

$title

+

$pass

+ + +{{ if $status }} +

$status

+{{ endif }} + +$text diff --git a/view/install_checks.tpl b/view/install_checks.tpl new file mode 100644 index 0000000000..538bdf0baf --- /dev/null +++ b/view/install_checks.tpl @@ -0,0 +1,24 @@ +

$title

+

$pass

+
+ +{{ for $checks as $check }} + + {{if $check.help }} + + {{endif}} +{{ endfor }} +
$check.title {{if $check.required}}(required){{endif}}
$check.help
+ +{{ if $phpath }} + +{{ endif }} + +{{ if $passed }} + + +{{ else }} + + +{{ endif }} +
diff --git a/view/install_db.tpl b/view/install_db.tpl index ff4e11ab16..7e2acdca57 100644 --- a/view/install_db.tpl +++ b/view/install_db.tpl @@ -1,44 +1,30 @@ -

$lbl_01

-

$lbl_02

+

$title

+

$pass

+

-$lbl_03 $lbl_04 $lbl_05 +$info_01
+$info_02
+$info_03

+{{ if $status }} +

$status

+{{ endif }} +
+ - - -
+{{ inc field_input.tpl with $field=$dbhost }}{{endinc}} +{{ inc field_input.tpl with $field=$dbuser }}{{endinc}} +{{ inc field_input.tpl with $field=$dbpass }}{{endinc}} +{{ inc field_input.tpl with $field=$dbdata }}{{endinc}} - - -
- - -
- - - -
- - - -
- -
-$lbl_10 -
- -$tzselect - -
-
diff --git a/view/install_settings.tpl b/view/install_settings.tpl new file mode 100644 index 0000000000..05b87f904e --- /dev/null +++ b/view/install_settings.tpl @@ -0,0 +1,25 @@ + +

$title

+

$pass

+ + +{{ if $status }} +

$status

+{{ endif }} + +
+ + + + + + + + +{{ inc field_input.tpl with $field=$adminmail }}{{endinc}} +$timezone + + + +
+ From 3f2a492ce799e6328b9a52150319d303727df21b Mon Sep 17 00:00:00 2001 From: friendica Date: Mon, 2 Jan 2012 13:59:50 -0800 Subject: [PATCH 05/10] revup --- boot.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/boot.php b/boot.php index 2f32130f5d..fe84913320 100644 --- a/boot.php +++ b/boot.php @@ -9,7 +9,7 @@ require_once('include/nav.php'); require_once('include/cache.php'); define ( 'FRIENDICA_PLATFORM', 'Friendica'); -define ( 'FRIENDICA_VERSION', '2.3.1213' ); +define ( 'FRIENDICA_VERSION', '2.3.1214' ); define ( 'DFRN_PROTOCOL_VERSION', '2.22' ); define ( 'DB_UPDATE_VERSION', 1114 ); From 4c35a6b0d7e2f2431571d63888816ecff446d258 Mon Sep 17 00:00:00 2001 From: friendica Date: Mon, 2 Jan 2012 16:54:37 -0800 Subject: [PATCH 06/10] conversation sql optimisations --- include/conversation.php | 59 ++++++++++++++++++++++++++++++++++++++++ mod/network.php | 30 +++++--------------- mod/profile.php | 11 ++++---- 3 files changed, 72 insertions(+), 28 deletions(-) diff --git a/include/conversation.php b/include/conversation.php index fae57c5655..d40b2ea7e8 100644 --- a/include/conversation.php +++ b/include/conversation.php @@ -884,3 +884,62 @@ function status_editor($a,$x, $notes_cid = 0) { return $o; } + + +function conv_sort($arr,$order) { + + if((!(is_array($arr) && count($arr)))) + return array(); + + $parents = array(); + + foreach($arr as $x) + if($x['id'] == $x['parent']) + $parents[] = $x; + + if(stristr($order,'created')) + usort($parents,'sort_thr_created'); + elseif(stristr($order,'commented')) + usort($parents,'sort_thr_commented'); + + foreach($parents as $x) + $x['children'] = array(); + + foreach($arr as $x) { + if($x['id'] != $x['parent']) { + $p = find_thread_parent_index($parents,$x); + $parents[$p]['children'][] = $x; + } + } + foreach($parents as $x) + if(count($x['children'])) + usort($x['children'],'sort_thr_created_rev'); + + $ret = array(); + foreach($parents as $x) { + $ret[] = $x; + foreach($x['children'] as $y) + $ret[] = $y; + } + + return $ret; +} + + +function sort_thr_created($a,$b) { + return strcmp($b['created'],$a['created']); +} + +function sort_thr_created_rev($a,$b) { + return strcmp($a['created'],$b['created']); +} + +function sort_thr_commented($a,$b) { + return strcmp($b['commented'],$a['commented']); +} + +function find_thread_parent_index($arr,$x) { + foreach($arr as $k => $v) + if($v['id'] == $x['parent']) + return $k; +} \ No newline at end of file diff --git a/mod/network.php b/mod/network.php index 55f5a8c95a..b493c419b0 100644 --- a/mod/network.php +++ b/mod/network.php @@ -15,14 +15,6 @@ function network_init(&$a) { $search = ((x($_GET,'search')) ? escape_tags($_GET['search']) : ''); - // We need a better way of managing a growing argument list - - // moved into savedsearches() - // $srchurl = '/network' - // . ((x($_GET,'cid')) ? '?cid=' . $_GET['cid'] : '') - // . ((x($_GET,'star')) ? '?star=' . $_GET['star'] : '') - // . ((x($_GET,'bmark')) ? '?bmark=' . $_GET['bmark'] : ''); - if(x($_GET,'save')) { $r = q("select * from `search` where `uid` = %d and `term` = '%s' limit 1", intval(local_user()), @@ -46,14 +38,10 @@ function network_init(&$a) { // search terms header if(x($_GET,'search')) { - $a->page['content'] .= '

Search Results For: ' . $search . '

'; + $a->page['content'] .= '

' . t('Search Results For:') . ' ' . $search . '

'; } $a->page['aside'] .= group_side('network','network',true,$group_id); - - // moved to saved searches to have it in the same div - //$a->page['aside'] .= search($search,'netsearch-box',$srchurl,true); - $a->page['aside'] .= saved_searches($search); } @@ -275,12 +263,6 @@ function network_content(&$a, $update = 0) { $sql_options = (($star) ? " and starred = 1 " : ''); $sql_options .= (($bmark) ? " and bookmark = 1 " : ''); - - $sql_new = ''; - $sql_items = ''; - $sql_update = ''; - - $sql_extra = " AND `item`.`parent` IN ( SELECT `parent` FROM `item` WHERE `id` = `parent` $sql_options ) "; if($group) { @@ -467,16 +449,18 @@ function network_content(&$a, $update = 0) { `contact`.`name`, `contact`.`photo`, `contact`.`url`, `contact`.`rel`, `contact`.`writable`, `contact`.`network`, `contact`.`thumb`, `contact`.`dfrn-id`, `contact`.`self`, `contact`.`id` AS `cid`, `contact`.`uid` AS `contact-uid` - FROM `item`, (SELECT `p`.`id`,`p`.`created`,`p`.`commented` FROM `item` AS `p` WHERE `p`.`parent`=`p`.`id`) as `parentitem`, `contact` + FROM `item`, `contact` WHERE `item`.`uid` = %d AND `item`.`visible` = 1 AND `item`.`deleted` = 0 AND `contact`.`id` = `item`.`contact-id` AND `contact`.`blocked` = 0 AND `contact`.`pending` = 0 - AND `item`.`parent` = `parentitem`.`id` AND `item`.`parent` IN ( %s ) - $sql_extra - ORDER BY `parentitem`.$ordering DESC, `parentitem`.`id` ASC, `item`.`gravity` ASC, `item`.`created` ASC ", + AND `item`.`parent` IN ( %s ) + $sql_extra ", intval(local_user()), dbesc($parents_str) ); + + $items = conv_sort($items,$ordering); + } } diff --git a/mod/profile.php b/mod/profile.php index 946499895b..90a609d036 100644 --- a/mod/profile.php +++ b/mod/profile.php @@ -167,7 +167,7 @@ function profile_content(&$a, $update = 0) { $r = q("SELECT distinct(parent) AS `item_id`, `contact`.`uid` AS `contact-uid` FROM `item` LEFT JOIN `contact` ON `contact`.`id` = `item`.`contact-id` WHERE `item`.`uid` = %d AND `item`.`visible` = 1 AND `item`.`deleted` = 0 - and `item`.`parent` in (select parent from item where unseen = 1 ) + and `item`.`unseen` = 1 AND `contact`.`blocked` = 0 AND `contact`.`pending` = 0 AND `item`.`wall` = 1 $sql_extra @@ -218,18 +218,19 @@ function profile_content(&$a, $update = 0) { `contact`.`name`, `contact`.`photo`, `contact`.`url`, `contact`.`network`, `contact`.`rel`, `contact`.`thumb`, `contact`.`self`, `contact`.`writable`, `contact`.`id` AS `cid`, `contact`.`uid` AS `contact-uid` - FROM `item`, (SELECT `p`.`id`,`p`.`created` FROM `item` AS `p` WHERE `p`.`parent` = `p`.`id`) AS `parentitem`, `contact` + FROM `item`, `contact` WHERE `item`.`uid` = %d AND `item`.`visible` = 1 AND `item`.`deleted` = 0 AND `contact`.`id` = `item`.`contact-id` AND `contact`.`blocked` = 0 AND `contact`.`pending` = 0 - AND `item`.`parent` = `parentitem`.`id` AND `item`.`parent` IN ( %s ) - $sql_extra - ORDER BY `parentitem`.`created` DESC, `gravity` ASC, `item`.`created` ASC ", + AND `item`.`parent` IN ( %s ) + $sql_extra ", intval($a->profile['profile_uid']), dbesc($parents_str) ); } + $items = conv_sort($items,'created'); + if($is_owner && ! $update) { $o .= get_birthdays(); $o .= get_events(); From f4b1d335a571365748ee348ed2b8ac6e1c6670db Mon Sep 17 00:00:00 2001 From: friendica Date: Mon, 2 Jan 2012 18:40:38 -0800 Subject: [PATCH 07/10] sql optimisation cont. --- include/bbcode.php | 2 +- mod/network.php | 9 ++++----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/include/bbcode.php b/include/bbcode.php index 5218a06e85..6b733c8f43 100644 --- a/include/bbcode.php +++ b/include/bbcode.php @@ -27,7 +27,7 @@ function tryoembed($match){ // BBcode 2 HTML was written by WAY2WEB.net - // extended to work with Mistpark/Friendika - Mike Macgirvin + // extended to work with Mistpark/Friendica - Mike Macgirvin function bbcode($Text,$preserve_nl = false) { diff --git a/mod/network.php b/mod/network.php index b493c419b0..6f53a24f80 100644 --- a/mod/network.php +++ b/mod/network.php @@ -263,7 +263,7 @@ function network_content(&$a, $update = 0) { $sql_options = (($star) ? " and starred = 1 " : ''); $sql_options .= (($bmark) ? " and bookmark = 1 " : ''); - $sql_extra = " AND `item`.`parent` IN ( SELECT `parent` FROM `item` WHERE `id` = `parent` $sql_options ) "; + $sql_extra = $sql_options; if($group) { $r = q("SELECT `name`, `id` FROM `group` WHERE `id` = %d AND `uid` = %d LIMIT 1", @@ -287,7 +287,7 @@ function network_content(&$a, $update = 0) { info( t('Group is empty')); } - $sql_extra = " AND `item`.`parent` IN ( SELECT DISTINCT(`parent`) FROM `item` WHERE 1 $sql_options AND ( `contact-id` IN ( $contact_str ) OR `allow_gid` REGEXP '<" . intval($group) . ">' )) "; + $sql_extra = " AND ( `contact-id` IN ( $contact_str ) OR `allow_gid` REGEXP '<" . intval($group) . ">' ) $sql_options "; $o = '

' . t('Group: ') . $r[0]['name'] . '

' . $o; } elseif($cid) { @@ -297,7 +297,7 @@ function network_content(&$a, $update = 0) { intval($cid) ); if(count($r)) { - $sql_extra = " AND `item`.`parent` IN ( SELECT DISTINCT(`parent`) FROM `item` WHERE 1 $sql_options AND `contact-id` = " . intval($cid) . " ) "; + $sql_extra = " AND `contact-id` = " . intval($cid) . " $sql_options "; $o = '

' . t('Contact: ') . $r[0]['name'] . '

' . $o; if($r[0]['network'] === NETWORK_OSTATUS && $r[0]['writable'] && (! get_pconfig(local_user(),'system','nowarn_insecure'))) { notice( t('Private messages to this person are at risk of public disclosure.') . EOL); @@ -350,14 +350,13 @@ function network_content(&$a, $update = 0) { $myurl = substr($myurl,strpos($myurl,'://')+3); $myurl = str_replace(array('www.','.'),array('','\\.'),$myurl); $diasp_url = str_replace('/profile/','/u/',$myurl); - $sql_extra .= sprintf(" AND `item`.`parent` IN (SELECT distinct(`parent`) from item where ( `author-link` regexp '%s' or `tag` regexp '%s' or tag regexp '%s' )) ", + $sql_extra .= sprintf(" AND ( `author-link` regexp '%s' or `tag` regexp '%s' or tag regexp '%s' ) ", dbesc($myurl . '$'), dbesc($myurl . '\\]'), dbesc($diasp_url . '\\]') ); } - if($update) { // only setup pagination on initial page view From 71377291babfb74c238e074a270a3f50679103bf Mon Sep 17 00:00:00 2001 From: friendica Date: Mon, 2 Jan 2012 18:50:28 -0800 Subject: [PATCH 08/10] that didn't work - revert --- mod/network.php | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/mod/network.php b/mod/network.php index 6f53a24f80..b493c419b0 100644 --- a/mod/network.php +++ b/mod/network.php @@ -263,7 +263,7 @@ function network_content(&$a, $update = 0) { $sql_options = (($star) ? " and starred = 1 " : ''); $sql_options .= (($bmark) ? " and bookmark = 1 " : ''); - $sql_extra = $sql_options; + $sql_extra = " AND `item`.`parent` IN ( SELECT `parent` FROM `item` WHERE `id` = `parent` $sql_options ) "; if($group) { $r = q("SELECT `name`, `id` FROM `group` WHERE `id` = %d AND `uid` = %d LIMIT 1", @@ -287,7 +287,7 @@ function network_content(&$a, $update = 0) { info( t('Group is empty')); } - $sql_extra = " AND ( `contact-id` IN ( $contact_str ) OR `allow_gid` REGEXP '<" . intval($group) . ">' ) $sql_options "; + $sql_extra = " AND `item`.`parent` IN ( SELECT DISTINCT(`parent`) FROM `item` WHERE 1 $sql_options AND ( `contact-id` IN ( $contact_str ) OR `allow_gid` REGEXP '<" . intval($group) . ">' )) "; $o = '

' . t('Group: ') . $r[0]['name'] . '

' . $o; } elseif($cid) { @@ -297,7 +297,7 @@ function network_content(&$a, $update = 0) { intval($cid) ); if(count($r)) { - $sql_extra = " AND `contact-id` = " . intval($cid) . " $sql_options "; + $sql_extra = " AND `item`.`parent` IN ( SELECT DISTINCT(`parent`) FROM `item` WHERE 1 $sql_options AND `contact-id` = " . intval($cid) . " ) "; $o = '

' . t('Contact: ') . $r[0]['name'] . '

' . $o; if($r[0]['network'] === NETWORK_OSTATUS && $r[0]['writable'] && (! get_pconfig(local_user(),'system','nowarn_insecure'))) { notice( t('Private messages to this person are at risk of public disclosure.') . EOL); @@ -350,13 +350,14 @@ function network_content(&$a, $update = 0) { $myurl = substr($myurl,strpos($myurl,'://')+3); $myurl = str_replace(array('www.','.'),array('','\\.'),$myurl); $diasp_url = str_replace('/profile/','/u/',$myurl); - $sql_extra .= sprintf(" AND ( `author-link` regexp '%s' or `tag` regexp '%s' or tag regexp '%s' ) ", + $sql_extra .= sprintf(" AND `item`.`parent` IN (SELECT distinct(`parent`) from item where ( `author-link` regexp '%s' or `tag` regexp '%s' or tag regexp '%s' )) ", dbesc($myurl . '$'), dbesc($myurl . '\\]'), dbesc($diasp_url . '\\]') ); } + if($update) { // only setup pagination on initial page view From 0db637bf006ba1869ee72239c7d9964894cdf575 Mon Sep 17 00:00:00 2001 From: friendica Date: Mon, 2 Jan 2012 19:33:26 -0800 Subject: [PATCH 09/10] hopefully this will speed up the network updates a wee bit more --- mod/network.php | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/mod/network.php b/mod/network.php index b493c419b0..397a701da4 100644 --- a/mod/network.php +++ b/mod/network.php @@ -263,7 +263,11 @@ function network_content(&$a, $update = 0) { $sql_options = (($star) ? " and starred = 1 " : ''); $sql_options .= (($bmark) ? " and bookmark = 1 " : ''); - $sql_extra = " AND `item`.`parent` IN ( SELECT `parent` FROM `item` WHERE `id` = `parent` $sql_options ) "; + // We'll need the following line if starred/bookmarks are allowed in comments in the future + // $sql_extra = " AND `item`.`parent` IN ( SELECT `parent` FROM `item` WHERE `id` = `parent` $sql_options ) "; + + // Otherwise, this is a bit faster: + $sql_extra = $sql_options; if($group) { $r = q("SELECT `name`, `id` FROM `group` WHERE `id` = %d AND `uid` = %d LIMIT 1", @@ -414,7 +418,7 @@ function network_content(&$a, $update = 0) { // Fetch a page full of parent items for this page if($update) { - $r = q("SELECT distinct(`parent`) AS `item_id`, `contact`.`uid` AS `contact_uid` + $r = q("SELECT `parent` AS `item_id`, `contact`.`uid` AS `contact_uid` FROM `item` LEFT JOIN `contact` ON `contact`.`id` = `item`.`contact-id` WHERE `item`.`uid` = %d AND `item`.`visible` = 1 AND `item`.`deleted` = 0 and `item`.`unseen` = 1 @@ -442,7 +446,8 @@ function network_content(&$a, $update = 0) { if(count($r)) { foreach($r as $rr) - $parents_arr[] = $rr['item_id']; + if(! array_key_exists($rr['item_id'],$parents_arr)) + $parents_arr[] = $rr['item_id']; $parents_str = implode(', ', $parents_arr); $items = q("SELECT `item`.*, `item`.`id` AS `item_id`, From 184230e06826117b1d87241e3acdf19935470e8f Mon Sep 17 00:00:00 2001 From: friendica Date: Mon, 2 Jan 2012 22:58:09 -0800 Subject: [PATCH 10/10] check count before foreach --- include/conversation.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/conversation.php b/include/conversation.php index d40b2ea7e8..f4432bfd97 100644 --- a/include/conversation.php +++ b/include/conversation.php @@ -918,8 +918,9 @@ function conv_sort($arr,$order) { $ret = array(); foreach($parents as $x) { $ret[] = $x; - foreach($x['children'] as $y) - $ret[] = $y; + if(count($x['children'])) + foreach($x['children'] as $y) + $ret[] = $y; } return $ret;