From 8c1e2b9800db082599aa7d29faa66e6c66e676bb Mon Sep 17 00:00:00 2001 From: Hypolite Petovan Date: Sun, 27 Dec 2020 21:15:21 -0500 Subject: [PATCH] Throw exception when item doesn't exist in Factory\Api\Mastodon\Status->createFromUriId - Address https://github.com/friendica/friendica/issues/9250#issuecomment-750464977 --- src/Factory/Api/Mastodon/Status.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Factory/Api/Mastodon/Status.php b/src/Factory/Api/Mastodon/Status.php index cd468a5fbd..e1c11de6cb 100644 --- a/src/Factory/Api/Mastodon/Status.php +++ b/src/Factory/Api/Mastodon/Status.php @@ -61,6 +61,10 @@ class Status extends BaseFactory public function createFromUriId(int $uriId, $uid = 0) { $item = Item::selectFirst([], ['uri-id' => $uriId, 'uid' => $uid]); + if (!$item) { + throw new HTTPException\NotFoundException('Item with URI ID ' . $uriId . 'not found' . ($uid ? ' for user ' . $uid : '.')); + } + $account = DI::mstdnAccount()->createFromContactId($item['author-id']); $counts = new \Friendica\Object\Api\Mastodon\Status\Counts(