diff --git a/src/Core/Update.php b/src/Core/Update.php index a4c5cf313e..2718d03d0c 100644 --- a/src/Core/Update.php +++ b/src/Core/Update.php @@ -129,20 +129,6 @@ class Update DI::lock()->release('dbupdate', true); } - if (!DBStructure::existsTable('config')) { - DBA::e(<<get('system', 'build'); if (empty($build)) { diff --git a/src/Core/Worker/Cron.php b/src/Core/Worker/Cron.php index d0b915f87a..dcb9fd3ab4 100644 --- a/src/Core/Worker/Cron.php +++ b/src/Core/Worker/Cron.php @@ -197,7 +197,7 @@ class Cron // Optimizing this table only last seconds if (DI::config()->get('system', 'optimize_tables')) { Logger::info('Optimize start'); - DBA::e("OPTIMIZE TABLE `post-delivery`"); + DBA::optimizeTable('post-delivery'); Logger::info('Optimize end'); } } diff --git a/src/Database/DBStructure.php b/src/Database/DBStructure.php index dc1e785a50..3141ca666b 100644 --- a/src/Database/DBStructure.php +++ b/src/Database/DBStructure.php @@ -57,6 +57,18 @@ class DBStructure echo DI::l10n()->t('The database version had been set to %s.', $version); } + /** + * Dops a specific table + * + * @param string $table the table name + * + * @return bool true if possible, otherwise false + */ + public static function dropTable(string $table): bool + { + return DBA::isResult(DBA::e('DROP TABLE ' . DBA::quoteIdentifier($table) . ';')); + } + /** * Drop unused tables * @@ -94,8 +106,7 @@ class DBStructure $sql = 'DROP TABLE ' . DBA::quoteIdentifier($table) . ';'; echo $sql . "\n"; - $result = DBA::e($sql); - if (!DBA::isResult($result)) { + if (!static::dropTable($table)) { self::printUpdateError($sql); } } else {