From 7ca47e8d213241f1b9cc00df61b418bb960adc2f Mon Sep 17 00:00:00 2001
From: Philipp <admin@philipp.info>
Date: Sat, 4 Dec 2021 23:24:56 +0100
Subject: [PATCH] Re enable Blocks/Lists test

---
 src/Module/Api/Twitter/Blocks/Lists.php       |  2 +-
 .../Twitter/Account/RateLimitStatusTest.php   |  3 +-
 .../Module/Api/Twitter/Blocks/ListsTest.php   | 28 +++++++++----------
 3 files changed, 17 insertions(+), 16 deletions(-)

diff --git a/src/Module/Api/Twitter/Blocks/Lists.php b/src/Module/Api/Twitter/Blocks/Lists.php
index 1260b9c7bd..44ffe00248 100644
--- a/src/Module/Api/Twitter/Blocks/Lists.php
+++ b/src/Module/Api/Twitter/Blocks/Lists.php
@@ -87,6 +87,6 @@ class Lists extends ContactEndpoint
 
 		self::setLinkHeader();
 
-		System::jsonExit($return);
+		$this->response->exit('lists', ['lists' => $return]);
 	}
 }
diff --git a/tests/src/Module/Api/Twitter/Account/RateLimitStatusTest.php b/tests/src/Module/Api/Twitter/Account/RateLimitStatusTest.php
index 64becb75c5..1368990d08 100644
--- a/tests/src/Module/Api/Twitter/Account/RateLimitStatusTest.php
+++ b/tests/src/Module/Api/Twitter/Account/RateLimitStatusTest.php
@@ -2,6 +2,7 @@
 
 namespace Friendica\Test\src\Module\Api\Twitter\Account;
 
+use Friendica\App\Router;
 use Friendica\Capabilities\ICanCreateResponses;
 use Friendica\DI;
 use Friendica\Module\Api\Twitter\Account\RateLimitStatus;
@@ -11,7 +12,7 @@ class RateLimitStatusTest extends ApiTest
 {
 	public function testWithJson()
 	{
-		$rateLimitStatus = new RateLimitStatus(DI::app(), DI::l10n(), DI::baseUrl(), DI::args(), DI::logger(), DI::profiler(), DI::apiResponse(), [], ['extension' => 'json']);
+		$rateLimitStatus = new RateLimitStatus(DI::app(), DI::l10n(), DI::baseUrl(), DI::args(), DI::logger(), DI::profiler(), DI::apiResponse(), ['REQUEST_METHOD' => Router::GET], ['extension' => 'json']);
 		$response = $rateLimitStatus->run();
 
 		$result = json_decode($response->getBody());
diff --git a/tests/src/Module/Api/Twitter/Blocks/ListsTest.php b/tests/src/Module/Api/Twitter/Blocks/ListsTest.php
index 9783a51e47..4f63581a70 100644
--- a/tests/src/Module/Api/Twitter/Blocks/ListsTest.php
+++ b/tests/src/Module/Api/Twitter/Blocks/ListsTest.php
@@ -2,30 +2,28 @@
 
 namespace Friendica\Test\src\Module\Api\Twitter\Blocks;
 
+use Friendica\App\Router;
+use Friendica\DI;
+use Friendica\Module\Api\Twitter\Blocks\Lists;
 use Friendica\Test\src\Module\Api\ApiTest;
 
 class ListsTest extends ApiTest
 {
 	/**
 	 * Test the api_statuses_f() function.
-	 *
-	 * @return void
 	 */
 	public function testApiStatusesFWithBlocks()
 	{
-		// $result = api_statuses_f('blocks');
-		// self::assertArrayHasKey('user', $result);
-	}
+		$lists    = new Lists(DI::app(), DI::l10n(), DI::baseUrl(), DI::args(), DI::logger(), DI::profiler(), DI::apiResponse(), ['REQUEST_METHOD' => Router::GET]);
+		$response = $lists->run();
 
-	/**
-	 * Test the api_blocks_list() function.
-	 *
-	 * @return void
-	 */
-	public function testApiBlocksList()
-	{
-		// $result = api_blocks_list('json');
-		// self::assertArrayHasKey('user', $result);
+		$body = (string)$response->getBody();
+
+		self::assertJson($body);
+
+		$json = json_decode($body);
+
+		self::assertIsArray($json->users);
 	}
 
 	/**
@@ -35,6 +33,8 @@ class ListsTest extends ApiTest
 	 */
 	public function testApiBlocksListWithUndefinedCursor()
 	{
+		self::markTestIncomplete('Needs refactoring of Lists - replace filter_input() with $request parameter checks');
+
 		// $_GET['cursor'] = 'undefined';
 		// self::assertFalse(api_blocks_list('json'));
 	}