From 65cb77b6a03cb79b85b203fbe00ddbe175257726 Mon Sep 17 00:00:00 2001 From: Hypolite Petovan Date: Mon, 27 Jan 2020 21:56:50 -0500 Subject: [PATCH] Fix wrong use of DPA::p return value in Module\NoScrape - Address https://github.com/friendica/friendica/issues/7998#issuecomment-579036775 --- src/Module/NoScrape.php | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/src/Module/NoScrape.php b/src/Module/NoScrape.php index 99b55f273d..27bf7a95cc 100644 --- a/src/Module/NoScrape.php +++ b/src/Module/NoScrape.php @@ -69,11 +69,20 @@ class NoScrape extends BaseModule $json_info['language'] = $a->profile['language']; if (!($a->profile['hide-friends'] ?? false)) { - /// @todo What should this value tell us? - $result = DBA::p("SELECT `gcontact`.`updated` FROM `contact` INNER JOIN `gcontact` WHERE `gcontact`.`nurl` = `contact`.`nurl` AND `self` AND `uid` = ? LIMIT 1", intval($a->profile['uid'])); - if (DBA::isResult($result)) { - $json_info["updated"] = date("c", strtotime($result[0]['updated'])); + $stmt = DBA::p( + "SELECT `gcontact`.`updated` + FROM `contact` + INNER JOIN `gcontact` + WHERE `gcontact`.`nurl` = `contact`.`nurl` + AND `self` + AND `uid` = ? + LIMIT 1", + intval($a->profile['uid']) + ); + if ($gcontact = DBA::fetch($stmt)) { + $json_info["updated"] = date("c", strtotime($gcontact['updated'])); } + DBA::close($stmt); $json_info['contacts'] = DBA::count('contact', [