From 14dff6b0e0c5ff43df8b2cd8da440bdeaf2b3384 Mon Sep 17 00:00:00 2001 From: FlxAlbroscheit Date: Sat, 7 Nov 2015 18:53:32 +0100 Subject: [PATCH 1/6] Preview last five conversations in message-sidebar --- mod/message.php | 133 +++++++++++++++++++++++++++--------------------- 1 file changed, 76 insertions(+), 57 deletions(-) diff --git a/mod/message.php b/mod/message.php index 1331ce7fb5..2a64c2e051 100644 --- a/mod/message.php +++ b/mod/message.php @@ -4,7 +4,12 @@ require_once('include/acl_selectors.php'); require_once('include/message.php'); function message_init(&$a) { - $tabs = array(); + + $tabs = ''; + + if (is_numeric($a->argv[1])) + $tabs = render_messages(get_messages(local_user(),0,5), 'mail_list.tpl'); + $new = array( 'label' => t('New Message'), 'url' => $a->get_baseurl(true) . '/message/new', @@ -55,7 +60,7 @@ function message_post(&$a) { if(! $plaintext) { $body = fix_mce_lf($body); } - + $ret = send_message($recipient, $body, $subject, $replyto); $norecip = false; @@ -246,8 +251,8 @@ function message_content(&$a) { // remove diaspora conversation pointer // Actually if we do this, we can never receive another reply to that conversation, - // as we will never again have the info we need to re-create it. - // We'll just have to orphan it. + // as we will never again have the info we need to re-create it. + // We'll just have to orphan it. //if($convid) { // q("delete from conv where id = %d limit 1", @@ -344,75 +349,29 @@ function message_content(&$a) { if($a->argc == 1) { - // list messages + // List messages $o .= $header; - $r = q("SELECT count(*) AS `total` FROM `mail` WHERE `mail`.`uid` = %d GROUP BY `parent-uri` ORDER BY `created` DESC", intval(local_user()), dbesc($myprofile) ); - if(count($r)) - $a->set_pager_total($r[0]['total']); - $r = q("SELECT max(`mail`.`created`) AS `mailcreated`, min(`mail`.`seen`) AS `mailseen`, - `mail`.* , `contact`.`name`, `contact`.`url`, `contact`.`thumb` , `contact`.`network`, - count( * ) as count - FROM `mail` LEFT JOIN `contact` ON `mail`.`contact-id` = `contact`.`id` - WHERE `mail`.`uid` = %d GROUP BY `parent-uri` ORDER BY `mailcreated` DESC LIMIT %d , %d ", - intval(local_user()), - // - intval($a->pager['start']), - intval($a->pager['itemspage']) - ); + if(count($r)) $a->set_pager_total($r[0]['total']); + + $r = get_messages(local_user(), $a->pager['start'], $a->pager['itemspage']); if(! count($r)) { info( t('No messages.') . EOL); return $o; } - $tpl = get_markup_template('mail_list.tpl'); - foreach($r as $rr) { - if($rr['unknown']) { - $partecipants = sprintf( t("Unknown sender - %s"),$rr['from-name']); - } - elseif (link_compare($rr['from-url'],$myprofile)){ - $partecipants = sprintf( t("You and %s"), $rr['name']); - } - else { - $partecipants = sprintf( t("%s and You"), $rr['from-name']); - } + $o .= render_messages($r, 'mail_list.tpl'); - if($a->theme['template_engine'] === 'internal') { - $subject_e = template_escape((($rr['mailseen']) ? $rr['title'] : '' . $rr['title'] . '')); - $body_e = template_escape($rr['body']); - $to_name_e = template_escape($rr['name']); - } - else { - $subject_e = (($rr['mailseen']) ? $rr['title'] : '' . $rr['title'] . ''); - $body_e = $rr['body']; - $to_name_e = $rr['name']; - } - - $o .= replace_macros($tpl, array( - '$id' => $rr['id'], - '$from_name' => $partecipants, - '$from_url' => (($rr['network'] === NETWORK_DFRN) ? $a->get_baseurl(true) . '/redir/' . $rr['contact-id'] : $rr['url']), - '$sparkle' => ' sparkle', - '$from_photo' => (($rr['thumb']) ? $rr['thumb'] : $rr['from-photo']), - '$subject' => $subject_e, - '$delete' => t('Delete conversation'), - '$body' => $body_e, - '$to_name' => $to_name_e, - '$date' => datetime_convert('UTC',date_default_timezone_get(),$rr['mailcreated'], t('D, d M Y - g:i A')), - '$ago' => relative_date($rr['mailcreated']), - '$seen' => $rr['mailseen'], - '$count' => sprintf( tt('%d message', '%d messages', $rr['count']), $rr['count']), - )); - } $o .= paginate($a); + return $o; } @@ -569,5 +528,65 @@ function message_content(&$a) { return $o; } - +} + +function get_messages($user, $lstart, $lend) { + + return q("SELECT max(`mail`.`created`) AS `mailcreated`, min(`mail`.`seen`) AS `mailseen`, + `mail`.* , `contact`.`name`, `contact`.`url`, `contact`.`thumb` , `contact`.`network`, + count( * ) as count + FROM `mail` LEFT JOIN `contact` ON `mail`.`contact-id` = `contact`.`id` + WHERE `mail`.`uid` = %d GROUP BY `parent-uri` ORDER BY `mailcreated` DESC LIMIT %d , %d ", + intval($user), intval($lstart), intval($lend) + ); +} + +function render_messages($msg, $t) { + + $a = get_app(); + + $tpl = get_markup_template($t); + $rslt = ''; + + foreach($msg as $rr) { + + if($rr['unknown']) { + $participants = sprintf( t("Unknown sender - %s"),$rr['from-name']); + } + elseif (link_compare($rr['from-url'], $myprofile)){ + $participants = sprintf( t("You and %s"), $rr['name']); + } + else { + $participants = sprintf( t("%s and You"), $rr['from-name']); + } + + if($a->theme['template_engine'] === 'internal') { + $subject_e = template_escape((($rr['mailseen']) ? $rr['title'] : '' . $rr['title'] . '')); + $body_e = template_escape($rr['body']); + $to_name_e = template_escape($rr['name']); + } + else { + $subject_e = (($rr['mailseen']) ? $rr['title'] : '' . $rr['title'] . ''); + $body_e = $rr['body']; + $to_name_e = $rr['name']; + } + + $rslt .= replace_macros($tpl, array( + '$id' => $rr['id'], + '$from_name' => $participants, + '$from_url' => (($rr['network'] === NETWORK_DFRN) ? $a->get_baseurl(true) . '/redir/' . $rr['contact-id'] : $rr['url']), + '$sparkle' => ' sparkle', + '$from_photo' => (($rr['thumb']) ? $rr['thumb'] : $rr['from-photo']), + '$subject' => $subject_e, + '$delete' => t('Delete conversation'), + '$body' => $body_e, + '$to_name' => $to_name_e, + '$date' => datetime_convert('UTC',date_default_timezone_get(),$rr['mailcreated'], t('D, d M Y - g:i A')), + '$ago' => relative_date($rr['mailcreated']), + '$seen' => $rr['mailseen'], + '$count' => sprintf( tt('%d message', '%d messages', $rr['count']), $rr['count']), + )); + } + + return $rslt; } From 603dad93f3c28eedad7f0740d0ccd3dcf2c1fd53 Mon Sep 17 00:00:00 2001 From: FlxAlbroscheit Date: Sat, 7 Nov 2015 18:54:20 +0100 Subject: [PATCH 2/6] Preview last five conversations in message-sidebar --- view/templates/message_side.tpl | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/view/templates/message_side.tpl b/view/templates/message_side.tpl index 3ee16e0b2e..903cfcda69 100644 --- a/view/templates/message_side.tpl +++ b/view/templates/message_side.tpl @@ -1,11 +1,10 @@ -
- - - + + {{if $tabs}} +
+ {{$tabs}} +
+ {{/if}} +
From a8c033a7f62c00bf849210e7da0b14343182e44b Mon Sep 17 00:00:00 2001 From: FlxAlbroscheit Date: Sat, 7 Nov 2015 18:55:13 +0100 Subject: [PATCH 3/6] Preview last five conversations in message-sidebar --- view/theme/duepuntozero/style.css | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/view/theme/duepuntozero/style.css b/view/theme/duepuntozero/style.css index 62b248e8c4..10b652595e 100644 --- a/view/theme/duepuntozero/style.css +++ b/view/theme/duepuntozero/style.css @@ -3495,5 +3495,9 @@ ul.menu-popup { .videos .video-top-wrapper:hover .video-delete { opacity: 1; } - - +#message-preview .mail-list-sender-url, #message-preview .mail-list-delete { + display: none; +} +#message-preview .mail-list-outside-wrapper { + margin-top: 20px; +} From 1b2349d01130a870794feb0c30811ffbe1e3c692 Mon Sep 17 00:00:00 2001 From: FlxAlbroscheit Date: Sat, 7 Nov 2015 18:56:05 +0100 Subject: [PATCH 4/6] Preview last five conversations in message-sidebar --- view/theme/frost/style.css | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/view/theme/frost/style.css b/view/theme/frost/style.css index 74b5dde0b6..f2bbebfca5 100644 --- a/view/theme/frost/style.css +++ b/view/theme/frost/style.css @@ -4165,5 +4165,9 @@ ul.notifications-menu-popup { margin-left: 40px; width: 130px; } - - +#message-preview .mail-list-sender, #message-preview .mail-list-delete { + display:none; +} +#message-preview .mail-list-outside-wrapper { + margin-top: 20px; +} From 06676e7c1b654867cafaaa9010f4e64faf636d48 Mon Sep 17 00:00:00 2001 From: FlxAlbroscheit Date: Sat, 7 Nov 2015 18:57:40 +0100 Subject: [PATCH 5/6] Preview last five conversations in message-sidebar --- view/theme/vier/style.css | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/view/theme/vier/style.css b/view/theme/vier/style.css index 3f48d2ec3f..75b8288636 100644 --- a/view/theme/vier/style.css +++ b/view/theme/vier/style.css @@ -3037,3 +3037,8 @@ a.mail-list-link { /* upload/select popup */ .fbrowser.image .photo-album-image-wrapper { margin-left: 10px; } + #message-preview { margin-top: 15px; } + #message-preview span { width: 100%; } + #message-preview .mail-count, #message-preview .mail-delete { display:none; } + #message-preview .mail-list-wrapper { padding: 3px; } + #message-preview .mail-date { opacity:0.6; font-size:10px; } From 613cf41fd69cf9114df357729bc95b52156744d8 Mon Sep 17 00:00:00 2001 From: FlxAlbroscheit Date: Sun, 8 Nov 2015 15:45:42 +0100 Subject: [PATCH 6/6] Preview last five conversations in message-sidebar --- mod/message.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mod/message.php b/mod/message.php index 2a64c2e051..0ed2b98841 100644 --- a/mod/message.php +++ b/mod/message.php @@ -7,8 +7,9 @@ function message_init(&$a) { $tabs = ''; - if (is_numeric($a->argv[1])) + if ($a->argc >1 && is_numeric($a->argv[1])) { $tabs = render_messages(get_messages(local_user(),0,5), 'mail_list.tpl'); + } $new = array( 'label' => t('New Message'),