From 5926cd534aac8bf481c49267be3cf9e9636a8a41 Mon Sep 17 00:00:00 2001 From: Hypolite Petovan Date: Sun, 17 Dec 2017 15:35:38 -0500 Subject: [PATCH] Add FIXME for unrecoverable missing variables --- src/Protocol/Diaspora.php | 1 + src/Protocol/OStatus.php | 1 + src/Protocol/PortableContact.php | 1 + src/Worker/Directory.php | 1 + 4 files changed, 4 insertions(+) diff --git a/src/Protocol/Diaspora.php b/src/Protocol/Diaspora.php index a56b1fe877..466104c404 100644 --- a/src/Protocol/Diaspora.php +++ b/src/Protocol/Diaspora.php @@ -4067,6 +4067,7 @@ class Diaspora foreach ($recips as $recip) { logger("Send updated profile data for user ".$uid." to contact ".$recip["id"], LOGGER_DEBUG); + /// @fixme $profile isn't available here self::buildAndTransmit($profile, $recip, "profile", $message, false, "", true); } } diff --git a/src/Protocol/OStatus.php b/src/Protocol/OStatus.php index cadc9a37ea..bf1deba772 100644 --- a/src/Protocol/OStatus.php +++ b/src/Protocol/OStatus.php @@ -1024,6 +1024,7 @@ class OStatus $orig_created = $xpath->query('atom:published/text()', $activityobjects)->item(0)->nodeValue; $orig_edited = $xpath->query('atom:updated/text()', $activityobjects)->item(0)->nodeValue; + /// @fixme $contact is unavailable here $orig_contact = $contact; $orig_author = self::fetchAuthor($xpath, $activityobjects, $importer, $orig_contact, false); diff --git a/src/Protocol/PortableContact.php b/src/Protocol/PortableContact.php index 0fcf6f5743..e0213ca5c4 100644 --- a/src/Protocol/PortableContact.php +++ b/src/Protocol/PortableContact.php @@ -816,6 +816,7 @@ class PortableContact return false; } + /// @fixme $element is unavailable here $server["site_name"] = $xpath->evaluate($element."//head/title/text()")->item(0)->nodeValue; return $server; } diff --git a/src/Worker/Directory.php b/src/Worker/Directory.php index 8e5383ac0c..42ae1fd997 100644 --- a/src/Worker/Directory.php +++ b/src/Worker/Directory.php @@ -25,6 +25,7 @@ class Directory { $dir .= "/submit"; + /// @fixme $argv is unavailable here $arr = array('url' => $argv[1]); call_hooks('globaldir_update', $arr);