From 3f35fed35a9e61e4a90dc765ddc82142e39ba9f1 Mon Sep 17 00:00:00 2001 From: Michael Vogel Date: Fri, 23 Sep 2016 06:29:02 +0000 Subject: [PATCH 1/2] Special characters should be escaped --- mod/profile.php | 4 ++-- view/theme/frio/php/default.php | 2 +- view/theme/frio/php/standard.php | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/mod/profile.php b/mod/profile.php index 681b1dbd1c..a8a6ad3885 100644 --- a/mod/profile.php +++ b/mod/profile.php @@ -10,7 +10,7 @@ function profile_init(&$a) { $a->page['aside'] = ''; if($a->argc > 1) - $which = $a->argv[1]; + $which = htmlspecialchars($a->argv[1]); else { $r = q("select nickname from user where blocked = 0 and account_expired = 0 and account_removed = 0 and verified = 1 order by rand() limit 1"); if(count($r)) { @@ -27,7 +27,7 @@ function profile_init(&$a) { $profile = 0; if((local_user()) && ($a->argc > 2) && ($a->argv[2] === 'view')) { $which = $a->user['nickname']; - $profile = $a->argv[1]; + $profile = htmlspecialchars($a->argv[1]); } else { auto_redir($a, $which); diff --git a/view/theme/frio/php/default.php b/view/theme/frio/php/default.php index db3a92a626..bfc11a3580 100644 --- a/view/theme/frio/php/default.php +++ b/view/theme/frio/php/default.php @@ -17,7 +17,7 @@ <?php if(x($page,'title')) echo $page['title'] ?> - + get_baseurl(); ?> diff --git a/view/theme/frio/php/standard.php b/view/theme/frio/php/standard.php index 5535b9ed71..4a92a6aecf 100644 --- a/view/theme/frio/php/standard.php +++ b/view/theme/frio/php/standard.php @@ -11,7 +11,7 @@ <?php if(x($page,'title')) echo $page['title'] ?> - + get_baseurl(); ?> From 5f9a392fc4ead71c6d154927ad8a3f26f29fe6d5 Mon Sep 17 00:00:00 2001 From: Michael Vogel Date: Fri, 23 Sep 2016 06:36:48 +0000 Subject: [PATCH 2/2] At the search we should do it as well. --- include/text.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/text.php b/include/text.php index 3aec42b323..2276f6688d 100644 --- a/include/text.php +++ b/include/text.php @@ -988,7 +988,7 @@ function search($s,$id='search-box',$url='search',$save = false, $aside = true) $a = get_app(); $values = array( - '$s' => $s, + '$s' => htmlspecialchars($s), '$id' => $id, '$action_url' => $url, '$search_label' => t('Search'),