From d7d653aab65e230c1ac8aede73ab43333ef68b55 Mon Sep 17 00:00:00 2001 From: rabuzarus <> Date: Wed, 22 Nov 2017 21:29:07 +0100 Subject: [PATCH 1/8] port tag cloud widget from hubzilla --- include/features.php | 1 + include/identity.php | 4 +- include/tags.php | 122 +++++++++++++++++++++++++++++ mod/profile.php | 1 + view/global.css | 46 +++++++++++ view/templates/tagblock_widget.tpl | 11 +++ view/theme/frio/css/style.css | 5 ++ 7 files changed, 188 insertions(+), 2 deletions(-) create mode 100644 view/templates/tagblock_widget.tpl diff --git a/include/features.php b/include/features.php index 9895fd6f77..340394ecea 100644 --- a/include/features.php +++ b/include/features.php @@ -114,6 +114,7 @@ function get_features($filtered = true) { 'advanced_profile' => array( t('Advanced Profile Settings'), array('forumlist_profile', t('List Forums'), t('Show visitors public community forums at the Advanced Profile Page'), false, Config::get('feature_lock','forumlist_profile')), + array('tagadelic', t('Tag Cloud'), t('Provide a personal tag cloud on your profile page'), false, Config::get('feature_lock', 'tagadelic')), ), ); diff --git a/include/identity.php b/include/identity.php index b8f4727ad8..2e6327d987 100644 --- a/include/identity.php +++ b/include/identity.php @@ -169,7 +169,7 @@ function get_profiledata_by_nick($nickname, $uid = 0, $profile = 0) "SELECT `contact`.`id` AS `contact_id`, `contact`.`photo` AS `contact_photo`, `contact`.`thumb` AS `contact_thumb`, `contact`.`micro` AS `contact_micro`, `profile`.`uid` AS `profile_uid`, `profile`.*, - `contact`.`avatar-date` AS picdate, `contact`.`addr`, `user`.* + `contact`.`avatar-date` AS picdate, `contact`.`addr`, `contact`.`url`, `user`.* FROM `profile` INNER JOIN `contact` on `contact`.`uid` = `profile`.`uid` AND `contact`.`self` INNER JOIN `user` ON `profile`.`uid` = `user`.`uid` @@ -183,7 +183,7 @@ function get_profiledata_by_nick($nickname, $uid = 0, $profile = 0) "SELECT `contact`.`id` AS `contact_id`, `contact`.`photo` as `contact_photo`, `contact`.`thumb` AS `contact_thumb`, `contact`.`micro` AS `contact_micro`, `profile`.`uid` AS `profile_uid`, `profile`.*, - `contact`.`avatar-date` AS picdate, `contact`.`addr`, `user`.* + `contact`.`avatar-date` AS picdate, `contact`.`addr`, `contact`.`url`, `user`.* FROM `profile` INNER JOIN `contact` ON `contact`.`uid` = `profile`.`uid` AND `contact`.`self` INNER JOIN `user` ON `profile`.`uid` = `user`.`uid` diff --git a/include/tags.php b/include/tags.php index 8720367fae..bae3e77ea4 100644 --- a/include/tags.php +++ b/include/tags.php @@ -2,6 +2,8 @@ use Friendica\App; use Friendica\Core\System; +use Friendica\Database\DBM; +use Friendica\Object\Contact; function create_tags_from_item($itemid) { $profile_base = System::baseUrl(); @@ -148,3 +150,123 @@ function update_items() { dba::close($messages); } + +// Tag cloud functions - need to be adpated to this database format +function tagadelic($uid, $count = 0, $authors = '', $owner = '', $flags = 0, $type = TERM_HASHTAG) { + require_once('include/security.php'); + + $item_condition = item_condition(); + $sql_options = item_permissions_sql($uid); + $count = intval($count); + if ($flags) { + if ($flags === 'wall') { + $sql_options .= " AND `item`.`wall` "; + } + } + if ($authors) { + if (!is_array($authors)) { + $authors = array($authors); + } + $sql_options .= " AND `item`.`author-id` IN (".implode(',', $authors).") "; + } + if ($owner) { + $sql_options .= " AND `item`.`owner-id` = ".intval($owner)." "; + } + + // Fetch tags + $r = q("SELECT `term`, COUNT(`term`) AS `total` FROM `term` + LEFT JOIN `item` ON `term`.`oid` = `item`.`id` + WHERE `term`.`uid` = %d AND `term`.`type` = %d + AND `term`.`otype` = %d AND `item`.`private` = 0 + $sql_options AND $item_condition + GROUP BY `term` ORDER BY `total` DESC %s", + intval($uid), + intval($type), + intval(TERM_OBJ_POST), + ((intval($count)) ? "LIMIT $count" : '') + ); + if(!DBM::is_result($r)) { + return array(); + } + + return tag_calc($r); +} + +function wtagblock($uid, $count = 0, $authors = '', $owner = '', $flags = 0, $type = TERM_HASHTAG) { + $o = ''; + $r = tagadelic($uid, $count, $authors, $owner, $flags, $type); + if($r) { + foreach ($r as $rr) { + $tag['level'] = $rr[2]; + $tag['url'] = urlencode($rr[0]); + $tag['name'] = $rr[0]; + + $tags[] = $tag; + } + + $tpl = get_markup_template("tagblock_widget.tpl"); + $o = replace_macros($tpl, array( + '$title' => t('Tags'), + '$tags' => $tags + )); + + } + return $o; +} + +function tag_calc($arr) { + $tags = array(); + $min = 1e9; + $max = -1e9; + $x = 0; + + if (!$arr) { + return array(); + } + + foreach ($arr as $rr) { + $tags[$x][0] = $rr['term']; + $tags[$x][1] = log($rr['total']); + $tags[$x][2] = 0; + $min = min($min, $tags[$x][1]); + $max = max($max, $tags[$x][1]); + $x ++; + } + + usort($tags, 'self::tags_sort'); + $range = max(.01, $max - $min) * 1.0001; + + for ($x = 0; $x < count($tags); $x ++) { + $tags[$x][2] = 1 + floor(9 * ($tags[$x][1] - $min) / $range); + } + + return $tags; +} + +function tags_sort($a,$b) { + if (strtolower($a[0]) == strtolower($b[0])) { + return 0; + } + return((strtolower($a[0]) < strtolower($b[0])) ? -1 : 1); +} + + +function tagcloud_wall_widget($arr = array()) { + $a = get_app(); + + if(!$a->profile['profile_uid'] || !$a->profile['url']) { + return ""; + } + + $limit = ((array_key_exists('limit', $arr)) ? intval($arr['limit']) : 50); + if(feature_enabled($a->profile['profile_uid'], 'tagadelic')) { + $owner_id = Contact::getIdForURL($a->profile['url']); + logger("public contact id: ".$owner_id); + if(!$owner_id) { + return ""; + } + return wtagblock($a->profile['profile_uid'], $limit, '', $owner_id, 'wall'); + } + + return ""; +} diff --git a/mod/profile.php b/mod/profile.php index 8a9b8b6666..9ad24ccd17 100644 --- a/mod/profile.php +++ b/mod/profile.php @@ -185,6 +185,7 @@ function profile_content(App $a, $update = 0) { $a->page['aside'] .= posted_date_widget(System::baseUrl(true) . '/profile/' . $a->profile['nickname'],$a->profile['profile_uid'],true); $a->page['aside'] .= categories_widget(System::baseUrl(true) . '/profile/' . $a->profile['nickname'],(x($category) ? xmlify($category) : '')); + $a->page['aside'] .= tagcloud_wall_widget(); if (can_write_wall($a,$a->profile['profile_uid'])) { diff --git a/view/global.css b/view/global.css index e990060943..cf8ad8d4e2 100644 --- a/view/global.css +++ b/view/global.css @@ -522,3 +522,49 @@ td.pendingnote > p > span { .invalid-src:after, .invalid-href:after { content: '⚠️'} img.invalid-src:after { vertical-align: top;} + +/* Tag cloud */ +.tag1, .tag1:hover { + font-size: 0.9em ; + color: DarkGray; +} +.tag2, .tag2:hover { + font-size: 1.0em; + color: LawnGreen; +} +.tag3, .tag3:hover { + font-size: 1.1em; + color: DarkOrange; +} +.tag4, .tag4:hover { + font-size: 1.2em; + color: Red; +} +.tag5, .tag5:hover { + font-size: 1.3em; + color: Gold; +} +.tag6, .tag6:hover { + font-size: 1.4em; + color: Teal; +} +.tag7, .tag7:hover { + font-size: 1.5em; + color: DarkMagenta; +} +.tag8, .tag8:hover { + font-size: 1.6em; + color: DarkGoldenRod; +} +.tag9, .tag9:hover { + font-size: 1.7em; + color: DarkBlue; +} +.tag10 .tag10:hover { + font-size: 1.8em; + color: DeepPink; +} +.tag1:hover, .tag2:hover, .tag3:hover, .tag4:hover, .tag5:hover, +.tag6:hover, .tag7:hover, .tag8:hover, .tag9:hover, .tag10:hover { + text-decoration: underline; +} \ No newline at end of file diff --git a/view/templates/tagblock_widget.tpl b/view/templates/tagblock_widget.tpl new file mode 100644 index 0000000000..3317d66730 --- /dev/null +++ b/view/templates/tagblock_widget.tpl @@ -0,0 +1,11 @@ + +
+

{{$title}}

+ +
+ {{foreach $tags as $tag}} + # + {{$tag.name}} + {{/foreach}} +
+
diff --git a/view/theme/frio/css/style.css b/view/theme/frio/css/style.css index ab8e3d5a53..a606f06296 100644 --- a/view/theme/frio/css/style.css +++ b/view/theme/frio/css/style.css @@ -1238,6 +1238,11 @@ aside #group-sidebar li .group-edit-tool:first-child { width: 75px; border-radius: 4px; } + +/* Tag cloud widget */ +.tagblock.widget > .tags { + text-align: center; +} /* Section */ section ul.tabs { display: none !important; From 59ae5633ec9080845a02de99665293655bd8b726 Mon Sep 17 00:00:00 2001 From: rabuzarus <> Date: Wed, 22 Nov 2017 23:18:01 +0100 Subject: [PATCH 2/8] tag-cloud: some polishing + remove authors (we don't use it at the moment) --- include/tags.php | 21 ++++++++------------- view/global.css | 6 ++++-- view/templates/tagblock_widget.tpl | 7 ++++--- view/theme/frio/css/style.css | 2 +- 4 files changed, 17 insertions(+), 19 deletions(-) diff --git a/include/tags.php b/include/tags.php index bae3e77ea4..fb3315441c 100644 --- a/include/tags.php +++ b/include/tags.php @@ -151,8 +151,7 @@ function update_items() { dba::close($messages); } -// Tag cloud functions - need to be adpated to this database format -function tagadelic($uid, $count = 0, $authors = '', $owner = '', $flags = 0, $type = TERM_HASHTAG) { +function tagadelic($uid, $count = 0, $owner = 0, $flags = 0, $type = TERM_HASHTAG) { require_once('include/security.php'); $item_condition = item_condition(); @@ -163,12 +162,7 @@ function tagadelic($uid, $count = 0, $authors = '', $owner = '', $flags = 0, $ty $sql_options .= " AND `item`.`wall` "; } } - if ($authors) { - if (!is_array($authors)) { - $authors = array($authors); - } - $sql_options .= " AND `item`.`author-id` IN (".implode(',', $authors).") "; - } + if ($owner) { $sql_options .= " AND `item`.`owner-id` = ".intval($owner)." "; } @@ -192,9 +186,9 @@ function tagadelic($uid, $count = 0, $authors = '', $owner = '', $flags = 0, $ty return tag_calc($r); } -function wtagblock($uid, $count = 0, $authors = '', $owner = '', $flags = 0, $type = TERM_HASHTAG) { +function wtagblock($uid, $count = 0,$owner = 0, $flags = 0, $type = TERM_HASHTAG) { $o = ''; - $r = tagadelic($uid, $count, $authors, $owner, $flags, $type); + $r = tagadelic($uid, $count, $owner, $flags, $type); if($r) { foreach ($r as $rr) { $tag['level'] = $rr[2]; @@ -233,7 +227,7 @@ function tag_calc($arr) { $x ++; } - usort($tags, 'self::tags_sort'); + usort($tags, 'tags_sort'); $range = max(.01, $max - $min) * 1.0001; for ($x = 0; $x < count($tags); $x ++) { @@ -259,13 +253,14 @@ function tagcloud_wall_widget($arr = array()) { } $limit = ((array_key_exists('limit', $arr)) ? intval($arr['limit']) : 50); + if(feature_enabled($a->profile['profile_uid'], 'tagadelic')) { $owner_id = Contact::getIdForURL($a->profile['url']); - logger("public contact id: ".$owner_id); + if(!$owner_id) { return ""; } - return wtagblock($a->profile['profile_uid'], $limit, '', $owner_id, 'wall'); + return wtagblock($a->profile['profile_uid'], $limit, $owner_id, 'wall'); } return ""; diff --git a/view/global.css b/view/global.css index cf8ad8d4e2..f3ca22b75a 100644 --- a/view/global.css +++ b/view/global.css @@ -564,7 +564,9 @@ img.invalid-src:after { vertical-align: top;} font-size: 1.8em; color: DeepPink; } -.tag1:hover, .tag2:hover, .tag3:hover, .tag4:hover, .tag5:hover, -.tag6:hover, .tag7:hover, .tag8:hover, .tag9:hover, .tag10:hover { +.tags > a:hover { text-decoration: underline; +} +.tag-cloud { + word-wrap: break-word; } \ No newline at end of file diff --git a/view/templates/tagblock_widget.tpl b/view/templates/tagblock_widget.tpl index 3317d66730..602d762aa5 100644 --- a/view/templates/tagblock_widget.tpl +++ b/view/templates/tagblock_widget.tpl @@ -2,10 +2,11 @@

{{$title}}

-
+
{{foreach $tags as $tag}} - # - {{$tag.name}} + + #{{$tag.name}} + {{/foreach}}
diff --git a/view/theme/frio/css/style.css b/view/theme/frio/css/style.css index a606f06296..f37c02e636 100644 --- a/view/theme/frio/css/style.css +++ b/view/theme/frio/css/style.css @@ -1240,7 +1240,7 @@ aside #group-sidebar li .group-edit-tool:first-child { } /* Tag cloud widget */ -.tagblock.widget > .tags { +.tagblock.widget > .tag-cloud { text-align: center; } /* Section */ From 19afabd2682e3ae88afc90bf47f726e03eadc8c4 Mon Sep 17 00:00:00 2001 From: rabuzarus <> Date: Thu, 23 Nov 2017 00:59:20 +0100 Subject: [PATCH 3/8] tags: possibility to filter posts for tags and profile owner (profile) --- include/tags.php | 22 +++++++++++++++------- mod/profile.php | 7 +++++++ view/templates/tagblock_widget.tpl | 2 +- 3 files changed, 23 insertions(+), 8 deletions(-) diff --git a/include/tags.php b/include/tags.php index fb3315441c..8a6b3ba746 100644 --- a/include/tags.php +++ b/include/tags.php @@ -151,7 +151,7 @@ function update_items() { dba::close($messages); } -function tagadelic($uid, $count = 0, $owner = 0, $flags = 0, $type = TERM_HASHTAG) { +function tagadelic($uid, $count = 0, $owner_id = 0, $flags = 0, $type = TERM_HASHTAG) { require_once('include/security.php'); $item_condition = item_condition(); @@ -163,8 +163,8 @@ function tagadelic($uid, $count = 0, $owner = 0, $flags = 0, $type = TERM_HASHTA } } - if ($owner) { - $sql_options .= " AND `item`.`owner-id` = ".intval($owner)." "; + if ($owner_id) { + $sql_options .= " AND `item`.`owner-id` = ".intval($owner_id)." "; } // Fetch tags @@ -186,13 +186,21 @@ function tagadelic($uid, $count = 0, $owner = 0, $flags = 0, $type = TERM_HASHTA return tag_calc($r); } -function wtagblock($uid, $count = 0,$owner = 0, $flags = 0, $type = TERM_HASHTAG) { +function wtagblock($uid, $count = 0,$owner_id = 0, $flags = 0, $type = TERM_HASHTAG) { $o = ''; - $r = tagadelic($uid, $count, $owner, $flags, $type); - if($r) { + $r = tagadelic($uid, $count, $owner_id, $flags, $type); + if($r && $owner_id) { + $contact = dba::select( + "contact", + array("url"), + array("id" => $owner_id), + array("limit" => 1) + ); + $url = System::removedBaseUrl($contact['url']); + foreach ($r as $rr) { $tag['level'] = $rr[2]; - $tag['url'] = urlencode($rr[0]); + $tag['url'] = $url."?tag=".urlencode($rr[0]); $tag['name'] = $rr[0]; $tags[] = $tag; diff --git a/mod/profile.php b/mod/profile.php index 9ad24ccd17..59835bd4cb 100644 --- a/mod/profile.php +++ b/mod/profile.php @@ -98,6 +98,8 @@ function profile_content(App $a, $update = 0) { $category = ((x($_GET,'category')) ? $_GET['category'] : ''); } + $hashtags = (x($_GET, 'tag') ? $_GET['tag'] : ''); + if (Config::get('system','block_public') && (! local_user()) && (! remote_user())) { return login(); } @@ -255,6 +257,11 @@ function profile_content(App $a, $update = 0) { //$sql_extra .= protect_sprintf(file_tag_file_query('item',$category,'category')); } + if (x($hashtags)) { + $sql_post_table .= sprintf("INNER JOIN (SELECT `oid` FROM `term` WHERE `term` = '%s' AND `otype` = %d AND `type` = %d AND `uid` = %d ORDER BY `tid` DESC) AS `term` ON `item`.`id` = `term`.`oid` ", + dbesc(protect_sprintf($hashtags)), intval(TERM_OBJ_POST), intval(TERM_HASHTAG), intval($a->profile['profile_uid'])); + } + if ($datequery) { $sql_extra2 .= protect_sprintf(sprintf(" AND `thread`.`created` <= '%s' ", dbesc(datetime_convert(date_default_timezone_get(),'',$datequery)))); } diff --git a/view/templates/tagblock_widget.tpl b/view/templates/tagblock_widget.tpl index 602d762aa5..114d32290b 100644 --- a/view/templates/tagblock_widget.tpl +++ b/view/templates/tagblock_widget.tpl @@ -5,7 +5,7 @@
{{foreach $tags as $tag}} - #{{$tag.name}} + #{{$tag.name}} {{/foreach}}
From f1b86d31caca533054841c2da323af9e9289a981 Mon Sep 17 00:00:00 2001 From: rabuzarus <> Date: Thu, 23 Nov 2017 03:43:39 +0100 Subject: [PATCH 4/8] tags-cloud: respect remote perms --- include/tags.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/tags.php b/include/tags.php index 8a6b3ba746..01c39d925a 100644 --- a/include/tags.php +++ b/include/tags.php @@ -171,8 +171,8 @@ function tagadelic($uid, $count = 0, $owner_id = 0, $flags = 0, $type = TERM_HAS $r = q("SELECT `term`, COUNT(`term`) AS `total` FROM `term` LEFT JOIN `item` ON `term`.`oid` = `item`.`id` WHERE `term`.`uid` = %d AND `term`.`type` = %d - AND `term`.`otype` = %d AND `item`.`private` = 0 - $sql_options AND $item_condition + AND `term`.`otype` = %d + AND $item_condition $sql_options GROUP BY `term` ORDER BY `total` DESC %s", intval($uid), intval($type), From 2844947f5c284748ff30012fbc4caecb2c59c794 Mon Sep 17 00:00:00 2001 From: rabuzarus <> Date: Sun, 26 Nov 2017 04:33:21 +0100 Subject: [PATCH 5/8] tag cloud: add doxygen docu --- include/tags.php | 60 ++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 50 insertions(+), 10 deletions(-) diff --git a/include/tags.php b/include/tags.php index 01c39d925a..6c13b82962 100644 --- a/include/tags.php +++ b/include/tags.php @@ -151,7 +151,19 @@ function update_items() { dba::close($messages); } -function tagadelic($uid, $count = 0, $owner_id = 0, $flags = 0, $type = TERM_HASHTAG) { +/** + * @brief Get alphabetical sorted array of used tags/terms of an user including + * a weighting by frequency of use. + * + * @param int $uid The user ID. + * @param int $count Max number of displayed tags/terms. + * @param int $owner_id The contact id of the owner of the tagged items. + * @param string $flags Special item flags. + * @param int $type The tag/term type. + * + * @return arr Alphabetical sorted array of used tags of an user. + */ +function tagadelic($uid, $count = 0, $owner_id = 0, $flags = '', $type = TERM_HASHTAG) { require_once('include/security.php'); $item_condition = item_condition(); @@ -186,14 +198,25 @@ function tagadelic($uid, $count = 0, $owner_id = 0, $flags = 0, $type = TERM_HAS return tag_calc($r); } -function wtagblock($uid, $count = 0,$owner_id = 0, $flags = 0, $type = TERM_HASHTAG) { +/** + * @brief Construct a tag/term cloud block for an user. + * + * @param int $uid The user ID. + * @param int $count Max number of displayed tags/terms. + * @param int $owner_id The contact ID of the owner of the tagged items. + * @param string $flags Special item flags. + * @param int $type The tag/term type. + * + * @return string HTML formatted output. + */ +function wtagblock($uid, $count = 0,$owner_id = 0, $flags = '', $type = TERM_HASHTAG) { $o = ''; $r = tagadelic($uid, $count, $owner_id, $flags, $type); - if($r && $owner_id) { + if (count($r)) { $contact = dba::select( "contact", array("url"), - array("id" => $owner_id), + array("id" => $uid), array("limit" => 1) ); $url = System::removedBaseUrl($contact['url']); @@ -216,6 +239,12 @@ function wtagblock($uid, $count = 0,$owner_id = 0, $flags = 0, $type = TERM_HASH return $o; } +/** + * @brief Calculate weighting of tags according to the frequency of use. + * + * @param array $arr Array of tags/terms with tag/term name and total count of use. + * @return array Alphabetical sorted array of used tags/terms of an user. + */ function tag_calc($arr) { $tags = array(); $min = 1e9; @@ -245,23 +274,34 @@ function tag_calc($arr) { return $tags; } -function tags_sort($a,$b) { +/** + * @brief Compare function to sort tags/terms alphabetically. + * + * @param type $a + * @param type $b + * + * @return int + */ +function tags_sort($a, $b) { if (strtolower($a[0]) == strtolower($b[0])) { return 0; } - return((strtolower($a[0]) < strtolower($b[0])) ? -1 : 1); + return ((strtolower($a[0]) < strtolower($b[0])) ? -1 : 1); } - -function tagcloud_wall_widget($arr = array()) { +/** + * @brief Insert a tag cloud widget for the present profile. + * + * @param int $limit Max number of displayed tags. + * @return string HTML formattat output. + */ +function tagcloud_wall_widget($limit = 50) { $a = get_app(); if(!$a->profile['profile_uid'] || !$a->profile['url']) { return ""; } - $limit = ((array_key_exists('limit', $arr)) ? intval($arr['limit']) : 50); - if(feature_enabled($a->profile['profile_uid'], 'tagadelic')) { $owner_id = Contact::getIdForURL($a->profile['url']); From 655b2cd0d379d1b15cf432400515496c0a963d74 Mon Sep 17 00:00:00 2001 From: rabuzarus <> Date: Sun, 26 Nov 2017 04:36:45 +0100 Subject: [PATCH 6/8] tag cloud: clear align settings in the tagcloud widget --- view/templates/tagblock_widget.tpl | 1 + 1 file changed, 1 insertion(+) diff --git a/view/templates/tagblock_widget.tpl b/view/templates/tagblock_widget.tpl index 114d32290b..fd007c9c10 100644 --- a/view/templates/tagblock_widget.tpl +++ b/view/templates/tagblock_widget.tpl @@ -9,4 +9,5 @@ {{/foreach}}
+
From ac6b191976226918c898c0e62ca7cb606652bf34 Mon Sep 17 00:00:00 2001 From: rabuzarus <> Date: Sun, 26 Nov 2017 16:14:16 +0100 Subject: [PATCH 7/8] tag cloud: use dba for db request --- include/tags.php | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/include/tags.php b/include/tags.php index 6c13b82962..7ea15f0b98 100644 --- a/include/tags.php +++ b/include/tags.php @@ -168,7 +168,8 @@ function tagadelic($uid, $count = 0, $owner_id = 0, $flags = '', $type = TERM_HA $item_condition = item_condition(); $sql_options = item_permissions_sql($uid); - $count = intval($count); + $limit = $count ? sprintf("LIMIT %d", intval($count)) : ""; + if ($flags) { if ($flags === 'wall') { $sql_options .= " AND `item`.`wall` "; @@ -180,16 +181,15 @@ function tagadelic($uid, $count = 0, $owner_id = 0, $flags = '', $type = TERM_HA } // Fetch tags - $r = q("SELECT `term`, COUNT(`term`) AS `total` FROM `term` + $r = dba::p("SELECT `term`, COUNT(`term`) AS `total` FROM `term` LEFT JOIN `item` ON `term`.`oid` = `item`.`id` - WHERE `term`.`uid` = %d AND `term`.`type` = %d - AND `term`.`otype` = %d + WHERE `term`.`uid` = ? AND `term`.`type` = ? + AND `term`.`otype` = ? AND $item_condition $sql_options - GROUP BY `term` ORDER BY `total` DESC %s", - intval($uid), - intval($type), - intval(TERM_OBJ_POST), - ((intval($count)) ? "LIMIT $count" : '') + GROUP BY `term` ORDER BY `total` DESC ? $limit", + $uid, + $type, + TERM_OBJ_POST ); if(!DBM::is_result($r)) { return array(); From 7d8370a17829c260dbf4a7623aed10d37b1f3420 Mon Sep 17 00:00:00 2001 From: rabuzarus <> Date: Sun, 26 Nov 2017 16:24:26 +0100 Subject: [PATCH 8/8] tag cloud: fix query --- include/tags.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/tags.php b/include/tags.php index 7ea15f0b98..ba8770e6f9 100644 --- a/include/tags.php +++ b/include/tags.php @@ -186,7 +186,7 @@ function tagadelic($uid, $count = 0, $owner_id = 0, $flags = '', $type = TERM_HA WHERE `term`.`uid` = ? AND `term`.`type` = ? AND `term`.`otype` = ? AND $item_condition $sql_options - GROUP BY `term` ORDER BY `total` DESC ? $limit", + GROUP BY `term` ORDER BY `total` DESC $limit", $uid, $type, TERM_OBJ_POST