From 3c074ab315ecb3fb5864eb85a9b2d0ce35d4aa5a Mon Sep 17 00:00:00 2001
From: Philipp <admin@philipp.info>
Date: Fri, 20 Aug 2021 19:48:20 +0200
Subject: [PATCH] HTTPRequest: Replace getInfo() with new parameter
 'content_length'

---
 src/Network/CurlResult.php     |  6 ------
 src/Network/GuzzleResponse.php |  5 -----
 src/Network/HTTPRequest.php    | 13 +++++++++++--
 src/Network/IHTTPRequest.php   |  1 +
 src/Network/IHTTPResult.php    |  5 -----
 src/Network/Probe.php          |  7 +------
 src/Util/ParseUrl.php          |  2 +-
 7 files changed, 14 insertions(+), 25 deletions(-)

diff --git a/src/Network/CurlResult.php b/src/Network/CurlResult.php
index 227d26140e..65c110338f 100644
--- a/src/Network/CurlResult.php
+++ b/src/Network/CurlResult.php
@@ -319,12 +319,6 @@ class CurlResult implements IHTTPResult
 		return $this->body;
 	}
 
-	/** {@inheritDoc} */
-	public function getInfo()
-	{
-		return $this->info;
-	}
-
 	/** {@inheritDoc} */
 	public function isRedirectUrl()
 	{
diff --git a/src/Network/GuzzleResponse.php b/src/Network/GuzzleResponse.php
index c6cab7c9e8..69e88b4025 100644
--- a/src/Network/GuzzleResponse.php
+++ b/src/Network/GuzzleResponse.php
@@ -121,11 +121,6 @@ class GuzzleResponse extends Response implements IHTTPResult, ResponseInterface
 		return $this->url;
 	}
 
-	public function getInfo()
-	{
-		// TODO: Implement getInfo() method.
-	}
-
 	/** {@inheritDoc} */
 	public function isRedirectUrl()
 	{
diff --git a/src/Network/HTTPRequest.php b/src/Network/HTTPRequest.php
index 3bc58c19be..cf9b53a92a 100644
--- a/src/Network/HTTPRequest.php
+++ b/src/Network/HTTPRequest.php
@@ -30,6 +30,7 @@ use Friendica\Util\Network;
 use Friendica\Util\Profiler;
 use GuzzleHttp\Client;
 use GuzzleHttp\Exception\RequestException;
+use GuzzleHttp\Exception\TransferException;
 use Psr\Http\Message\RequestInterface;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\UriInterface;
@@ -204,6 +205,13 @@ class HTTPRequest implements IHTTPRequest
 			$this->logger->notice('Curl redirect.', ['url' => $request->getUri(), 'to' => $uri]);
 		};
 
+		$onHeaders = function (ResponseInterface $response) use ($opts) {
+			if (!empty($opts['content_length']) &&
+				$response->getHeaderLine('Content-Length') > $opts['content_length']) {
+				throw new TransferException('The file is too big!');
+			}
+		};
+
 		$client = new Client([
 			'allow_redirect' => [
 				'max' => 8,
@@ -220,8 +228,9 @@ class HTTPRequest implements IHTTPRequest
 		try {
 			$response = $client->get($url);
 			return new GuzzleResponse($response, $url);
-		} catch (RequestException $exception) {
-			if ($exception->hasResponse()) {
+		} catch (TransferException $exception) {
+			if ($exception instanceof RequestException &&
+				$exception->hasResponse()) {
 				return new GuzzleResponse($exception->getResponse(), $url, $exception->getCode(), $exception->getMessage());
 			} else {
 				return new CurlResult($url, '', ['http_code' => $exception->getCode()], $exception->getCode(), $exception->getMessage());
diff --git a/src/Network/IHTTPRequest.php b/src/Network/IHTTPRequest.php
index efe9f5f8b2..b496c7feba 100644
--- a/src/Network/IHTTPRequest.php
+++ b/src/Network/IHTTPRequest.php
@@ -79,6 +79,7 @@ interface IHTTPRequest
 	 *                           'timeout' => int Timeout in seconds, default system config value or 60 seconds
 	 *                           'cookiejar' => path to cookie jar file
 	 *                           'header' => header array
+	 *                           'content_length' => int maximum File content length
 	 *
 	 * @return IHTTPResult
 	 */
diff --git a/src/Network/IHTTPResult.php b/src/Network/IHTTPResult.php
index 5904bcfa38..77ee86976b 100644
--- a/src/Network/IHTTPResult.php
+++ b/src/Network/IHTTPResult.php
@@ -82,11 +82,6 @@ interface IHTTPResult
 	 */
 	public function getBody();
 
-	/**
-	 * @return array
-	 */
-	public function getInfo();
-
 	/**
 	 * @return boolean
 	 */
diff --git a/src/Network/Probe.php b/src/Network/Probe.php
index 8cee679400..1115808007 100644
--- a/src/Network/Probe.php
+++ b/src/Network/Probe.php
@@ -424,16 +424,11 @@ class Probe
 	 */
 	private static function getHideStatus($url)
 	{
-		$curlResult = DI::httpRequest()->get($url);
+		$curlResult = DI::httpRequest()->get($url, false, ['content_length' => 1000000]);
 		if (!$curlResult->isSuccess()) {
 			return false;
 		}
 
-		// If the file is too large then exit
-		if (($curlResult->getInfo()['download_content_length'] ?? 0) > 1000000) {
-			return false;
-		}
-
 		// If it isn't a HTML file then exit
 		if (($curlResult->getContentType() != '') && !strstr(strtolower($curlResult->getContentType()), 'html')) {
 			return false;
diff --git a/src/Util/ParseUrl.php b/src/Util/ParseUrl.php
index 75210af0f0..d95897b1d0 100644
--- a/src/Util/ParseUrl.php
+++ b/src/Util/ParseUrl.php
@@ -213,7 +213,7 @@ class ParseUrl
 			return $siteinfo;
 		}
 
-		$curlResult = DI::httpRequest()->get($url);
+		$curlResult = DI::httpRequest()->get($url, false, ['content_length' => 1000000]);
 		if (!$curlResult->isSuccess() || empty($curlResult->getBody())) {
 			return $siteinfo;
 		}