From 3bf7664ee3a224189647f150aabcff241b4650e5 Mon Sep 17 00:00:00 2001
From: Michael <heluecht@pirati.ca>
Date: Wed, 8 Jan 2020 22:36:31 +0000
Subject: [PATCH] changed priority of messages

---
 include/enotify.php         | 18 +++++++++---------
 src/Content/Text/BBCode.php |  3 +++
 2 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/include/enotify.php b/include/enotify.php
index 50e23930e9..63bdd97c2f 100644
--- a/include/enotify.php
+++ b/include/enotify.php
@@ -184,10 +184,10 @@ function notification($params)
 		// First go for the general message
 
 		// "George Bull's post"
-		if ($params['activity']['explicit_tagged']) {
-			$message = '%1$s tagged you on %2$s\'s %3$s %4$s';
-		} elseif ($params['activity']['origin_comment']) {
+		if ($params['activity']['origin_comment']) {
 			$message = '%1$s replied to you on %2$s\'s %3$s %4$s';
+		} elseif ($params['activity']['explicit_tagged']) {
+			$message = '%1$s tagged you on %2$s\'s %3$s %4$s';
 		} else {
 			$message = '%1$s commented on %2$s\'s %3$s %4$s';
 		}
@@ -198,10 +198,10 @@ function notification($params)
 
 		// "your post"
 		if ($params['activity']['origin_thread']) {
-			if ($params['activity']['explicit_tagged']) {
-				$message = '%1$s tagged you on your %2$s %3$s';
-			} elseif ($params['activity']['origin_comment']) {
+			if ($params['activity']['origin_comment']) {
 				$message = '%1$s replied to you on your %2$s %3$s';
+			} elseif ($params['activity']['explicit_tagged']) {
+				$message = '%1$s tagged you on your %2$s %3$s';
 			} else {
 				$message = '%1$s commented on your %2$s %3$s';
 			}
@@ -209,10 +209,10 @@ function notification($params)
 			$dest_str = $l10n->t($message, $params['source_name'], $item_post_type, $title);
 		// "their post"
 		} elseif ($item['author-link'] == $params['source_link']) {
-			if ($params['activity']['explicit_tagged']) {
-				$message = '%1$s tagged you on their %2$s %3$s';
-			} elseif ($params['activity']['origin_comment']) {
+			if ($params['activity']['origin_comment']) {
 				$message = '%1$s replied to you on their %2$s %3$s';
+			} elseif ($params['activity']['explicit_tagged']) {
+				$message = '%1$s tagged you on their %2$s %3$s';
 			} else {
 				$message = '%1$s commented on their %2$s %3$s';
 			}
diff --git a/src/Content/Text/BBCode.php b/src/Content/Text/BBCode.php
index 51fa08ad3d..46eb95bd30 100644
--- a/src/Content/Text/BBCode.php
+++ b/src/Content/Text/BBCode.php
@@ -967,6 +967,9 @@ class BBCode
 				$attributes['avatar']   = ($author_contact['micro'] ?? '') ?: $attributes['avatar'];
 				$attributes['profile']  = ($author_contact['url']   ?? '') ?: $attributes['profile'];
 
+				// $author_contact['url'] could be empty. So then we fill it with the profile
+				$author_contact['url']  = ($attributes['profile']   ?? '') ?: $author_contact['url'];
+
 				if ($attributes['avatar']) {
 					$attributes['avatar'] = ProxyUtils::proxifyUrl($attributes['avatar'], false, ProxyUtils::SIZE_THUMB);
 				}