From 33c7abd376346651fbf5ebefd73b13db14557924 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Roland=20H=C3=A4der?= Date: Fri, 12 Aug 2022 13:13:05 +0200 Subject: [PATCH] Changes: - methods should ALWAYS start lower-case, not upper - documented a bit more --- src/Factory/Api/Mastodon/Conversation.php | 5 ++++- src/Module/Api/Mastodon/Conversations.php | 2 +- src/Module/Api/Mastodon/Conversations/Read.php | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/Factory/Api/Mastodon/Conversation.php b/src/Factory/Api/Mastodon/Conversation.php index b872911592..4666030509 100644 --- a/src/Factory/Api/Mastodon/Conversation.php +++ b/src/Factory/Api/Mastodon/Conversation.php @@ -46,9 +46,12 @@ class Conversation extends BaseFactory } /** + * @param int $id Conversation id + * + * @return \Friendica\Object\Api\Mastodon\Conversation * @throws ImagickException|HTTPException\InternalServerErrorException|HTTPException\NotFoundException */ - public function CreateFromConvId(int $id): \Friendica\Object\Api\Mastodon\Conversation + public function createFromConvId(int $id): \Friendica\Object\Api\Mastodon\Conversation { $accounts = []; $unread = false; diff --git a/src/Module/Api/Mastodon/Conversations.php b/src/Module/Api/Mastodon/Conversations.php index 16fa127c80..066c36b9db 100644 --- a/src/Module/Api/Mastodon/Conversations.php +++ b/src/Module/Api/Mastodon/Conversations.php @@ -85,7 +85,7 @@ class Conversations extends BaseApi while ($conv = DBA::fetch($convs)) { self::setBoundaries($conv['id']); - $conversations[] = DI::mstdnConversation()->CreateFromConvId($conv['id']); + $conversations[] = DI::mstdnConversation()->createFromConvId($conv['id']); } DBA::close($convs); diff --git a/src/Module/Api/Mastodon/Conversations/Read.php b/src/Module/Api/Mastodon/Conversations/Read.php index 3882b33002..b01dc9d7ca 100644 --- a/src/Module/Api/Mastodon/Conversations/Read.php +++ b/src/Module/Api/Mastodon/Conversations/Read.php @@ -42,6 +42,6 @@ class Read extends BaseApi DBA::update('mail', ['seen' => true], ['convid' => $this->parameters['id'], 'uid' => $uid]); - System::jsonExit(DI::mstdnConversation()->CreateFromConvId($this->parameters['id'])->toArray()); + System::jsonExit(DI::mstdnConversation()->createFromConvId($this->parameters['id'])->toArray()); } }