From dcd7553da94a309b1a87bbbfa533ac8ce9fd16e3 Mon Sep 17 00:00:00 2001
From: Hypolite Petovan <hypolite@mrpetovan.com>
Date: Thu, 11 Jun 2020 20:26:29 -0400
Subject: [PATCH] [frio] Replace only the users table element when reordering
 on a column in mod_admin.js

- Replace duplicate jQuery query with a variable
---
 view/theme/frio/js/mod_admin.js | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/view/theme/frio/js/mod_admin.js b/view/theme/frio/js/mod_admin.js
index f0c9dd32df..05d13b0e5c 100644
--- a/view/theme/frio/js/mod_admin.js
+++ b/view/theme/frio/js/mod_admin.js
@@ -2,16 +2,17 @@
  * Javascript for the admin module
  */
 $(function() {
-	$('body').on('click', '.selectall', function() {
+	let $body = $('body');
+	$body.on('click', '.selectall', function() {
 		selectall($(this).data('selectAll'));
 	});
-	$('body').on('click', '.selectnone', function() {
+	$body.on('click', '.selectnone', function() {
 		selectnone($(this).data('selectNone'));
 	});
 
 	// Toggle checkbox status to all or none for all checkboxes of a specific
 	// css class.
-	$('body').on('change', 'input[type=checkbox].selecttoggle', function() {
+	$body.on('change', 'input[type=checkbox].selecttoggle', function() {
 		$this = $(this);
 		if ($this.prop('checked')) {
 			selectall($this.data('selectClass'));
@@ -23,7 +24,7 @@ $(function() {
 	});
 
 	// Use AJAX calls to reorder the table (so we don't need to reload the page).
-	$('body').on('click', '.table-order', function(e) {
+	$body.on('click', '.table-order', function(e) {
 		e.preventDefault();
 
 		// Get the parent table element.
@@ -31,15 +32,15 @@ $(function() {
 		var orderUrl = this.getAttribute("data-order-url");
 		table.fadeTo("fast", 0.33);
 
-		$("body").css("cursor", "wait");
+		$body.css("cursor", "wait");
 
 		$.get(orderUrl, function(data) {
 			// Find the table element in the html we got.
 			var result = $(data).find('#' + table[0].id);
 			// And add the new table html to the parent.
-			$(table).parent().html(result);
+			$(table).replaceWith(result);
 
-			$("body").css("cursor", "auto");
+			$body.css("cursor", "auto");
 		});
 	});