removed parentheses + added TODO about a small rewrite

Signed-off-by: Roland Haeder <roland@mxchange.org>
This commit is contained in:
Roland Häder 2017-03-24 21:05:08 +01:00
parent b5b3451b31
commit 0e19fdfc71
No known key found for this signature in database
GPG Key ID: B72F8185C6C7BD78
1 changed files with 10 additions and 8 deletions

View File

@ -253,7 +253,6 @@ define ( 'NETWORK_PHANTOM', 'unkn'); // Place holder
* and existing allocations MUST NEVER BE CHANGED * and existing allocations MUST NEVER BE CHANGED
* OR RE-ASSIGNED! You may only add to them. * OR RE-ASSIGNED! You may only add to them.
*/ */
$netgroup_ids = array( $netgroup_ids = array(
NETWORK_DFRN => (-1), NETWORK_DFRN => (-1),
NETWORK_ZOT => (-2), NETWORK_ZOT => (-2),
@ -503,6 +502,7 @@ function startup() {
*/ */
class App { class App {
/// @TODO decide indending as a colorful mixure is ahead ...
public $module_loaded = false; public $module_loaded = false;
public $query_string; public $query_string;
public $config; public $config;
@ -810,11 +810,11 @@ class App {
$basepath = $_SERVER["PWD"]; $basepath = $_SERVER["PWD"];
} }
return($basepath); return $basepath;
} }
function get_scheme() { function get_scheme() {
return($this->scheme); return $this->scheme;
} }
/** /**
@ -1048,7 +1048,7 @@ class App {
// Is the function called statically? // Is the function called statically?
if (!(isset($this) && get_class($this) == __CLASS__)) { if (!(isset($this) && get_class($this) == __CLASS__)) {
return(self::$a->remove_baseurl($orig_url)); return self::$a->remove_baseurl($orig_url);
} }
// Remove the hostname from the url if it is an internal link // Remove the hostname from the url if it is an internal link
@ -1233,11 +1233,11 @@ class App {
} }
function get_useragent() { function get_useragent() {
return(FRIENDICA_PLATFORM." '".FRIENDICA_CODENAME."' ".FRIENDICA_VERSION."-".DB_UPDATE_VERSION."; ".$this->get_baseurl()); return (FRIENDICA_PLATFORM." '".FRIENDICA_CODENAME."' ".FRIENDICA_VERSION."-".DB_UPDATE_VERSION."; ".$this->get_baseurl());
} }
function is_friendica_app() { function is_friendica_app() {
return($this->is_friendica_app); return $this->is_friendica_app;
} }
/** /**
@ -1249,6 +1249,7 @@ class App {
* @return bool Is it a known backend? * @return bool Is it a known backend?
*/ */
function is_backend() { function is_backend() {
/// @Should be made static to speedup things
$backend = array(); $backend = array();
$backend[] = "_well_known"; $backend[] = "_well_known";
$backend[] = "api"; $backend[] = "api";
@ -1270,6 +1271,7 @@ class App {
$backend[] = "statistics_json"; $backend[] = "statistics_json";
$backend[] = "xrd"; $backend[] = "xrd";
/// @TODO Maybe rewrite this part: return (in_array() || $this->backend); ?
if (in_array($this->module, $backend)) { if (in_array($this->module, $backend)) {
return(true); return(true);
} else { } else {
@ -2359,7 +2361,7 @@ function get_cachefile($file, $writemode = true) {
} }
/// @TODO no need to put braces here /// @TODO no need to put braces here
return($cachepath); return $cachepath;
} }
function clear_cache($basepath = "", $path = "") { function clear_cache($basepath = "", $path = "") {
@ -2511,7 +2513,7 @@ function set_template_engine(App $a, $engine = 'internal') {
if (!function_exists('exif_imagetype')) { if (!function_exists('exif_imagetype')) {
function exif_imagetype($file) { function exif_imagetype($file) {
$size = getimagesize($file); $size = getimagesize($file);
return($size[2]); return $size[2];
} }
} }