From 701e761c689608569c02d3218145048027b41794 Mon Sep 17 00:00:00 2001 From: Roland Haeder Date: Tue, 4 Apr 2017 19:47:32 +0200 Subject: [PATCH 1/4] added spaces + some curly braces + some usage of dbm::is_result() Signed-off-by: Roland Haeder --- include/dba_pdo.php | 189 +++++++++++++++++++++------------------- include/dbstructure.php | 16 ++-- include/diaspora.php | 14 +-- include/expire.php | 7 +- 4 files changed, 121 insertions(+), 105 deletions(-) diff --git a/include/dba_pdo.php b/include/dba_pdo.php index 4549d7a0ce..4a1d5aca15 100644 --- a/include/dba_pdo.php +++ b/include/dba_pdo.php @@ -49,12 +49,14 @@ class dba { function __construct($server,$user,$pass,$db,$install = false) { $a = get_app(); - # work around, to store the database - configuration in DDDBL - $objDataObjectPool = new DataObjectPool('Database-Definition'); - $objDataObjectPool->add('DEFAULT', array('CONNECTION' => "mysql:host=$server;dbname=$db", - 'USER' => $user, - 'PASS' => $pass, - 'DEFAULT' => true)); + // work around, to store the database - configuration in DDDBL + $objDataObjectPool = new DataObjectPool('Database-Definition'); + $objDataObjectPool->add('DEFAULT', array( + 'CONNECTION' => "mysql:host=$server;dbname=$db", + 'USER' => $user, + 'PASS' => $pass, + 'DEFAULT' => true + )); $stamp1 = microtime(true); @@ -63,35 +65,34 @@ class dba { $pass = trim($pass); $db = trim($db); - if (!(strlen($server) && strlen($user))){ + if (!(strlen($server) && strlen($user))) { $this->connected = false; $this->db = null; return; } - if ($install) { - if (strlen($server) && ($server !== 'localhost') && ($server !== '127.0.0.1')) { - if (! dns_get_record($server, DNS_A + DNS_CNAME + DNS_PTR)) { - $this->error = sprintf( t('Cannot locate DNS info for database server \'%s\''), $server); - $this->connected = false; - $this->db = null; - return; - } + if ($install && strlen($server) && ($server !== 'localhost') && ($server !== '127.0.0.1')) { + if (! dns_get_record($server, DNS_A + DNS_CNAME + DNS_PTR)) { + $this->error = sprintf( t('Cannot locate DNS info for database server \'%s\''), $server); + $this->connected = false; + $this->db = null; + return; } } - # etablish connection to database and store PDO object - DDDBL\connect(); - $this->db = DDDBL\getDB(); + // Establish connection to database and store PDO object + DDDBL\connect(); + $this->db = DDDBL\getDB(); - if (DDDBL\isConnected()) { - $this->connected = true; - } + if (DDDBL\isConnected()) { + $this->connected = true; + } if (! $this->connected) { $this->db = null; - if (! $install) + if (! $install) { system_unavailable(); + } } $a->save_timestamp($stamp1, "network"); @@ -104,44 +105,49 @@ class dba { public function q($sql, $onlyquery = false) { $a = get_app(); - $strHandler = (true === $onlyquery) ? 'PDOStatement' : 'MULTI'; + $strHandler = (true === $onlyquery) ? 'PDOStatement' : 'MULTI'; - $strQueryAlias = md5($sql); - $strSQLType = strtoupper(strstr($sql, ' ', true)); + $strQueryAlias = md5($sql); + $strSQLType = strtoupper(strstr($sql, ' ', true)); - $objPreparedQueryPool = new DataObjectPool('Query-Definition'); + $objPreparedQueryPool = new DataObjectPool('Query-Definition'); - # check if query do not exists till now, if so create its definition - if (!$objPreparedQueryPool->exists($strQueryAlias)) - $objPreparedQueryPool->add($strQueryAlias, array('QUERY' => $sql, - 'HANDLER' => $strHandler)); + // check if query do not exists till now, if so create its definition + if (!$objPreparedQueryPool->exists($strQueryAlias)) { + $objPreparedQueryPool->add($strQueryAlias, array( + 'QUERY' => $sql, + 'HANDLER' => $strHandler + )); + } - if ((! $this->db) || (! $this->connected)) + if ((! $this->db) || (! $this->connected)) { return false; + } $this->error = ''; $stamp1 = microtime(true); - try { - $r = DDDBL\get($strQueryAlias); + try { + $r = DDDBL\get($strQueryAlias); - # bad workaround to emulate the bizzare behavior of mysql_query - if (in_array($strSQLType, array('INSERT', 'UPDATE', 'DELETE', 'CREATE', 'DROP', 'SET'))) - $result = true; - $intErrorCode = false; - - } catch (Exception $objException) { - $result = false; - $intErrorCode = $objPreparedQueryPool->get($strQueryAlias)->get('PDOStatement')->errorCode(); - } + // bad workaround to emulate the bizzare behavior of mysql_query + if (in_array($strSQLType, array('INSERT', 'UPDATE', 'DELETE', 'CREATE', 'DROP', 'SET'))) { + $result = true; + } + $intErrorCode = false; + } catch (Exception $objException) { + $result = false; + $intErrorCode = $objPreparedQueryPool->get($strQueryAlias)->get('PDOStatement')->errorCode(); + } $stamp2 = microtime(true); $duration = (float)($stamp2-$stamp1); $a->save_timestamp($stamp1, "database"); - if (x($a->config,'system') && x($a->config['system'],'db_log')) { + /// @TODO really check $a->config for 'system'? it is very generic and should be there + if (x($a->config, 'system') && x($a->config['system'], 'db_log')) { if (($duration > $a->config["system"]["db_loglimit"])) { $duration = round($duration, 3); $backtrace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS); @@ -152,24 +158,24 @@ class dba { } } - if ($intErrorCode) - $this->error = $intErrorCode; + if ($intErrorCode) { + $this->error = $intErrorCode; + } if (strlen($this->error)) { logger('dba: ' . $this->error); } if ($this->debug) { - $mesg = ''; - if ($result === false) + if ($result === false) { $mesg = 'false'; - elseif ($result === true) + } elseif ($result === true) { $mesg = 'true'; - else { - # this needs fixing, but is a bug itself - #$mesg = mysql_num_rows($result) . ' results' . EOL; + } else { + /// @TODO this needs fixing, but is a bug itself + // $mesg = mysql_num_rows($result) . ' results' . EOL; } $str = 'SQL = ' . printable($sql) . EOL . 'SQL returned ' . $mesg @@ -179,46 +185,49 @@ class dba { logger('dba: ' . $str ); } - /** + /* * If dbfail.out exists, we will write any failed calls directly to it, * regardless of any logging that may or may nor be in effect. * These usually indicate SQL syntax errors that need to be resolved. */ - if (isset($result) AND ($result === false)) { logger('dba: ' . printable($sql) . ' returned false.' . "\n" . $this->error); - if (file_exists('dbfail.out')) + if (file_exists('dbfail.out')) { file_put_contents('dbfail.out', datetime_convert() . "\n" . printable($sql) . ' returned false' . "\n" . $this->error . "\n", FILE_APPEND); + } } - if (isset($result) AND (($result === true) || ($result === false))) + if (isset($result) AND (($result === true) || ($result === false))) { return $result; + } if ($onlyquery) { $this->result = $r; # this will store an PDOStatement Object in result - $this->result->execute(); # execute the Statement, to get its result + $this->result->execute(); # execute the Statement, to get its result return true; } //$a->save_timestamp($stamp1, "database"); - if ($this->debug) + if ($this->debug) { logger('dba: ' . printable(print_r($r, true))); - return($r); + } + + return $r; } public function qfetch() { + if (false === $this->result) { + return false; + } - if (false === $this->result) - return false; - - return $this->result->fetch(); - + return $this->result->fetch(); } public function qclose() { - if ($this->result) - return $this->result->closeCursor(); + if ($this->result) { + return $this->result->closeCursor(); + } } public function dbg($dbg) { @@ -227,17 +236,20 @@ class dba { public function escape($str) { if ($this->db && $this->connected) { - $strQuoted = $this->db->quote($str); - # this workaround is needed, because quote creates "'" and the beginning and the end - # of the string, which is correct. but until now the queries set this delimiter manually, - # so we must remove them from here and wait until everything uses prepared statements - return mb_substr($strQuoted, 1, mb_strlen($strQuoted) - 2); + $strQuoted = $this->db->quote($str); + /* + * this workaround is needed, because quote creates "'" and the beginning and the end + * of the string, which is correct. but until now the queries set this delimiter manually, + * so we must remove them from here and wait until everything uses prepared statements + */ + return mb_substr($strQuoted, 1, mb_strlen($strQuoted) - 2); } } - function __destruct() { - if ($this->db) - DDDBL\disconnect(); + public function __destruct() { + if ($this->db) { + DDDBL\disconnect(); + } } }} @@ -300,34 +312,33 @@ function q($sql) { }} -/** - * - * Raw db query, no arguments - * - */ - if (! function_exists('dbq')) { +/** + * Raw db query, no arguments + */ function dbq($sql) { global $db; - if ($db && $db->connected) + if ($db && $db->connected) { $ret = $db->q($sql); - else + } else { $ret = false; + } return $ret; }} -// Caller is responsible for ensuring that any integer arguments to -// dbesc_array are actually integers and not malformed strings containing -// SQL injection vectors. All integer array elements should be specifically -// cast to int to avoid trouble. - - +/* + * Caller is responsible for ensuring that any integer arguments to + * dbesc_array are actually integers and not malformed strings containing + * SQL injection vectors. All integer array elements should be specifically + * cast to int to avoid trouble. + */ if (! function_exists('dbesc_array_cb')) { function dbesc_array_cb(&$item, $key) { - if (is_string($item)) + if (is_string($item)) { $item = dbesc($item); + } }} @@ -340,5 +351,5 @@ function dbesc_array(&$arr) { if (! function_exists('dba_timer')) { function dba_timer() { - return microtime(true); + return microtime(true); }} diff --git a/include/dbstructure.php b/include/dbstructure.php index 6a14220c24..3aebef0ad8 100644 --- a/include/dbstructure.php +++ b/include/dbstructure.php @@ -3,12 +3,12 @@ use Friendica\App; use Friendica\Core\Config; -require_once("boot.php"); -require_once("include/text.php"); +require_once "boot.php"; +require_once "include/text.php"; define('NEW_UPDATE_ROUTINE_VERSION', 1170); -/* +/** * Converts all tables from MyISAM to InnoDB */ function convert_to_innodb() { @@ -1756,7 +1756,7 @@ function dbstructure_run(&$argv, &$argc) { unset($db_host, $db_user, $db_pass, $db_data); } - if ($argc==2) { + if ($argc == 2) { switch ($argv[1]) { case "dryrun": update_structure(true, false); @@ -1766,7 +1766,7 @@ function dbstructure_run(&$argv, &$argc) { $build = get_config('system','build'); if (!x($build)) { - set_config('system','build',DB_UPDATE_VERSION); + set_config('system', 'build', DB_UPDATE_VERSION); $build = DB_UPDATE_VERSION; } @@ -1776,7 +1776,9 @@ function dbstructure_run(&$argv, &$argc) { // run any left update_nnnn functions in update.php for ($x = $stored; $x < $current; $x ++) { $r = run_update_function($x); - if (!$r) break; + if (!$r) { + break; + } } set_config('system','build',DB_UPDATE_VERSION); @@ -1803,7 +1805,7 @@ function dbstructure_run(&$argv, &$argc) { } -if (array_search(__file__,get_included_files())===0) { +if (array_search(__FILE__,get_included_files())===0) { dbstructure_run($_SERVER["argv"],$_SERVER["argc"]); killme(); } diff --git a/include/diaspora.php b/include/diaspora.php index 820f8bd896..f0d1a8ca31 100644 --- a/include/diaspora.php +++ b/include/diaspora.php @@ -3777,8 +3777,10 @@ class Diaspora { $message = self::construct_like($r[0], $contact); $message["author_signature"] = self::signature($contact, $message); - // We now store the signature more flexible to dynamically support new fields. - // This will break Diaspora compatibility with Friendica versions prior to 3.5. + /* + * Now store the signature more flexible to dynamically support new fields. + * This will break Diaspora compatibility with Friendica versions prior to 3.5. + */ q("INSERT INTO `sign` (`iid`,`signed_text`) VALUES (%d,'%s')", intval($message_id), dbesc(json_encode($message)) @@ -3810,9 +3812,11 @@ class Diaspora { $message = self::construct_comment($item, $contact); $message["author_signature"] = self::signature($contact, $message); - // We now store the signature more flexible to dynamically support new fields. - // This will break Diaspora compatibility with Friendica versions prior to 3.5. - q("INSERT INTO `sign` (`iid`,`signed_text`) VALUES (%d,'%s')", + /* + * Now store the signature more flexible to dynamically support new fields. + * This will break Diaspora compatibility with Friendica versions prior to 3.5. + */ + q("INSERT INTO `sign` (`iid`, `signed_text`) VALUES (%d, '%s')", intval($message_id), dbesc(json_encode($message)) ); diff --git a/include/expire.php b/include/expire.php index 73bffb20dc..aa34cbaa5b 100644 --- a/include/expire.php +++ b/include/expire.php @@ -19,18 +19,17 @@ function expire_run(&$argv, &$argc){ } // make this optional as it could have a performance impact on large sites - - if (intval(get_config('system','optimize_items'))) { + if (intval(get_config('system', 'optimize_items'))) { q("OPTIMIZE TABLE `item`"); } logger('expire: start'); - $r = q("SELECT `uid`,`username`,`expire` FROM `user` WHERE `expire` != 0"); + $r = q("SELECT `uid`, `username`, `expire` FROM `user` WHERE `expire` != 0"); if (dbm::is_result($r)) { foreach ($r as $rr) { logger('Expire: ' . $rr['username'] . ' interval: ' . $rr['expire'], LOGGER_DEBUG); - item_expire($rr['uid'],$rr['expire']); + item_expire($rr['uid'], $rr['expire']); } } From f4a33ed3f0b8358cc419164d74c737c414410f3e Mon Sep 17 00:00:00 2001 From: Roland Haeder Date: Tue, 4 Apr 2017 19:48:13 +0200 Subject: [PATCH 2/4] added spaces + some curly braces + some usage of dbm::is_result() Signed-off-by: Roland Haeder --- include/pgettext.php | 49 ++++++++++++---------- include/plugin.php | 79 +++++++++++++++++++---------------- include/poller.php | 9 ++-- include/post_update.php | 4 +- include/profile_selectors.php | 12 +++--- include/pubsubpublish.php | 7 ++-- include/queue.php | 21 +++++++++- include/queue_fn.php | 11 ++--- include/quoteconvert.php | 6 +-- 9 files changed, 114 insertions(+), 84 deletions(-) diff --git a/include/pgettext.php b/include/pgettext.php index 9b541e8e3c..756905a43a 100644 --- a/include/pgettext.php +++ b/include/pgettext.php @@ -12,15 +12,15 @@ use Friendica\Core\Config; -require_once("include/dba.php"); +require_once "include/dba.php"; -if(! function_exists('get_browser_language')) { +if (! function_exists('get_browser_language')) { /** * @brief get the prefered language from the HTTP_ACCEPT_LANGUAGE header */ function get_browser_language() { - if (x($_SERVER,'HTTP_ACCEPT_LANGUAGE')) { + if (x($_SERVER, 'HTTP_ACCEPT_LANGUAGE')) { // break up string into pieces (languages and q factors) preg_match_all('/([a-z]{1,8}(-[a-z]{1,8})?)\s*(;\s*q\s*=\s*(1|0\.[0-9]+))?/i', $_SERVER['HTTP_ACCEPT_LANGUAGE'], $lang_parse); @@ -29,11 +29,11 @@ function get_browser_language() { if (count($lang_parse[1])) { // go through the list of prefered languages and add a generic language // for sub-linguas (e.g. de-ch will add de) if not already in array - for ($i=0; $i3 ) { + if (strlen($lang_parse[1][$i])>3 ) { $dashpos = strpos($lang_parse[1][$i], '-'); - if (! in_array(substr($lang_parse[1][$i], 0, $dashpos), $lang_list ) ) { + if (!in_array(substr($lang_parse[1][$i], 0, $dashpos), $lang_list ) ) { $lang_list[] = strtolower(substr($lang_parse[1][$i], 0, $dashpos)); } } @@ -42,7 +42,7 @@ function get_browser_language() { } // check if we have translations for the preferred languages and pick the 1st that has - for ($i=0; $ilangsave = $lang; - if($language === $lang) + if ($language === $lang) { return; + } - if(isset($a->strings) && count($a->strings)) { + if (isset($a->strings) && count($a->strings)) { $a->stringsave = $a->strings; } $a->strings = array(); @@ -77,13 +78,15 @@ function push_lang($language) { function pop_lang() { global $lang, $a; - if($lang === $a->langsave) + if ($lang === $a->langsave) { return; + } - if(isset($a->stringsave)) + if (isset($a->stringsave)) { $a->strings = $a->stringsave; - else + } else { $a->strings = array(); + } $lang = $a->langsave; } @@ -91,7 +94,7 @@ function pop_lang() { // l -if(! function_exists('load_translation_table')) { +if (! function_exists('load_translation_table')) { /** * load string translation table for alternate language * @@ -106,15 +109,15 @@ function load_translation_table($lang) { // load enabled plugins strings $plugins = q("SELECT name FROM addon WHERE installed=1;"); if ($plugins!==false) { - foreach($plugins as $p) { + foreach ($plugins as $p) { $name = $p['name']; - if(file_exists("addon/$name/lang/$lang/strings.php")) { + if (file_exists("addon/$name/lang/$lang/strings.php")) { include("addon/$name/lang/$lang/strings.php"); } } } - if(file_exists("view/lang/$lang/strings.php")) { + if (file_exists("view/lang/$lang/strings.php")) { include("view/lang/$lang/strings.php"); } @@ -122,27 +125,27 @@ function load_translation_table($lang) { // translate string if translation exists -if(! function_exists('t')) { +if (! function_exists('t')) { function t($s) { $a = get_app(); - if(x($a->strings,$s)) { + if (x($a->strings,$s)) { $t = $a->strings[$s]; return is_array($t)?$t[0]:$t; } return $s; }} -if(! function_exists('tt')){ +if (! function_exists('tt')){ function tt($singular, $plural, $count){ global $lang; $a = get_app(); - if(x($a->strings,$singular)) { + if (x($a->strings,$singular)) { $t = $a->strings[$singular]; $f = 'string_plural_select_' . str_replace('-','_',$lang); - if(! function_exists($f)) + if (! function_exists($f)) $f = 'string_plural_select_default'; $k = $f($count); return is_array($t)?$t[$k]:$t; @@ -158,7 +161,7 @@ function tt($singular, $plural, $count){ // provide a fallback which will not collide with // a function defined in any language file -if(! function_exists('string_plural_select_default')) { +if (! function_exists('string_plural_select_default')) { function string_plural_select_default($n) { return ($n != 1); }} @@ -185,7 +188,7 @@ function get_available_languages() { $strings_file_paths[] = 'view/lang/en/strings.php'; } asort($strings_file_paths); - foreach($strings_file_paths as $strings_file_path) { + foreach ($strings_file_paths as $strings_file_path) { $path_array = explode('/', $strings_file_path); $langs[$path_array[2]] = $path_array[2]; } diff --git a/include/plugin.php b/include/plugin.php index 336b213aa3..9021f814b1 100644 --- a/include/plugin.php +++ b/include/plugin.php @@ -21,7 +21,7 @@ function uninstall_plugin($plugin){ ); @include_once('addon/' . $plugin . '/' . $plugin . '.php'); - if(function_exists($plugin . '_uninstall')) { + if (function_exists($plugin . '_uninstall')) { $func = $plugin . '_uninstall'; $func(); } @@ -37,12 +37,12 @@ if (! function_exists('install_plugin')){ function install_plugin($plugin) { // silently fail if plugin was removed - if(! file_exists('addon/' . $plugin . '/' . $plugin . '.php')) + if (! file_exists('addon/' . $plugin . '/' . $plugin . '.php')) return false; logger("Addons: installing " . $plugin); $t = @filemtime('addon/' . $plugin . '/' . $plugin . '.php'); @include_once('addon/' . $plugin . '/' . $plugin . '.php'); - if(function_exists($plugin . '_install')) { + if (function_exists($plugin . '_install')) { $func = $plugin . '_install'; $func(); @@ -58,7 +58,7 @@ function install_plugin($plugin) { // once most site tables have been updated. // This way the system won't fall over dead during the update. - if(file_exists('addon/' . $plugin . '/.hidden')) { + if (file_exists('addon/' . $plugin . '/.hidden')) { q("UPDATE `addon` SET `hidden` = 1 WHERE `name` = '%s'", dbesc($plugin) ); @@ -74,10 +74,10 @@ function install_plugin($plugin) { // reload all updated plugins -if(! function_exists('reload_plugins')) { +if (! function_exists('reload_plugins')) { function reload_plugins() { $plugins = get_config('system','addon'); - if(strlen($plugins)) { + if (strlen($plugins)) { $r = q("SELECT * FROM `addon` WHERE `installed` = 1"); if (dbm::is_result($r)) @@ -87,25 +87,25 @@ function reload_plugins() { $parr = explode(',',$plugins); - if(count($parr)) { - foreach($parr as $pl) { + if (count($parr)) { + foreach ($parr as $pl) { $pl = trim($pl); $fname = 'addon/' . $pl . '/' . $pl . '.php'; - if(file_exists($fname)) { + if (file_exists($fname)) { $t = @filemtime($fname); - foreach($installed as $i) { - if(($i['name'] == $pl) && ($i['timestamp'] != $t)) { + foreach ($installed as $i) { + if (($i['name'] == $pl) && ($i['timestamp'] != $t)) { logger('Reloading plugin: ' . $i['name']); @include_once($fname); - if(function_exists($pl . '_uninstall')) { + if (function_exists($pl . '_uninstall')) { $func = $pl . '_uninstall'; $func(); } - if(function_exists($pl . '_install')) { + if (function_exists($pl . '_install')) { $func = $pl . '_install'; $func(); } @@ -143,7 +143,7 @@ function plugin_enabled($plugin) { * @param int $priority A priority (defaults to 0) * @return mixed|bool */ -if(! function_exists('register_hook')) { +if (! function_exists('register_hook')) { function register_hook($hook,$file,$function,$priority=0) { $r = q("SELECT * FROM `hook` WHERE `hook` = '%s' AND `file` = '%s' AND `function` = '%s' LIMIT 1", @@ -171,7 +171,7 @@ function register_hook($hook,$file,$function,$priority=0) { * @param string $function the name of the function that the hook called * @return array */ -if(! function_exists('unregister_hook')) { +if (! function_exists('unregister_hook')) { function unregister_hook($hook,$file,$function) { $r = q("DELETE FROM `hook` WHERE `hook` = '%s' AND `file` = '%s' AND `function` = '%s'", @@ -183,7 +183,7 @@ function unregister_hook($hook,$file,$function) { }} -if(! function_exists('load_hooks')) { +if (! function_exists('load_hooks')) { function load_hooks() { $a = get_app(); $a->hooks = array(); @@ -191,7 +191,7 @@ function load_hooks() { if (dbm::is_result($r)) { foreach ($r as $rr) { - if(! array_key_exists($rr['hook'],$a->hooks)) + if (! array_key_exists($rr['hook'],$a->hooks)) $a->hooks[$rr['hook']] = array(); $a->hooks[$rr['hook']][] = array($rr['file'],$rr['function']); } @@ -245,13 +245,13 @@ function call_single_hook($a, $name, $hook, &$data = null) { //check if an app_menu hook exist for plugin $name. //Return true if the plugin is an app -if(! function_exists('plugin_is_app')) { +if (! function_exists('plugin_is_app')) { function plugin_is_app($name) { $a = get_app(); - if(is_array($a->hooks) && (array_key_exists('app_menu',$a->hooks))) { - foreach($a->hooks['app_menu'] as $hook) { - if($hook[0] == 'addon/'.$name.'/'.$name.'.php') + if (is_array($a->hooks) && (array_key_exists('app_menu',$a->hooks))) { + foreach ($a->hooks['app_menu'] as $hook) { + if ($hook[0] == 'addon/'.$name.'/'.$name.'.php') return true; } } @@ -298,7 +298,7 @@ function get_plugin_info($plugin){ if ($r){ $ll = explode("\n", $m[0]); - foreach( $ll as $l ) { + foreach ( $ll as $l ) { $l = trim($l,"\t\n\r */"); if ($l!=""){ list($k,$v) = array_map("trim", explode(":",$l,2)); @@ -353,9 +353,9 @@ function get_theme_info($theme){ 'unsupported' => false ); - if(file_exists("view/theme/$theme/experimental")) + if (file_exists("view/theme/$theme/experimental")) $info['experimental'] = true; - if(file_exists("view/theme/$theme/unsupported")) + if (file_exists("view/theme/$theme/unsupported")) $info['unsupported'] = true; if (!is_file("view/theme/$theme/theme.php")) return $info; @@ -369,7 +369,7 @@ function get_theme_info($theme){ if ($r){ $ll = explode("\n", $m[0]); - foreach( $ll as $l ) { + foreach ( $ll as $l ) { $l = trim($l,"\t\n\r */"); if ($l!=""){ list($k,$v) = array_map("trim", explode(":",$l,2)); @@ -413,7 +413,7 @@ function get_theme_info($theme){ */ function get_theme_screenshot($theme) { $exts = array('.png','.jpg'); - foreach($exts as $ext) { + foreach ($exts as $ext) { if (file_exists('view/theme/' . $theme . '/screenshot' . $ext)) { return(App::get_baseurl() . '/view/theme/' . $theme . '/screenshot' . $ext); } @@ -512,11 +512,11 @@ function service_class_fetch($uid,$property) { $service_class = $r[0]['service_class']; } } - if(! x($service_class)) + if (! x($service_class)) return false; // everything is allowed $arr = get_config('service_class',$service_class); - if(! is_array($arr) || (! count($arr))) + if (! is_array($arr) || (! count($arr))) return false; return((array_key_exists($property,$arr)) ? $arr[$property] : false); @@ -525,12 +525,14 @@ function service_class_fetch($uid,$property) { function upgrade_link($bbcode = false) { $l = get_config('service_class','upgrade_link'); - if(! $l) + if (! $l) { return ''; - if($bbcode) + } + if ($bbcode) { $t = sprintf('[url=%s]' . t('Click here to upgrade.') . '[/url]', $l); - else + } else { $t = sprintf('' . t('Click here to upgrade.') . '', $l); + } return $t; } @@ -557,13 +559,15 @@ function upgrade_bool_message($bbcode = false) { */ function theme_include($file, $root = '') { // Make sure $root ends with a slash / if it's not blank - if($root !== '' && $root[strlen($root)-1] !== '/') + if ($root !== '' && $root[strlen($root)-1] !== '/') { $root = $root . '/'; + } $theme_info = $a->theme_info; - if(is_array($theme_info) AND array_key_exists('extends',$theme_info)) + if (is_array($theme_info) AND array_key_exists('extends',$theme_info)) { $parent = $theme_info['extends']; - else + } else { $parent = 'NOPATH'; + } $theme = current_theme(); $thname = $theme; $ext = substr($file,strrpos($file,'.')+1); @@ -572,12 +576,13 @@ function theme_include($file, $root = '') { "{$root}view/theme/$parent/$ext/$file", "{$root}view/$ext/$file", ); - foreach($paths as $p) { + foreach ($paths as $p) { // strpos() is faster than strstr when checking if one string is in another (http://php.net/manual/en/function.strstr.php) - if(strpos($p,'NOPATH') !== false) + if (strpos($p,'NOPATH') !== false) { continue; - if(file_exists($p)) + } elseif (file_exists($p)) { return $p; + } } return ''; } diff --git a/include/poller.php b/include/poller.php index ae249ffe46..0600434a71 100644 --- a/include/poller.php +++ b/include/poller.php @@ -23,7 +23,7 @@ function poller_run($argv, $argc){ $a = new App(dirname(__DIR__)); } - if(is_null($db)) { + if (is_null($db)) { @include(".htconfig.php"); require_once("include/dba.php"); $db = new dba($db_host, $db_user, $db_pass, $db_data); @@ -55,7 +55,7 @@ function poller_run($argv, $argc){ return; } - if(($argc <= 1) OR ($argv[1] != "no_cron")) { + if (($argc <= 1) OR ($argv[1] != "no_cron")) { poller_run_cron(); } @@ -378,8 +378,9 @@ function poller_kill_stale_workers() { // Kill long running processes // Check if the priority is in a valid range - if (!in_array($pid["priority"], array(PRIORITY_CRITICAL, PRIORITY_HIGH, PRIORITY_MEDIUM, PRIORITY_LOW, PRIORITY_NEGLIGIBLE))) + if (!in_array($pid["priority"], array(PRIORITY_CRITICAL, PRIORITY_HIGH, PRIORITY_MEDIUM, PRIORITY_LOW, PRIORITY_NEGLIGIBLE))) { $pid["priority"] = PRIORITY_MEDIUM; + } // Define the maximum durations $max_duration_defaults = array(PRIORITY_CRITICAL => 360, PRIORITY_HIGH => 10, PRIORITY_MEDIUM => 60, PRIORITY_LOW => 180, PRIORITY_NEGLIGIBLE => 360); @@ -421,7 +422,7 @@ function poller_too_much_workers() { // Decrease the number of workers at higher load $load = current_load(); - if($load) { + if ($load) { $maxsysload = intval(Config::get("system", "maxloadavg", 50)); $maxworkers = $queues; diff --git a/include/post_update.php b/include/post_update.php index 9d18b27b4f..af49bb555c 100644 --- a/include/post_update.php +++ b/include/post_update.php @@ -68,7 +68,7 @@ function post_update_1192() { } // Set the "gcontact-id" in the item table and add a new gcontact entry if needed - foreach($item_arr AS $item) { + foreach ($item_arr AS $item) { $gcontact_id = get_gcontact_id(array("url" => $item['author-link'], "network" => $item['network'], "photo" => $item['author-avatar'], "name" => $item['author-name'])); q("UPDATE `item` SET `gcontact-id` = %d WHERE `uid` = %d AND `author-link` = '%s' AND `gcontact-id` = 0", @@ -204,7 +204,7 @@ function post_update_1198() { } // Set the "gcontact-id" in the item table and add a new gcontact entry if needed - foreach($item_arr AS $item) { + foreach ($item_arr AS $item) { $author_id = get_contact($item["author-link"], 0); $owner_id = get_contact($item["owner-link"], 0); diff --git a/include/profile_selectors.php b/include/profile_selectors.php index 8d29fd0998..af6c0d96c4 100644 --- a/include/profile_selectors.php +++ b/include/profile_selectors.php @@ -8,8 +8,8 @@ function gender_selector($current="",$suffix="") { call_hooks('gender_selector', $select); $o .= ""; - foreach($select as $selection) { - if($selection !== 'NOTRANSLATION') { + foreach ($select as $selection) { + if ($selection !== 'NOTRANSLATION') { $selected = (($selection == $current) ? ' selected="selected" ' : ''); $o .= ""; } @@ -44,8 +44,8 @@ function marital_selector($current="",$suffix="") { call_hooks('marital_selector', $select); $o .= "