From 09b7e217c718f88379652112e428229073408c88 Mon Sep 17 00:00:00 2001
From: Andreas Neustifter <andreas.neustifter@gmail.com>
Date: Tue, 10 Jul 2018 00:20:57 +0200
Subject: [PATCH] [Suggestion] Move New User Tip Link (#5342)

* Move new member tips to navigation bar.

The link looks so forlorn when its just somewhere in there. Put it in the nav bar.

* Style new member hints link propery.

* Make changes requested by @MrPetovan.
---
 mod/profile.php               |  4 ----
 src/Model/Profile.php         | 10 ++++++++++
 view/global.css               |  4 +---
 view/theme/frio/css/style.css |  4 ++++
 view/theme/vier/style.css     |  5 +++++
 5 files changed, 20 insertions(+), 7 deletions(-)

diff --git a/mod/profile.php b/mod/profile.php
index 8d156cbd64..93172397b2 100644
--- a/mod/profile.php
+++ b/mod/profile.php
@@ -191,10 +191,6 @@ function profile_content(App $a, $update = 0)
 
 		$o .= Widget::commonFriendsVisitor($a->profile['profile_uid']);
 
-		if (x($_SESSION, 'new_member') && $is_owner) {
-			$o .= '<div id="newmember-tips"><a href="newmember"><b>' . L10n::t('Tips for New Members') . '</b></a></div>';
-		}
-
 		$commpage = $a->profile['page-flags'] == PAGE_COMMUNITY;
 		$commvisitor = $commpage && $remote_contact;
 
diff --git a/src/Model/Profile.php b/src/Model/Profile.php
index 94d8de572c..c006f18400 100644
--- a/src/Model/Profile.php
+++ b/src/Model/Profile.php
@@ -947,6 +947,16 @@ class Profile
 			];
 		}
 
+		if (!empty($_SESSION['new_member']) && $is_owner) {
+			$tabs[] = [
+				'label' => L10n::t('Tips for New Members'),
+				'url'   => System::baseUrl() . '/newmember',
+				'sel'   => false,
+				'title' => L10n::t('Tips for New Members'),
+				'id'    => 'newmember-tab',
+			];
+		}
+
 		if (!$is_owner && empty($a->profile['hide-friends'])) {
 			$tabs[] = [
 				'label' => L10n::t('Contacts'),
diff --git a/view/global.css b/view/global.css
index 0e6a36e2c6..4a4a169aa7 100644
--- a/view/global.css
+++ b/view/global.css
@@ -207,10 +207,8 @@ blockquote.shared_content {
 }
 
 #newmember-tips {
+  margin-top: -3px;
   font-size: 1.2em;
-  float: right;
-  margin-top: -32px;
-  padding-right: 10px;
 }
 
 /* headers */
diff --git a/view/theme/frio/css/style.css b/view/theme/frio/css/style.css
index ed64ba638c..9f5fe71766 100644
--- a/view/theme/frio/css/style.css
+++ b/view/theme/frio/css/style.css
@@ -972,6 +972,10 @@ nav.navbar a, nav.navbar .btn-link {
     padding: 2px 10px;
 }
 
+#newmember-tab > a {
+  font-size: 1.2em;
+  font-weight: 800;
+}
 
 /*
  * Aside
diff --git a/view/theme/vier/style.css b/view/theme/vier/style.css
index 475fda035e..c70af646c7 100644
--- a/view/theme/vier/style.css
+++ b/view/theme/vier/style.css
@@ -2340,6 +2340,11 @@ ul.tabs li .active, span.pager_current a {
   text-decoration: none;
 }
 
+#newmember-tab > a {
+  font-size: 1.2em;
+  font-weight: 800;
+}
+
 /**
  * Form fields
  */