blockbot: Adding new bots to the blocklist #869

Merged
annando merged 2 commits from bots into develop 4 years ago
annando commented 4 years ago (Migrated from github.com)

Some new bots are added.

Some new bots are added.
MrPetovan (Migrated from github.com) approved these changes 4 years ago
MrPetovan commented 4 years ago (Migrated from github.com)
FYI: https://social.mootech.eu/@maxine/102412789235076104
annando commented 4 years ago (Migrated from github.com)

I already had seen that. I was considering adding that agent to the block list as well. But in fact we already are having a working server block mechanism.

I already had seen that. I was considering adding that agent to the block list as well. But in fact we already are having a working server block mechanism.
MrPetovan (Migrated from github.com) approved these changes 4 years ago
MrPetovan commented 4 years ago (Migrated from github.com)

Yes, but this crawler block would apply to any server running the Gab social software.

Yes, but this crawler block would apply to any server running the Gab social software.
annando commented 4 years ago (Migrated from github.com)

Yeah, I see the benefit. I only don't want to hardcode this. So possibly we can add some configuration.

Yeah, I see the benefit. I only don't want to hardcode this. So possibly we can add some configuration.
MrPetovan commented 4 years ago (Migrated from github.com)

Fair enough.

Fair enough.
MrPetovan commented 4 years ago (Migrated from github.com)

@tobiasd Thanks for the merge, but if I understand @annando 's process correctly, I think he wanted to have a permanently-open PR to keep adding more bots without having to submit a PR each time. He should have used the Draft PR feature of course, but so far he seems to have been unable to find the button.

@tobiasd Thanks for the merge, but if I understand @annando 's process correctly, I think he wanted to have a permanently-open PR to keep adding more bots without having to submit a PR each time. He should have used the Draft PR feature of course, but so far he seems to have been unable to find the button.
tobiasd commented 4 years ago (Migrated from github.com)

I remember he had written a note about that in the last PR, but as it was missing in this PR I thought that was only with the initial collection of bots.

I remember he had written a note about that in the last PR, but as it was missing in this PR I thought that was only with the initial collection of bots.
MrPetovan commented 4 years ago (Migrated from github.com)

I don't blame you, and you may even be right in this instance.

I don't blame you, and you may even be right in this instance.
annando commented 4 years ago (Migrated from github.com)

I was asking myself how we could handle this. Possibly we can do a merge whenever the list grew significantly or so.

P.S.: I used the draft thingy in some previous PR if you might remember 😬

I was asking myself how we could handle this. Possibly we can do a merge whenever the list grew significantly or so. P.S.: I used the draft thingy in some previous PR if you might remember :grimacing:

Reviewers

The pull request has been merged as aeddb3283d.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b bots develop
git pull origin bots

Step 2:

Merge the changes and update on Forgejo.
git checkout develop
git merge --no-ff bots
git push origin develop
Sign in to join this conversation.
Loading…
There is no content yet.