friendica/friendica-addons
7
2
Fork 14
Code Issues 3 Pull requests 3 Releases 16 Wiki Activity

Audon audioplayer App #1414

Merged
MrPetovan merged 19 commits from :develop into develop 2023-08-18 18:41:35 +02:00
Conversation 5 Commits 19 Files changed 4 +8 -7
1 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit f93c242568 - Show all commits

13
audon/audon.php
View file

@ -1,7 +1,7 @@
<?php
/*
* Name: AUDON Application
* Description: add a audon instance for audio. Based on webRTC Addon
* Name: Audon Application
loma-one marked this conversation as resolved Outdated
MrPetovan commented 2023-08-18 16:05:41 +02:00
Outdated
Review
Copy link

Please capitalize the Audon name when not used in code context.

Please capitalize the Audon name when not used in code context.
loma-one marked this conversation as resolved Outdated
MrPetovan commented 2023-08-18 16:28:19 +02:00
Outdated
Review
Copy link

Thanks for the change, however I meant "Audon", not "AUDON". I'll highlight the other instances I noticed.

Thanks for the change, however I meant "Audon", not "AUDON". I'll highlight the other instances I noticed.
* Description: add a audon instance. Based on webRTC Addon
loma-one marked this conversation as resolved Outdated
MrPetovan commented 2023-08-18 16:28:39 +02:00
Outdated
Review
Copy link

Add an Audon instance

`Add an Audon instance`
* Version: 0.1
* Author: Stephen Mahood <https://friends.mayfirst.org/profile/marxistvegan>
* Author: Tobias Diekershoff <https://f.diekershoff.de/profile/tobias>
@ -19,7 +19,7 @@ function audon_install()
function audon_app_menu(array &$b)
{
$b['app_menu'][] = '<div class="app-title"><a href="audon">' . DI::l10n()->t('audon Audiochat') . '</a></div>';
$b['app_menu'][] = '<div class="app-title"><a href="audon">' . DI::l10n()->t('Audon Audiochat') . '</a></div>';
loma-one marked this conversation as resolved Outdated
MrPetovan commented 2023-08-18 16:28:56 +02:00
Outdated
Review
Copy link

Audon Audiochat

`Audon Audiochat`
}
function audon_addon_admin(string &$o)
@ -29,9 +29,9 @@ function audon_addon_admin(string &$o)
'$submit' => DI::l10n()->t('Save Settings'),
'$audonurl' => [
'audonurl',
DI::l10n()->t('audon Base URL'),
DI::l10n()->t('Audon Base URL'),
loma-one marked this conversation as resolved Outdated
MrPetovan commented 2023-08-18 16:30:25 +02:00
Outdated
Review
Copy link
			DI::l10n()->t('Audon Base URL'),
```php DI::l10n()->t('Audon Base URL'), ```
DI::config()->get('audon','audonurl'),
loma-one marked this conversation as resolved Outdated
MrPetovan commented 2023-08-18 16:06:11 +02:00
Outdated
Review
Copy link

Code standards: Please add a space after commas.

Code standards: Please add a space after commas.
loma-one marked this conversation as resolved
MrPetovan commented 2023-08-18 16:29:09 +02:00
Review
Copy link
			DI::config()->get('audon', 'audonurl'),
```php DI::config()->get('audon', 'audonurl'), ```
DI::l10n()->t('Page your users will create a audon Audio chat room on. For example you could use https://audon.space.'),
DI::l10n()->t('Page your users will create an Audon audio chat room on. For example you could use https://audon.space.'),
loma-one marked this conversation as resolved Outdated
MrPetovan commented 2023-08-18 16:29:27 +02:00
Outdated
Review
Copy link

Page your users will create an Audon audio chat room on. For example you could use https://audon.space.

`Page your users will create an Audon audio chat room on. For example you could use https://audon.space.`
],
]);
}
@ -55,11 +55,12 @@ function audon_content(): string
/* landingpage to create chatrooms */
$audonurl = DI::config()->get('audon', 'audonurl');
loma-one marked this conversation as resolved Outdated
MrPetovan commented 2023-08-18 16:29:42 +02:00
Outdated
Review
Copy link
	$audonurl = DI::config()->get('audon', 'audonurl');
```php $audonurl = DI::config()->get('audon', 'audonurl'); ```
/* embedd the landing page in an iframe */
$o .= '<h2>' . DI::l10n()->t('Audio Chat') . '</h2>';
$o .= '<p>' . DI::l10n()->t('Audon is an audio conferencing tool. Connect your account to Audon and create a room. Share the generated link to talk to other participants.') . '</p>';
if ($audonurl == '') {
loma-one marked this conversation as resolved
MrPetovan commented 2023-08-18 16:32:24 +02:00
Review
Copy link

Please contact your Friendica administrator to remind them to configure the Audon addon.

`Please contact your Friendica administrator to remind them to configure the Audon addon.`
$o .= '<p>' . DI::l10n()->t('Please contact your friendica administrator to remind them to configure the Audon addon.') . '</p>';
$o .= '<p>' . DI::l10n()->t('Please contact your Friendica administrator to remind them to configure the Audon addon.') . '</p>';
} else {
$o .= '<iframe src="' . $audonurl . '" width="740px" height="600px"></iframe>';
}