From c5602f427a30c90fa45de5c1e29dc84c4c8af476 Mon Sep 17 00:00:00 2001 From: Hypolite Petovan Date: Sun, 3 Jul 2022 11:40:59 -0400 Subject: [PATCH] [twitter] Add logging for error conditions in twitter_fetchtimeline() --- twitter/twitter.php | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/twitter/twitter.php b/twitter/twitter.php index 5e3a4b9c..dd3f8986 100644 --- a/twitter/twitter.php +++ b/twitter/twitter.php @@ -1257,22 +1257,26 @@ function twitter_fetchtimeline(App $a, int $uid) } if ($first_time) { + Logger::warning('First time, continue'); continue; } - if (!stristr($post->source, $application_name)) { - Logger::info('Preparing mirror post', ['twitter-id' => $post->id_str, 'uid' => $uid]); - - $mirrorpost = twitter_do_mirrorpost($a, $uid, $post); - - if (empty($mirrorpost['body'])) { - continue; - } - - Logger::info('Posting mirror post', ['twitter-id' => $post->id_str, 'uid' => $uid]); - - Post\Delayed::add($mirrorpost['extid'], $mirrorpost, PRIORITY_MEDIUM, Post\Delayed::UNPREPARED); + if (stristr($post->source, $application_name)) { + Logger::warning('Source is application name', ['source' => $post->source, 'application_name' => $application_name]); + continue; } + Logger::info('Preparing mirror post', ['twitter-id' => $post->id_str, 'uid' => $uid]); + + $mirrorpost = twitter_do_mirrorpost($a, $uid, $post); + + if (empty($mirrorpost['body'])) { + Logger::warning('Body is empty', ['post' => $post, 'mirrorpost' => $mirrorpost]); + continue; + } + + Logger::info('Posting mirror post', ['twitter-id' => $post->id_str, 'uid' => $uid]); + + Post\Delayed::add($mirrorpost['extid'], $mirrorpost, PRIORITY_MEDIUM, Post\Delayed::UNPREPARED); } } DI::pConfig()->set($uid, 'twitter', 'lastid', $lastid);