From 9e73131493c901a10e048ca4e3b8f7e4905c3bb7 Mon Sep 17 00:00:00 2001 From: Hypolite Petovan Date: Fri, 15 Jun 2018 20:53:50 -0400 Subject: [PATCH 1/3] [twitter] Fix PHP 7.2 notice in twitter_fetchparentposts --- twitter/twitter.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/twitter/twitter.php b/twitter/twitter.php index a38fd72b..d9f6f20f 100644 --- a/twitter/twitter.php +++ b/twitter/twitter.php @@ -1578,7 +1578,7 @@ function twitter_fetchparentposts(App $a, $uid, $post, $connection, $self, $own_ break; } - if (!count($post)) { + if (empty($post)) { logger("twitter_fetchparentposts: Can't fetch post " . $parameters->id, LOGGER_DEBUG); break; } From b5f687f816c7bd05b4396caa17d046824fe0dfa2 Mon Sep 17 00:00:00 2001 From: Hypolite Petovan Date: Fri, 15 Jun 2018 20:54:07 -0400 Subject: [PATCH 2/3] [twitter] Cleanup use list --- twitter/twitter.php | 1 - 1 file changed, 1 deletion(-) diff --git a/twitter/twitter.php b/twitter/twitter.php index d9f6f20f..cc73627a 100644 --- a/twitter/twitter.php +++ b/twitter/twitter.php @@ -75,7 +75,6 @@ use Friendica\Model\Contact; use Friendica\Model\Group; use Friendica\Model\Item; use Friendica\Model\ItemContent; -use Friendica\Model\Photo; use Friendica\Model\Queue; use Friendica\Model\User; use Friendica\Object\Image; From fb0e99ba0e7de50aed141e252b3df9eb9b19ad42 Mon Sep 17 00:00:00 2001 From: Hypolite Petovan Date: Fri, 15 Jun 2018 20:54:19 -0400 Subject: [PATCH 3/3] [twitter] Add type hint to twitter_fetchparentposts --- twitter/twitter.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/twitter/twitter.php b/twitter/twitter.php index cc73627a..da103aea 100644 --- a/twitter/twitter.php +++ b/twitter/twitter.php @@ -1561,7 +1561,7 @@ function twitter_checknotification(App $a, $uid, $own_id, $top_item, $postarray) } } -function twitter_fetchparentposts(App $a, $uid, $post, $connection, $self, $own_id) +function twitter_fetchparentposts(App $a, $uid, $post, TwitterOAuth $connection, $self, $own_id) { logger("twitter_fetchparentposts: Fetching for user " . $uid . " and post " . $post->id_str, LOGGER_DEBUG);