From da4b08fc4a3e98451d4265ace66a409e39a06402 Mon Sep 17 00:00:00 2001 From: Alexandre Alapetite Date: Thu, 28 Sep 2017 21:24:07 +0200 Subject: [PATCH] SQL fix fbrowser (RC) https://github.com/friendica/friendica/pull/3742 Fixing non-standard GROUP BY, and non-standard ORDER BY. ``` DB Error 1055: Expression #2 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'friendica.photo.id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by q, fbrowser_content SELECT `resource-id`, `id`, `filename`, type, min(`scale`) AS `hiq`,max(`scale`) AS `loq`, `desc` FROM `photo` WHERE `uid` = 1 AND `album` != 'Contact Photos' AND `album` != 'Contact Photos' GROUP BY `resource-id` ORDER BY created DESC LIMIT 0, 10 2017-09-27T17:16:35Z@tmkfko6titb71nug3i4vr1mnb1 [NORMAL]:dba.php:553:p DB Error 1055: Expression #2 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'friendica.photo.id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by q, fbrowser_content ``` ``` ERROR 1055 (42000): Expression #1 of ORDER BY clause is not in GROUP BY clause and contains nonaggregated column 'friendica.photo.created' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by ``` --- mod/fbrowser.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mod/fbrowser.php b/mod/fbrowser.php index d1448b81d..ce90eaee9 100644 --- a/mod/fbrowser.php +++ b/mod/fbrowser.php @@ -56,7 +56,8 @@ function fbrowser_content(App $a) { $path[]=array($a->argv[2], $album); } - $r = q("SELECT `resource-id`, `id`, `filename`, type, min(`scale`) AS `hiq`,max(`scale`) AS `loq`, `desc` + $r = q("SELECT `resource-id`, ANY_VALUE(`id`) AS `id`, ANY_VALUE(`filename`) AS `filename`, ANY_VALUE(`type`) AS `type`, + min(`scale`) AS `hiq`, max(`scale`) AS `loq`, ANY_VALUE(`desc`) AS `desc`, ANY_VALUE(`created`) AS `created` FROM `photo` WHERE `uid` = %d $sql_extra AND `album` != '%s' AND `album` != '%s' GROUP BY `resource-id` $sql_extra2", intval(local_user()),