diff --git a/bin/dev/minifyjs.sh b/bin/dev/minifyjs.sh index 50a56a45c..caa2b3846 100755 --- a/bin/dev/minifyjs.sh +++ b/bin/dev/minifyjs.sh @@ -5,16 +5,13 @@ command -v uglifyjs >/dev/null 2>&1 || { echo >&2 "I require UglifyJS but it's n MINIFY_CMD=uglifyjs JSFILES=( - "view/js/acl.js" "view/js/ajaxupload.js" "view/js/country.js" "view/js/main.js" "vendor/asset/base64/base64.min.js" - "view/theme/frost/js/acl.js" "view/theme/frost/js/jquery.divgrow-1.3.1.f1.js" "view/theme/frost/js/main.js" "view/theme/frost/js/theme.js" - "view/theme/frost-mobile/js/acl.js" "view/theme/frost-mobile/js/jquery.divgrow-1.3.1.f1.js" "view/theme/frost-mobile/js/main.js" "view/theme/frost-mobile/js/theme.js" diff --git a/mod/community.php b/mod/community.php index 81857c6d3..4d98f0c4f 100644 --- a/mod/community.php +++ b/mod/community.php @@ -125,7 +125,7 @@ function community_content(App $a, $update = 0) 'default_location' => $a->user['default-location'], 'nickname' => $a->user['nickname'], 'lockstate' => (is_array($a->user) && (strlen($a->user['allow_cid']) || strlen($a->user['allow_gid']) || strlen($a->user['deny_cid']) || strlen($a->user['deny_gid'])) ? 'lock' : 'unlock'), - 'acl' => ACL::getFullSelectorHTML($a->user, true), + 'acl' => ACL::getFullSelectorHTML($a->page, $a->user, true), 'bang' => '', 'visitor' => 'block', 'profile_uid' => local_user(), diff --git a/mod/display.php b/mod/display.php index 12fa8d7ec..175616f98 100644 --- a/mod/display.php +++ b/mod/display.php @@ -304,7 +304,7 @@ function display_content(App $a, $update = false, $update_uid = 0) 'default_location' => $a->user['default-location'], 'nickname' => $a->user['nickname'], 'lockstate' => (is_array($a->user) && (strlen($a->user['allow_cid']) || strlen($a->user['allow_gid']) || strlen($a->user['deny_cid']) || strlen($a->user['deny_gid'])) ? 'lock' : 'unlock'), - 'acl' => ACL::getFullSelectorHTML($a->user, true), + 'acl' => ACL::getFullSelectorHTML($a->page, $a->user, true), 'bang' => '', 'visitor' => 'block', 'profile_uid' => local_user(), diff --git a/mod/events.php b/mod/events.php index 11bb25f51..a642f1665 100644 --- a/mod/events.php +++ b/mod/events.php @@ -13,6 +13,7 @@ use Friendica\Core\L10n; use Friendica\Core\Logger; use Friendica\Core\Renderer; use Friendica\Core\System; +use Friendica\Core\Theme; use Friendica\Core\Worker; use Friendica\Database\DBA; use Friendica\Model\Event; @@ -384,6 +385,12 @@ function events_content(App $a) $events[$key]['item'] = $event_item; } + // ACL blocks are loaded in modals in frio + $a->page->registerFooterScript(Theme::getPathForFile('asset/typeahead.js/dist/typeahead.bundle.js')); + $a->page->registerFooterScript(Theme::getPathForFile('js/friendica-tagsinput/friendica-tagsinput.js')); + $a->page->registerStylesheet(Theme::getPathForFile('js/friendica-tagsinput/friendica-tagsinput.css')); + $a->page->registerStylesheet(Theme::getPathForFile('js/friendica-tagsinput/friendica-tagsinput-typeahead.css')); + $o = Renderer::replaceMacros($tpl, [ '$tabs' => $tabs, '$title' => L10n::t('Events'), @@ -486,7 +493,7 @@ function events_content(App $a) $perms = ACL::getDefaultUserPermissions($orig_event); if (!$cid && in_array($mode, ['new', 'copy'])) { - $acl = ACL::getFullSelectorHTML($a->user, false, $orig_event); + $acl = ACL::getFullSelectorHTML($a->page, $a->user, false, $perms); } else { $acl = ''; } @@ -506,11 +513,6 @@ function events_content(App $a) '$cid' => $cid, '$uri' => $uri, - '$allow_cid' => json_encode($perms['allow_cid']), - '$allow_gid' => json_encode($perms['allow_gid']), - '$deny_cid' => json_encode($perms['deny_cid']), - '$deny_gid' => json_encode($perms['deny_gid']), - '$title' => L10n::t('Event details'), '$desc' => L10n::t('Starting date and Title are required.'), '$s_text' => L10n::t('Event Starts:') . ' *', diff --git a/mod/network.php b/mod/network.php index 5fbfa9a5d..44c7c8b44 100644 --- a/mod/network.php +++ b/mod/network.php @@ -377,7 +377,7 @@ function networkFlatView(App $a, $update = 0) (strlen($a->user['allow_cid']) || strlen($a->user['allow_gid']) || strlen($a->user['deny_cid']) || strlen($a->user['deny_gid'])) ? 'lock' : 'unlock'), 'default_perms' => ACL::getDefaultUserPermissions($a->user), - 'acl' => ACL::getFullSelectorHTML($a->user, true), + 'acl' => ACL::getFullSelectorHTML($a->page, $a->user, true), 'bang' => '', 'visitor' => 'block', 'profile_uid' => local_user(), @@ -554,7 +554,7 @@ function networkThreadedView(App $a, $update, $parent) (strlen($a->user['allow_cid']) || strlen($a->user['allow_gid']) || strlen($a->user['deny_cid']) || strlen($a->user['deny_gid']))) ? 'lock' : 'unlock'), 'default_perms' => ACL::getDefaultUserPermissions($a->user), - 'acl' => ACL::getFullSelectorHTML($a->user, true, $default_permissions), + 'acl' => ACL::getFullSelectorHTML($a->page, $a->user, true, $default_permissions), 'bang' => (($gid || $cid || $nets) ? '!' : ''), 'visitor' => 'block', 'profile_uid' => local_user(), diff --git a/mod/photos.php b/mod/photos.php index e0630e7dc..684e525d4 100644 --- a/mod/photos.php +++ b/mod/photos.php @@ -960,7 +960,7 @@ function photos_content(App $a) $tpl = Renderer::getMarkupTemplate('photos_upload.tpl'); - $aclselect_e = ($visitor ? '' : ACL::getFullSelectorHTML($a->user)); + $aclselect_e = ($visitor ? '' : ACL::getFullSelectorHTML($a->page, $a->user)); $o .= Renderer::replaceMacros($tpl,[ '$pagename' => L10n::t('Upload Photos'), @@ -1332,7 +1332,7 @@ function photos_content(App $a) $album_e = $ph[0]['album']; $caption_e = $ph[0]['desc']; - $aclselect_e = ACL::getFullSelectorHTML($a->user, false, $ph[0]); + $aclselect_e = ACL::getFullSelectorHTML($a->page, $a->user, false, $ph[0]); $edit = Renderer::replaceMacros($edit_tpl, [ '$id' => $ph[0]['id'], diff --git a/mod/settings.php b/mod/settings.php index 45867c7ef..c7fcbc0e5 100644 --- a/mod/settings.php +++ b/mod/settings.php @@ -1206,7 +1206,7 @@ function settings_content(App $a) '$permissions' => L10n::t('Default Post Permissions'), '$permdesc' => L10n::t("\x28click to open/close\x29"), '$visibility' => $profile['net-publish'], - '$aclselect' => ACL::getFullSelectorHTML($a->user), + '$aclselect' => ACL::getFullSelectorHTML($a->page, $a->user), '$suggestme' => $suggestme, '$blockwall'=> $blockwall, // array('blockwall', L10n::t('Allow friends to post to your profile page:'), !$blockwall, ''), '$blocktags'=> $blocktags, // array('blocktags', L10n::t('Allow friends to tag your posts:'), !$blocktags, ''), diff --git a/src/App/Page.php b/src/App/Page.php index 7af0bc899..7b3bc286f 100644 --- a/src/App/Page.php +++ b/src/App/Page.php @@ -15,6 +15,7 @@ use Friendica\Core\Renderer; use Friendica\Core\Theme; use Friendica\Module\Special\HTTPException as ModuleHTTPException; use Friendica\Network\HTTPException; +use Friendica\Util\Strings; /** * Contains the page specific environment variables for the current Page @@ -224,15 +225,15 @@ class Page implements ArrayAccess * being first */ $this->page['htmlhead'] = Renderer::replaceMacros($tpl, [ - '$local_user' => local_user(), - '$generator' => 'Friendica' . ' ' . FRIENDICA_VERSION, - '$delitem' => $l10n->t('Delete this item?'), - '$update_interval' => $interval, - '$shortcut_icon' => $shortcut_icon, - '$touch_icon' => $touch_icon, - '$block_public' => intval($config->get('system', 'block_public')), - '$stylesheets' => $this->stylesheets, - ]) . $this->page['htmlhead']; + '$local_user' => local_user(), + '$generator' => 'Friendica' . ' ' . FRIENDICA_VERSION, + '$delitem' => $l10n->t('Delete this item?'), + '$update_interval' => $interval, + '$shortcut_icon' => $shortcut_icon, + '$touch_icon' => $touch_icon, + '$block_public' => intval($config->get('system', 'block_public')), + '$stylesheets' => array_unique($this->stylesheets), + ]) . $this->page['htmlhead']; } /** @@ -282,8 +283,8 @@ class Page implements ArrayAccess $tpl = Renderer::getMarkupTemplate('footer.tpl'); $this->page['footer'] = Renderer::replaceMacros($tpl, [ - '$footerScripts' => $this->footerScripts, - ]) . $this->page['footer']; + '$footerScripts' => array_unique($this->footerScripts), + ]) . $this->page['footer']; } /** @@ -455,13 +456,13 @@ class Page implements ArrayAccess * to load another page template than the default one. * The page templates are located in /view/php/ or in the theme directory. */ - if (isset($_GET["mode"])) { - $template = Theme::getPathForFile($_GET["mode"] . '.php'); + if (isset($_GET['mode'])) { + $template = Theme::getPathForFile('php/' . Strings::sanitizeFilePathItem($_GET['mode']) . '.php'); } // If there is no page template use the default page template if (empty($template)) { - $template = Theme::getPathForFile("default.php"); + $template = Theme::getPathForFile('php/default.php'); } // Theme templates expect $a as an App instance @@ -470,7 +471,6 @@ class Page implements ArrayAccess // Used as is in view/php/default.php $lang = $l10n->getCurrentLang(); - /// @TODO Looks unsafe (remote-inclusion), is maybe not but Core\Theme::getPathForFile() uses file_exists() but does not escape anything require_once $template; } } diff --git a/src/Core/ACL.php b/src/Core/ACL.php index df2f86e2b..880a1e47f 100644 --- a/src/Core/ACL.php +++ b/src/Core/ACL.php @@ -6,13 +6,11 @@ namespace Friendica\Core; +use Friendica\App\Page; use Friendica\BaseObject; -use Friendica\Content\Feature; use Friendica\Database\DBA; use Friendica\Model\Contact; -use Friendica\Model\GContact; -use Friendica\Core\Session; -use Friendica\Util\Network; +use Friendica\Model\Group; /** * Handle ACL management and display @@ -251,29 +249,110 @@ class ACL extends BaseObject ]; } + /** + * Returns the ACL list of contacts for a given user id + * + * @param int $user_id + * @return array + * @throws \Exception + */ + public static function getContactListByUserId(int $user_id) + { + $acl_contacts = Contact::selectToArray( + ['id', 'name', 'addr', 'micro'], + ['uid' => $user_id, 'pending' => false, 'rel' => [Contact::FOLLOWER, Contact::FRIEND]] + ); + array_walk($acl_contacts, function (&$value) { + $value['type'] = 'contact'; + }); + + return $acl_contacts; + } + + /** + * Returns the ACL list of groups (including meta-groups) for a given user id + * + * @param int $user_id + * @return array + */ + public static function getGroupListByUserId(int $user_id) + { + $acl_groups = [ + [ + 'id' => Group::FOLLOWERS, + 'name' => L10n::t('Followers'), + 'addr' => '', + 'micro' => 'images/twopeople.png', + 'type' => 'group', + ], + [ + 'id' => Group::MUTUALS, + 'name' => L10n::t('Mutuals'), + 'addr' => '', + 'micro' => 'images/twopeople.png', + 'type' => 'group', + ] + ]; + foreach (Group::getByUserId($user_id) as $group) { + $acl_groups[] = [ + 'id' => $group['id'], + 'name' => $group['name'], + 'addr' => '', + 'micro' => 'images/twopeople.png', + 'type' => 'group', + ]; + } + + return $acl_groups; + } + /** * Return the full jot ACL selector HTML * + * @param Page $page * @param array $user User array - * @param bool $show_jotnets - * @param array $default_permissions Static defaults permission array: ['allow_cid' => '', 'allow_gid' => '', 'deny_cid' => '', 'deny_gid' => ''] + * @param bool $for_federation + * @param array $default_permissions Static defaults permission array: + * [ + * 'allow_cid' => [], + * 'allow_gid' => [], + * 'deny_cid' => [], + * 'deny_gid' => [], + * 'hidewall' => true/false + * ] * @return string * @throws \Friendica\Network\HTTPException\InternalServerErrorException */ - public static function getFullSelectorHTML(array $user = null, $show_jotnets = false, array $default_permissions = []) + public static function getFullSelectorHTML(Page $page, array $user = null, bool $for_federation = false, array $default_permissions = []) { + $page->registerFooterScript(Theme::getPathForFile('asset/typeahead.js/dist/typeahead.bundle.js')); + $page->registerFooterScript(Theme::getPathForFile('js/friendica-tagsinput/friendica-tagsinput.js')); + $page->registerStylesheet(Theme::getPathForFile('js/friendica-tagsinput/friendica-tagsinput.css')); + $page->registerStylesheet(Theme::getPathForFile('js/friendica-tagsinput/friendica-tagsinput-typeahead.css')); + // Defaults user permissions if (empty($default_permissions)) { $default_permissions = self::getDefaultUserPermissions($user); } + if (count($default_permissions['allow_cid']) + + count($default_permissions['allow_gid']) + + count($default_permissions['deny_cid']) + + count($default_permissions['deny_gid'])) { + $visibility = 'custom'; + } else { + $visibility = 'public'; + // Default permission display for custom panel + $default_permissions['allow_gid'] = [Group::FOLLOWERS]; + } + $jotnets_fields = []; - if ($show_jotnets) { + if ($for_federation) { $mail_enabled = false; $pubmail_enabled = false; if (function_exists('imap_open') && !Config::get('system', 'imap_disabled')) { - $mailacct = DBA::selectFirst('mailacct', ['pubmail'], ['`uid` = ? AND `server` != ""', local_user()]); + $mailacct = DBA::selectFirst('mailacct', ['pubmail'], ['`uid` = ? AND `server` != ""', $user['úid']]); if (DBA::isResult($mailacct)) { $mail_enabled = true; $pubmail_enabled = !empty($mailacct['pubmail']); @@ -296,27 +375,35 @@ class ACL extends BaseObject } } + $acl_contacts = self::getContactListByUserId($user['uid']); + + $acl_groups = self::getGroupListByUserId($user['uid']); + + $acl_list = array_merge($acl_groups, $acl_contacts); + $tpl = Renderer::getMarkupTemplate('acl_selector.tpl'); $o = Renderer::replaceMacros($tpl, [ - '$showall' => L10n::t('Visible to everybody'), - '$show' => L10n::t('show'), - '$hide' => L10n::t('don\'t show'), - '$allowcid' => json_encode(($default_permissions['allow_cid'] ?? '') ?: []), // We need arrays for - '$allowgid' => json_encode(($default_permissions['allow_gid'] ?? '') ?: []), // Javascript since we - '$denycid' => json_encode(($default_permissions['deny_cid'] ?? '') ?: []), // call .remove() and - '$denygid' => json_encode(($default_permissions['deny_gid'] ?? '') ?: []), // .push() on these values - '$networks' => $show_jotnets, - '$emailcc' => L10n::t('CC: email addresses'), - '$emtitle' => L10n::t('Example: bob@example.com, mary@example.com'), - '$jotnets_enabled' => empty($default_permissions['hidewall']), + '$public_title' => L10n::t('Public'), + '$public_desc' => L10n::t('This content will be shown to all your followers and can be seen in the community pages and by anyone with its link.'), + '$custom_title' => L10n::t('Limited/Private'), + '$custom_desc' => L10n::t('This content will be shown only to the people in the first box, to the exception of the people mentioned in the second box. It won\'t appear anywhere public.'), + '$allow_label' => L10n::t('Show to:'), + '$deny_label' => L10n::t('Except to:'), + '$emailcc' => L10n::t('CC: email addresses'), + '$emtitle' => L10n::t('Example: bob@example.com, mary@example.com'), '$jotnets_summary' => L10n::t('Connectors'), - '$jotnets_fields' => $jotnets_fields, '$jotnets_disabled_label' => L10n::t('Connectors disabled, since "%s" is enabled.', L10n::t('Hide your profile details from unknown viewers?')), - '$aclModalTitle' => L10n::t('Permissions'), - '$aclModalDismiss' => L10n::t('Close'), - '$features' => [ - 'aclautomention' => !empty($user['uid']) && Feature::isEnabled($user['uid'], 'aclautomention') ? 'true' : 'false' - ], + '$visibility' => $visibility, + '$acl_contacts' => $acl_contacts, + '$acl_groups' => $acl_groups, + '$acl_list' => $acl_list, + '$contact_allow' => implode(',', $default_permissions['allow_cid']), + '$group_allow' => implode(',', $default_permissions['allow_gid']), + '$contact_deny' => implode(',', $default_permissions['deny_cid']), + '$group_deny' => implode(',', $default_permissions['deny_gid']), + '$for_federation' => $for_federation, + '$jotnets_fields' => $jotnets_fields, + '$user_hidewall' => $default_permissions['hidewall'], ]); return $o; diff --git a/src/Core/Theme.php b/src/Core/Theme.php index 61798a396..7a59f1132 100644 --- a/src/Core/Theme.php +++ b/src/Core/Theme.php @@ -185,45 +185,33 @@ class Theme /** * @brief Get the full path to relevant theme files by filename * - * This function search in the theme directory (and if not present in global theme directory) - * if there is a directory with the file extension and for a file with the given - * filename. + * This function searches in order in the current theme directory, in the current theme parent directory, and lastly + * in the base view/ folder. * * @param string $file Filename - * @param string $root Full root path * @return string Path to the file or empty string if the file isn't found - * @throws \Friendica\Network\HTTPException\InternalServerErrorException + * @throws \Exception */ - public static function getPathForFile($file, $root = '') + public static function getPathForFile($file) { - $file = basename($file); + $a = BaseObject::getApp(); + + $theme = $a->getCurrentTheme(); + + $parent = Strings::sanitizeFilePathItem($a->theme_info['extends'] ?? $theme); - // Make sure $root ends with a slash / if it's not blank - if ($root !== '' && $root[strlen($root) - 1] !== '/') { - $root = $root . '/'; - } - $theme_info = \get_app()->theme_info; - if (is_array($theme_info) && array_key_exists('extends', $theme_info)) { - $parent = $theme_info['extends']; - } else { - $parent = 'NOPATH'; - } - $theme = \get_app()->getCurrentTheme(); - $parent = Strings::sanitizeFilePathItem($parent); - $ext = substr($file, strrpos($file, '.') + 1); $paths = [ - "{$root}view/theme/$theme/$ext/$file", - "{$root}view/theme/$parent/$ext/$file", - "{$root}view/$ext/$file", + "view/theme/$theme/$file", + "view/theme/$parent/$file", + "view/$file", ]; - foreach ($paths as $p) { - // strpos() is faster than strstr when checking if one string is in another (http://php.net/manual/en/function.strstr.php) - if (strpos($p, 'NOPATH') !== false) { - continue; - } elseif (file_exists($p)) { - return $p; + + foreach ($paths as $path) { + if (file_exists($path)) { + return $path; } } + return ''; } diff --git a/src/Module/Bookmarklet.php b/src/Module/Bookmarklet.php index a50f23c25..08bac2c1d 100644 --- a/src/Module/Bookmarklet.php +++ b/src/Module/Bookmarklet.php @@ -44,7 +44,7 @@ class Bookmarklet extends BaseModule 'nickname' => $app->user['nickname'], 'lockstate' => ((is_array($app->user) && ((strlen($app->user['allow_cid'])) || (strlen($app->user['allow_gid'])) || (strlen($app->user['deny_cid'])) || (strlen($app->user['deny_gid'])))) ? 'lock' : 'unlock'), 'default_perms' => ACL::getDefaultUserPermissions($app->user), - 'acl' => ACL::getFullSelectorHTML($app->user, true), + 'acl' => ACL::getFullSelectorHTML($app->page, $app->user, true), 'bang' => '', 'visitor' => 'block', 'profile_uid' => local_user(), diff --git a/src/Module/Contact.php b/src/Module/Contact.php index ded5ffbe2..5ef06b72a 100644 --- a/src/Module/Contact.php +++ b/src/Module/Contact.php @@ -926,7 +926,7 @@ class Contact extends BaseModule 'default_location' => $a->user['default-location'], 'nickname' => $a->user['nickname'], 'lockstate' => (is_array($a->user) && (strlen($a->user['allow_cid']) || strlen($a->user['allow_gid']) || strlen($a->user['deny_cid']) || strlen($a->user['deny_gid'])) ? 'lock' : 'unlock'), - 'acl' => ACL::getFullSelectorHTML($a->user, true), + 'acl' => ACL::getFullSelectorHTML($a->page, $a->user, true), 'bang' => '', 'visitor' => 'block', 'profile_uid' => local_user(), diff --git a/src/Module/Item/Compose.php b/src/Module/Item/Compose.php index ad0a2d805..db44ee3d1 100644 --- a/src/Module/Item/Compose.php +++ b/src/Module/Item/Compose.php @@ -4,10 +4,13 @@ namespace Friendica\Module\Item; use Friendica\BaseModule; use Friendica\Content\Feature; +use Friendica\Core\ACL; use Friendica\Core\Config; use Friendica\Core\Hook; use Friendica\Core\L10n; use Friendica\Core\Renderer; +use Friendica\Core\System; +use Friendica\Core\Theme; use Friendica\Database\DBA; use Friendica\Model\Contact; use Friendica\Model\FileTag; @@ -45,7 +48,7 @@ class Compose extends BaseModule } /// @TODO Retrieve parameter from router - $posttype = $a->argv[1] ?? Item::PT_ARTICLE; + $posttype = $parameters['type'] ?? Item::PT_ARTICLE; if (!in_array($posttype, [Item::PT_ARTICLE, Item::PT_PERSONAL_NOTE])) { switch ($posttype) { case 'note': @@ -62,20 +65,37 @@ class Compose extends BaseModule /** @var ACLFormatter $aclFormatter */ $aclFormatter = self::getClass(ACLFormatter::class); + $contact_allow_list = $aclFormatter->expand($user['allow_cid']); + $group_allow_list = $aclFormatter->expand($user['allow_gid']); + $contact_deny_list = $aclFormatter->expand($user['deny_cid']); + $group_deny_list = $aclFormatter->expand($user['deny_gid']); + switch ($posttype) { case Item::PT_PERSONAL_NOTE: $compose_title = L10n::t('Compose new personal note'); $type = 'note'; $doesFederate = false; - $contact_allow = $a->contact['id']; - $group_allow = ''; + $contact_allow_list = [$a->contact['id']]; + $group_allow_list = []; + $contact_deny_list = []; + $group_deny_list = []; break; default: $compose_title = L10n::t('Compose new post'); $type = 'post'; $doesFederate = true; - $contact_allow = implode(',', $aclFormatter->expand($user['allow_cid'])); - $group_allow = implode(',', $aclFormatter->expand($user['allow_gid'])) ?: Group::FOLLOWERS; + + if ($_REQUEST['contact_allow'] + . $_REQUEST['group_allow'] + . $_REQUEST['contact_deny'] + . $_REQUEST['group_deny']) + { + $contact_allow_list = $_REQUEST['contact_allow'] ? explode(',', $_REQUEST['contact_allow']) : []; + $group_allow_list = $_REQUEST['group_allow'] ? explode(',', $_REQUEST['group_allow']) : []; + $contact_deny_list = $_REQUEST['contact_deny'] ? explode(',', $_REQUEST['contact_deny']) : []; + $group_deny_list = $_REQUEST['group_deny'] ? explode(',', $_REQUEST['group_deny']) : []; + } + break; } @@ -84,93 +104,19 @@ class Compose extends BaseModule $body = $_REQUEST['body'] ?? ''; $location = $_REQUEST['location'] ?? $user['default-location']; $wall = $_REQUEST['wall'] ?? $type == 'post'; - $contact_allow = $_REQUEST['contact_allow'] ?? $contact_allow; - $group_allow = $_REQUEST['group_allow'] ?? $group_allow; - $contact_deny = $_REQUEST['contact_deny'] ?? implode(',', $aclFormatter->expand($user['deny_cid'])); - $group_deny = $_REQUEST['group_deny'] ?? implode(',', $aclFormatter->expand($user['deny_gid'])); - $visibility = ($contact_allow . $user['allow_gid'] . $user['deny_cid'] . $user['deny_gid']) ? 'custom' : 'public'; - - $acl_contacts = Contact::selectToArray(['id', 'name', 'addr', 'micro'], ['uid' => local_user(), 'pending' => false, 'rel' => [Contact::FOLLOWER, Contact::FRIEND]]); - array_walk($acl_contacts, function (&$value) { - $value['type'] = 'contact'; - }); - - $acl_groups = [ - [ - 'id' => Group::FOLLOWERS, - 'name' => L10n::t('Followers'), - 'addr' => '', - 'micro' => 'images/twopeople.png', - 'type' => 'group', - ], - [ - 'id' => Group::MUTUALS, - 'name' => L10n::t('Mutuals'), - 'addr' => '', - 'micro' => 'images/twopeople.png', - 'type' => 'group', - ] - ]; - foreach (Group::getByUserId(local_user()) as $group) { - $acl_groups[] = [ - 'id' => $group['id'], - 'name' => $group['name'], - 'addr' => '', - 'micro' => 'images/twopeople.png', - 'type' => 'group', - ]; - } - - $acl = array_merge($acl_groups, $acl_contacts); - - $jotnets_fields = []; - $mail_enabled = false; - $pubmail_enabled = false; - if (function_exists('imap_open') && !Config::get('system', 'imap_disabled')) { - $mailacct = DBA::selectFirst('mailacct', ['pubmail'], ['`uid` = ? AND `server` != ""', local_user()]); - if (DBA::isResult($mailacct)) { - $mail_enabled = true; - $pubmail_enabled = !empty($mailacct['pubmail']); - } - } - - if (empty($user['hidewall'])) { - if ($mail_enabled) { - $jotnets_fields[] = [ - 'type' => 'checkbox', - 'field' => [ - 'pubmail_enable', - L10n::t('Post to Email'), - $pubmail_enabled - ] - ]; - } - - Hook::callAll('jot_networks', $jotnets_fields); - } $jotplugins = ''; Hook::callAll('jot_tool', $jotplugins); // Output - - $a->registerFooterScript('view/js/ajaxupload.js'); - $a->registerFooterScript('view/js/linkPreview.js'); - $a->registerFooterScript('view/asset/typeahead.js/dist/typeahead.bundle.js'); - $a->registerFooterScript('view/theme/frio/frameworks/friendica-tagsinput/friendica-tagsinput.js'); - $a->registerStylesheet('view/theme/frio/frameworks/friendica-tagsinput/friendica-tagsinput.css'); - $a->registerStylesheet('view/theme/frio/frameworks/friendica-tagsinput/friendica-tagsinput-typeahead.css'); - - $tpl = Renderer::getMarkupTemplate('item/compose-footer.tpl'); - $a->page['footer'] .= Renderer::replaceMacros($tpl, [ - '$acl_contacts' => $acl_contacts, - '$acl_groups' => $acl_groups, - '$acl' => $acl, - ]); + $a->page->registerFooterScript(Theme::getPathForFile('js/ajaxupload.js')); + $a->page->registerFooterScript(Theme::getPathForFile('js/linkPreview.js')); + $a->page->registerFooterScript(Theme::getPathForFile('js/compose.js')); $tpl = Renderer::getMarkupTemplate('item/compose.tpl'); return Renderer::replaceMacros($tpl, [ '$compose_title'=> $compose_title, + '$visibility_title'=> L10n::t('Visibility'), '$id' => 0, '$posttype' => $posttype, '$type' => $type, @@ -197,25 +143,26 @@ class Compose extends BaseModule '$wait' => L10n::t('Please wait'), '$placeholdertitle' => L10n::t('Set title'), '$placeholdercategory' => (Feature::isEnabled(local_user(),'categories') ? L10n::t('Categories (comma-separated list)') : ''), - '$public_title' => L10n::t('Public'), - '$public_desc' => L10n::t('This post will be sent to all your followers and can be seen in the community pages and by anyone with its link.'), - '$custom_title' => L10n::t('Limited/Private'), - '$custom_desc' => L10n::t('This post will be sent only to the people in the first box, to the exception of the people mentioned in the second box. It won\'t appear anywhere public.'), - '$emailcc' => L10n::t('CC: email addresses'), + '$title' => $title, '$category' => $category, '$body' => $body, '$location' => $location, - '$visibility' => $visibility, - '$contact_allow'=> $contact_allow, - '$group_allow' => $group_allow, - '$contact_deny' => $contact_deny, - '$group_deny' => $group_deny, + + '$contact_allow'=> implode(',', $contact_allow_list), + '$group_allow' => implode(',', $group_allow_list), + '$contact_deny' => implode(',', $contact_deny_list), + '$group_deny' => implode(',', $group_deny_list), + '$jotplugins' => $jotplugins, - '$doesFederate' => $doesFederate, - '$jotnets_fields'=> $jotnets_fields, '$sourceapp' => L10n::t($a->sourcename), - '$rand_num' => Crypto::randomDigits(12) + '$rand_num' => Crypto::randomDigits(12), + '$acl_selector' => ACL::getFullSelectorHTML($a->page, $a->user, $doesFederate, [ + 'allow_cid' => $contact_allow_list, + 'allow_gid' => $group_allow_list, + 'deny_cid' => $contact_deny_list, + 'deny_gid' => $group_deny_list, + ]), ]); } } diff --git a/src/Module/Profile.php b/src/Module/Profile.php index aab591856..db1a6f86b 100644 --- a/src/Module/Profile.php +++ b/src/Module/Profile.php @@ -208,7 +208,7 @@ class Profile extends BaseModule || strlen($a->user['deny_cid']) || strlen($a->user['deny_gid']) ) ? 'lock' : 'unlock', - 'acl' => $is_owner ? ACL::getFullSelectorHTML($a->user, true) : '', + 'acl' => $is_owner ? ACL::getFullSelectorHTML($a->page, $a->user, true) : '', 'bang' => '', 'visitor' => $is_owner || $commvisitor ? 'block' : 'none', 'profile_uid' => $a->profile['profile_uid'], diff --git a/view/js/acl.js b/view/js/acl.js deleted file mode 100644 index b50dbaec8..000000000 --- a/view/js/acl.js +++ /dev/null @@ -1,376 +0,0 @@ -// @license magnet:?xt=urn:btih:0b31508aeb0634b347b8270c7bee4d411b5d4109&dn=agpl-3.0.txt AGPLv3-or-later -function ACL(backend_url, preset, automention, is_mobile){ - - this.url = backend_url; - this.automention = automention; - this.is_mobile = is_mobile; - - - this.kp_timer = null; - - if (preset == undefined) { - preset = []; - } - this.allow_cid = (preset[0] || []); - this.allow_gid = (preset[1] || []); - this.deny_cid = (preset[2] || []); - this.deny_gid = (preset[3] || []); - this.group_uids = []; - this.forumCache = null; - - if (this.is_mobile) { - this.nw = 1; - } else { - this.nw = 4; - } - - - this.list_content = $("#acl-list-content"); - this.item_tpl = unescape($(".acl-list-item[rel=acl-template]").html()); - this.showall = $("#acl-showall"); - - if (preset.length==0) { - this.showall.addClass("selected"); - } - - /*events*/ - this.showall.click(this.on_showall.bind(this)); - $(document).on("click", ".acl-button-show", this.on_button_show.bind(this)); - $(document).on("click", ".acl-button-hide", this.on_button_hide.bind(this)); - $("#acl-search").keypress(this.on_search.bind(this)); - $("#acl-wrapper").parents("form").submit(this.on_submit.bind(this)); - - /* add/remove mentions */ - this.element = $("#profile-jot-text"); - this.htmlelm = this.element.get()[0]; -} - -ACL.prototype.remove_mention = function(id) { - if (!this.automention) { - return; - } - var nick = this.data[id].nick; - var addr = this.data[id].addr; - - if (addr != "") { - var searchText = "!" + addr + " "; - } else { - var searchText = "!" + nick + "+" + id + " "; - } - - var start = this.element.val().indexOf(searchText); - if (start < 0) { - return; - } - var end = start + searchText.length; - this.element.setSelection(start, end).replaceSelectedText('').collapseSelection(false); -}; - -ACL.prototype.add_mention = function(id) { - if (!this.automention) { - return; - } - var nick = this.data[id].nick; - var addr = this.data[id].addr; - - if (addr != "") { - var searchText = "!" + addr + " "; - } else { - var searchText = "!" + nick + "+" + id + " "; - } - - if (this.element.val().indexOf( searchText) >= 0 ) { - return; - } - this.element.val(searchText + this.element.val()).trigger('change'); -} - -ACL.prototype.on_submit = function(){ - var aclfields = $("#acl-fields").html(""); - $(this.allow_gid).each(function(i,v){ - aclfields.append(""); - }); - $(this.allow_cid).each(function(i,v){ - aclfields.append(""); - }); - $(this.deny_gid).each(function(i,v){ - aclfields.append(""); - }); - $(this.deny_cid).each(function(i,v){ - aclfields.append(""); - }); -}; - -ACL.prototype.search = function(){ - var srcstr = $("#acl-search").val(); - this.list_content.html(""); - this.get(0,100, srcstr); -}; - -ACL.prototype.on_search = function(event){ - if (this.kp_timer) clearTimeout(this.kp_timer); - - // Triggers an immediate search while preventing form submission - if (event.key === 'Enter') { - this.search(); - event.preventDefault(); - } else { - this.kp_timer = setTimeout( this.search.bind(this), 500); - } -}; - -ACL.prototype.on_showall = function(event){ - event.preventDefault() - event.stopPropagation(); - - if (this.showall.hasClass("selected")){ - return false; - } - this.showall.addClass("selected"); - - this.allow_cid = []; - this.allow_gid = []; - this.deny_cid = []; - this.deny_gid = []; - - this.update_view(); - - return false; -}; - -ACL.prototype.on_button_show = function(event){ - event.preventDefault() - event.stopImmediatePropagation() - event.stopPropagation(); - - this.set_allow($(event.target).parent().attr('id')); - - return false; -}; - -ACL.prototype.on_button_hide = function(event){ - event.preventDefault() - event.stopImmediatePropagation() - event.stopPropagation(); - - this.set_deny($(event.target).parent().attr('id')); - - return false; -}; - -ACL.prototype.set_allow = function(itemid) { - type = itemid[0]; - id = parseInt(itemid.substr(1)); - - switch (type){ - case "g": - if (this.allow_gid.indexOf(id) < 0) { - this.allow_gid.push(id); - }else { - this.allow_gid.remove(id); - } - if (this.deny_gid.indexOf(id) >= 0) { - this.deny_gid.remove(id); - } - break; - case "c": - if (this.allow_cid.indexOf(id) < 0){ - this.allow_cid.push(id); - if (this.data[id].forum == "1") { - // If we have select already a forum, - // we need to remove the old one (because friendica does - // allow only one forum as receiver). - if (this.forumCache !== null && this.forumCache !== id) { - this.deselectCid(this.forumCache); - } - // Update the forum cache. - this.forumCache = id; - this.add_mention(id); - } - } else { - this.allow_cid.remove(id); - if (this.data[id].forum == "1") { - this.remove_mention(id); - } - } - if (this.deny_cid.indexOf(id) >=0 ) { - this.deny_cid.remove(id); - } - break; - } - this.update_view(); -}; - -ACL.prototype.set_deny = function(itemid){ - type = itemid[0]; - id = parseInt(itemid.substr(1)); - - switch(type){ - case "g": - if (this.deny_gid.indexOf(id)<0){ - this.deny_gid.push(id) - } else { - this.deny_gid.remove(id); - } - if (this.allow_gid.indexOf(id)>=0) this.allow_gid.remove(id); - break; - case "c": - if (this.data[id].forum=="1") this.remove_mention(id); - if (this.deny_cid.indexOf(id)<0){ - this.deny_cid.push(id) - } else { - this.deny_cid.remove(id); - } - if (this.allow_cid.indexOf(id)>=0) this.allow_cid.remove(id); - break; - } - this.update_view(); -}; - -ACL.prototype.is_show_all = function() { - return (this.allow_gid.length==0 && this.allow_cid.length==0 && - this.deny_gid.length==0 && this.deny_cid.length==0); -}; - -ACL.prototype.update_view = function () { - if (this.is_show_all()) { - this.showall.addClass("selected"); - /* jot acl */ - $('#jot-perms-icon').removeClass('lock').addClass('unlock'); - $('#jot-public').show(); - $('.profile-jot-net input[type=checkbox]').each(function() { - // Restores checkbox state if it had been saved - if ($(this).attr('data-checked') !== undefined) { - $(this).prop('checked', $(this).attr('data-checked') === 'true'); - } - }); - - $('.profile-jot-net input').attr('disabled', false); - if (typeof editor != 'undefined' && editor != false) { - $('#profile-jot-desc').html(ispublic); - } - } else { - this.showall.removeClass("selected"); - /* jot acl */ - $('#jot-perms-icon').removeClass('unlock').addClass('lock'); - $('#jot-public').hide(); - $('.profile-jot-net input[type=checkbox]').each(function() { - // Saves current checkbox state - $(this) - .attr('data-checked', $(this).prop('checked')) - .prop('checked', false); - }); - $('.profile-jot-net input').attr('disabled', 'disabled'); - $('#profile-jot-desc').html(' '); - } - - $("#acl-list-content .acl-list-item").each(function (index, element) { - $(this).removeClass("groupshow grouphide"); - - itemid = $(element).attr('id'); - type = itemid[0]; - id = parseInt(itemid.substr(1)); - - btshow = $(element).children(".acl-button-show").removeClass("selected"); - bthide = $(element).children(".acl-button-hide").removeClass("selected"); - - switch (type) { - case "g": - var uclass = ""; - if (this.allow_gid.indexOf(id) >= 0) { - btshow.addClass("selected"); - bthide.removeClass("selected"); - uclass = "groupshow"; - } - if (this.deny_gid.indexOf(id) >= 0) { - btshow.removeClass("selected"); - bthide.addClass("selected"); - uclass = "grouphide"; - } - - $(this.group_uids[id]).each(function (i, v) { - if (uclass == "grouphide") - $("#c" + v).removeClass("groupshow"); - if (uclass != "") { - var cls = $("#c" + v).attr('class'); - if (cls == undefined) - return true; - var hiding = cls.indexOf('grouphide'); - if (hiding == -1) - $("#c" + v).addClass(uclass); - } - }); - - break; - case "c": - if (this.allow_cid.indexOf(id) >= 0) { - btshow.addClass("selected"); - bthide.removeClass("selected"); - } - if (this.deny_cid.indexOf(id) >= 0) { - btshow.removeClass("selected"); - bthide.addClass("selected"); - } - } - - }.bind(this)); - -}; - -ACL.prototype.get = function(start,count, search){ - var postdata = { - start:start, - count:count, - search:search, - } - - $.ajax({ - type:'POST', - url: this.url, - data: postdata, - dataType: 'json', - success:this.populate.bind(this) - }); -}; - -ACL.prototype.populate = function(data){ - var height = Math.ceil(data.tot / this.nw) * 42; - this.list_content.height(height); - this.data = {}; - $(data.items).each(function(index, item) { - if (item.separator != undefined) { - html = "