From 5cc8b28b41941fff62cb8ea6e3a5fecc459795d1 Mon Sep 17 00:00:00 2001
From: Alexey Kuznetsov <axet@me.com>
Date: Mon, 10 Dec 2018 17:04:56 +0300
Subject: [PATCH] clenaups

---
 .../axet/audiorecorder/activities/MainActivity.java       | 8 +++-----
 .../axet/audiorecorder/activities/RecordingActivity.java  | 3 +--
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/app/src/main/java/com/github/axet/audiorecorder/activities/MainActivity.java b/app/src/main/java/com/github/axet/audiorecorder/activities/MainActivity.java
index c935728..afeb2c0 100644
--- a/app/src/main/java/com/github/axet/audiorecorder/activities/MainActivity.java
+++ b/app/src/main/java/com/github/axet/audiorecorder/activities/MainActivity.java
@@ -39,6 +39,8 @@ import com.github.axet.audiorecorder.services.RecordingService;
 public class MainActivity extends AppCompatThemeActivity {
     public final static String TAG = MainActivity.class.getSimpleName();
 
+    public static final int RESULT_PERMS = 1;
+
     FloatingActionButton fab;
     Handler handler = new Handler();
 
@@ -170,12 +172,8 @@ public class MainActivity extends AppCompatThemeActivity {
 
     @Override
     public boolean onOptionsItemSelected(MenuItem item) {
-        // Handle action bar base clicks here. The action bar will
-        // automatically handle clicks on the Home/Up button, so long
-        // as you specify a parent activity in AndroidManifest.xml.
         int id = item.getItemId();
 
-        //noinspection SimplifiableIfStatement
         if (id == R.id.action_settings) {
             startActivity(new Intent(this, SettingsActivity.class));
             return true;
@@ -257,7 +255,7 @@ public class MainActivity extends AppCompatThemeActivity {
     public void onRequestPermissionsResult(int requestCode, String[] permissions, int[] grantResults) {
         super.onRequestPermissionsResult(requestCode, permissions, grantResults);
         switch (requestCode) {
-            case 1:
+            case RESULT_PERMS:
                 if (Storage.permitted(MainActivity.this, permissions)) {
                     try {
                         storage.migrateLocalStorage();
diff --git a/app/src/main/java/com/github/axet/audiorecorder/activities/RecordingActivity.java b/app/src/main/java/com/github/axet/audiorecorder/activities/RecordingActivity.java
index ede24ef..79d0e78 100644
--- a/app/src/main/java/com/github/axet/audiorecorder/activities/RecordingActivity.java
+++ b/app/src/main/java/com/github/axet/audiorecorder/activities/RecordingActivity.java
@@ -783,8 +783,7 @@ public class RecordingActivity extends AppCompatThemeActivity {
 
             RecordingService.startService(this, Storage.getName(this, recording.targetUri), true, encoder != null, duration);
         } catch (RuntimeException e) {
-            Log.d(TAG, "unable to start", e);
-            Toast.makeText(RecordingActivity.this, "Unable to initialize AudioRecord", Toast.LENGTH_SHORT).show();
+            Toast.Error(RecordingActivity.this, e);
             finish();
         }
     }