From cdc69179fa0de2b68fdcbe7628edf97755f9e275 Mon Sep 17 00:00:00 2001
From: Adam Magness <adam.magness@gmail.com>
Date: Wed, 6 Dec 2017 16:02:21 -0500
Subject: [PATCH] Update false evaluations

update false to is_null where needed.
---
 fromapp/fromapp.php       | 27 ++++++++++++++++-----------
 notimeline/notimeline.php |  3 ++-
 numfriends/numfriends.php |  3 ++-
 qcomment/qcomment.php     |  3 ++-
 4 files changed, 22 insertions(+), 14 deletions(-)

diff --git a/fromapp/fromapp.php b/fromapp/fromapp.php
index 2d0b98ca7..2828f500d 100644
--- a/fromapp/fromapp.php
+++ b/fromapp/fromapp.php
@@ -51,7 +51,7 @@ function fromapp_settings(&$a,&$s) {
 	/* Get the current state of our config variable */
 
 	$fromapp = PConfig::get(local_user(),'fromapp','app');
-	if($fromapp === false)
+	if(is_null($fromapp))
 		$fromapp = '';
 
 	$force = intval(PConfig::get(local_user(),'fromapp','force'));
@@ -84,24 +84,29 @@ function fromapp_settings(&$a,&$s) {
 
 }
 
-function fromapp_post_hook(&$a,&$item) {
-   if(! local_user())
-        return;
+function fromapp_post_hook(&$a,&$item)
+{
+	if(! local_user()) {
+		return;
+	}
 
-    if(local_user() != $item['uid'])
-        return;
+    if(local_user() != $item['uid']) {
+		return;
+	}
 
     $app = PConfig::get(local_user(), 'fromapp', 'app');
 	$force = intval(PConfig::get(local_user(), 'fromapp','force'));
 
-    if(($app === false) || (! strlen($app)))
-        return;
-
-	if(strlen(trim($item['app'])) && (! $force))
+    if(is_null($app) || (! strlen($app))) {
 		return;
+	}
+
+	if(strlen(trim($item['app'])) && (! $force)) {
+		return;
+	}
 
 	$apps = explode(',',$app);
 	$item['app'] = trim($apps[mt_rand(0,count($apps)-1)]);
+	
 	return;
-
 }
diff --git a/notimeline/notimeline.php b/notimeline/notimeline.php
index 33e66b132..8f0727183 100644
--- a/notimeline/notimeline.php
+++ b/notimeline/notimeline.php
@@ -45,8 +45,9 @@ function notimeline_settings(&$a,&$s) {
 	/* Get the current state of our config variable */
 
 	$notimeline = PConfig::get(local_user(),'system','no_wall_archive_widget');
-	if($notimeline === false)
+	if(is_null($notimeline)) {
 		$notimeline = false;
+	}
 
 	$notimeline_checked = (($notimeline) ? ' checked="checked" ' : '');
 
diff --git a/numfriends/numfriends.php b/numfriends/numfriends.php
index d7f43b4fa..b6d302d58 100755
--- a/numfriends/numfriends.php
+++ b/numfriends/numfriends.php
@@ -69,8 +69,9 @@ function numfriends_settings(&$a,&$s) {
 	/* Get the current state of our config variable */
 
 	$numfriends = PConfig::get(local_user(),'system','display_friend_count');
-	if($numfriends === false)
+	if(is_null($numfriends)) {
 		$numfriends = 24;
+	}
 	
 	/* Add some HTML to the existing form */
 
diff --git a/qcomment/qcomment.php b/qcomment/qcomment.php
index 90826e541..2a44fcb09 100755
--- a/qcomment/qcomment.php
+++ b/qcomment/qcomment.php
@@ -49,8 +49,9 @@ function qcomment_addon_settings(&$a,&$s) {
     $a->page['htmlhead'] .= '<link rel="stylesheet"  type="text/css" href="' . $a->get_baseurl() . '/addon/qcomment/qcomment.css' . '" media="all" />' . "\r\n";
 
 	$words = PConfig::get(local_user(),'qcomment','words');
-	if($words === false)
+	if(is_null($words)) {
 		$words = t(':-)') . "\n" . t(':-(') . "\n" .  t('lol');
+	}
 
     $s .= '<div class="settings-block">';
     $s .= '<h3>' . t('Quick Comment Settings') . '</h3>';